Re: [PATCH] Merging colors [Was: Re: change tracking quite unusable in LyX 1.6.x]

2009-01-14 Thread Jean-Marc Lasgouttes
Le 14 janv. 09 à 23:19, Vincent van Ravesteijn a écrit : Done. The nice thing is that we can now also make a new color: Color_deletedtextmodifier. This can be set by the user to specify the degree of lightening or darkening of the color. It would be nice if the user can also put this to Colo

Re: [patch] number localization

2009-01-14 Thread Jean-Marc Lasgouttes
What is the trimmed() good for? QString::toDouble() cannot handle trailing whitespace. Oh, I see. JMarc

Re: [patch] number localization

2009-01-14 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Le 14 janv. 09 à 20:05, Jürgen Spitzmüller a écrit : > > The attached patch (for trunk only) introduces number localization,   > > something > > I wanted for a long time (I wasn't aware it was so easy). > > What is the trimmed() good for? QString::toDouble() cannot ha

Re: [patch] fix bug 5686 for branch

2009-01-14 Thread Christian Ridderström
On Thu, 15 Jan 2009, Uwe Stöhr wrote: I don't understand your concerns. I listed the 3 possibilities to fix this and why I have chosen the one I implemented. There is not other way to fix this, see also the last sentence of this mail. We also do this all the time: When you enter a "#" in norma

Re: [patch] fix bug 5682

2009-01-14 Thread Uwe Stöhr
> Sure? The following works for me as expected: > > a\hspace{0.25\textwidth}b > \vspace{.5\textheight} Indeed it works. So please add them. (I don't know why it didn't for me yesterday. I only tested by deleting noPercents(), perhaps that was not enough). regards Uwe

Re: [patch] fix bug 5686 for branch

2009-01-14 Thread Uwe Stöhr
I don't like the concept. Better teach the users about proper use instead of "fixing" it behind their backs. I don't understand your concerns. I listed the 3 possibilities to fix this and why I have chosen the one I implemented. There is not other way to fix this, see also the last sentence of

Re: [patch] ButtonController for Dialogs with AutoApply

2009-01-14 Thread rgheck
Vincent van Ravesteijn wrote: Hi all, In preparation for the GuiTabular dialog I added a buttoncontroller policy for Dialogs with an autoapply checkbox. As as example I added a patch for the GuiCharacter dialog. (PS if you want me to shut up and apply the patches immediately, just give a hi

Re: [PATCH] Merging colors [Was: Re: change tracking quite unusable in LyX 1.6.x]

2009-01-14 Thread rgheck
If I can go through with this, I would like to have a few OKs, because changing all ColorCode's in the sources to Color is a quite intrusive operation. Yes, though that sort of sed-patch can often be committed separately, for the most part, and it's usually fairly safe, in the sense that, if

Re: [patch] Re: The disabling of submenus

2009-01-14 Thread rgheck
this looks good to me...but... Index: src/frontends/qt4/Menus.cpp === --- src/frontends/qt4/Menus.cpp (revision 28166) +++ src/frontends/qt4/Menus.cpp (working copy) @@ -95,6 +95,15 @@ Submenu, ///

Re: [patch] Disabling of Edit->Math menu item

2009-01-14 Thread rgheck
Vincent van Ravesteijn wrote: The Edit->Math menu item is _always_ enabled. This is caused by the command "math-insert \textstyle"... The patch fixes this. Objections ? None here. rh

[patch] ButtonController for Dialogs with AutoApply

2009-01-14 Thread Vincent van Ravesteijn
Hi all, In preparation for the GuiTabular dialog I added a buttoncontroller policy for Dialogs with an autoapply checkbox. As as example I added a patch for the GuiCharacter dialog. (PS if you want me to shut up and apply the patches immediately, just give a hint) Vincent Index: src/fronte

Improving Paste

2009-01-14 Thread Tommaso Cucinotta
Hi, I noticed that copy&paste seems to have some problems when doing operations from different environments (text vs mathed). For example, copying an entire math inset and trying to paste inside another math inset. Actually, it pastes nothing. In other cases, I saw the latex export to be actual

[PATCH] Merging colors [Was: Re: change tracking quite unusable in LyX 1.6.x]

2009-01-14 Thread Vincent van Ravesteijn
Jean-Marc Lasgouttes schreef: I created a new class ColorCode (and renamed the old enum to something else). Why not Color? I moved this class to Color.cpp and renamed it to Color. You could remove this type and set mergecolor to Color_ignore when no merging is required (would b

[patch] Re: The disabling of submenus

2009-01-14 Thread Vincent van Ravesteijn
Solutions I see: 1/ disable the menu only if it is empty (and apply Vincent's patch to remove 'No Document Open' entries). YES, for cases like Insert->Float. Now we have a type MenuItem::Info for this kind of not so very helpful messages. 2/ gray out the submenu but keep it openabl

Re: [patch] number localization

2009-01-14 Thread Jean-Marc Lasgouttes
Le 14 janv. 09 à 20:05, Jürgen Spitzmüller a écrit : The attached patch (for trunk only) introduces number localization, something I wanted for a long time (I wasn't aware it was so easy). What is the trimmed() good for? So you can now, in German localization, enter 1,2 instead of 1.2 (the

[patch] Disabling of Edit->Math menu item

2009-01-14 Thread Vincent van Ravesteijn
The Edit->Math menu item is _always_ enabled. This is caused by the command "math-insert \textstyle"... The patch fixes this. Objections ? Vincent Index: src/LyXAction.cpp === --- src/LyXAction.cpp (revision 28166) +++ src/LyXAc

Re: [patch] number localization

2009-01-14 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > The attached patch (for trunk only) introduces number localization, something > I wanted for a long time (I wasn't aware it was so easy). > > So you can now, in German localization, enter 1,2 instead of 1.2 (the latter > is still possible, but the numbers will be disp

Re: [Cvslog] r28146 - in /lyx-devel/trunk/src/frontends/qt4: LengthCom...

2009-01-14 Thread Andre Poenitz
On Wed, Jan 14, 2009 at 10:20:34AM -, sp...@lyx.org wrote: > LengthCombo::LengthCombo(QWidget * parent) > : QComboBox(parent) > { > - for (int i = 0; i < lyx::num_units; i++) > - addItem(lyx::qt_(lyx::unit_name_gui[i])); > + for (int i = 0; i < lyx::num_units; i++) {

[patch] number localization

2009-01-14 Thread Jürgen Spitzmüller
The attached patch (for trunk only) introduces number localization, something I wanted for a long time (I wasn't aware it was so easy). So you can now, in German localization, enter 1,2 instead of 1.2 (the latter is still possible, but the numbers will be displayed in the local form). Objection

Re: [patch] fix bug 5686 for branch

2009-01-14 Thread Andre Poenitz
On Wed, Jan 14, 2009 at 02:37:42AM +0100, Uwe Stöhr wrote: > http://www.lyx.org/trac/changeset/28141 fixes > http://bugzilla.lyx.org/show_bug.cgi?id=5686. Now "\" characters in the > url field are translated in the background to "/". So one can insert path > to files as you like - Windows or Uni

Re: r28146 - in /lyx-devel/trunk/src/frontends/qt4: LengthCom...

2009-01-14 Thread Abdelrazak Younes
sp...@lyx.org wrote: Author: spitz Date: Wed Jan 14 11:20:33 2009 New Revision: 28146 URL: http://www.lyx.org/trac/changeset/28146 Log: * LengthCombo.{cpp, h}: - use model/view infrastructure to store reliable data The next step (if you feel like it) is to switch a QStandardItemModel

Re: Finding maths with AdvancedSearch

2009-01-14 Thread Pavel Sanda
Tommaso Cucinotta wrote: > please, find attached a preliminary replace functionality its in. pavel

Re: [Cvslog] r28160 - in /lyx-devel/trunk/src/frontends/qt4: GuiGraphi...

2009-01-14 Thread Pavel Sanda
sa...@lyx.org wrote: > Author: sanda > Date: Wed Jan 14 16:10:15 2009 > New Revision: 28160 > > URL: http://www.lyx.org/trac/changeset/28160 > Log: > Add editable combobox for groups in graphics dialogs as discussed in > http://www.mail-archive.com/lyx-us...@lists.lyx.org/msg70194.html i have tes

Re: make check fails

2009-01-14 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Pavel Sanda writes: > > > hi, > > > > make check now fails for lyx-1.6. > > test_convert now returns > > 1.1001 instead of 1.1 for convert(1.1) > > > > what should be the correct return? > > I think this test is wrong. I am not sure how to make such a th

Re: [PATCH] Second try at tighter preamble

2009-01-14 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Since nobody ever complained over the extra stuff in the preamble, I > propose to skip it for branch. If someone does complain, we can apply it > > :) OK. Jürgen

Re: [PATCH] Second try at tighter preamble

2009-01-14 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: >> Knowing that, shall I still apply to branch (and add some release-note >> warnings)? > > Hm, I'm not sure, actually. What would have been your decision? Since nobody ever complained over the extra stuff in the preamble, I propose to skip it for branch. If someone doe

Re: [Cvslog] r28156 - in /lyx-devel/branches/BRANCH_1_6_X/src: FuncCod...

2009-01-14 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > > Please remember status.16x. > > I updated it, but did not commit :) And the same just happened to me (forgot to save before committing) Jürgen

Re: [PATCH] Second try at tighter preamble

2009-01-14 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > I was about to do it, and now I have doubts. This patch will break > documents where people though it is clever to put some stuff in a Note > just to trigger the validate machinery (maybe because they use ERT that > does not trigger validate, or something). In the long

Re: make check fails

2009-01-14 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: > hi, > > make check now fails for lyx-1.6. > test_convert now returns > 1.1001 instead of 1.1 for convert(1.1) > > what should be the correct return? I think this test is wrong. I am not sure how to make such a thing work... JMarc

Re: [Cvslog] r28156 - in /lyx-devel/branches/BRANCH_1_6_X/src: FuncCod...

2009-01-14 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > Please remember status.16x. I updated it, but did not commit :) JMarc

Re: [Cvslog] r28156 - in /lyx-devel/branches/BRANCH_1_6_X/src: FuncCod...

2009-01-14 Thread Jürgen Spitzmüller
lasgouttes wrote: > Author: lasgouttes > Date: Wed Jan 14 15:32:59 2009 > New Revision: 28156 > > URL: http://www.lyx.org/trac/changeset/28156 > Log: > Fix bug 4741: Pasting with middle mouse button into read only document > works http://bugzilla.lyx.org/show_bug.cgi?id=4741 Please remember status

Re: [PATCH] Second try at tighter preamble

2009-01-14 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > Jean-Marc Lasgouttes wrote: >> This patch is in trunk. What about branch? (it is only 'optimization', >> so it is as you prefer, Juergen. > > Go ahead. I was about to do it, and now I have doubts. This patch will break documents where people though it is clever to put

Re: Add math autocorrect to RC file

2009-01-14 Thread Jean-Marc Lasgouttes
Martin Vermeer writes: > On Wed, 14 Jan 2009 14:37:47 +0100 > Jean-Marc Lasgouttes wrote: > >> Martin Vermeer writes: >> > + // leave autocorrect mode if necessary >> > + if (autocorrectEnabled(cur) && c == ' ' && cur.autocorrect()) { >> >> Two questions (probably related) >> - why do you pas

Re: Add math autocorrect to RC file

2009-01-14 Thread Martin Vermeer
On Wed, 14 Jan 2009 14:37:47 +0100 Jean-Marc Lasgouttes wrote: > Martin Vermeer writes: > > + // leave autocorrect mode if necessary > > + if (autocorrectEnabled(cur) && c == ' ' && cur.autocorrect()) { > > Two questions (probably related) > - why do you pass cur to autocorrectEnabled, wher

RE: layout question

2009-01-14 Thread leuven edwin
jean-marc wrote: > Currently, listings reuses ERT (?) to handle spaces. We could of course > decide to have a new parameter to alloz multiple normal space. Even > better, we could use \obeyspaces in LyX-Code to make normal spaces > work like ~. This would solve many problems IMO (but create interes

Re: Add math autocorrect to RC file

2009-01-14 Thread Jean-Marc Lasgouttes
Martin Vermeer writes: > + // leave autocorrect mode if necessary > + if (autocorrectEnabled(cur) && c == ' ' && cur.autocorrect()) { Two questions (probably related) - why do you pass cur to autocorrectEnabled, whereas it does not rely on the cursor? - why not put the cur.autocorrect() t

Re: LyX-List and KOMA Labeling

2009-01-14 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > A third choice would not solve the problem. We should stick with the > name that is used in the class documentation. Indeed :) JMarc

Re: [patch] fix bug 5686 for branch

2009-01-14 Thread Christian Ridderström
On Wed, 14 Jan 2009, Uwe Stöhr wrote: 1. when the user presses "\", nothing is inserted 2. when the user presses "\", a "/" appears 3. when the user presses "\", he gets the "\" as expected Just curious... do you mean 'presses'? And if so, what happens when you paste a URI? I'm not sure it

Re: [patch] fix bug 5686 for branch

2009-01-14 Thread Christian Ridderström
On Wed, 14 Jan 2009, Jürgen Spitzmüller wrote: Uwe Stöhr wrote: Do you also document this, as well as that "\" (which is a valid character in  > unix paths) must be inserted as "\\"? "\" is not allowed in \href, that was the bug. This is independent if it is valid in some case or not. Unix-p

Re: Add math autocorrect to RC file

2009-01-14 Thread Martin Vermeer
On Wed, 14 Jan 2009 13:22:54 +0100 Pavel Sanda wrote: > Martin Vermeer wrote: > > As in the attached. This makes it possible to enable autocorrection in the > > preferences file. > > would it be possible to add some list of autocorrected things into some of > our manual? Hmmm, yes. > it may

Re: Add math autocorrect to RC file

2009-01-14 Thread Pavel Sanda
Martin Vermeer wrote: > As in the attached. This makes it possible to enable autocorrection in the > preferences file. would it be possible to add some list of autocorrected things into some of our manual? it may be worth to add checkbox into preferences gui. pavel

Add math autocorrect to RC file

2009-01-14 Thread Martin Vermeer
As in the attached. This makes it possible to enable autocorrection in the preferences file. - Martin Index: LyXRC.h === --- LyXRC.h (revision 28149) +++ LyXRC.h (working copy) @@ -38,6 +38,7 @@ enum LyXRCTags { RC_ACCEPT_COMP

Re: [patch] fix bug 5686 for branch

2009-01-14 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > > Do you also document this, as well as that "\" (which is a valid > > character in > >  > unix paths) must be inserted as "\\"? > > "\" is not allowed in \href, that was the bug. This is independent if it is > valid in some case or not. Unix-paths use "/" not "\" as far as I kno

Re: [patch] fix bug 5686 for branch

2009-01-14 Thread Uwe Stöhr
> Do you also document this, as well as that "\" (which is a valid character in > unix paths) must be inserted as "\\"? "\" is not allowed in \href, that was the bug. This is independent if it is valid in some case or not. Unix-paths use "/" not "\" as far as I know. Note that \href takes only U

Re: LyX-List and KOMA Labeling

2009-01-14 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > I have to say that, personnally, 'Labeling' does not sound like a list > to me. But List is of course too vague. Would there be a third choice > like "Labeled List" or something? Could one of our esteemed natvie > English speakers enlighten us? A third choice would no

Re: [Cvslog] r28138 - in /lyx-devel/trunk/src: FuncCode.h LyXAction.cp...

2009-01-14 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > i would like to have this in branch. Juergen? OK. Note that there's a typo here: +/*! + * \var lyx::FuncCode lyx::LFUN_VC_COMMAND + * \li Action: Executes external command. This command is intended to support +               additonal VCS commands. Jürgen

Re: [patch] fix bug 5686 for branch

2009-01-14 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > > The result, e.g. > > file:C:/file.txt > > is handled correctly by Firefox and Internet Explorer. > > > > OK for branch too? > > Do you also document this, as well as that "\" (which is a valid character in > unix paths) must be inserted as "\\"? shouldn't be this co

Re: [patch] fix bug 5686 for branch

2009-01-14 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > http://www.lyx.org/trac/changeset/28141 fixes > http://bugzilla.lyx.org/show_bug.cgi?id=5686. Now "\" characters in the url > field are translated in the background to "/". So one can insert path to > files as you like - Windows or Unix style. > The result, e.g. > file:C:/file.tx

Re: I/Pspell leftovers

2009-01-14 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > Pavel Sanda wrote: >> > Which ones? >> >> the spellchecker vars, eg std::string spellchecker_alt_lang; >> just try to find ispell string in those. > > I think all pref settings make perfect sense for aspell. grep and sed tell me that spellchecker_use_input_encoding,

Re: [patch] fix bug 5610: description wrong in beamer

2009-01-14 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Still, I wonder why beamer needs such 'protection' whereas the other > classes are happy as-is. This is a bug in beamer IMO. I guess this is because beamer (the lyxframe command, for that matter) does some tricky token scanning in order to detect the various argument

Re: [patch] fix bug 5610: description wrong in beamer

2009-01-14 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > http://bugzilla.lyx.org/show_bug.cgi?id=5610 > > Objections? If not, I'd like to put this into 1.6.1svn (and trunk), > since it strikes my straightforward. Still, I wonder why beamer needs such 'protection' whereas the other classes are happy as-is. This is a bug in

Re: [patch] fix bug 5682

2009-01-14 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > > BTW, why did we remove the %-items from hspace and vspace again? I think > > that > >  > \hspace{0.25\linewidth} or \vspace{.5\textheight} might be quite useful, >  > wouldn't it? > > Yes it would, but \h(v)space don't allow relative units. Sure? The following works for me as

Re: LyX-List and KOMA Labeling

2009-01-14 Thread Guenter Milde
On 2009-01-13, Jean-Marc Lasgouttes wrote: > Jürgen Spitzmüller writes: >> I'm still undecided (apart from the fact that I do not like renaming >> of "Labeling"). I can happily live with renaming "List" to "Labeling" instead (as long as the LyX documentation is updated). (Actually, my private l