Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Pavel Sanda
Tommaso Cucinotta wrote: Unfortunately, it does not seem to currently work if you open the child document only (e.g., only b.lyx), but not its master -- if there is any with the expection of documents, which have set default master in settings there is no way how to know the master. so i

Re: [Patch] LyXErr into progress debug pane

2009-12-30 Thread Jean-Marc Lasgouttes
Le 29 déc. 09 à 21:15, Pavel Sanda a écrit : Andre Poenitz wrote: why we need is quite clear - there is xtimes the same code and we dont want to copy nad paste it. i dont like the macro solution but i failed to produce template which would be desirable for this. either my c++ skills are

Re: [Patch] LyXErr into progress debug pane

2009-12-30 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: What's the code you try to get working? look at the Peter's patch in next message: +LyXErr toStream(LyXErr l, T t) but now instead of toStream... i would like to write it as operator. Write the operator template, and then declare each specialization like

Re: [Patch] LyXErr into progress debug pane

2009-12-30 Thread Peter Kümmel
rgheck wrote: On 12/29/2009 02:22 PM, Peter Kümmel wrote: After the reply to JMarc I also tought about a template solution. Attached a patch, but it's tested only with msvc. Don't you only need the one specialization, if all the others are different? rh Making the operator a

Re: r32670 - in lyx-devel/trunk/src: frontends/qt4 frontends/qt4/ui support

2009-12-30 Thread Peter Kümmel
Pavel Sanda wrote: Pavel Sanda wrote: kuem...@lyx.org wrote: +struct LevelButton : QRadioButton +{ + LevelButton(const QString name) : QRadioButton(name) {} + Debug::Type level; +}; we will need checkboxes or buttons, since the levels can be combined. you can set eg files+version

Re: r32670 - in lyx-devel/trunk/src: frontends/qt4 frontends/qt4/ui support

2009-12-30 Thread Peter Kümmel
Pavel Sanda wrote: kuem...@lyx.org wrote: +struct LevelButton : QRadioButton +{ +LevelButton(const QString name) : QRadioButton(name) {} +Debug::Type level; +}; we will need checkboxes or buttons, since the levels can be combined. you can set eg files+version control debug level.

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Tommaso Cucinotta
Pavel Sanda wrote: Tommaso Cucinotta wrote: Unfortunately, it does not seem to currently work if you open the child document only (e.g., only b.lyx), but not its master -- if there is any with the expection of documents, which have set default master in settings there is no way how

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Pavel Sanda
Tommaso Cucinotta wrote: std::vector is used many times - its maybe time for using clause in .cpp didn't get it -- please, explain i just meant that having using namespace std; one does not need std:: prefixes. pavel

Re: r32670 - in lyx-devel/trunk/src: frontends/qt4 frontends/qt4/ui support

2009-12-30 Thread Pavel Sanda
Peter Kümmel wrote: we will need checkboxes or buttons, since the levels can be combined. you can set eg files+version control debug level. i'm not sure its easy job, it would be fine to use use more horizontal space of the window for the boxes, eg. two or three columns. feel free

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Tommaso Cucinotta
Tommaso Cucinotta wrote: ok, so I would disable the master document option if currentMainWA()-buffer()-masterBuffer() == currentMainWA()-buffer() or smth. like that. I'll circulate an updated patch before committing. please, find it attached (it also checks the children of the

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Pavel Sanda
Tommaso Cucinotta wrote: Perhaps it may be better to leave the user with the puzzle of whether choosing Current Document or Master Document even if he/she has no clue i'm fine with that. pavel

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Tommaso Cucinotta
Pavel Sanda wrote: i'm fine with that. pavel it's in: r32678 and r32679 (cosmetics) Next (hope easy) step should be All open documents scope. After that, it should be trivial to search for All documentation, once we have a means for opening all documentation buffers -- any way for doing

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Pavel Sanda
Tommaso Cucinotta wrote: Pavel Sanda wrote: i'm fine with that. pavel it's in: r32678 and r32679 (cosmetics) so fixedintrunk for #4422 ? Next (hope easy) step should be All open documents scope. After that, it should be trivial to search for All documentation, that would be fine and

[patch] Automated formatting of Keytest bug reports.

2009-12-30 Thread John McCabe-Dansted
The attached patch allows most of the fields in the trac bugreport to filled in with one click from the keytest summary page. The hope is that this would help ensure that the keytest bug-reports are consistent, complete and accurate. An example of a bug entered using this button:

FindAdv - OpenDocuments Scope (was: Re: FindAdv - MasterDocument Scope)

2009-12-30 Thread Tommaso Cucinotta
Tommaso Cucinotta wrote: Next (hope easy) step should be All open documents scope. r32680 Open more than 1 file (e.g., two or three Help Manuals), C-S-f, switch to Advanced pane, select Open Documents, then keep searching, and you get occurrences in all open buffers (ordering is the same as

Re: r32680 - in lyx-devel/trunk/src: . frontends/qt4 frontends/qt4/ui

2009-12-30 Thread rgheck
On 12/30/2009 04:50 PM, tomm...@lyx.org wrote: Modified: lyx-devel/trunk/src/lyxfind.cpp == --- lyx-devel/trunk/src/lyxfind.cpp Wed Dec 30 19:58:20 2009(r32679) +++ lyx-devel/trunk/src/lyxfind.cpp Wed Dec

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Tommaso Cucinotta
Pavel Sanda wrote: it's in: r32678 and r32679 (cosmetics) so fixedintrunk for #4422 ? Yes, r32678 fixes bug #4422 (when using the Advanced Find feature). You can close/fixedintrunk it, AFAICS. Next (hope easy) step should be All open documents scope. After that, it should be trivial

Re: r32680 - in lyx-devel/trunk/src: . frontends/qt4 frontends/qt4/ui

2009-12-30 Thread Tommaso Cucinotta
rgheck wrote: On 12/30/2009 04:50 PM, tomm...@lyx.org wrote: +bool prev_open_buffer(Buffer * p_buf) { +BufferList::const_iterator it = find(theBufferList().begin(), theBufferList().end(), p_buf); +LASSERT(it != theBufferList().end(), /**/) +if (it == theBufferList().begin()) { +

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread rgheck
On 12/30/2009 05:05 PM, Tommaso Cucinotta wrote: ? Is there any loop going over all manuals that builds the Help Menu ? No. It's hardcoded in classic.ui. rh

markDirty() on Current- or Document- Buffer ?

2009-12-30 Thread Tommaso Cucinotta
Hello, after C-S-f, when I type whatever in the Find WorkArea, the document buffer is marked dirty, which is wrong. With the attached patch, the markDirty() is redirected on the Find WA itself, which may actually be useless, but at the end a temporary dirty buffer is ignored. However, other

Re: markDirty() on Current- or Document- Buffer ?

2009-12-30 Thread Tommaso Cucinotta
Given the line that follows: - doc_buffer-markDirty(); + lv-currentBufferView()-buffer().markDirty(); if (lv lv-currentBufferView()) { // BufferView::update() updates

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Pavel Sanda
Tommaso Cucinotta wrote: Yes, r32678 fixes bug #4422 (when using the Advanced Find feature). You can close/fixedintrunk it, AFAICS. Next (hope easy) step should be All open documents scope. After that, it should be trivial to search for All documentation, that would be fine and fix

Are info and label dialogs broken?

2009-12-30 Thread Bo Peng
Dear all, In the spirit of a new year, I checked out the lyx trunk and would like to see what has been done to lyx in order to fix perhaps a number of standing insetInfo bugs. I was pleasantly surprised that scons is still working and compiled the trunk without problem under a Ubuntu 9.10 system.

Re: Are info and label dialogs broken?

2009-12-30 Thread Bo Peng
Is the file marked read-only? Yes, but the values should still be populated to the dialogs, right? At least the figure dialog displays filenames in this case. Or is this a bug for the figure dialog? Bo

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Pavel Sanda
Tommaso Cucinotta wrote: > Unfortunately, it does not seem to currently work if you open the child > document only (e.g., only b.lyx), but not its master -- if there is any with the expection of documents, which have set default master in settings there is no way how to know the master. so i

Re: [Patch] LyXErr into progress debug pane

2009-12-30 Thread Jean-Marc Lasgouttes
Le 29 déc. 09 à 21:15, Pavel Sanda a écrit : Andre Poenitz wrote: why we need is quite clear - there is xtimes the same code and we dont want to copy nad paste it. i dont like the macro solution but i failed to produce template which would be desirable for this. either my c++ skills are

Re: [Patch] LyXErr into progress debug pane

2009-12-30 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: >>> What's the code you try to get working? >> >> look at the Peter's patch in next message: >> +LyXErr & toStream(LyXErr & l, T t) >> >> but now instead of toStream... i would like to write it as operator<<. > > Write the operator<< template, and then declare each

Re: [Patch] LyXErr into progress debug pane

2009-12-30 Thread Peter Kümmel
rgheck wrote: > On 12/29/2009 02:22 PM, Peter Kümmel wrote: >> After the reply to JMarc I also tought about a template solution. >> Attached a patch, but it's tested only with msvc. >> >> > Don't you only need the one specialization, if all the others are different? > > rh Making the

Re: r32670 - in lyx-devel/trunk/src: frontends/qt4 frontends/qt4/ui support

2009-12-30 Thread Peter Kümmel
Pavel Sanda wrote: > Pavel Sanda wrote: >> kuem...@lyx.org wrote: >>> +struct LevelButton : QRadioButton >>> +{ >>> + LevelButton(const QString& name) : QRadioButton(name) {} >>> + Debug::Type level; >>> +}; >> we will need checkboxes or buttons, since the levels can be combined. >> you can

Re: r32670 - in lyx-devel/trunk/src: frontends/qt4 frontends/qt4/ui support

2009-12-30 Thread Peter Kümmel
Pavel Sanda wrote: > kuem...@lyx.org wrote: >> +struct LevelButton : QRadioButton >> +{ >> +LevelButton(const QString& name) : QRadioButton(name) {} >> +Debug::Type level; >> +}; > > we will need checkboxes or buttons, since the levels can be combined. > you can set eg files+version

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Tommaso Cucinotta
Pavel Sanda wrote: Tommaso Cucinotta wrote: Unfortunately, it does not seem to currently work if you open the child document only (e.g., only b.lyx), but not its master -- if there is any with the expection of documents, which have set default master in settings there is no way how

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Pavel Sanda
Tommaso Cucinotta wrote: >> std::vector is used many times - its maybe time for using clause in .cpp > didn't get it -- please, explain i just meant that having using namespace std; one does not need std:: prefixes. pavel

Re: r32670 - in lyx-devel/trunk/src: frontends/qt4 frontends/qt4/ui support

2009-12-30 Thread Pavel Sanda
Peter Kümmel wrote: > > we will need checkboxes or buttons, since the levels can be combined. > > you can set eg files+version control debug level. > > > > i'm not sure its easy job, it would be fine to use use more horizontal > > space of the window > > for the boxes, eg. two or three columns.

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Tommaso Cucinotta
Tommaso Cucinotta wrote: ok, so I would disable the "master document" option if currentMainWA()->buffer()->masterBuffer() == currentMainWA()->buffer() or smth. like that. I'll circulate an updated patch before committing. please, find it attached (it also checks the children of the

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Pavel Sanda
Tommaso Cucinotta wrote: > Perhaps it may be better to leave the user with the "puzzle" of whether > choosing "Current Document" or "Master Document" even if he/she has no clue i'm fine with that. pavel

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Tommaso Cucinotta
Pavel Sanda wrote: i'm fine with that. pavel it's in: r32678 and r32679 (cosmetics) Next (hope easy) step should be "All open documents" scope. After that, it should be trivial to search for "All documentation", once we have a means for "opening" all documentation buffers -- any way for

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Pavel Sanda
Tommaso Cucinotta wrote: > Pavel Sanda wrote: >> i'm fine with that. >> pavel >> > it's in: r32678 and r32679 (cosmetics) so fixedintrunk for #4422 ? > Next (hope easy) step should be "All open documents" scope. > > After that, it should be trivial to search for "All documentation", that

[patch] Automated formatting of Keytest bug reports.

2009-12-30 Thread John McCabe-Dansted
The attached patch allows most of the fields in the trac bugreport to filled in with one click from the keytest summary page. The hope is that this would help ensure that the keytest bug-reports are consistent, complete and accurate. An example of a bug entered using this button:

FindAdv - OpenDocuments Scope (was: Re: FindAdv - MasterDocument Scope)

2009-12-30 Thread Tommaso Cucinotta
Tommaso Cucinotta wrote: Next (hope easy) step should be "All open documents" scope. r32680 Open more than 1 file (e.g., two or three Help Manuals), C-S-f, switch to "Advanced" pane, select "Open Documents", then keep searching, and you get occurrences in all open buffers (ordering is the

Re: r32680 - in lyx-devel/trunk/src: . frontends/qt4 frontends/qt4/ui

2009-12-30 Thread rgheck
On 12/30/2009 04:50 PM, tomm...@lyx.org wrote: Modified: lyx-devel/trunk/src/lyxfind.cpp == --- lyx-devel/trunk/src/lyxfind.cpp Wed Dec 30 19:58:20 2009(r32679) +++ lyx-devel/trunk/src/lyxfind.cpp Wed Dec

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Tommaso Cucinotta
Pavel Sanda wrote: it's in: r32678 and r32679 (cosmetics) so fixedintrunk for #4422 ? Yes, r32678 fixes bug #4422 (when using the Advanced Find feature). You can close/fixedintrunk it, AFAICS. Next (hope easy) step should be "All open documents" scope. After that, it should be

Re: r32680 - in lyx-devel/trunk/src: . frontends/qt4 frontends/qt4/ui

2009-12-30 Thread Tommaso Cucinotta
rgheck wrote: On 12/30/2009 04:50 PM, tomm...@lyx.org wrote: +bool prev_open_buffer(Buffer *& p_buf) { +BufferList::const_iterator it = find(theBufferList().begin(), theBufferList().end(), p_buf); +LASSERT(it != theBufferList().end(), /**/) +if (it == theBufferList().begin()) { +

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread rgheck
On 12/30/2009 05:05 PM, Tommaso Cucinotta wrote: ? Is there any loop going over all manuals that builds the Help Menu ? No. It's hardcoded in classic.ui. rh

markDirty() on Current- or Document- Buffer ?

2009-12-30 Thread Tommaso Cucinotta
Hello, after C-S-f, when I type whatever in the Find WorkArea, the document buffer is marked dirty, which is wrong. With the attached patch, the markDirty() is redirected on the Find WA itself, which may actually be useless, but at the end a temporary dirty buffer is ignored. However, other

Re: markDirty() on Current- or Document- Buffer ?

2009-12-30 Thread Tommaso Cucinotta
Given the line that follows: - doc_buffer->markDirty(); + lv->currentBufferView()->buffer().markDirty(); if (lv && lv->currentBufferView()) { // BufferView::update()

Re: FindAdv - MasterDocument Scope

2009-12-30 Thread Pavel Sanda
Tommaso Cucinotta wrote: > Yes, r32678 fixes bug #4422 (when using the Advanced Find feature). You can > close/fixedintrunk it, AFAICS. >>> Next (hope easy) step should be "All open documents" scope. >>> >>> After that, it should be trivial to search for "All documentation", >>> >> that

Are info and label dialogs broken?

2009-12-30 Thread Bo Peng
Dear all, In the spirit of a new year, I checked out the lyx trunk and would like to see what has been done to lyx in order to fix perhaps a number of standing insetInfo bugs. I was pleasantly surprised that scons is still working and compiled the trunk without problem under a Ubuntu 9.10 system.

Re: Are info and label dialogs broken?

2009-12-30 Thread Bo Peng
> Is the file marked read-only? Yes, but the values should still be populated to the dialogs, right? At least the figure dialog displays filenames in this case. Or is this a bug for the figure dialog? Bo