Jenkins build is back to normal : Build branch "master" » ubuntu-xenial-qt4-autotools-extended #141

2017-04-06 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/141/

Re: Doxygen sourcedoc: Should there be a non-empty "main" page?

2017-04-06 Thread Christian Ridderström
On 6 April 2017 at 13:47, Jean-Marc Lasgouttes wrote: > Le 04/04/2017 à 22:08, Christian Ridderström a écrit : > >> Hi, >> >> Should the Doxygen docs have a "main page"? At >> https://www.lyx.org/sourcedoc/latest/index.html >> the main page is currently empty. >> >> I

Re: Jenkins build is back to normal : Build branch "master" » ubuntu-xenial-qt4-autotools-extended #118

2017-04-06 Thread Christian Ridderström
On 6 April 2017 at 19:45, Jean-Marc Lasgouttes wrote: > I did that. Please remove your own patch. > I've modified the CI job to not apply _your_ patch ;-) I've also started a new build, so in an hour or two we should see that it works. Thanks, /C

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #140

2017-04-06 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/140/-- Started by an SCM change Building remotely on lyx-linux3 (linux) in workspace

Re: [patch] support for \baselineskip

2017-04-06 Thread Uwe Stöhr
El 06.04.2017 a las 10:50, Jean-Marc Lasgouttes escribió: Concerning the code in Length::inInch: the value normally needs to take into account the line spacing setting of the document. I understand that it is difficult to obtain here, but a minimal action would be to document this shortcoming

Re: [patch] support for \baselineskip

2017-04-06 Thread Uwe Stöhr
El 06.04.2017 a las 09:41, Jean-Marc Lasgouttes escribió: Le 06/04/2017 à 08:08, Pavel Sanda a écrit : I don't have strong opinion whether BLS should or shouldn't be available for both horizontal and vertical. I however dislike the code you posted. The easy way how to 'fix' it is to drop all

Re: [patch] support for fontspec options

2017-04-06 Thread Uwe Stöhr
El 06.04.2017 a las 12:01, Jürgen Spitzmüller escribió: I mean we need to think about a sensible UI instead of cluttering the dialog with three more line widgets. And I think we should not attempt to push in one feature after the other at this point, but rather focus on stabilizing and

Re: Re-organizing templates and examples folders (#8715)

2017-04-06 Thread Richard Heck
On 04/06/2017 03:46 AM, Jean-Marc Lasgouttes wrote: > Le 06/04/2017 à 05:44, Scott Kostyshak a écrit : >> Dear all, >> >> There is a proposal to reorganize templates and examples folders. If we >> do want to do it, I think that soon would be a good time. >> >> To take a look at the proposal, check

Re: Jenkins build is back to normal : Build branch "master" » ubuntu-xenial-qt4-autotools-extended #118

2017-04-06 Thread Jean-Marc Lasgouttes
I did that. Please remove your own patch. JMarc Le 6 avril 2017 13:47:40 GMT+02:00, Jean-Marc Lasgouttes a écrit : >> I've forgotten the topic, but perhaps this patch should go into >master >> at some suitable point. > >I am going to do it right now.

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #139

2017-04-06 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/139/-- Started by an SCM change Building remotely on lyx-linux3 (linux) in workspace

Re: [patch] Re: LyX master still not ready for Python 3

2017-04-06 Thread José Abílio Matos
On Wednesday, 5 April 2017 21.08.09 WEST Enrico Forestieri wrote: > Most probably you have some non-ascii characters in a \DeclareLaTeXClass > line in some of your layout files. Now those files are explicitly read as > utf-8 encoded. If this is so, the attached patch should help. It should be

Re: Doxygen sourcedoc: Should there be a non-empty "main" page?

2017-04-06 Thread Jean-Marc Lasgouttes
Le 04/04/2017 à 22:08, Christian Ridderström a écrit : Hi, Should the Doxygen docs have a "main page"? At https://www.lyx.org/sourcedoc/latest/index.html the main page is currently empty. I don't know if this is an error on my side, or if we simply haven't created a main page. I really

Re: Jenkins build is back to normal : Build branch "master" » ubuntu-xenial-qt4-autotools-extended #118

2017-04-06 Thread Jean-Marc Lasgouttes
Le 04/04/2017 à 21:44, Christian Ridderström a écrit : I modified the configuration of the CI job such that it applies your patch before trying to build: 0001-Require-automake-1.14-and-autoconf-2.65.patch I've forgotten the topic, but perhaps this patch should go into master at some suitable

Re: [LyX/master] Work around bug in QTextLine::xToCursor

2017-04-06 Thread Jean-Marc Lasgouttes
Le 06/04/2017 à 05:05, Scott Kostyshak a écrit : To make sure I understand, you are against the attached patch because the changes are not as complicated as in the iconv case, right? No, I would be against the attached because it is wrong: what should be in ifdef is the if(){} else{} and

Re: tex2lyx tests currently broken on master

2017-04-06 Thread Kornel Benko
Am Mittwoch, 5. April 2017 um 23:21:12, schrieb Scott Kostyshak > The tex2lyx tests are currently broken on master. > > Scott For me it looks like src/tex2lyx/test/runtests.py is not python3 ready yet. The errors are File

Re: [patch] support for fontspec options

2017-04-06 Thread Jürgen Spitzmüller
2017-04-06 9:31 GMT+02:00 Uwe Stöhr : > > *From: *Jürgen Spitzmüller > *Sent: *Donnerstag, 6. April 2017 08:53‎ > > > This looks rather ugly. I think we should integrate this properly for > 2.4 and not hectically push something into 2.3. > > What do you mean? This is what I

Re: [LyX/master] support to indent formulas

2017-04-06 Thread Jean-Marc Lasgouttes
Le 06/04/2017 à 11:03, "Uwe Stöhr" a écrit : Gesendet: Donnerstag, 06. April 2017 um 04:03 Uhr Von: "Scott Kostyshak" Please see my attached before/after screenshots. What are the before/after screenshots you see on Windows? Hi Scott, what do you mean? I added 3 elements

Re: [LyX/master] Add support to cross out characters

2017-04-06 Thread Jean-Marc Lasgouttes
Le 06/04/2017 à 10:59, "Uwe Stöhr" a écrit : If you find a better solution to paint the strokes, please improve my drawing routine accordingly. That is not how it works. Actually, I propose to add a rule to our coding rules that says that no code which does not take in account zoom and DPI

Re: [LyX/master] support to indent formulas

2017-04-06 Thread Uwe Stöhr
> Gesendet: Donnerstag, 06. April 2017 um 04:03 Uhr > Von: "Scott Kostyshak" > > Please see my attached before/after screenshots. What are the > before/after screenshots you see on Windows? Hi Scott, what do you mean? I added 3 elements to the UI. I cannot see anything

Re: [LyX/master] Add support to cross out characters

2017-04-06 Thread Uwe Stöhr
Von: "Scott Kostyshak" > Uwe, I've tested but there are a lot of crosses. For example, see the attached screenshot. It seems the number of crosses depends on the level of zoom, which I don't think makes sense. Also, if you change the font size, the number of crosses in the PDF

Re: [patch] support for \baselineskip

2017-04-06 Thread Jean-Marc Lasgouttes
Le 02/04/2017 à 14:52, Uwe Stöhr a écrit : After only 7 years ;-) I found time to finish a patch to support \baselineskip, see attached. The patch is a fileformat change. \baselineskip is the distance between the baseline of 2 subsequent text lines in a paragraph. Therefore

Re: [patch] Re: LyX master still not ready for Python 3

2017-04-06 Thread José Abílio Matos
On Wednesday, 5 April 2017 21.48.21 WEST Uwe Stöhr wrote: > El 05.04.2017 a las 22:08, Enrico Forestieri escribió: > > Most probably you have some non-ascii characters in a \DeclareLaTeXClass > > line in some of your layout files. Now those files are explicitly read as > > utf-8 encoded. If this

Re: [patch] Re: LyX master still not ready for Python 3

2017-04-06 Thread José Abílio Matos
On Wednesday, 5 April 2017 09.38.24 WEST Kornel Benko wrote: > ATM cmake(lyx) checks for python >= 2.7. I stand corrected then. :-) Thank you Kornel. -- José Abílio

Re: [LyX/master] Add support to cross out characters

2017-04-06 Thread José Abílio Matos
On Thursday, 6 April 2017 02.56.51 WEST Scott Kostyshak wrote: > I see it's used in other places in lyx2lyx (grep for '== True'), so > perhaps this is convention in Python? Nope. The convention is the former: if changed: ... -- José Abílio

Re: [LyX/master] support to indent formulas

2017-04-06 Thread Jean-Marc Lasgouttes
Le 05/04/2017 à 22:22, Uwe Stöhr a écrit : commit 808339790c94b0bffa316efddc7e913bd83c91c7 Author: Uwe Stöhr Date: Wed Apr 5 22:22:47 2017 +0200 support to indent formulas - adds support for the general document class option fleqn - adds support to specify the

Re: Re-organizing templates and examples folders (#8715)

2017-04-06 Thread Jean-Marc Lasgouttes
Le 06/04/2017 à 05:44, Scott Kostyshak a écrit : Dear all, There is a proposal to reorganize templates and examples folders. If we do want to do it, I think that soon would be a good time. To take a look at the proposal, check out: http://www.lyx.org/trac/ticket/8715 I did take a look,

Re: [patch] support for \baselineskip

2017-04-06 Thread Jean-Marc Lasgouttes
Le 06/04/2017 à 08:08, Pavel Sanda a écrit : I don't have strong opinion whether BLS should or shouldn't be available for both horizontal and vertical. I however dislike the code you posted. The easy way how to 'fix' it is to drop all these removeUnits on various places and thus effectively

Re: [patch] support for fontspec options

2017-04-06 Thread Uwe Stöhr

Re: [patch] support for fontspec options

2017-04-06 Thread Jürgen Spitzmüller
This looks rather ugly. I think we should integrate this properly for 2.4 and not hectically push something into 2.3. Jürgen 2017-04-06 3:26 GMT+02:00 Uwe Stöhr : > El 06.04.2017 a las 03:24, Uwe Stöhr escribió: > > Attached is the screenshot of the simple UI. >> > > Now it is

Re: [patch] support for \baselineskip

2017-04-06 Thread Pavel Sanda
Uwe Stöhr wrote: >>> + // remove baselineskip from width units >>> + columnWidthUnitLC->removeUnit(Length::BLS); >>> + tabularWidthUnitLC->removeUnit(Length::BLS); >> >> This is ugly. >> >> Unless you want to be consistent and do it for all 'senseless' combinations >> of vert/horiz spacing