Re: [LyX/master] Fix Qt dep warn and remove XLFD font workaround

2020-03-20 Thread Scott Kostyshak
On Fri, Mar 20, 2020 at 06:37:20PM +0100, Pavel Sanda wrote: > On Thu, Mar 19, 2020 at 05:12:19PM +0100, Scott Kostyshak wrote: > > commit d4ff3a295959d27e21fb914d78505cebd96732ad > > Author: Scott Kostyshak > > Date: Thu Mar 19 12:20:16 2020 -0400 > > > > Fix Qt dep warn and remove XLFD

Re: Master tree: Missing \endcsname inserted.

2020-03-20 Thread Kornel Benko
Am Fri, 20 Mar 2020 17:19:46 -0400 schrieb Richard Kimberly Heck : > On 3/20/20 3:55 PM, Kornel Benko wrote: > > Am Fri, 20 Mar 2020 15:26:47 -0400 > > schrieb Richard Kimberly Heck : > > > >> On 3/20/20 2:44 PM, Kornel Benko wrote: > >>> This is the latex message I get compiling for instance

Re: Master tree: Missing \endcsname inserted.

2020-03-20 Thread Richard Kimberly Heck
On 3/20/20 3:55 PM, Kornel Benko wrote: > Am Fri, 20 Mar 2020 15:26:47 -0400 > schrieb Richard Kimberly Heck : > >> On 3/20/20 2:44 PM, Kornel Benko wrote: >>> This is the latex message I get compiling for instance Additional.lyx. >>> >>> Bisect lead to >>> Author: Richard Kimberly Heck >>> Date:

Re: Registry handling on windows (installer)

2020-03-20 Thread Yu Jin
Am Fr., 20. März 2020 um 20:16 Uhr schrieb Richard Kimberly Heck < rikih...@lyx.org>: > On 3/20/20 1:47 PM, Pavel Sanda wrote: > > On Tue, Mar 17, 2020 at 10:26:16AM +0100, Yu Jin wrote: > >>> I have created a batch file, which deletes the redundant files. I have > >>> decided to delete

Re: Master tree: Missing \endcsname inserted.

2020-03-20 Thread Kornel Benko
Am Fri, 20 Mar 2020 15:26:47 -0400 schrieb Richard Kimberly Heck : > On 3/20/20 2:44 PM, Kornel Benko wrote: > > This is the latex message I get compiling for instance Additional.lyx. > > > > Bisect lead to > > Author: Richard Kimberly Heck > > Date: Tue Mar 17 01:50:28 2020 -0400 > > > >

Re: Save on save

2020-03-20 Thread Daniel
On 2020-03-20 19:34, Pavel Sanda wrote: On Fri, Mar 20, 2020 at 07:12:00PM +0100, Daniel wrote: I think such an indication is optional, but might be a good idea. Except for libre office I saw no other application that has this indication. Maybe because the indication in the title is already

Re: Master tree: Missing \endcsname inserted.

2020-03-20 Thread Richard Kimberly Heck
On 3/20/20 2:44 PM, Kornel Benko wrote: > This is the latex message I get compiling for instance Additional.lyx. > > Bisect lead to > Author: Richard Kimberly Heck > Date: Tue Mar 17 01:50:28 2020 -0400 > > Track whether title has been issued via OutputParams. > > When branches are

Re: Registry handling on windows (installer)

2020-03-20 Thread Richard Kimberly Heck
On 3/20/20 1:47 PM, Pavel Sanda wrote: > On Tue, Mar 17, 2020 at 10:26:16AM +0100, Yu Jin wrote: >>> I have created a batch file, which deletes the redundant files. I have >>> decided to delete convert.exe and leave magick.exe, because it aligns with >>> the installed version of imagemagick and

Master tree: Missing \endcsname inserted.

2020-03-20 Thread Kornel Benko
This is the latex message I get compiling for instance Additional.lyx. Bisect lead to Author: Richard Kimberly Heck Date: Tue Mar 17 01:50:28 2020 -0400 Track whether title has been issued via OutputParams. When branches are used in the title, we may need to track whether

Re: Save on save

2020-03-20 Thread Pavel Sanda
On Fri, Mar 20, 2020 at 07:12:00PM +0100, Daniel wrote: > I think such an indication is optional, but might be a good idea. Except for > libre office I saw no other application that has this indication. Maybe > because the indication in the title is already considered sufficient? As far as I

Re: Save on save

2020-03-20 Thread Daniel
On 2020-03-20 18:46, Pavel Sanda wrote: On Fri, Mar 20, 2020 at 11:15:11AM -0400, Richard Kimberly Heck wrote: I looked briefly at this. I think we would need to check that Buffer::isClean is not used for otherpurposes, or else introduce some other Buffer::canSave method for this purpose. I

Re: Registry handling on windows (installer)

2020-03-20 Thread Pavel Sanda
On Tue, Mar 17, 2020 at 10:26:16AM +0100, Yu Jin wrote: > > I have created a batch file, which deletes the redundant files. I have > > decided to delete convert.exe and leave magick.exe, because it aligns with > > the installed version of imagemagick and with what was shipped with LyX > > until

Re: Save on save

2020-03-20 Thread Pavel Sanda
On Fri, Mar 20, 2020 at 11:15:11AM -0400, Richard Kimberly Heck wrote: > I looked briefly at this. I think we would need to check that > Buffer::isClean is not used for otherpurposes, or else introduce some > other Buffer::canSave method for this purpose. I guess we would need some new state,

Re: [LyX/master] Fix Qt dep warn and remove XLFD font workaround

2020-03-20 Thread Pavel Sanda
On Thu, Mar 19, 2020 at 05:12:19PM +0100, Scott Kostyshak wrote: > commit d4ff3a295959d27e21fb914d78505cebd96732ad > Author: Scott Kostyshak > Date: Thu Mar 19 12:20:16 2020 -0400 > > Fix Qt dep warn and remove XLFD font workaround ... > I tested that compilation with Qt 4.8.7 works

Re: Save on save

2020-03-20 Thread Richard Kimberly Heck
On 3/20/20 7:30 AM, Kornel Benko wrote: > Am Fri, 20 Mar 2020 10:19:05 +0100 > schrieb Jean-Marc Lasgouttes : > >> Le 20/03/2020 à 08:11, Daniel a écrit : >>> Save As is a bit complicated as a general replacement for Save. But I >>> can't remember to use it just for some cases. When I make

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

2020-03-20 Thread Scott Kostyshak
On Fri, Mar 20, 2020 at 03:08:20PM +0100, Jean-Marc Lasgouttes wrote: > Le 20/03/2020 à 14:49, Scott Kostyshak a écrit : > > > I would say that we don't care, so width() is better since is is shorter > > > and > > > easier to understand :) > > > > Just to double-check: By width() you mean

Re: [PATCH] cat.py: fix Python deprecation warning

2020-03-20 Thread Scott Kostyshak
On Fri, Mar 20, 2020 at 12:29:34PM +0100, Kornel Benko wrote: > Am Thu, 19 Mar 2020 18:53:46 -0400 > schrieb Scott Kostyshak : > > > See attached patch regarding our development script cat.py. It fixes a > > Python 3 deprecation warning. However, I believe it changes behavior > > with Python 2.

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

2020-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2020 à 14:49, Scott Kostyshak a écrit : I would say that we don't care, so width() is better since is is shorter and easier to understand :) Just to double-check: By width() you mean boundingRect().width(), and yes you are saying it is shorter than horizontalAdvance() because we do

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

2020-03-20 Thread Scott Kostyshak
On Fri, Mar 20, 2020 at 10:17:51AM +0100, Jean-Marc Lasgouttes wrote: > Le 20/03/2020 à 03:41, Scott Kostyshak a écrit : > > > The entry in the change log hints (from my understanding) that it is a > > > renaming, but the blog article I linked to suggests things could be more > > > complicated. >

Re: [LyX/master] Fix Qt dep warn and remove XLFD font workaround

2020-03-20 Thread Scott Kostyshak
On Fri, Mar 20, 2020 at 12:15:32PM +0100, Enrico Forestieri wrote: > On Thu, Mar 19, 2020 at 05:12:19PM +0100, Scott Kostyshak wrote: > > commit d4ff3a295959d27e21fb914d78505cebd96732ad > > Author: Scott Kostyshak > > Date: Thu Mar 19 12:20:16 2020 -0400 > > > > Fix Qt dep warn and remove

Re: Save on save

2020-03-20 Thread Kornel Benko
Am Fri, 20 Mar 2020 10:19:05 +0100 schrieb Jean-Marc Lasgouttes : > Le 20/03/2020 à 08:11, Daniel a écrit : > > Save As is a bit complicated as a general replacement for Save. But I > > can't remember to use it just for some cases. When I make changes to > > insets that seem important to me I

Re: [PATCH] cat.py: fix Python deprecation warning

2020-03-20 Thread Kornel Benko
Am Thu, 19 Mar 2020 18:53:46 -0400 schrieb Scott Kostyshak : > See attached patch regarding our development script cat.py. It fixes a > Python 3 deprecation warning. However, I believe it changes behavior > with Python 2. The script has a "python3" shebang line (see > 3f03f0a447e), however that

Re: [LyX/master] Fix Qt dep warn and remove XLFD font workaround

2020-03-20 Thread Enrico Forestieri
On Thu, Mar 19, 2020 at 05:12:19PM +0100, Scott Kostyshak wrote: > commit d4ff3a295959d27e21fb914d78505cebd96732ad > Author: Scott Kostyshak > Date: Thu Mar 19 12:20:16 2020 -0400 > > Fix Qt dep warn and remove XLFD font workaround [...] > @@ -215,11 +204,8 @@ QFont symbolFont(QString

Re: Save on save

2020-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2020 à 08:11, Daniel a écrit : Save As is a bit complicated as a general replacement for Save. But I can't remember to use it just for some cases. When I make changes to insets that seem important to me I just think I should be able to save them as I save every other document change.

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

2020-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2020 à 03:41, Scott Kostyshak a écrit : The entry in the change log hints (from my understanding) that it is a renaming, but the blog article I linked to suggests things could be more complicated. Looking at the code, it does seem to be equivalent: qreal QFontMetricsF::width(const

Re: Save on save

2020-03-20 Thread Daniel
On 2020-03-19 23:09, Guenter Milde wrote: On 2020-03-19, Richard Kimberly Heck wrote: On 3/19/20 9:46 AM, racoon wrote: On 2020-03-19 14:43, Richard Kimberly Heck wrote: On 3/19/20 5:43 AM, Daniel wrote: All applications (Libre Writer, Pages, Visual Studio Code, TextEdit, etc.) I tested save