Re: New Section Toolbar Button and Depth-setting Suggestion

2020-05-12 Thread Jürgen Spitzmüller
Am Dienstag, den 12.05.2020, 20:07 +0200 schrieb Jean-Marc Lasgouttes: > This would be the patch below pas de patch ci-dessous Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-d

Re: Work on Windows installer

2020-05-12 Thread Jürgen Spitzmüller
Am Mittwoch, den 13.05.2020, 07:30 +0200 schrieb Yu Jin: > 1. I could rewrite everything that I think is doable in a much better > way, this would mean actually creating a new installer, then checking > the old one function by function and then deciding which to rewarite > and which to adopt. This

Work on Windows installer

2020-05-12 Thread Yu Jin
Ive been studying the code for windows installer and understand it pretty well now. However the more I understand it, the more I find it hardly readable and not intuitive. There are many little things that can be made more elegant, but also the whole setup of the files and how they are structured i

Re: New Section Toolbar Button and Depth-setting Suggestion

2020-05-12 Thread Jean-Marc Lasgouttes
Le 11/05/2020 à 08:10, Jürgen Spitzmüller a écrit : For what it's worth, libreoffice's icon does have this double functionality. Yes, that's actually a nifty feature. BTW we already support the feature via Tab/Shift-Tab (I was surprised to find out). This would be the patch below, but this ch

Re: pit_type as unsigned

2020-05-12 Thread Jean-Marc Lasgouttes
Le 11/05/2020 à 23:55, Richard Kimberly Heck a écrit : On 5/11/20 7:00 AM, Jean-Marc Lasgouttes wrote: What about the patch below? I find it ridiculous (and slow) to use next() to access our random access container. I am surprised though by this issue, since using 'begin() + i' in things like in