Re: Cursor intersects with \cap

2020-09-07 Thread Scott Kostyshak
On Tue, Sep 08, 2020 at 02:25:57AM +0200, Enrico Forestieri wrote: > On Mon, Sep 07, 2020 at 07:30:25PM -0400, Scott Kostyshak wrote: > > On Tue, Sep 08, 2020 at 12:11:25AM +0200, Enrico Forestieri wrote: > > > On Mon, Sep 07, 2020 at 03:52:11PM -0400, Scott Kostyshak wrote: > > > > > > > To repro

Re: Cursor intersects with \cap

2020-09-07 Thread Enrico Forestieri
On Mon, Sep 07, 2020 at 07:30:25PM -0400, Scott Kostyshak wrote: > On Tue, Sep 08, 2020 at 12:11:25AM +0200, Enrico Forestieri wrote: > > On Mon, Sep 07, 2020 at 03:52:11PM -0400, Scott Kostyshak wrote: > > > > > To reproduce, open the attached file. Put the cursor just after \cap. It > > > might

Re: Cursor intersects with \cap

2020-09-07 Thread Scott Kostyshak
On Tue, Sep 08, 2020 at 12:11:25AM +0200, Enrico Forestieri wrote: > On Mon, Sep 07, 2020 at 03:52:11PM -0400, Scott Kostyshak wrote: > > > To reproduce, open the attached file. Put the cursor just after \cap. It > > might help to zoom in. For me, it shows that the cursor intersects the > > \cap.

Re: Cursor intersects with \cap

2020-09-07 Thread Enrico Forestieri
On Mon, Sep 07, 2020 at 03:52:11PM -0400, Scott Kostyshak wrote: > To reproduce, open the attached file. Put the cursor just after \cap. It > might help to zoom in. For me, it shows that the cursor intersects the > \cap. For me it does not intersect but the cursor is practically attached to \cap.

Re: [LyX/master] Implement properly \limits and \nolimits

2020-09-07 Thread Enrico Forestieri
On Mon, Sep 07, 2020 at 07:02:39PM +0200, Enrico Forestieri wrote: > On Mon, Sep 07, 2020 at 12:43:35PM +0200, Jean-Marc Lasgouttes wrote: > > Le 07/09/2020 à 01:15, Scott Kostyshak a écrit : > > > I think this might have caused a change in LaTeX exported in some cases. > > > In the attached .lyx f

Re: Cursor intersects with \cap

2020-09-07 Thread Kornel Benko
Am Mon, 7 Sep 2020 15:52:11 -0400 schrieb Scott Kostyshak : > To reproduce, open the attached file. Put the cursor just after \cap. It > might help to zoom in. For me, it shows that the cursor intersects the > \cap. I see it too, but only with BIG zoom. > I see this on master and 2.3.x, but not

Re: [PATCH] Fix uninitialized variable with wrong type

2020-09-07 Thread Kornel Benko
Am Mon, 7 Sep 2020 22:17:01 +0300 schrieb Yuriy Skalko : > Hello. > > I've fixed a minor issue in LyX code: usage of uninitialized variable, > also its type should be signed. > > Patch attached. > > Yuriy > > > From 33d157a6dd359a8f20b9499342f05e57087f6f57 Mon Sep 17 00:00:00 2001 > From: Yur

Cursor intersects with \cap

2020-09-07 Thread Scott Kostyshak
To reproduce, open the attached file. Put the cursor just after \cap. It might help to zoom in. For me, it shows that the cursor intersects the \cap. I see this on master and 2.3.x, but not on 2.3.0. I think it's because there were improvements with respect to 2.3.0 to spacing with these types of

Re: Patch, CMake, fix some warnings in DTL

2020-09-07 Thread Yu Jin
Am Mo., 7. Sept. 2020 um 21:09 Uhr schrieb Kornel Benko : > Am Mon, 7 Sep 2020 20:51:52 +0200 > schrieb Yu Jin : > > > Can I commit the attached patch? It is used here (dtl.h): > > > > #if (defined(__cplusplus) || defined(__STDC__) || defined(c_plusplus)) > > #define STDC 1 > > #else > > #define S

[PATCH] Fix uninitialized variable with wrong type

2020-09-07 Thread Yuriy Skalko
Hello. I've fixed a minor issue in LyX code: usage of uninitialized variable, also its type should be signed. Patch attached. Yuriy >From 33d157a6dd359a8f20b9499342f05e57087f6f57 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Mon, 7 Sep 2020 04:12:54 +0300 Subject: [PATCH] Fix uninitialize

Re: Patch, CMake, fix some warnings in DTL

2020-09-07 Thread Kornel Benko
Am Mon, 7 Sep 2020 20:51:52 +0200 schrieb Yu Jin : > Can I commit the attached patch? It is used here (dtl.h): > > #if (defined(__cplusplus) || defined(__STDC__) || defined(c_plusplus)) > #define STDC 1 > #else > #define STDC 0 > #endif > > /* Version (Traditional or ANSI) of C affects prototype

Patch, CMake, fix some warnings in DTL

2020-09-07 Thread Yu Jin
Can I commit the attached patch? It is used here (dtl.h): #if (defined(__cplusplus) || defined(__STDC__) || defined(c_plusplus)) #define STDC 1 #else #define STDC 0 #endif /* Version (Traditional or ANSI) of C affects prototype and type definitions */ #if STDC #define ARGS(parenthesized_list) par

Re: Possible regression on master regarding integral limit

2020-09-07 Thread Scott Kostyshak
On Mon, Sep 07, 2020 at 12:17:40PM +0200, Jean-Marc Lasgouttes wrote: > Le 02/09/2020 à 23:21, Enrico Forestieri a écrit : > > The suspect being f96b99dc, where the way the math parser deals with > > \limits was changed. Now, \limits gets swallowed on reloading a document. > > Indeed, I was too la

Re: Potential regression on master regarding layout after dissolving inset

2020-09-07 Thread Scott Kostyshak
On Mon, Sep 07, 2020 at 02:33:24PM +0200, Jean-Marc Lasgouttes wrote: > Le 06/09/2020 à 03:22, Scott Kostyshak a écrit : > > There's another issue that seems related, although I'm not sure it is: > > > > 1. Start a new document > > 2. Begin a "Section" layout and enter "abcdef". > > 3. Select "def

Re: Possible regression regarding repainting jump

2020-09-07 Thread Scott Kostyshak
On Mon, Sep 07, 2020 at 12:58:15PM +0200, Jean-Marc Lasgouttes wrote: > Le 07/09/2020 à 10:20, Kornel Benko a écrit : > > Am Sun, 6 Sep 2020 19:36:43 -0400 > > schrieb Scott Kostyshak : > > > > > See the attached mwe, which has instructions to reproduce inside. > > > > > > Scott > > > > I don't

Re: [LyX/master] Implement properly \limits and \nolimits

2020-09-07 Thread Enrico Forestieri
On Mon, Sep 07, 2020 at 12:43:35PM +0200, Jean-Marc Lasgouttes wrote: > Le 07/09/2020 à 01:15, Scott Kostyshak a écrit : > > I think this might have caused a change in LaTeX exported in some cases. > > In the attached .lyx file, if you load with 2.3.x, it does not use the > > package esint. But if

Re: Potential regression on master regarding layout after dissolving inset

2020-09-07 Thread Jean-Marc Lasgouttes
Le 06/09/2020 à 03:22, Scott Kostyshak a écrit : There's another issue that seems related, although I'm not sure it is: 1. Start a new document 2. Begin a "Section" layout and enter "abcdef". 3. Select "def" and go to Insert > Branch > Insert New Branch and put in any branch name. The layou

Re: Possible regression regarding repainting jump

2020-09-07 Thread Jean-Marc Lasgouttes
Le 07/09/2020 à 10:20, Kornel Benko a écrit : Am Sun, 6 Sep 2020 19:36:43 -0400 schrieb Scott Kostyshak : See the attached mwe, which has instructions to reproduce inside. Scott I don't see any difference. Neither in master nor in 2.3.x I see it, preview needs to be off. No idea of what ma

Re: Non-pointed rectangle corners

2020-09-07 Thread Jean-Marc Lasgouttes
Le 06/08/2020 à 12:09, Daniel a écrit : Looks like a good idea. I think though that you could just enforce it and not expose the parameters to our painter. Attached. Is the idea to better not introduce any parameters (complexity) before they become really useful? Racoon, before I commit the

Re: [LyX/master] Implement properly \limits and \nolimits

2020-09-07 Thread Jean-Marc Lasgouttes
Le 07/09/2020 à 01:15, Scott Kostyshak a écrit : I think this might have caused a change in LaTeX exported in some cases. In the attached .lyx file, if you load with 2.3.x, it does not use the package esint. But if you load with master, it does. I think this is related to the following ticket:

Re: Possible regression on master regarding integral limit

2020-09-07 Thread Jean-Marc Lasgouttes
Le 02/09/2020 à 23:21, Enrico Forestieri a écrit : The suspect being f96b99dc, where the way the math parser deals with \limits was changed. Now, \limits gets swallowed on reloading a document. Indeed, I was too lazy to define limits_ in InsetMathMacro::Private, and the consequence is that it

Re: Possible regression regarding repainting jump

2020-09-07 Thread Kornel Benko
Am Sun, 6 Sep 2020 19:36:43 -0400 schrieb Scott Kostyshak : > See the attached mwe, which has instructions to reproduce inside. > > Scott I don't see any difference. Neither in master nor in 2.3.x Kornel pgpWmQpozkY0s.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailin