Re: Surrounding white frame in fullscreen

2020-11-21 Thread Richard Kimberly Heck
On 11/21/20 12:08 PM, Pavel Sanda wrote: > On Sat, Nov 21, 2020 at 05:24:34PM +0100, Stephan Witt wrote: > until (at least) Qt 5.7.1 fullscreen was over the whole screen, in newer > Qt > (tested 5.11.3) there is now two bright pixel frame around (well visible > and > annoying

Re: Preference to disable input completion?

2020-11-21 Thread Scott Kostyshak
On Sat, Nov 21, 2020 at 09:55:03PM +0100, Pavel Sanda wrote: > On Sat, Nov 21, 2020 at 03:07:20PM -0500, Scott Kostyshak wrote: > > do something similar to preview with the combo box. Pavel, would you be > > fine with this or prefer not to add a new preference for this type of > > thing? > > I do

Re: Preference to disable input completion?

2020-11-21 Thread Andrew Parsloe
On 22/11/2020 3:36 am, Scott Kostyshak wrote: You can alway put into your preferences change to the Tab shortcut True. I want to turn input completion off for text completion but leave it on for math completion. Andrew and Joel, if you also want that I already have a patch that I think

Re: Preference to disable input completion?

2020-11-21 Thread Pavel Sanda
On Sat, Nov 21, 2020 at 03:07:20PM -0500, Scott Kostyshak wrote: > do something similar to preview with the combo box. Pavel, would you be > fine with this or prefer not to add a new preference for this type of > thing? I do not have any strong opinion. If the current behaviour infuriates two peop

Spellchecking dictionaries in LyX 2.4 installer

2020-11-21 Thread Yuriy Skalko
The thread grown fast and in different directions, so I want to get it back to the initial proposal. Taking only concrete numbers: I've proposed to include dicts for Russian and Portuguese. Then Joel proposed to include dicts for top 25 languages. And Stephan told that he packages 82 dicts for

Re: Preference to disable input completion?

2020-11-21 Thread Scott Kostyshak
On Sat, Nov 21, 2020 at 12:27:54PM -0700, Joel Kulesza wrote: > On Sat, Nov 21, 2020 at 7:36 AM Scott Kostyshak wrote: > > > I want to turn input completion off for text completion but leave it on > > for math completion. Andrew and Joel, if you also want that I already have > > a patch that I th

Re: Preference to disable input completion?

2020-11-21 Thread Scott Kostyshak
On Sat, Nov 21, 2020 at 04:49:57PM +0100, Jean-Marc Lasgouttes wrote: > Le 21/11/2020 à 16:15, Richard Kimberly Heck a écrit : > > > True. I want to turn input completion off for text completion but leave > > > it on for math completion. Andrew and Joel, if you also want that I > > > already have

Re: Boost in LyX

2020-11-21 Thread Yuriy Skalko
This is how the code is elsewhere. Do you use tab size == 4 ? Yes, 4 spaces, so the formatting below is right? As for me it is hard to separate condition from following statements. if (!current_view_ || (!lyxrc.open_buffers_in_tabs && current_view_->documentBufferView() !

Re: Boost in LyX

2020-11-21 Thread Thibaut Cuvelier
On Sat, 21 Nov 2020 at 20:17, Yuriy Skalko wrote: > > It compiles flawlessly with MSVC 2019 (16.7.1): > > > > C:\Program Files (x86)\Microsoft Visual Studio\2019\Community>cl /v > >> Microsoft (R) C/C++ Optimizing Compiler Version 19.27.29111 for x64 > >> Copyright (C) Microsoft Corporation. All

Re: Preference to disable input completion?

2020-11-21 Thread Joel Kulesza
On Sat, Nov 21, 2020 at 7:36 AM Scott Kostyshak wrote: > I want to turn input completion off for text completion but leave it on > for math completion. Andrew and Joel, if you also want that I already have > a patch that I think does this that I can use locally. Let me know if you > want me to po

Re: Boost in LyX

2020-11-21 Thread Yuriy Skalko
It compiles flawlessly with MSVC 2019 (16.7.1): C:\Program Files (x86)\Microsoft Visual Studio\2019\Community>cl /v Microsoft (R) C/C++ Optimizing Compiler Version 19.27.29111 for x64 Copyright (C) Microsoft Corporation. All rights reserved. However, it fails when linking (but I'm not sure i

Re: Boost in LyX

2020-11-21 Thread Thibaut Cuvelier
On Sat, 21 Nov 2020 at 19:54, Yuriy Skalko wrote: > > > > I like them, but a couple remarks. > > > > * patch 2: broken indentation > > > > if (!current_view_ > > - || (!lyxrc.open_buffers_in_tabs > > - && current_view_->documentBufferView()

Re: Boost in LyX

2020-11-21 Thread Jean-Marc Lasgouttes
Le 21/11/2020 à 19:54, Yuriy Skalko a écrit : I "broke" it because now condition and nested block have same level of indentation and it is hard to see where they are separated. Comment helps but still... This is how the code is elsewhere. Do you use tab size == 4 ? * concerning std::any, curr

Re: Boost in LyX

2020-11-21 Thread Yuriy Skalko
I like them, but a couple remarks. * patch 2: broken indentation if (!current_view_ - || (!lyxrc.open_buffers_in_tabs - && current_view_->documentBufferView() != 0 - && !is_open)) { + || (!lyxrc.

Re: Boost in LyX

2020-11-21 Thread Yuriy Skalko
Le 21/11/2020 à 16:18, Richard Kimberly Heck a écrit : What about to get rid of std algorithms and use just plain range for loops? No lambdas, no boost::range, fast compilation and code speed :) This one looks good to me, but I'd like also to know what JMarc thinks. Person

Re: Surrounding white frame in fullscreen

2020-11-21 Thread Pavel Sanda
On Sat, Nov 21, 2020 at 05:24:34PM +0100, Stephan Witt wrote: > >>> until (at least) Qt 5.7.1 fullscreen was over the whole screen, in newer > >>> Qt > >>> (tested 5.11.3) there is now two bright pixel frame around (well visible > >>> and > >>> annoying if you use dark color schemes). This is be

Re: Surrounding white frame in fullscreen

2020-11-21 Thread Stephan Witt
Am 21.11.2020 um 16:08 schrieb Pavel Sanda : > > On Fri, Nov 20, 2020 at 02:56:06PM +0100, Pavel Sanda wrote: >> On Fri, Nov 20, 2020 at 01:37:28PM +0100, Pavel Sanda wrote: >>> Hi, >>> >>> until (at least) Qt 5.7.1 fullscreen was over the whole screen, in newer Qt >>> (tested 5.11.3) there is no

Re: Boost in LyX

2020-11-21 Thread Jean-Marc Lasgouttes
Le 21/11/2020 à 15:37, Yuriy Skalko a écrit : If Boost is only used for temporary implementation of really useful features from newer standards (and only for older compilers) it should be Ok. And this dependency will drop itself over time. Some steps in this direction are in attached patches.

Re: Boost in LyX

2020-11-21 Thread Jean-Marc Lasgouttes
Le 21/11/2020 à 16:18, Richard Kimberly Heck a écrit : What about to get rid of std algorithms and use just plain range for loops? No lambdas, no boost::range, fast compilation and code speed :) This one looks good to me, but I'd like also to know what JMarc thinks. Personally I prefer it a l

Re: Preference to disable input completion?

2020-11-21 Thread Jean-Marc Lasgouttes
Le 21/11/2020 à 16:15, Richard Kimberly Heck a écrit : True. I want to turn input completion off for text completion but leave it on for math completion. Andrew and Joel, if you also want that I already have a patch that I think does this that I can use locally. Let me know if you want me to po

Re: Boost in LyX

2020-11-21 Thread Richard Kimberly Heck
On 11/20/20 7:50 PM, Yuriy Skalko wrote: >> Le 20/11/2020 à 18:33, Pavel Sanda a écrit : >>> On Fri, Nov 20, 2020 at 04:14:57PM +0100, Jean-Marc Lasgouttes wrote: Le 20/11/2020 ?? 15:33, Yuriy Skalko a écrit : > I assume that it is a template-heavy thing and it can significantly > incr

Re: Preference to disable input completion?

2020-11-21 Thread Richard Kimberly Heck
On 11/21/20 9:36 AM, Scott Kostyshak wrote: > On Sat, Nov 21, 2020 at 03:20:52PM +0100, Pavel Sanda wrote: >> On Sat, Nov 21, 2020 at 09:14:43AM -0500, Scott Kostyshak wrote: >>> On Sat, Nov 21, 2020 at 10:10:53AM +1300, Andrew Parsloe wrote: On 21/11/2020 3:28 am, Joel Kulesza wrote: > On

Re: Surrounding white frame in fullscreen

2020-11-21 Thread Pavel Sanda
On Fri, Nov 20, 2020 at 02:56:06PM +0100, Pavel Sanda wrote: > On Fri, Nov 20, 2020 at 01:37:28PM +0100, Pavel Sanda wrote: > > Hi, > > > > until (at least) Qt 5.7.1 fullscreen was over the whole screen, in newer Qt > > (tested 5.11.3) there is now two bright pixel frame around (well visible and >

Re: Boost in LyX

2020-11-21 Thread Yuriy Skalko
If Boost is only used for temporary implementation of really useful features from newer standards (and only for older compilers) it should be Ok. And this dependency will drop itself over time. Some steps in this direction are in attached patches. Yuriy From 32ac6a047bda71c47c17a4ff1417bd273a

Re: Preference to disable input completion?

2020-11-21 Thread Scott Kostyshak
On Sat, Nov 21, 2020 at 03:20:52PM +0100, Pavel Sanda wrote: > On Sat, Nov 21, 2020 at 09:14:43AM -0500, Scott Kostyshak wrote: > > On Sat, Nov 21, 2020 at 10:10:53AM +1300, Andrew Parsloe wrote: > > > On 21/11/2020 3:28 am, Joel Kulesza wrote: > > > > On Thu, Nov 19, 2020 at 8:28 PM Scott Kostysha

Re: Preference to disable input completion?

2020-11-21 Thread Pavel Sanda
On Sat, Nov 21, 2020 at 09:14:43AM -0500, Scott Kostyshak wrote: > On Sat, Nov 21, 2020 at 10:10:53AM +1300, Andrew Parsloe wrote: > > On 21/11/2020 3:28 am, Joel Kulesza wrote: > > > On Thu, Nov 19, 2020 at 8:28 PM Scott Kostyshak > > > wrote: > > > > > > Does anyone

Re: Preference to disable input completion?

2020-11-21 Thread Scott Kostyshak
On Sat, Nov 21, 2020 at 10:10:53AM +1300, Andrew Parsloe wrote: > On 21/11/2020 3:28 am, Joel Kulesza wrote: > > On Thu, Nov 19, 2020 at 8:28 PM Scott Kostyshak > > wrote: > > > > Does anyone else find (non-automatic) completion annoying in text > > mode? > > >