Re: [Windows] Remove the default binding between buffer-zoom and Alt+0

On 1/14/21 8:00 PM, Thibaut Cuvelier wrote: > Dear list, > > On Windows, you use the Alt key to enter special characters. For > instance, Alt+0156 for œ, Alt+0171 for «, or ALT+0187 for ». Few > standard keyboard layouts propose these characters. > > However, by default, in LyX, this has a very pro

[Windows] Remove the default binding between buffer-zoom and Alt+0

Dear list, On Windows, you use the Alt key to enter special characters. For instance, Alt+0156 for œ, Alt+0171 for «, or ALT+0187 for ». Few standard keyboard layouts propose these characters. However, by default, in LyX, this has a very problematic side-effect: Alt+0 resets the zoom level to zer

Re: Use C++ testing framework

On 1/14/21 6:24 PM, Yuriy Skalko wrote: >> I hope that developers will respond to this and say "The ctests suck. >> If they were simple unit tests then I would contribute to writing >> them and I would run them before I commit!". I will (seriously) be >> happy to see such messages. >> >> In any cas

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

OK, now will you commit the replacements? Kornel Please commit them. I don't have patch and only figured out why that call is considered ambiguous by Clang. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Use C++ testing framework

Thanks for continuing this conversation, Yuriy. Scott, thanks for such detailed reply. I'm strongly in favor of a unit testing framework. That said, I just don't think most LyX developers are. I don't know if it's because writing tests is not fun or if the belief is that the time spent to wr

Re: Update docs on the wiki

Le 14 janvier 2021 22:10:48 Pavel Sanda a écrit : On Thu, Jan 14, 2021 at 02:00:22PM +0100, Jean-Pierre Chrétien wrote: Hello, I'm about to update the docs on the wiki. Could someone give me privately the identity and password to connect to ftp://wiki.lyx.org ? Sent privately. P Thanks, P

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Am Thu, 14 Jan 2021 22:00:33 +0200 schrieb Yuriy Skalko : > > > > Maybe '-std=c++17'? > > AFAIR Scott successfully compiled LyX with -std=c++20 on Clang. Other > compiler options also seem usual. > > > Yuriy OK, now will you commit the replacements? Kornel pgpOik6ZxF44D.pgp Desc

Re: Update docs on the wiki

On 1/14/21 4:09 PM, Pavel Sanda wrote: On Thu, Jan 14, 2021 at 02:00:22PM +0100, Jean-Pierre Chrétien wrote: Hello, I'm about to update the docs on the wiki. Could someone give me privately the identity and password to connect to ftp://wiki.lyx.org ? Sent privately. Can you send it to me as

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Am 14.01.2021 um 20:56 schrieb Yuriy Skalko : > >> I used the debugger to bring some light into it. > > Thanks Stephan. It crashes on the call to move(?) assignment operator, but it > is still not clear looking on these sources. I haven't tried Valgrind yet. To trigger the crash I picked the se

Re: Update docs on the wiki

On Thu, Jan 14, 2021 at 02:00:22PM +0100, Jean-Pierre Chrétien wrote: > Hello, > > I'm about to update the docs on the wiki. Could someone give me privately > the identity and password to connect to ftp://wiki.lyx.org ? Sent privately. P -- lyx-devel mailing list lyx-devel@lists.lyx.org http://l

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Maybe '-std=c++17'? AFAIR Scott successfully compiled LyX with -std=c++20 on Clang. Other compiler options also seem usual. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

I used the debugger to bring some light into it. Thanks Stephan. It crashes on the call to move(?) assignment operator, but it is still not clear looking on these sources. I haven't tried Valgrind yet. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/list

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Am 14.01.2021 um 19:45 schrieb Scott Kostyshak : > > On Thu, Jan 14, 2021 at 05:36:58PM +0100, Jean-Marc Lasgouttes wrote: >> Le 14/01/2021 à 16:53, Scott Kostyshak a écrit : >>> On Thu, Jan 14, 2021 at 09:34:37AM +0100, Jean-Marc Lasgouttes wrote: Le 13/01/2021 à 17:59, Scott Kostyshak a écr

Re: Regular crash in modifying regex

Am Thu, 14 Jan 2021 14:15:40 -0500 schrieb Richard Kimberly Heck : > On 1/14/21 1:24 PM, Kornel Benko wrote: > > Am Thu, 14 Jan 2021 13:08:24 -0500 > > schrieb Richard Kimberly Heck : > > > >> On 1/14/21 4:40 AM, Kornel Benko wrote: > >>> Am Thu, 14 Jan 2021 04:29:21 -0500 > >>> schrieb Richar

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Am Thu, 14 Jan 2021 21:17:26 +0200 schrieb Yuriy Skalko : > > Yes, it helps. Now the next are > > /usr2/src/lyx/lyx-git/src/graphics/GraphicsCacheItem.cpp:445 > > /usr2/src/lyx/lyx-git/src/mathed/MathExtern.cpp:602 > > /usr2/src/lyx/lyx-git/src/mathed/MathExtern.cpp:687 > >

Re: Regular crash in modifying regex

On 1/14/21 2:15 PM, Richard Kimberly Heck wrote: > On 1/14/21 1:24 PM, Kornel Benko wrote: >> Am Thu, 14 Jan 2021 13:08:24 -0500 >> schrieb Richard Kimberly Heck : >> >>> On 1/14/21 4:40 AM, Kornel Benko wrote: Am Thu, 14 Jan 2021 04:29:21 -0500 schrieb Richard Kimberly Heck :

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Yes, it helps. Now the next are /usr2/src/lyx/lyx-git/src/graphics/GraphicsCacheItem.cpp:445 /usr2/src/lyx/lyx-git/src/mathed/MathExtern.cpp:602 /usr2/src/lyx/lyx-git/src/mathed/MathExtern.cpp:687 /usr2/src/lyx/lyx-git/src/mathed/MathExtern.cpp:772 /usr2/src

Re: Regular crash in modifying regex

On 1/14/21 1:24 PM, Kornel Benko wrote: > Am Thu, 14 Jan 2021 13:08:24 -0500 > schrieb Richard Kimberly Heck : > >> On 1/14/21 4:40 AM, Kornel Benko wrote: >>> Am Thu, 14 Jan 2021 04:29:21 -0500 >>> schrieb Richard Kimberly Heck : >>> On 1/14/21 4:19 AM, Kornel Benko wrote: > Am Thu, 1

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

On Thu, Jan 14, 2021 at 07:48:51PM +0100, Jean-Marc Lasgouttes wrote: > Le 14/01/2021 à 19:45, Scott Kostyshak a écrit : > > Thanks, this is good to know. What is your intuition for when it would > > be helpful to try the different C++ standard library? > > I do not have an intuition about it. I m

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Am Thu, 14 Jan 2021 20:30:03 +0200 schrieb Yuriy Skalko : > > I cannot even compile everything under clang8 > > /usr2/src/lyx/lyx-git/src/support/FileMonitor.cpp:62:9: error: call to > > 'make_unique' is > > ambiguous return make_unique(instance().getGuard(filename)); > >^

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Should it work w/o -std=c++17? What do expect to happen with different compiler switches for build of Qt-libs and LyX? On GCC it works now with all standards: from C++11 to C++20. The show stopper with -mmacosx-version-min=10.10 is: /Users/stephan/git/lyx/src/insets/ExternalTransforms.cpp:334

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Le 14/01/2021 à 19:45, Scott Kostyshak a écrit : Thanks, this is good to know. What is your intuition for when it would be helpful to try the different C++ standard library? I do not have an intuition about it. I mainly compile with different compilers/libc to see whether it breaks or whether

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

On Thu, Jan 14, 2021 at 05:36:58PM +0100, Jean-Marc Lasgouttes wrote: > Le 14/01/2021 à 16:53, Scott Kostyshak a écrit : > > On Thu, Jan 14, 2021 at 09:34:37AM +0100, Jean-Marc Lasgouttes wrote: > > > Le 13/01/2021 à 17:59, Scott Kostyshak a écrit : > > > > I just tested with Clang and cannot repro

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

I cannot even compile everything under clang8 /usr2/src/lyx/lyx-git/src/support/FileMonitor.cpp:62:9: error: call to 'make_unique' is ambiguous return make_unique(instance().getGuard(filename)); ^~~~ /usr/bin/../lib/gcc/x86_64-linux-gnu/8/../../../../include/c+

Re: Regular crash in modifying regex

Am Thu, 14 Jan 2021 13:08:24 -0500 schrieb Richard Kimberly Heck : > On 1/14/21 4:40 AM, Kornel Benko wrote: > > Am Thu, 14 Jan 2021 04:29:21 -0500 > > schrieb Richard Kimberly Heck : > > > >> On 1/14/21 4:19 AM, Kornel Benko wrote: > >>> Am Thu, 14 Jan 2021 04:15:18 -0500 > >>> schrieb Richar

Re: Regular crash in modifying regex

On 1/14/21 4:40 AM, Kornel Benko wrote: > Am Thu, 14 Jan 2021 04:29:21 -0500 > schrieb Richard Kimberly Heck : > >> On 1/14/21 4:19 AM, Kornel Benko wrote: >>> Am Thu, 14 Jan 2021 04:15:18 -0500 >>> schrieb Richard Kimberly Heck : >>> On 1/14/21 3:45 AM, Kornel Benko wrote: > Am Thu, 1

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Am 14.01.2021 um 17:57 schrieb Stephan Witt : > > Am 14.01.2021 um 17:09 schrieb Stephan Witt : >> >> Am 14.01.2021 um 09:30 schrieb Yuriy Skalko : >>> Sorry, I’ve reverted the change for now locally. I can answer your questions later… Perhaps the compiler flags of the autotools

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Am 14.01.2021 um 17:09 schrieb Stephan Witt : > > Am 14.01.2021 um 09:30 schrieb Yuriy Skalko : >> >>> Sorry, I’ve reverted the change for now locally. I can answer your >>> questions later… >>> Perhaps the compiler flags of the autotools build are of interest (but >>> cmake build crashes eithe

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Le 14/01/2021 à 16:53, Scott Kostyshak a écrit : On Thu, Jan 14, 2021 at 09:34:37AM +0100, Jean-Marc Lasgouttes wrote: Le 13/01/2021 à 17:59, Scott Kostyshak a écrit : I just tested with Clang and cannot reproduce. Stephan, does the list need to have more than one "recent file"? Note that the

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Am Wed, 13 Jan 2021 11:59:28 -0500 schrieb Scott Kostyshak : > On Wed, Jan 13, 2021 at 10:37:30AM +0100, Jean-Marc Lasgouttes wrote: > > Le 13/01/2021 à 10:21, Yuriy Skalko a écrit : > > > > Hi Yuriy, > > > > > > > > I’m seeing a crash after this commit when using File->Open recent. > > > > >

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Am 14.01.2021 um 09:30 schrieb Yuriy Skalko : > >> Sorry, I’ve reverted the change for now locally. I can answer your questions >> later… >> Perhaps the compiler flags of the autotools build are of interest (but cmake >> build crashes either): >> Configuration >> Host type: x86_64

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

On Thu, Jan 14, 2021 at 09:34:37AM +0100, Jean-Marc Lasgouttes wrote: > Le 13/01/2021 à 17:59, Scott Kostyshak a écrit : > > I just tested with Clang and cannot reproduce. Stephan, does the list need > > to have more than one "recent file"? Note that the recent files are stored > > in the "sessio

Re: Regular crash in modifying regex

Am Thu, 14 Jan 2021 10:40:00 +0100 schrieb Kornel Benko : > Am Thu, 14 Jan 2021 04:29:21 -0500 > schrieb Richard Kimberly Heck : > > > On 1/14/21 4:19 AM, Kornel Benko wrote: > > > Am Thu, 14 Jan 2021 04:15:18 -0500 > > > schrieb Richard Kimberly Heck : > > > > > >> On 1/14/21 3:45 AM, Korn

Update docs on the wiki

Hello, I'm about to update the docs on the wiki. Could someone give me privately the identity and password to connect to ftp://wiki.lyx.org ? -- Thanks and regards Jean-Pierre -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Regular crash in modifying regex

Am Thu, 14 Jan 2021 04:29:21 -0500 schrieb Richard Kimberly Heck : > On 1/14/21 4:19 AM, Kornel Benko wrote: > > Am Thu, 14 Jan 2021 04:15:18 -0500 > > schrieb Richard Kimberly Heck : > > > >> On 1/14/21 3:45 AM, Kornel Benko wrote: > >>> Am Thu, 14 Jan 2021 07:53:16 +0100 > >>> schrieb Jürgen

Re: Regular crash in modifying regex

On 1/14/21 4:19 AM, Kornel Benko wrote: > Am Thu, 14 Jan 2021 04:15:18 -0500 > schrieb Richard Kimberly Heck : > >> On 1/14/21 3:45 AM, Kornel Benko wrote: >>> Am Thu, 14 Jan 2021 07:53:16 +0100 >>> schrieb Jürgen Spitzmüller : >>> Am Donnerstag, dem 14.01.2021 um 00:58 +0100 schrieb Kornel

Re: Regular crash in modifying regex

Am Thu, 14 Jan 2021 04:15:18 -0500 schrieb Richard Kimberly Heck : > On 1/14/21 3:45 AM, Kornel Benko wrote: > > Am Thu, 14 Jan 2021 07:53:16 +0100 > > schrieb Jürgen Spitzmüller : > > > >> Am Donnerstag, dem 14.01.2021 um 00:58 +0100 schrieb Kornel Benko: > >>> How to reproduce > >>> > >>> 1.

Re: Regular crash in modifying regex

Am Thu, 14 Jan 2021 10:04:22 +0100 schrieb Jürgen Spitzmüller : > Am Donnerstag, dem 14.01.2021 um 09:45 +0100 schrieb Kornel Benko: > > Yes, attached. Last commit was fcea6c47. > > Did you have the outliner open? > > Jürgen > No, and the respective (internal) search-buffer should not trigge

Re: Use C++ testing framework

Am Thu, 14 Jan 2021 10:43:23 +0200 schrieb Yuriy Skalko : > > I am reluctant ... have you seen, how many tests (in cmake) there already > > are? > > Here it gives > > $ ctest -N | wc > >7605 22812 504591 > > > > OTOH, more tests cannot hurt. > > > > Kornel > > Yes, I'v

Re: Regular crash in modifying regex

On 1/14/21 3:45 AM, Kornel Benko wrote: > Am Thu, 14 Jan 2021 07:53:16 +0100 > schrieb Jürgen Spitzmüller : > >> Am Donnerstag, dem 14.01.2021 um 00:58 +0100 schrieb Kornel Benko: >>> How to reproduce >>> >>> 1.) Open lyx file e.g. Additional.lyx >>> 2.) select AdvFind >>> 3.) select regexp-mode >>

Re: Regular crash in modifying regex

Am Donnerstag, dem 14.01.2021 um 09:45 +0100 schrieb Kornel Benko: > Yes, attached. Last commit was fcea6c47. Did you have the outliner open? Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailma

Re: Regular crash in modifying regex

Am Thu, 14 Jan 2021 07:53:16 +0100 schrieb Jürgen Spitzmüller : > Am Donnerstag, dem 14.01.2021 um 00:58 +0100 schrieb Kornel Benko: > > How to reproduce > > > > 1.) Open lyx file e.g. Additional.lyx > > 2.) select AdvFind > > 3.) select regexp-mode > > 4.) insert any text not in this file > > 5.

Re: Use C++ testing framework

I am reluctant ... have you seen, how many tests (in cmake) there already are? Here it gives $ ctest -N | wc 7605 22812 504591 OTOH, more tests cannot hurt. Kornel Yes, I've seen (and really appreciate) that there are many ctests. As I understand these are export tests t

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Le 13/01/2021 à 17:59, Scott Kostyshak a écrit : I just tested with Clang and cannot reproduce. Stephan, does the list need to have more than one "recent file"? Note that the recent files are stored in the "session" file. You could experiment by seeing if it depends on which file you choose or

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Sorry, I’ve reverted the change for now locally. I can answer your questions later… Perhaps the compiler flags of the autotools build are of interest (but cmake build crashes either): Configuration Host type: x86_64-apple-darwin18.7.0 Special build flags: build=release

Re: Regular crash in modifying regex

Does not crash for me. Can you produce a backtrace? Jürgen Also cannot reproduce on Windows. It is strange that constification commit breaks the search. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Regular crash in modifying regex

On 1/14/21 3:08 AM, Kornel Benko wrote: > Am Wed, 13 Jan 2021 22:01:43 -0500 > schrieb Richard Kimberly Heck : > >> On 1/13/21 7:39 PM, Kornel Benko wrote: >>> Am Thu, 14 Jan 2021 00:58:40 +0100 >>> schrieb Kornel Benko : >>> How to reproduce 1.) Open lyx file e.g. Additional.lyx >

Re: Regular crash in modifying regex

Am Wed, 13 Jan 2021 22:01:43 -0500 schrieb Richard Kimberly Heck : > On 1/13/21 7:39 PM, Kornel Benko wrote: > > Am Thu, 14 Jan 2021 00:58:40 +0100 > > schrieb Kornel Benko : > > > >> How to reproduce > >> > >> 1.) Open lyx file e.g. Additional.lyx > >> 2.) select AdvFind > >> 3.) select regexp-

Re: [LyX/master] Add move constructor and move assignment operator for FileName class

Am 13.01.2021 um 17:59 schrieb Scott Kostyshak : > > On Wed, Jan 13, 2021 at 10:37:30AM +0100, Jean-Marc Lasgouttes wrote: >> Le 13/01/2021 à 10:21, Yuriy Skalko a écrit : Hi Yuriy, I’m seeing a crash after this commit when using File->Open recent. I’m having 5 fil