Re: ru/UserGuide ctests failing

2021-01-22 Thread Scott Kostyshak
On Fri, Jan 22, 2021 at 10:51:00AM +0200, Yuriy Skalko wrote: > > There are several ru/UserGuide ctests failing on current master, > > including the default output (pdflatex). > > > > > > Scott > > That is after my latest patch to it? > It was an update in contents of the > document, no changes

Re: CMake on Windows

2021-01-22 Thread Thibaut Cuvelier
On Thu, 21 Jan 2021 at 19:23, Kornel Benko wrote: > Am Thu, 21 Jan 2021 18:26:38 +0100 > schrieb Thibaut Cuvelier : > > > Dear list, and Pavel mostly :) > > > > I'm starting again to configure LyX on Windows, and the CMake files do > not behave as > > expected. > > > > I am setting

Re: [Windows] Remove the default binding between buffer-zoom and Alt+0

2021-01-22 Thread Thibaut Cuvelier
On Sat, 16 Jan 2021 at 20:54, Andrew Parsloe wrote: > > On 17/01/2021 1:42 am, Jean-Marc Lasgouttes wrote: > > Le 16/01/2021 à 04:36, Andrew Parsloe a écrit : > >> As a LyX user on windows, I would be reluctant to see Ctrl+- > >> changed. To meit sits comfortably alongside Ctrl+space to give a >

Re: [CONFIRMED] Delimiter issue in 2.3.6.1 and in master

2021-01-22 Thread Paul A. Rubin
On 1/22/21 12:03 PM, Richard Kimberly Heck wrote: On 1/22/21 11:17 AM, Pavel Sanda wrote: On Thu, Jan 21, 2021 at 06:16:25PM -0500, Richard Kimberly Heck wrote: the problem happens. It looks as if the images are not properly aligned and maybe the top got cut off for some reason. Does it get

Re: [CONFIRMED] Delimiter issue in 2.3.6.1 and in master

2021-01-22 Thread Richard Kimberly Heck
On 1/22/21 11:17 AM, Pavel Sanda wrote: On Thu, Jan 21, 2021 at 06:16:25PM -0500, Richard Kimberly Heck wrote: the problem happens. It looks as if the images are not properly aligned and maybe the top got cut off for some reason. Does it get better if you increase DelimiterUi->LeftLW->iconSize

Re: Should search match strings in deleted ct area?

2021-01-22 Thread Richard Kimberly Heck
On 1/22/21 11:10 AM, Kornel Benko wrote: > Am Fri, 22 Jan 2021 11:02:05 -0500 > schrieb Richard Kimberly Heck : > >> On 1/22/21 10:26 AM, Jürgen Spitzmüller wrote: >>> Am Freitag, dem 22.01.2021 um 14:04 +0100 schrieb Kornel Benko: As the subject says. ATM it is the case, but I'd

Re: [CONFIRMED] Delimiter issue in 2.3.6.1 and in master

2021-01-22 Thread Joel Kulesza
On Fri, Jan 22, 2021 at 3:33 AM José Abílio Matos wrote: > On Thursday, January 21, 2021 9:44:09 PM WET Richard Kimberly Heck wrote: > > > Yes, I see it, and in master too. Screenshot attached. > > > > > > Riki > > Hi Riki, > > I do not see this on Fedora 33 using both 2.3.6.1 and alpha1

Re: CMake on Windows

2021-01-22 Thread Pavel Sanda
On Thu, Jan 21, 2021 at 06:26:38PM +0100, Thibaut Cuvelier wrote: > Dear list, and Pavel mostly :) I do not know how I earned it, given that I don't even know how to run cmake :) Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [CONFIRMED] Delimiter issue in 2.3.6.1 and in master

2021-01-22 Thread Pavel Sanda
On Thu, Jan 21, 2021 at 06:16:25PM -0500, Richard Kimberly Heck wrote: > the problem happens. It looks as if the images are not properly aligned and > maybe the top got cut off for some reason. Does it get better if you increase DelimiterUi->LeftLW->iconSize by couple pixels? Pavel --

Re: Should search match strings in deleted ct area?

2021-01-22 Thread Kornel Benko
Am Fri, 22 Jan 2021 11:02:05 -0500 schrieb Richard Kimberly Heck : > On 1/22/21 10:26 AM, Jürgen Spitzmüller wrote: > > Am Freitag, dem 22.01.2021 um 14:04 +0100 schrieb Kornel Benko: > >> As the subject says. > >> > >> ATM it is the case, but I'd like to change it. > >> (see

Re: Should search match strings in deleted ct area?

2021-01-22 Thread Kornel Benko
Am Fri, 22 Jan 2021 16:19:50 +0100 schrieb Jean-Marc Lasgouttes : > Le 22/01/2021 à 15:17, Kornel Benko a écrit : > >> I see. I thought about deleted words, you think about deleted letters. > > > > So, what would you now decide? I am totally unsure, how to proceed. > > Each way has its own

Re: Should search match strings in deleted ct area?

2021-01-22 Thread Richard Kimberly Heck
On 1/22/21 10:26 AM, Jürgen Spitzmüller wrote: > Am Freitag, dem 22.01.2021 um 14:04 +0100 schrieb Kornel Benko: >> As the subject says. >> >> ATM it is the case, but I'd like to change it. >> (see output_latex.cpp:447,762,1668,1677) > I think deleted material should be ignored, as in simple

Re: [CONFIRMED] Delimiter issue in 2.3.6.1 and in master

2021-01-22 Thread Richard Kimberly Heck
On 1/22/21 6:49 AM, Pavel Sanda wrote: > On Fri, Jan 22, 2021 at 10:33:39AM +, José Abílio Matos wrote: >> Hi Riki, >> I do not see this on Fedora 33 using both 2.3.6.1 and alpha1 packages. >> >> I am just adding another data point to this report. > I do not see it on stable debian. Do we

Re: Should search match strings in deleted ct area?

2021-01-22 Thread Jürgen Spitzmüller
Am Freitag, dem 22.01.2021 um 14:04 +0100 schrieb Kornel Benko: > As the subject says. > > ATM it is the case, but I'd like to change it. > (see output_latex.cpp:447,762,1668,1677) I think deleted material should be ignored, as in simple search (nowadays). Jürgen > > Kornel

Re: Should search match strings in deleted ct area?

2021-01-22 Thread Jean-Marc Lasgouttes
Le 22/01/2021 à 15:17, Kornel Benko a écrit : I see. I thought about deleted words, you think about deleted letters. So, what would you now decide? I am totally unsure, how to proceed. Each way has its own advantage. I think that you do the coding, so you get to decide. JMarc -- lyx-devel

Re: Should search match strings in deleted ct area?

2021-01-22 Thread Kornel Benko
Am Fri, 22 Jan 2021 14:57:49 +0100 schrieb Jean-Marc Lasgouttes : > Le 22/01/2021 à 14:42, Kornel Benko a écrit : > >> I find it nice that search finds in deleted text. > > > > Say you have a word 'abc' and remove 'b' in change tracking. > > Now you are not able to find 'ac', (OK you are able,

Re: Should search match strings in deleted ct area?

2021-01-22 Thread Jean-Marc Lasgouttes
Le 22/01/2021 à 14:42, Kornel Benko a écrit : I find it nice that search finds in deleted text. Say you have a word 'abc' and remove 'b' in change tracking. Now you are not able to find 'ac', (OK you are able, but only because FindAdv has still a bug) I see. I thought about deleted words,

Re: Should search match strings in deleted ct area?

2021-01-22 Thread Kornel Benko
Am Fri, 22 Jan 2021 14:14:41 +0100 schrieb Jean-Marc Lasgouttes : > Le 22/01/2021 à 14:04, Kornel Benko a écrit : > > As the subject says. > > > > ATM it is the case, but I'd like to change it. > > (see output_latex.cpp:447,762,1668,1677) > > I find it nice that search finds in deleted text.

Re: Should search match strings in deleted ct area?

2021-01-22 Thread Jean-Marc Lasgouttes
Le 22/01/2021 à 14:04, Kornel Benko a écrit : As the subject says. ATM it is the case, but I'd like to change it. (see output_latex.cpp:447,762,1668,1677) I find it nice that search finds in deleted text. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org

Should search match strings in deleted ct area?

2021-01-22 Thread Kornel Benko
As the subject says. ATM it is the case, but I'd like to change it. (see output_latex.cpp:447,762,1668,1677) Kornel pgpbPub4GBdd5.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [CONFIRMED] Delimiter issue in 2.3.6.1 and in master

2021-01-22 Thread Pavel Sanda
On Fri, Jan 22, 2021 at 10:33:39AM +, José Abílio Matos wrote: > Hi Riki, > I do not see this on Fedora 33 using both 2.3.6.1 and alpha1 packages. > > I am just adding another data point to this report. I do not see it on stable debian. P -- lyx-devel mailing list lyx-devel@lists.lyx.org

Re: [CONFIRMED] Delimiter issue in 2.3.6.1 and in master

2021-01-22 Thread José Abílio Matos
On Thursday, January 21, 2021 9:44:09 PM WET Richard Kimberly Heck wrote: > Yes, I see it, and in master too. Screenshot attached. > > Riki Hi Riki, I do not see this on Fedora 33 using both 2.3.6.1 and alpha1 packages. I am just adding another data point to this report. -- José Abílio--

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-22 Thread Jürgen Spitzmüller
Am Freitag, dem 22.01.2021 um 11:02 +0100 schrieb Jean-Marc Lasgouttes: > What I had in mind is that we save the name when there is one, and > the hexcode when there is no name. > > Example: > * code: Color_background, name: "background", rgb: "linen" > => saved: "background" > > * code:

Re: [LyX/master] Prevent branch background color from leaking out of the document

2021-01-22 Thread Jean-Marc Lasgouttes
Le 21/01/2021 à 14:02, Jürgen Spitzmüller a écrit : My point is saving in the document. We need \color background in the LyX header in order to dynamically assign the correct color (and yes we do that via getFromLyXName). We cannot save the color code, as we need to save it as string (to

Re: [PATCH] Patches to review

2021-01-22 Thread Yuriy Skalko
Thanks for all for reviewing the patches! Patch 1 (the Development.lyx patch) is good. Nice addition of the enum class. Patch 4 also looks good. I thought it could break Qt 4.8 compilation but that's not the case [1, 2]. Sorry that I don't know enough to look at the others. Scott Yes,

ru/UserGuide ctests failing

2021-01-22 Thread Yuriy Skalko
There are several ru/UserGuide ctests failing on current master, including the default output (pdflatex). Scott That is after my latest patch to it? It was an update in contents of the document, no changes in settings. What are the errors? Yuriy -- lyx-devel mailing list