Patch review

2021-09-28 Thread Yuriy Skalko
Hi all, I've recently compiled LyX with latest version of GCC and used several useful diagnostic options. Two simpler patches are already committed, but the third one is bigger and worth additional checkup -- it is in attachment. Best Regards, Yuriy From

Re: IconInfo iconInfo: member call on null pointer

2021-09-28 Thread Kornel Benko
Am Tue, 28 Sep 2021 11:28:10 +0200 schrieb Jean-Marc Lasgouttes : > Le 27/09/2021 à 12:37, Kornel Benko a écrit : > > What makes me wonder: why should created pdf depend on HighDpi of users > > screen? > > (See > > src/frontends/qt/GuiApplication.cpp:558 > >

Re: IconInfo iconInfo: member call on null pointer

2021-09-28 Thread Jean-Marc Lasgouttes
Le 27/09/2021 à 12:37, Kornel Benko a écrit : What makes me wonder: why should created pdf depend on HighDpi of users screen? (See src/frontends/qt/GuiApplication.cpp:558 src/frontends/qt/GuiApplication.h:173) I suspect we should always use the HiDpi version. It is however

Re: IconInfo iconInfo: member call on null pointer

2021-09-28 Thread Jean-Marc Lasgouttes
Le 28/09/2021 à 11:04, Kornel Benko a écrit : What about the attached? Done at 84655a07. Good. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: IconInfo iconInfo: member call on null pointer

2021-09-28 Thread Kornel Benko
Am Mon, 27 Sep 2021 20:34:25 -0400 schrieb Scott Kostyshak : > On Mon, Sep 27, 2021 at 12:03:19PM +0200, Kornel Benko wrote: > > Am Sat, 25 Sep 2021 15:45:19 -0400 > > schrieb Scott Kostyshak : > > > > > > > > > > I will look at the differences between GUI and command line, and between > > >