Re: SIGSEGV introduced recently on master when deleting an inset

2024-04-06 Thread Jürgen Spitzmüller
Am Sonntag, dem 07.04.2024 um 06:50 +0200 schrieb Jürgen Spitzmüller: > Just doing a bisect. 73678dcde977802d5ff3ae07f0226484041fff48 is the first bad commit commit 73678dcde977802d5ff3ae07f0226484041fff48 Author: Jean-Marc Lasgouttes Date: Mon Nov 27 15:57:09 2023 +0100 Avoid full

Re: SIGSEGV introduced recently on master when deleting an inset

2024-04-06 Thread Jürgen Spitzmüller
Am Sonntag, dem 07.04.2024 um 00:38 -0400 schrieb Richard Kimberly Heck: > I am hoping this is not in 2.4.x and is due to the big inset merge. > Can you check? Not in 2.4.x. Just doing a bisect. I also assured it is not connected with my recent fix before backporting. -- Jürgen -- lyx-devel

Re: SIGSEGV introduced recently on master when deleting an inset

2024-04-06 Thread Richard Kimberly Heck
On 4/6/24 16:14, Scott Kostyshak wrote: To reproduce: 1. Open the attached example. 2. Put the cursor just after the Note inset. 3. Press twice. I get a SIGSEGV with the attached backtrace. Can anyone else reproduce on current master? I am hoping this is not in 2.4.x and is due to the big

Re: File format increases on master make it hard to test

2024-04-06 Thread Jürgen Spitzmüller
Am Samstag, dem 06.04.2024 um 16:51 -0400 schrieb Scott Kostyshak: > I imagine others face the same situation? Is there anything that can > be done? No, I think this will be a nightmare to maintain. And then, you really do not "text master" if you strip the most interesting commits. -- Jürgen

Re: Misplaced IME window in 2.4.0

2024-04-06 Thread Allan Chain
On 2024-04-07 4:15 AM, lyx-devel-requ...@lists.lyx.org wrote: On Sat, Apr 06, 2024 at 04:48:03PM GMT, Allan Chain wrote: Hi Scott, I think its a regression in LyX code. Although the Qt version is different, the code in 2.3.x branch correctly returns the position of the caret in

File format increases on master make it hard to test

2024-04-06 Thread Scott Kostyshak
I've been enjoying testing master, but on the first file format increment, I'll stop a lot of my testing since they're documents I will want to work on with other people. I have a few documents that only I use and for that I'll try to continue to test master. I imagine others face the same

SIGSEGV introduced recently on master when deleting an inset

2024-04-06 Thread Scott Kostyshak
To reproduce: 1. Open the attached example. 2. Put the cursor just after the Note inset. 3. Press twice. I get a SIGSEGV with the attached backtrace. Can anyone else reproduce on current master? Scott example-sigsegv-on-delete-note-inset.23.lyx Description: application/lyx Thread 1 "lyx"

Re: [LyX/master] Fix assertion when pasting paragraph with insets in lyxrc.ct_markup_copied

2024-04-06 Thread Richard Kimberly Heck
On 4/6/24 03:51, Jürgen Spitzmüller wrote: Am Samstag, dem 06.04.2024 um 07:48 + schrieb Juergen Spitzmueller: commit 9198ed5965809a1e951d1b721899d0051e619e34 Author: Juergen Spitzmueller Date:   Sat Apr 6 09:47:22 2024 +0200     Fix assertion when pasting paragraph with insets in

Re: Screwed display for table (all lyx versions)

2024-04-06 Thread Scott Kostyshak
On Sat, Apr 06, 2024 at 11:14:45AM GMT, Kornel Benko wrote: > > The created pdf looks like I wanted. I can reproduce (the weird LyX display) on current master and on 2.3.x. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org

Re: Misplaced IME window in 2.4.0

2024-04-06 Thread Scott Kostyshak
On Sat, Apr 06, 2024 at 04:48:03PM GMT, Allan Chain wrote: > Hi Scott, > > I think its a regression in LyX code. Although the Qt version is different, > the code in 2.3.x branch correctly returns the position of the caret in > `GuiWorkArea::inputMethodQuery`. However in 2.4.x branch, it returns >

Re: Compiling With Qt5

2024-04-06 Thread Kornel Benko
Am Sat, 6 Apr 2024 10:59:42 +0200 schrieb Pavel Sanda : > On Sat, Apr 06, 2024 at 10:37:16AM +0200, Kornel Benko wrote: > > In this commit I only fixed the the wrong casing of "Qt6Core_Found" to > > "Qt6Core_FOUND". So this code was there for a long time, but was not > > working. > >

Screwed display for table (all lyx versions)

2024-04-06 Thread Kornel Benko
The created pdf looks like I wanted. Kornel Funktionstasten.lyx Description: application/lyx pgpN4FCuRw8VY.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Compiling With Qt5

2024-04-06 Thread Pavel Sanda
On Sat, Apr 06, 2024 at 10:37:16AM +0200, Kornel Benko wrote: > In this commit I only fixed the the wrong casing of "Qt6Core_Found" to > "Qt6Core_FOUND". > So this code was there for a long time, but was not working. Nevertheless, can we have cmake defaulting to qt5 for 2.4.x? P -- lyx-devel

Re: Misplaced IME window in 2.4.0

2024-04-06 Thread Allan Chain
Hi Scott, I think its a regression in LyX code. Although the Qt version is different, the code in 2.3.x branch correctly returns the position of the caret in `GuiWorkArea::inputMethodQuery`. However in 2.4.x branch, it returns `im_cursor_rect_` which is only updated when preedit is enabled.

Re: Compiling With Qt5

2024-04-06 Thread Kornel Benko
Am Fri, 5 Apr 2024 17:23:57 -0400 schrieb Richard Kimberly Heck : > On 4/5/24 03:02, Kornel Benko wrote: > > Am Thu, 4 Apr 2024 13:39:18 -0400 > > schrieb Richard Kimberly Heck : > > > >> On 4/3/24 06:34, Jean-Marc Lasgouttes wrote: > >>> Le 03/04/2024 à 12:27, Pavel Sanda a écrit : >

Re: Biginset branch has landed (sorry for the spam)

2024-04-06 Thread Jürgen Spitzmüller
Am Freitag, dem 05.04.2024 um 16:17 +0200 schrieb Jean-Marc Lasgouttes: > What now? Well, testing is welcome when you have time : does > everything works the same, but faster for big document that were > annoying?. I see drawing omissions with change tracking. Select part of a word with CT on and

Re: Compiling With Qt5

2024-04-06 Thread Jürgen Spitzmüller
Am Freitag, dem 05.04.2024 um 17:23 -0400 schrieb Richard Kimberly Heck: > Unless I'm misreading it, commit 993e784a6284a to 2.4.x makes Qt6 the > default (and that commit is also in 2.4.1-devel). That's bad. I think our Qt6 implementation still has too many drawbacks. I would keep it opt-in in

Re: [LyX/master] Fix assertion when pasting paragraph with insets in lyxrc.ct_markup_copied

2024-04-06 Thread Jürgen Spitzmüller
Am Samstag, dem 06.04.2024 um 07:48 + schrieb Juergen Spitzmueller: > commit 9198ed5965809a1e951d1b721899d0051e619e34 > Author: Juergen Spitzmueller > Date:   Sat Apr 6 09:47:22 2024 +0200 > >     Fix assertion when pasting paragraph with insets in > lyxrc.ct_markup_copied >     >     This

Re: Misplaced IME window in 2.4.0

2024-04-06 Thread Jürgen Spitzmüller
Am Freitag, dem 05.04.2024 um 23:01 -0400 schrieb Scott Kostyshak: > On Thu, Mar 21, 2024 at 11:31:35AM GMT, Allan Chain wrote: > > Hello, LyX developers! > > > > I'm trying out LyX 2.4.0-rc3 (qt6) on KDE6+Wayland, and I'm using > > fcitx5 to > > input CJK characters. I found that the candidate