Re: Tarballs for LyX 2.2.0 are on FTP

2016-06-06 Thread Guillaume Munch
Le 06/06/2016 22:47, Richard Heck a écrit : On 06/06/2016 04:27 PM, Guillaume Munch wrote: Le 06/06/2016 20:33, Georg Baum a écrit : Jean-Marc Lasgouttes wrote: Le 05/06/2016 à 21:05, Guillaume Munch a écrit : Yet, most of the file format changes are very simple. I wonder whether one could

Re: boost:regex & gcc

2016-06-06 Thread Guillaume Munch
Le 06/06/2016 20:37, Pavel Sanda a écrit : Guillaume Munch wrote: 11. boost:regex. We have learnt the pitfalls of having two regex libraries at the same time. However, according to a comment in the source, gcc < 4.9.0 supports std::regex badly. Do we still care about gcc < 4.9.0 ? (no

Re: Tarballs for LyX 2.2.0 are on FTP

2016-06-06 Thread Guillaume Munch
Le 06/06/2016 20:33, Georg Baum a écrit : Jean-Marc Lasgouttes wrote: Le 05/06/2016 à 21:05, Guillaume Munch a écrit : Yet, most of the file format changes are very simple. I wonder whether one could introduce a single compilation variable to disable them, and ask developers to enclose file

Re: [PATCH] unique_ptr and some clean-up

2016-06-06 Thread Guillaume Munch
Le 06/06/2016 10:35, Jean-Marc Lasgouttes a écrit : Le 05/06/2016 à 13:54, Georg Baum a écrit : I won't comment on the other items. IMHO, discussing all these in one message makes things more complicated. I would prefer to go step by step. I agree with Georg on that. It would be better to

Re: [PATCH] unique_ptr and some clean-up

2016-06-06 Thread Guillaume Munch
Le 06/06/2016 10:22, Jean-Marc Lasgouttes a écrit : Le 05/06/2016 à 13:54, Georg Baum a écrit : Looks good, I have only one minor comment: Please do not use _MSC_VER in the sources. This code is better located in config.h, like that: #if (__cplusplus >= 201402L) ||

Re: [LyX/master] Do not duplicate jpg format

2016-06-06 Thread Guillaume Munch
Le 04/06/2016 08:23, Georg Baum a écrit : Guillaume Munch wrote: Why not just using a set instead of a vector if this is important? I believe that the order matters. We prefer the first format that is reachable with a converter. With the current solution, qt can give a preference, You

Re: [PATCH] unique_ptr and some clean-up

2016-06-05 Thread Guillaume Munch
Le 05/06/2016 12:54, Georg Baum a écrit : Therefore I would vote to support MSVC 2013 and later, but nothing earlier. In light of the lack of support of unicode string literals in MSVC 2013, the availability of mingw and the fact that a last-minute switch to MSVC 2015 was already necessary for

Re: expected behavior when pasting multiple cells from one table to another

2016-06-05 Thread Guillaume Munch
Le 07/03/2016 04:30, Scott Kostyshak a écrit : On Sun, Mar 06, 2016 at 09:47:05PM +0100, Jean-Marc Lasgouttes wrote: Le 06/03/16 17:52, Scott Kostyshak a écrit : I do not see why overwriting is a problem. We do it everywhere, there is nothing special about tables. Where else do we overwite

Re: Visible carriage return

2016-06-05 Thread Guillaume Munch
Le 03/06/2016 16:11, Richard Heck a écrit : On 06/03/2016 11:05 AM, Guillaume Munch wrote: Le 03/06/2016 08:18, Richard Heck a écrit : On 06/02/2016 08:04 PM, Giorgio Zavarise wrote: Hi, I have a question concerning the space around centered equation. When you type text and then add centered

Re: Tarballs for LyX 2.2.0 are on FTP

2016-06-05 Thread Guillaume Munch
Le 03/06/2016 13:02, Jean-Marc Lasgouttes a écrit : Le 31/05/2016 à 22:26, Georg Baum a écrit : In addition I would suggest the following: (Officially) allow new features that do not require a file format change into minor releases. The main reason is again that this allows testing more

Re: checkbox to filter font list by document language

2016-06-04 Thread Guillaume Munch
Le 02/06/2016 20:27, Jean-Marc Lasgouttes a écrit : Le 02/06/16 à 20:41, Scott Kostyshak a écrit : You are right, LyX deserves a better font selection dialog. I had a quick look: there is the QFontDialog widget which has a writing system selection menu. See

Re: Require C++11 for 2.3?

2016-06-04 Thread Guillaume Munch
Le 03/06/2016 06:24, Scott Kostyshak a écrit : Dear all, Are we going to require C++11 starting with LyX 2.3.0? From what I understand, this will make several things easier. Scott Apart from Boost features and smart pointers from the other message, two areas come to mind: * char32_t and

Re: One official build system?

2016-06-03 Thread Guillaume Munch
Le 03/06/2016 06:16, Scott Kostyshak a écrit : Dear all, The following email thread (3 years ago) suggests that we would like to move to one official build system in the long-run across all platforms, but that there were barriers to using CMake:

Re: [LyX/master] Do not duplicate jpg format

2016-06-03 Thread Guillaume Munch
Le 02/06/2016 21:33, Georg Baum a écrit : commit 8d255ced2a003b2b8262bf51d1b245ff0dee9dc3 Author: Georg Baum Date: Thu Jun 2 22:31:27 2016 +0200 Do not duplicate jpg format Some qt versions report both "jpeg" and "jpg" as loadable file extensions. In this case

Re: checkbox to filter font list by document language

2016-06-02 Thread Guillaume Munch
Le 02/06/2016 07:07, Scott Kostyshak a écrit : Dear all, I have many system fonts installed (the command `fc-list | wc -l` gives me 1595. Can anyone beat that?). When testing LyX's XeTeX export with system fonts and various languages, it can be a little annoying to find a font that has the

Re: [LyX/master] Show names of debug modes in the debug panel

2016-05-31 Thread Guillaume Munch
Le 31/05/2016 00:15, Guillaume Munch a écrit : commit 2b6d0ae3deae80558a73346d60739fa408cbe2c3 Author: Guillaume Munch <g...@lyx.org> Date: Sun May 29 23:33:12 2016 +0100 Show names of debug modes in the debug panel Sometimes it's hard to know which is which from a trans

Re: [LyX/master] * lib/RELEASE-NOTES

2016-05-30 Thread Guillaume Munch
Le 30/05/2016 15:58, Jean-Marc Lasgouttes a écrit : Le 30/05/2016 16:40, Guillaume Munch a écrit : Qt4: 75% of the time is spent (in number of instructions) inside QTextEngine::shapeText(). Of these 75%, 2/3 is requested by metrics calculation (QTextLine::setLineWidth() from GuiFontMetrics

Re: Extra rules inserted when changing table alignment

2016-05-30 Thread Guillaume Munch
Le 30/05/2016 10:36, Andrew Parsloe a écrit : LyX 2.2.0, windows 7. When I change either horizontal or vertical alignment of a table by means of the context menu > Settings, extra vertical rules are inserted in a table. I've attached an example file. The table toolbar buttons don't seem to

Re: [LyX/master] * lib/RELEASE-NOTES

2016-05-30 Thread Guillaume Munch
Le 30/05/2016 14:33, Jean-Marc Lasgouttes a écrit : Le 27/05/2016 23:08, Guillaume Munch a écrit : The protocol is to change the width of the window (all other things equal). Qt4: 75% of the time is spent (in number of instructions) inside QTextEngine::shapeText(). Of these 75%, 2/3

Re: SVG display on LyX appears corrupted on the 2.2RC1 Windows build

2016-05-29 Thread Guillaume Munch
Le 05/05/2016 13:04, Georg Baum a écrit : Guillaume Munch wrote: Le 27/04/2016 21:42, Georg Baum a écrit : Guillaume Munch wrote: Is there a criteria to detect "bad" svg converters (at least some of them)? In the other message you wrote about "explicit svg->png con

Re: Tarballs for LyX 2.2.0 are on FTP

2016-05-29 Thread Guillaume Munch
Le 26/05/2016 07:45, Jean-Marc Lasgouttes a écrit : Le 25/05/2016 19:11, Jürgen Spitzmüller a écrit : Thanks to everyone for all the help with the final steps in the release process. Congratulations. And thanks for the excellent management job, Scott. Indeed. You did it much more thoroughly

Re: Git Branch Update

2016-05-29 Thread Guillaume Munch
Le 28/05/2016 22:49, Richard Heck a écrit : The old 2.3-staging branch has been merged into master. I'll plan to delete 2.3-staging completely in a few days. Rebasing local branches fails with strange conflicts. For instance one conflict I have is because 49d52796 has not been applied to

Re: [LyX/master] * lib/RELEASE-NOTES

2016-05-27 Thread Guillaume Munch
Le 24/05/2016 09:49, Jean-Marc Lasgouttes a écrit : Le 24/05/2016 à 00:51, Guillaume Munch a écrit : Do you know any other bug on Linux+qt5.5.1 than http://www.lyx.org/trac/ticket/9731 ? Because on the other hand with qt4 there is the critical http://www.lyx.org/trac/ticket/9362. I also

Re: Tarballs for LyX 2.2.0 are on FTP

2016-05-26 Thread Guillaume Munch
Le 26/05/2016 15:12, Uwe Stöhr a écrit : Am 25.05.2016 um 00:37 schrieb Richard Heck: We have lots of warnings like this. They are usually fixed by doing the conversion explicitly, so probably nothing really needs to be done for the release. This is suspicious to me because usually MSVC has

Re: [LyX/master] * lib/RELEASE-NOTES

2016-05-23 Thread Guillaume Munch
Le 24/05/2016 00:06, Scott Kostyshak a écrit : On Mon, May 23, 2016 at 11:51:11PM +0100, Guillaume Munch wrote: Le 23/05/2016 23:12, Scott Kostyshak a écrit : On Wed, May 11, 2016 at 10:36:13AM -0700, Pavel Sanda wrote: Pavel Sanda wrote: commit 518876b370ac00f4ee5840a65d40c1d79d0ed2ad

Re: [LyX/master] * lib/RELEASE-NOTES

2016-05-23 Thread Guillaume Munch
Le 23/05/2016 23:12, Scott Kostyshak a écrit : On Wed, May 11, 2016 at 10:36:13AM -0700, Pavel Sanda wrote: Pavel Sanda wrote: commit 518876b370ac00f4ee5840a65d40c1d79d0ed2ad Author: Pavel Sanda Date: Wed May 11 10:31:59 2016 -0700 * lib/RELEASE-NOTES It would be nice

Re: Plan to tag and tar 2.2.0rc2 on Monday

2016-05-22 Thread Guillaume Munch
Le 22/05/2016 16:38, Georg Baum a écrit : Scott Kostyshak wrote: Dear all, Unless something comes up, I'm planning to tag and tar rc2 on Monday. At that point I'll put the tar balls on the FTP and whenever Mac and Win binaries are uploaded we will announce the release. Great! I wonder

Re: We will have to change our output for newest LuaTeX

2016-05-20 Thread Guillaume Munch
Le 20/05/2016 19:26, Scott Kostyshak a écrit : On Fri, May 20, 2016 at 04:06:22PM +, Guenter Milde wrote: On 2016-05-20, Jean-Marc Lasgouttes wrote: Le 20/05/2016 à 13:17, Guenter Milde a écrit : On 2016-05-20, Scott Kostyshak wrote: There have been some changes in the luatex engine

Re: Update on situation for 2.2.0 release

2016-05-19 Thread Guillaume Munch
Le 18/05/2016 03:27, Scott Kostyshak a écrit : On Wed, May 18, 2016 at 12:58:51AM +0100, Guillaume Munch wrote: Le 17/05/2016 19:31, Scott Kostyshak a écrit : I tried your patch. I have the same problems as with Stephan's patch (also reported by Kornel). For example, none of alt+f, alt+f, alt

Re: Update on situation for 2.2.0 release

2016-05-17 Thread Guillaume Munch
31d Mon Sep 17 00:00:00 2001 From: Guillaume Munch <g...@lyx.org> Date: Tue, 17 May 2016 18:45:37 +0100 Subject: [PATCH] bug #10075 --- src/frontends/qt4/CustomizedWidgets.cpp | 23 +++ src/frontends/qt4/CustomizedWidgets.h | 1 - 2 files changed, 3 insertions(+), 21

Re: Update on situation for 2.2.0 release

2016-05-17 Thread Guillaume Munch
ried. Guillaume >From 2f695983a1392d95d8c29dfaff98fa16e93250b7 Mon Sep 17 00:00:00 2001 From: Guillaume Munch <g...@lyx.org> Date: Tue, 17 May 2016 18:45:37 +0100 Subject: [PATCH] bug #10075 --- src/frontends/qt4/CustomizedWidgets.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-

Re: [LyX/master] German UserGuide.lyx: tons of typographic fixes sent in by an unknown user

2016-05-09 Thread Guillaume Munch
Le 09/05/2016 21:14, Georg Baum a écrit : This is BTW a good example why it is always useful to look at the diff before committing, and why having redable diffs (as currently discussed in the .po file thread) is important. Could the same not be said for svgz and sfd files? In particular it

Re: [patch] Remove the "Keep" checkbox in the outliner panel

2016-05-09 Thread Guillaume Munch
Le 09/05/2016 06:21, Pavel Sanda a écrit : I agree. If you ever find time to look at the issue that would earn you beer delivery in front of your door :) I have now bookmarked this thread in case I need to refer to it later :)

Re: [LyX/master] German UserGuide.lyx: tons of typographic fixes sent in by an unknown user

2016-05-08 Thread Guillaume Munch
I think compression has been enabled by mistake. Le 09/05/2016 00:25, Uwe Stöhr a écrit : commit 41e928b2e50e372e46926972a9b183dc0607f3f0 Author: Uwe Stöhr Date: Mon May 9 01:24:02 2016 +0200 German UserGuide.lyx: tons of typographic fixes sent in by an unknown user

Re: [patch] Remove the "Keep" checkbox in the outliner panel

2016-05-08 Thread Guillaume Munch
Le 06/05/2016 12:46, Pavel Sanda a écrit : Guillaume Munch wrote: Dear list I propose to remove the "Keep" checkbox in the outliner panel. The panel would behave as if always checked. Hold on, it does not look like that here. When I set depth 2 in outliner, open user guide and c

Re: Update on situation for 2.2.0 release

2016-05-08 Thread Guillaume Munch
Le 06/05/2016 21:09, Scott Kostyshak a écrit : On Wed, May 04, 2016 at 11:19:56PM +0100, Guillaume Munch wrote: Le 04/05/2016 21:39, Scott Kostyshak a écrit : What am I missing? #10068: Files distributed with lyx should not contain parbreak and latexpar http://mid.gmane.org/nfu741$c3j$1

Re: [LyX/2.3-staging] Remove special code for Qt5 to manage HiDPI. It's not needed anymore and leads to strange icon scaling problems in mixed resolution environment. For reference see the screen shot

2016-05-07 Thread Guillaume Munch
Which version of qt is this for? Here on Ubuntu we are still stuck with 5.5.1 for a little while. More generally what qt version is going to be supported by 2.3 ? Le 07/05/2016 08:56, Stephan Witt a écrit : commit 1cd6633870c679d987e17e3901da3ac6a2873ab3 Author: Stephan Witt

Re: current master is incompilable

2016-05-06 Thread Guillaume Munch
On 07/05/2016 01:21, Uwe Stöhr wrote: I get GuiClipboard.cpp D:\LyXGit\Master\src\frontends\qt4\GuiClipboard.cpp(558): error C2027: use of undefined type 'QTimer' [D:\LyXGit\Master\compile-2015\src\frontends\qt4\frontend_qt.vcxproj]

Re: SVG display on LyX appears corrupted on the 2.2RC1 Windows build

2016-05-05 Thread Guillaume Munch
Le 05/05/2016 13:04, Georg Baum a écrit : Attached is a combined version. While testing, I found out that svgz appears as an extra format in the qt format list as well, so I removed that also. Works for me

Re: Update on situation for 2.2.0 release

2016-05-04 Thread Guillaume Munch
Le 04/05/2016 21:39, Scott Kostyshak a écrit : 4. Insert Cross-Reference Causes Crash. See #9992. Unfortunately, no one can reproduce except the OP, Joel. Joel has been extremely helpful in debugging and is able to compile LyX but only with Qt 5.5.1. Unless we make further progress in

Re: SVG display on LyX appears corrupted on the 2.2RC1 Windows build

2016-05-04 Thread Guillaume Munch
Le 27/04/2016 21:42, Georg Baum a écrit : Guillaume Munch wrote: Is there a criteria to detect "bad" svg converters (at least some of them)? In the other message you wrote about "explicit svg->png converter". What does explicit mean? explicit means "no defa

Re: A tiny cedilla anomaly

2016-05-03 Thread Guillaume Munch
Le 03/05/2016 06:09, Stephan Witt a écrit : Am 03.05.2016 um 03:04 schrieb Guillaume Munch <g...@lyx.org>: Le 03/05/2016 01:40, Scott Kostyshak a écrit : On Sun, May 01, 2016 at 08:38:58AM +0200, Stephan Witt wrote: Am 01.05.2016 um 04:06 schrieb Scott Kostyshak <skost...@lyx.org&g

Re: [LyX/2.3-staging] TocWidget: Fix perf regression

2016-05-02 Thread Guillaume Munch
Le 03/05/2016 01:45, Scott Kostyshak a écrit : On Sun, May 01, 2016 at 03:17:31PM +0100, Guillaume Munch wrote: Le 01/05/2016 00:26, Scott Kostyshak a écrit : On Sat, Apr 30, 2016 at 03:44:48PM +0100, Guillaume Munch wrote: This is candidate for 2.2.0 and 2.1.5. How noticeable and bad

Re: A tiny cedilla anomaly

2016-05-02 Thread Guillaume Munch
Le 03/05/2016 01:40, Scott Kostyshak a écrit : On Sun, May 01, 2016 at 08:38:58AM +0200, Stephan Witt wrote: Am 01.05.2016 um 04:06 schrieb Scott Kostyshak : On Sun, May 01, 2016 at 01:28:56PM +1200, Andrew Parsloe wrote: On 1/05/2016 11:33 a.m., Jean-Marc Lasgouttes wrote:

Re: [LyX/2.3-staging] TocWidget: Fix perf regression

2016-05-01 Thread Guillaume Munch
Le 01/05/2016 00:26, Scott Kostyshak a écrit : On Sat, Apr 30, 2016 at 03:44:48PM +0100, Guillaume Munch wrote: This is candidate for 2.2.0 and 2.1.5. How noticeable and bad is the regression? On the one hand I did not notice any particular slowness, on the other hand it nullified the fix

Re: [LyX/2.3-staging] TocWidget: clean-up the timer logic

2016-04-30 Thread Guillaume Munch
This is candidate for 2.2.2-staging Le 30/04/2016 15:42, Guillaume Munch a écrit : commit 96a9946ea2300ae10a8fac55530fbeb6d5713280 Author: Guillaume Munch <g...@lyx.org> Date: Fri Apr 29 22:48:53 2016 +0100 TocWidget: clean-up the timer logic The timer logic introduced to

[patch] Remove the "Keep" checkbox in the outliner panel

2016-04-30 Thread Guillaume Munch
n.h -- 2.1.4 >From 4cf3365b94e1816e9da59091bff40081b5cd96ed Mon Sep 17 00:00:00 2001 From: Guillaume Munch <g...@lyx.org> Date: Sat, 30 Apr 2016 15:47:40 +0100 Subject: [PATCH 2/2] Outliner: Remove the "Keep" option. Now it is always enabled. When it was disabled, the tre

Re: [LyX/2.3-staging] TocWidget: Fix perf regression

2016-04-30 Thread Guillaume Munch
This is candidate for 2.2.0 and 2.1.5. Le 30/04/2016 15:42, Guillaume Munch a écrit : commit af89840334486e310d7951b2e84363f1caee0dfa Author: Guillaume Munch <g...@lyx.org> Date: Sat Apr 30 00:25:46 2016 +0100 TocWidget: Fix perf regression 4d1ad336 fixed #9754 but cause

Re: #10068: Files distributed with lyx should not contain parbreak and latexpar separators

2016-04-28 Thread Guillaume Munch
For your information. In case you missed it. Attached patches: http://www.lyx.org/trac/attachment/ticket/10068/0001-Templates-remove-parbreak-and-latexpar-separators.patch http://www.lyx.org/trac/attachment/ticket/10068/0002-Examples-remove-parbreak-and-latexpar-separators.patch Le 12/04/2016

Re: Extra space before nested sublist

2016-04-27 Thread Guillaume Munch
Le 27/04/2016 21:35, Richard Heck a écrit : On 04/27/2016 11:36 AM, Kemal Ilgar Eroglu wrote: Hi all, I'm using LyX version 2.1.4. My problem is as follows: When creating a nested list environment, LyX inserts a blank line before the \begin{enumerate} of the sublist. It creates code like:

Re: SVG display on LyX appears corrupted on the 2.2RC1 Windows build

2016-04-27 Thread Guillaume Munch
Le 27/04/2016 21:19, Georg Baum a écrit : Scott Kostyshak wrote: Even in the case where imagemagick could produce low quality results, if imagemagick is used for the conversion for the PDF wouldn't it make sense to also use it for LyX's display? This would give the user a better chance of

Re: SVG display on LyX appears corrupted on the 2.2RC1 Windows build

2016-04-27 Thread Guillaume Munch
Le 24/04/2016 17:23, Scott Kostyshak a écrit : On Sun, Apr 24, 2016 at 01:54:31PM +0100, Guillaume Munch wrote: Le 24/04/2016 05:03, Scott Kostyshak a écrit : On Fri, Apr 22, 2016 at 06:08:31PM +0100, Guillaume Munch wrote: Le 18/04/2016 02:20, Scott Kostyshak a écrit : I imagine Guillaume

Re: lyx2.2.0rc1 insert-citation problems

2016-04-24 Thread Guillaume Munch
Le 24/04/2016 04:23, Scott Kostyshak a écrit : I like the patch you attached. Although I understand your dissatisfaction that it doesn't completely fix one of the regressions you were targetting, it is nice to get rid of that hack and more importantly to solve the crash. Please commit this

Re: SVG display on LyX appears corrupted on the 2.2RC1 Windows build

2016-04-24 Thread Guillaume Munch
Le 24/04/2016 06:11, Scott Kostyshak a écrit : I wouldn't be surprised if this depends on the Qt version (e.g. different Qt "features" and difficulty of Qt getting the high res right) It is indeed different with Qt5 here, but not in a good way: the preview is even smaller, about one third

Re: SVG display on LyX appears corrupted on the 2.2RC1 Windows build

2016-04-24 Thread Guillaume Munch
Le 24/04/2016 05:03, Scott Kostyshak a écrit : On Fri, Apr 22, 2016 at 06:08:31PM +0100, Guillaume Munch wrote: Le 18/04/2016 02:20, Scott Kostyshak a écrit : I imagine Guillaume did not intend this as a full patch, Indeed. More importantly, the patch does not change anything for me. I

Re: lyx2.2.0rc1 insert-citation problems

2016-04-23 Thread Guillaume Munch
Le 23/04/2016 01:54, bruce muirhead a écrit : On 22/04/16 13:37, Guillaume Munch wrote: Le 22/04/2016 03:56, Guillaume Munch a écrit : Le 21/04/2016 21:04, Scott Kostyshak a écrit : Also, since Guillaume had made some improvements to this commit, it might be nice to know if Bruce still sees

Re: SVG display on LyX appears corrupted on the 2.2RC1 Windows build

2016-04-22 Thread Guillaume Munch
Le 18/04/2016 02:20, Scott Kostyshak a écrit : I imagine Guillaume did not intend this as a full patch, Indeed. More importantly, the patch does not change anything for me. I am testing with lyxinkscape.lyx and lyxinkscape.svg that can be downloaded from #9778 (note you need to change the

Re: lyx2.2.0rc1 insert-citation problems

2016-04-21 Thread Guillaume Munch
Le 22/04/2016 03:56, Guillaume Munch a écrit : Le 21/04/2016 21:04, Scott Kostyshak a écrit : Also, since Guillaume had made some improvements to this commit, it might be nice to know if Bruce still sees the problem on 2.3-staging. Bruce, can you do the following? git checkout 2.3-staging

Re: lyx2.2.0rc1 insert-citation problems

2016-04-21 Thread Guillaume Munch
mpiling again, the following: bruce@debian:~/lyx$ git reset --hard HEAD is now at b5a2f1c Fix broken layout of the citation dialog (#10019) bruce@debian:~/lyx$ git bisect bad b5a2f1c7e5caf6f79b6894b562769a5513b7b13f is the first bad commit commit b5a2f1c7e5caf6f79b6894b562769a5513b7b13f Author:

Re: lyx2.2.0rc1 insert-citation problems

2016-04-21 Thread Guillaume Munch
Le 22/04/2016 02:55, bruce muirhead a écrit : On 22/04/16 10:24, Guillaume Munch wrote: Thanks for that information Guillaume. I am learning as I go, so some simple mistakes are happening and I apologise for that. No need to apologise for anything. Thanks for all the test and especially

Re: lyx2.2.0rc1 insert-citation problems

2016-04-21 Thread Guillaume Munch
7b13f] Fix broken layout of the citation dialog (#10019) Then, after compiling again, the following: bruce@debian:~/lyx$ git reset --hard HEAD is now at b5a2f1c Fix broken layout of the citation dialog (#10019) bruce@debian:~/lyx$ git bisect bad b5a2f1c7e5caf6f79b6894b562769a5513b7b13f i

Re: Bug in rc1: entering ancient greek

2016-04-21 Thread Guillaume Munch
Le 21/04/2016 16:20, john kennan a écrit : The crash occurs when the format in the view source pane is LaTeX (plain) or LaTeX (pdflatex) It does not occur when the format is plain text, or LaTeX (XeTeX) or LaTeX (LuaTeX) Is is possible to trigger a similar crash using View > DVI or View > PDF

Re: Bug in rc1: entering ancient greek

2016-04-20 Thread Guillaume Munch
Le 20/04/2016 22:44, mn a écrit : On 20.04.16 21:22, Guenter Milde wrote: This is on Mac, 10.10, LyX-rc1 Is this a known bug; I couldn't find it on trac? Steps to reproduce: – launch LyX – enter some characters – start new line – switch OS input-method to “Greek Polytonic” – enter some

Re: [LyX/2.3-staging] Make inset-select-all select all cells only in tables

2016-04-20 Thread Guillaume Munch
Le 19/04/2016 11:01, Jean-Marc Lasgouttes a écrit : Le 19/04/2016 01:26, Guillaume Munch a écrit : This turns InsetMathHull::isTable() into a redefinition of Inset::isTable(). OK, I missed the definition of InsetMathHull::isTable() at that time. As I see it, your version of isTable means

Re: [LyX/2.3-staging] Make inset-select-all select all cells only in tables

2016-04-18 Thread Guillaume Munch
Le 18/04/2016 14:59, Jean-Marc Lasgouttes a écrit : --- a/src/insets/Inset.h +++ b/src/insets/Inset.h @@ -347,6 +347,8 @@ public: virtual bool clickable(BufferView const &, int, int) const { return false; } /// Move one cell backwards virtual bool

Re: [LyX/2.3-staging] LyXToolBox: a QToolBox with minimum size management

2016-04-17 Thread Guillaume Munch
Le 17/04/2016 14:12, Stephan Witt a écrit : Am 17.04.2016 um 11:46 schrieb Kornel Benko <kor...@lyx.org>: Am Sonntag, 17. April 2016 um 01:34:41, schrieb Guillaume Munch <g...@lyx.org> commit 367a7a6dddc7917d5e99fa6ba894812ad6f62e48 Author: Guillaume Munch <g...@lyx.org> Dat

Re: [LyX/2.3-staging] LyXToolBox: a QToolBox with minimum size management

2016-04-17 Thread Guillaume Munch
Le 17/04/2016 14:12, Stephan Witt a écrit : Am 17.04.2016 um 11:46 schrieb Kornel Benko <kor...@lyx.org>: Am Sonntag, 17. April 2016 um 01:34:41, schrieb Guillaume Munch <g...@lyx.org> commit 367a7a6dddc7917d5e99fa6ba894812ad6f62e48 Author: Guillaume Munch <g...@lyx.org> Dat

Re: [LyX/2.3-staging] LyXToolBox: a QToolBox with minimum size management

2016-04-17 Thread Guillaume Munch
Le 17/04/2016 10:46, Kornel Benko a écrit : Am Sonntag, 17. April 2016 um 01:34:41, schrieb Guillaume Munch <g...@lyx.org> commit 367a7a6dddc7917d5e99fa6ba894812ad6f62e48 Author: Guillaume Munch <g...@lyx.org> Date: Tue Mar 22 21:57:17 2016 + LyXToolBox: a QToolBox with

Re: [LyX/2.3-staging] Sanitize InsetMathHull and add a check for mutability in LFUN_MATH_MUTATE

2016-04-16 Thread Guillaume Munch
Le 17/04/2016 00:09, Richard Heck a écrit : On 04/16/2016 05:58 PM, Guillaume Munch wrote: commit 9b45121e4fbecd6c15f42d81a6d522236079760c Author: Guillaume Munch <g...@lyx.org> Date: Mon Dec 14 01:54:27 2015 + Sanitize InsetMathHull and add a check for muta

Re: [PATCH] compilation fix for libc++ in C++11 mode

2016-04-16 Thread Guillaume Munch
Le 10/01/2016 21:38, Jean-Marc Lasgouttes a écrit : Le 10/01/16 22:33, Guillaume Munch a écrit : I imagine that Toc and other classes are being forward-declared in some headers probably for the same speed reason. Toc.h is there to provide an alternative to the forward declarations without

Re: Staging Branches [REVISED]

2016-04-16 Thread Guillaume Munch
Le 16/04/2016 20:44, Richard Heck a écrit : We now have three staging branches. These are: 2.3-staging 2.2.1-staging 2.2.2-staging 2.3-staging can be treated as master usually is: It is for development on what will become 2.3 and is now open for commits. This branch will be

Re: [RFC] Staging Branches and Trac

2016-04-16 Thread Guillaume Munch
Le 16/04/2016 20:49, Richard Heck a écrit : As Scott pointed out, my previous suggestions for how fixes committed to the staging branches should be handled in trac was silly. We can't reuse "fixedinmaster" for 2.3-staging. I'm also not sure that we want to introduce a new status

Re: "Splitting of consecutive environments has been reworked and enhanced"

2016-04-16 Thread Guillaume Munch
Le 24/01/2016 23:08, Enrico Forestieri a écrit : On Sun, Jan 24, 2016 at 10:41:39PM +0100, Enrico Forestieri wrote: On Fri, Jan 22, 2016 at 06:36:03PM -0500, Guillaume Munch wrote: Maybe we can go with the improvements you already made for beta, and commit this particular patch to master

Re: SVG display on LyX appears corrupted on the 2.2RC1 Windows build

2016-04-16 Thread Guillaume Munch
Le 16/04/2016 19:55, Guenter Milde a écrit : On 2016-04-16, Scott Kostyshak wrote: That would be another nice reason to do that, but I'm not sure if that is indeed true. However I suppose the conversion is so quick it doesn't make a difference since the relevant timing comparison is compiling

Re: Staging Branches

2016-04-16 Thread Guillaume Munch
Le 16/04/2016 18:55, Scott Kostyshak a écrit : On Sat, Apr 16, 2016 at 07:45:29PM +0200, Jean-Marc Lasgouttes wrote: Le 16/04/16 19:31, Scott Kostyshak a écrit : On Sat, Apr 16, 2016 at 08:34:47AM -0400, Richard Heck wrote: As usual, fixes for bugs committed to 2.2.1-staging (=2.2.x) should

Re: SVG display on LyX appears corrupted on the 2.2RC1 Windows build

2016-04-16 Thread Guillaume Munch
Le 16/04/2016 16:33, Guillaume Munch a écrit : Le 15/04/2016 09:12, Scott Kostyshak a écrit : On Fri, Apr 15, 2016 at 01:53:03AM +0200, Shankar Giri Venkita Giri wrote: I tried to incluide an SVG graphic in a LyX file and it appears horribly corrupted (black triangles everywhere in the image

Re: SVG display on LyX appears corrupted on the 2.2RC1 Windows build

2016-04-16 Thread Guillaume Munch
Le 15/04/2016 09:12, Scott Kostyshak a écrit : On Fri, Apr 15, 2016 at 01:53:03AM +0200, Shankar Giri Venkita Giri wrote: I tried to incluide an SVG graphic in a LyX file and it appears horribly corrupted (black triangles everywhere in the image boundary). PDF output is fine. LyX 2.1 did not

Re: 2.2: can't see source preview

2016-04-15 Thread Guillaume Munch
Le 15/04/2016 03:47, Richard Heck a écrit : On 04/14/2016 09:16 AM, Neal Becker wrote: Guillaume Munch wrote: Le 14/04/2016 13:59, Neal Becker a écrit : Problem is, I use black text on white background. The source preview is unreadable because it's dark text with a black background. I went

Re: Enhancement Suggestion: Preamble Fixed-width Font

2016-04-14 Thread Guillaume Munch
Le 14/04/2016 19:53, Stephan Witt a écrit : Am 14.04.2016 um 20:16 schrieb Guillaume Munch <g...@lyx.org>: Le 14/04/2016 19:05, Stephan Witt a écrit : Yes, it’s attached. Thanks for testing. Works well on Linux+qt{4,5}. Two remarks: * isFixedPitch() would be in an anonymous nam

Re: Enhancement Suggestion: Preamble Fixed-width Font

2016-04-14 Thread Guillaume Munch
Le 14/04/2016 19:05, Stephan Witt a écrit : Yes, it’s attached. Thanks for testing. Works well on Linux+qt{4,5}. Two remarks: * isFixedPitch() would be in an anonymous namespace by what I know of LyX's code style. * In my patch I compute typewriterFontName() from typewriterSystemFont.

Re: Enhancement Suggestion: Preamble Fixed-width Font

2016-04-14 Thread Guillaume Munch
Le 14/04/2016 18:41, Stephan Witt a écrit : Am 14.04.2016 um 19:28 schrieb Guillaume Munch <g...@lyx.org>: Le 14/04/2016 18:10, Stephan Witt a écrit : Am 14.04.2016 um 18:18 schrieb Joel Kulesza <jkule...@gmail.com>: On Thu, Apr 14, 2016 at 10:24 AM, Guillaume Munch <g...

Re: Enhancement Suggestion: Preamble Fixed-width Font

2016-04-14 Thread Guillaume Munch
Le 14/04/2016 18:10, Stephan Witt a écrit : Am 14.04.2016 um 18:18 schrieb Joel Kulesza <jkule...@gmail.com>: On Thu, Apr 14, 2016 at 10:24 AM, Guillaume Munch <g...@lyx.org> wrote: Can you please try the attached patch? That patch seemed to work to correct the issue in both

Re: Enhancement Suggestion: Preamble Fixed-width Font

2016-04-14 Thread Guillaume Munch
Le 14/04/2016 17:18, Joel Kulesza a écrit : On Thu, Apr 14, 2016 at 10:24 AM, Guillaume Munch <g...@lyx.org <mailto:g...@lyx.org>> wrote: Can you please try the attached patch? That patch seemed to work to correct the issue in both places (see attached). The font seem

Re: 2.2: can't see source preview

2016-04-14 Thread Guillaume Munch
Le 14/04/2016 16:21, Guillaume Munch a écrit : Le 14/04/2016 14:36, Neal Becker a écrit : Guillaume Munch wrote: Le 14/04/2016 14:16, Neal Becker a écrit : Guillaume Munch wrote: Le 14/04/2016 13:59, Neal Becker a écrit : Problem is, I use black text on white background. The source

Re: 2.2: can't see source preview

2016-04-14 Thread Guillaume Munch
Le 14/04/2016 14:36, Neal Becker a écrit : Guillaume Munch wrote: Le 14/04/2016 14:16, Neal Becker a écrit : Guillaume Munch wrote: Le 14/04/2016 13:59, Neal Becker a écrit : Problem is, I use black text on white background. The source preview is unreadable because it's dark text

Re: Enhancement Suggestion: Preamble Fixed-width Font

2016-04-14 Thread Guillaume Munch
Le 14/04/2016 13:33, Joel Kulesza a écrit : On Thu, Apr 14, 2016 at 8:29 AM, Joel Kulesza <jkule...@gmail.com <mailto:jkule...@gmail.com>> wrote: On Thu, Apr 14, 2016 at 8:18 AM, Guillaume Munch <g...@lyx.org <mailto:g...@lyx.org>> wrote: Yes it's

Re: 2.2: can't see source preview

2016-04-14 Thread Guillaume Munch
Le 14/04/2016 14:16, Neal Becker a écrit : Guillaume Munch wrote: Le 14/04/2016 13:59, Neal Becker a écrit : Problem is, I use black text on white background. The source preview is unreadable because it's dark text with a black background. I went to preferences/colors and tried changing

Re: 2.2: can't see source preview

2016-04-14 Thread Guillaume Munch
Le 14/04/2016 13:59, Neal Becker a écrit : Problem is, I use black text on white background. The source preview is unreadable because it's dark text with a black background. I went to preferences/colors and tried changing everything that was black, but nothing seemed to fix it. I didn't see

Re: Enhancement Suggestion: Preamble Fixed-width Font

2016-04-14 Thread Guillaume Munch
Le 14/04/2016 12:13, Joel Kulesza a écrit : On Wed, Feb 17, 2016 at 10:39 PM, Scott Kostyshak > wrote: On Wed, Feb 17, 2016 at 10:11:27PM -0500, Richard Heck wrote: > Seems to me a change better for 2.2.0, if Scott is all right with it. Yes

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 21:48, Andrew Parsloe a écrit : Jean-Marc earlier suggested that I make a trac ticket. Time zones have obviously got in the way. Is a ticket still needed? I don't think so. Thanks for the report, I know I would have suffered from that bug at some point. Guillaume

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 20:53, Scott Kostyshak a écrit : On Mon, Apr 11, 2016 at 08:27:42PM +0100, Guillaume Munch wrote: Le 11/04/2016 20:10, Richard Heck a écrit : Again, why stripping "Flex:" off the beginning of name_? This is not how it is done before the regression. Or did I miss

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 20:10, Richard Heck a écrit : Again, why stripping "Flex:" off the beginning of name_? This is not how it is done before the regression. Or did I miss something? name_ wouldn't have contained "Flex:". It's there because InsetLayout::name() includes it. I am not sure that you

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 19:02, Richard Heck a écrit : On 04/11/2016 12:57 PM, Guillaume Munch wrote: Le 11/04/2016 17:28, Jean-Marc Lasgouttes a écrit : Le 11/04/2016 17:53, Scott Kostyshak a écrit : I can confirm that I do not see the problem in 2.1.4 and I do see it with 2.2.0dev. I suppose

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 17:28, Jean-Marc Lasgouttes a écrit : Le 11/04/2016 17:53, Scott Kostyshak a écrit : I can confirm that I do not see the problem in 2.1.4 and I do see it with 2.2.0dev. I suppose this is a dataloss bug, and that there is a rule of not going to an RC with a known dataloss bug that

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 17:39, Jean-Marc Lasgouttes a écrit : Le 11/04/2016 18:33, Richard Heck a écrit : Here is a very lightly tested patch. It looks OK to me, but this kind of changes has potential to do more harm than good. So if we do not have 1/ good user testing and 2/ a +1 from someone who

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 17:33, Richard Heck a écrit : This is exactly what I was going to do. A quicker and dirtier and very safe (IMO) fix is: @@ -75,6 +75,8 @@ void InsetFlex::write(ostream & os) const // use il.name(), since this resolves obsoleted // InsetLayout

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
t;)) name = support::token(name, ':', 1); You both beat me to it! Here's my take on it (with some cleanup and replacing token with split). Now on to commenting your patches. >From 22f3371127079a4cb14c3ec8cb2edc3398149f66 Mon Sep 17 00:00:00 2001 From: Guillaume Munch <

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 12:36, Jean-Marc Lasgouttes a écrit : Le 11/04/2016 07:27, Andrew Parsloe a écrit : Suppose a module defines flex insets moo and baa (the locale-dependent version of foo and bah in New Zealand), and these are used in a document to which the module has been added. If the module is

Re: Proposal for a guide on updating layouts

2016-04-02 Thread Guillaume Munch
Le 02/04/2016 09:17, Scott Kostyshak a écrit : On Fri, Apr 01, 2016 at 09:23:05PM +, Guenter Milde wrote: Patch below, OK to commit? Regarding "Summary... by GM.", note that we have two GM's. Yes, sorry about this. I did not realise it when I chose this login. I am always careful now

Re: Insert LyX Separator

2016-04-02 Thread Guillaume Munch
Le 02/04/2016 18:58, Scott Kostyshak a écrit : On Sat, Apr 02, 2016 at 06:53:49PM +0200, Guillaume Munch wrote: Le 02/04/2016 17:12, Richard Heck a écrit : Is there a menu entry for inserting LyX separators and paragraph breaks? I would have thought I'd find it under Insert> Formatt

<    1   2   3   4   5   6   7   8   9   10   >