Re: [LyX/master] Prevent accidental usage of wrong copy constructor

2014-11-14 Thread Jean-Marc Lasgouttes
Le 11/11/2014 20:58, Georg Baum a écrit : commit 8f93600d3fa8182ba43973075cf37e7ecb2be8d3 Author: Georg Baum b...@lyx.org Date: Tue Nov 11 07:22:14 2014 +0100 Prevent accidental usage of wrong copy constructor Is this what we use boost:noncopyable for in some places? It would be nice

Re: [LyX/master] Prevent accidental usage of wrong copy constructor

2014-11-14 Thread Georg Baum
Jean-Marc Lasgouttes wrote: Le 11/11/2014 20:58, Georg Baum a écrit : commit 8f93600d3fa8182ba43973075cf37e7ecb2be8d3 Author: Georg Baum b...@lyx.org Date: Tue Nov 11 07:22:14 2014 +0100 Prevent accidental usage of wrong copy constructor Is this what we use boost:noncopyable for

Re: [LyX/master] Prevent accidental usage of wrong copy constructor

2014-11-14 Thread Abdelrazak Younes
On 14/11/2014 18:48, Georg Baum wrote: Jean-Marc Lasgouttes wrote: Le 11/11/2014 20:58, Georg Baum a écrit : commit 8f93600d3fa8182ba43973075cf37e7ecb2be8d3 Author: Georg Baum b...@lyx.org Date: Tue Nov 11 07:22:14 2014 +0100 Prevent accidental usage of wrong copy constructor Is

Re: [LyX/master] Prevent accidental usage of wrong copy constructor

2014-11-14 Thread Georg Baum
Abdelrazak Younes wrote: Nitpick: private stuff is at the end of the class not at the top. Sure, but the private noncopyable stuff is the only thing I prefer at the top, since it is then near the other contructors. Abdel. PS: I got some nice ideas today about teletext charset handling

Re: [LyX/master] Prevent accidental usage of wrong copy constructor

2014-11-14 Thread Richard Heck
On 11/14/2014 09:02 PM, Jean-Marc Lasgouttes wrote: I agree with you actually. My points were probably: * we should get rid of the few users of boost::noncopyable * ot would be better to use the terse style of comments we use elsewhere. It turns out there are only three places we use it. Now

Re: [LyX/master] Prevent accidental usage of wrong copy constructor

2014-11-14 Thread Jean-Marc Lasgouttes
Le 11/11/2014 20:58, Georg Baum a écrit : commit 8f93600d3fa8182ba43973075cf37e7ecb2be8d3 Author: Georg Baum Date: Tue Nov 11 07:22:14 2014 +0100 Prevent accidental usage of wrong copy constructor Is this what we use boost:noncopyable for in some places? It would be

Re: [LyX/master] Prevent accidental usage of wrong copy constructor

2014-11-14 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 11/11/2014 20:58, Georg Baum a écrit : >> commit 8f93600d3fa8182ba43973075cf37e7ecb2be8d3 >> Author: Georg Baum >> Date: Tue Nov 11 07:22:14 2014 +0100 >> >> Prevent accidental usage of wrong copy constructor > > Is this what we use

Re: [LyX/master] Prevent accidental usage of wrong copy constructor

2014-11-14 Thread Abdelrazak Younes
On 14/11/2014 18:48, Georg Baum wrote: Jean-Marc Lasgouttes wrote: Le 11/11/2014 20:58, Georg Baum a écrit : commit 8f93600d3fa8182ba43973075cf37e7ecb2be8d3 Author: Georg Baum Date: Tue Nov 11 07:22:14 2014 +0100 Prevent accidental usage of wrong copy constructor Is

Re: [LyX/master] Prevent accidental usage of wrong copy constructor

2014-11-14 Thread Georg Baum
Abdelrazak Younes wrote: > Nitpick: private stuff is at the end of the class not at the top. Sure, but the private noncopyable stuff is the only thing I prefer at the top, since it is then near the other contructors. > Abdel. > > PS: I got some nice ideas today about teletext charset handling

Re: [LyX/master] Prevent accidental usage of wrong copy constructor

2014-11-14 Thread Richard Heck
On 11/14/2014 09:02 PM, Jean-Marc Lasgouttes wrote: I agree with you actually. My points were probably: * we should get rid of the few users of boost::noncopyable * ot would be better to use the terse style of comments we use elsewhere. It turns out there are only three places we use it. Now