Re: [LyX/master] Try to fix #4889 in the right way

2016-08-17 Thread Scott Kostyshak
On Wed, Aug 17, 2016 at 12:06:20PM +0200, Jean-Marc Lasgouttes wrote: > Le 07/08/2016 à 05:44, Scott Kostyshak a écrit : > > Here is another one: the new page inset. See attached example. Can you > > reproduce? > > I tried a more radical approach now, where insets draw their background by >

Re: [LyX/master] Try to fix #4889 in the right way

2016-08-17 Thread Jean-Marc Lasgouttes
Le 07/08/2016 à 05:44, Scott Kostyshak a écrit : Here is another one: the new page inset. See attached example. Can you reproduce? I tried a more radical approach now, where insets draw their background by default. It will catch other cases like VSpace. Tell me how it fares. JMarc

Re: [LyX/master] Try to fix #4889 in the right way

2016-08-06 Thread Scott Kostyshak
On Thu, Aug 04, 2016 at 06:27:29PM -0400, Scott Kostyshak wrote: > On Thu, Aug 04, 2016 at 11:22:46PM +0200, Jean-Marc Lasgouttes wrote: > > Le 24/07/2016 à 23:49, Scott Kostyshak a écrit : > > > This commit appears to have changed behavior for me (says git bisect). > > > With the attached

Re: [LyX/master] Try to fix #4889 in the right way

2016-08-04 Thread Scott Kostyshak
On Thu, Aug 04, 2016 at 11:22:46PM +0200, Jean-Marc Lasgouttes wrote: > Le 24/07/2016 à 23:49, Scott Kostyshak a écrit : > > This commit appears to have changed behavior for me (says git bisect). > > With the attached document, when I select with the mouse some text, the > > special inset "LyX"

Re: [LyX/master] Try to fix #4889 in the right way

2016-08-04 Thread Jean-Marc Lasgouttes
Le 24/07/2016 à 23:49, Scott Kostyshak a écrit : This commit appears to have changed behavior for me (says git bisect). With the attached document, when I select with the mouse some text, the special inset "LyX" alternates between being bold and not bold. Can you reproduce? Better now? JMarc

Re: [LyX/master] Try to fix #4889 in the right way

2016-07-26 Thread Scott Kostyshak
On Tue, Jul 26, 2016 at 01:10:03PM +0200, Jean-Marc Lasgouttes wrote: > Le 25/07/2016 à 04:22, Scott Kostyshak a écrit : > > Also, I'm curious why there is a difference if painting is done with > > mouse versus with keyboard. e.g. I cannot reproduce the issue when > > selecting with keyboard. Why

Re: [LyX/master] Try to fix #4889 in the right way

2016-07-26 Thread Jean-Marc Lasgouttes
Le 25/07/2016 à 04:22, Scott Kostyshak a écrit : Also, I'm curious why there is a difference if painting is done with mouse versus with keyboard. e.g. I cannot reproduce the issue when selecting with keyboard. Why does this asymmetry exist? One case is a full painting where the background has

Re: [LyX/master] Try to fix #4889 in the right way

2016-07-24 Thread Scott Kostyshak
On Sun, Jul 24, 2016 at 07:40:36PM -0400, Scott Kostyshak wrote: > On Mon, Jul 25, 2016 at 01:30:09AM +0200, Jean-Marc Lasgouttes wrote: > > I missed that indeed. I will fix it but will probably not be able to commit > > soon. > > > > JMarc > > OK let me know if you need any testing. Also,

Re: [LyX/master] Try to fix #4889 in the right way

2016-07-24 Thread Scott Kostyshak
On Mon, Jul 25, 2016 at 01:30:09AM +0200, Jean-Marc Lasgouttes wrote: > I missed that indeed. I will fix it but will probably not be able to commit > soon. > > JMarc OK let me know if you need any testing. Scott signature.asc Description: PGP signature

Re: [LyX/master] Try to fix #4889 in the right way

2016-07-24 Thread Jean-Marc Lasgouttes
I missed that indeed. I will fix it but will probably not be able to commit soon. JMarc Le 24 juillet 2016 23:49:02 GMT+02:00, Scott Kostyshak a écrit : >On Wed, Jul 20, 2016 at 12:38:18AM +0200, Jean-Marc Lasgouttes wrote: >> commit 9940acc5063d17f18f50c690085c7d97f25d909d

Re: [LyX/master] Try to fix #4889 in the right way

2016-07-24 Thread Scott Kostyshak
On Wed, Jul 20, 2016 at 12:38:18AM +0200, Jean-Marc Lasgouttes wrote: > commit 9940acc5063d17f18f50c690085c7d97f25d909d > Author: Jean-Marc Lasgouttes > Date: Wed Jul 20 00:12:21 2016 +0200 > > Try to fix #4889 in the right way > > For reference, the bug was