Richard Heck wrote:
The attached addresses http://bugzilla.lyx.org/show_bug.cgi?id=3650. The
issues were two. (i) When the old inset was erased, the iterator became
invalid, and the attempt to increment it caused an abort; (ii) after
clearing that up, a different abort made it clear that the
Richard Heck wrote:
Index: Paragraph.h
===
--- Paragraph.h (revision 18413)
+++ Paragraph.h (working copy)
@@ -359,9 +359,11 @@
///
bool hfillExpansion(Row const row, pos_type pos) const;
- /// Check if we are in
Abdelrazak Younes schrieb:
Richard Heck wrote:
Index: Paragraph.h
===
--- Paragraph.h(revision 18413)
+++ Paragraph.h(working copy)
@@ -359,9 +359,11 @@
///
bool hfillExpansion(Row const row, pos_type pos) const;
Bernhard Roider wrote:
In general enums are more explicative:
enum CursorMove {
NoMove,
MoveRight,
MoveLeft
}
I did not take a closer look at the code, but shouldn't it be forward
and backward instead of right and left?
I don't think so. The `right' and `left' don't actually
Abdelrazak Younes wrote:
Richard Heck wrote:
Index: Paragraph.h
===
--- Paragraph.h(revision 18413)
+++ Paragraph.h(working copy)
@@ -359,9 +359,11 @@
///
bool hfillExpansion(Row const row, pos_type pos)
Jürgen Spitzmüller wrote:
Richard Heck wrote:
The attached addresses http://bugzilla.lyx.org/show_bug.cgi?id=3650. The
issues were two. (i) When the old inset was erased, the iterator became
invalid, and the attempt to increment it caused an abort; (ii) after
clearing that up, a different
Richard Heck wrote:
> The attached addresses http://bugzilla.lyx.org/show_bug.cgi?id=3650. The
> issues were two. (i) When the old inset was erased, the iterator became
> invalid, and the attempt to increment it caused an abort; (ii) after
> clearing that up, a different abort made it clear that
Richard Heck wrote:
Index: Paragraph.h
===
--- Paragraph.h (revision 18413)
+++ Paragraph.h (working copy)
@@ -359,9 +359,11 @@
///
bool hfillExpansion(Row const & row, pos_type pos) const;
- /// Check if we are in
Abdelrazak Younes schrieb:
Richard Heck wrote:
Index: Paragraph.h
===
--- Paragraph.h(revision 18413)
+++ Paragraph.h(working copy)
@@ -359,9 +359,11 @@
///
bool hfillExpansion(Row const & row, pos_type pos)
Bernhard Roider wrote:
>> In general enums are more explicative:
>>
>> enum CursorMove {
>> NoMove,
>> MoveRight,
>> MoveLeft
>> }
>>
> I did not take a closer look at the code, but shouldn't it be forward
> and backward instead of right and left?
I don't think so. The `right' and
Abdelrazak Younes wrote:
> Richard Heck wrote:
>> Index: Paragraph.h
>> ===
>> --- Paragraph.h(revision 18413)
>> +++ Paragraph.h(working copy)
>> @@ -359,9 +359,11 @@
>> ///
>> bool hfillExpansion(Row const & row,
Jürgen Spitzmüller wrote:
> Richard Heck wrote:
>
>> The attached addresses http://bugzilla.lyx.org/show_bug.cgi?id=3650. The
>> issues were two. (i) When the old inset was erased, the iterator became
>> invalid, and the attempt to increment it caused an abort; (ii) after
>> clearing that up, a
The attached addresses http://bugzilla.lyx.org/show_bug.cgi?id=3650. The
issues were two. (i) When the old inset was erased, the iterator became
invalid, and the attempt to increment it caused an abort; (ii) after
clearing that up, a different abort made it clear that the cursor
position needed
Richard Heck wrote:
NOTE: Some other issues I noticed here, which I'll put in bugzilla if it
seems a good idea. (iii) Change the layout of one of
these paragraphs to Standard. Shouldn't the bibitem be erased? (This
could be handled in checkBiblio without too much effort.)
Never mind that
The attached addresses http://bugzilla.lyx.org/show_bug.cgi?id=3650.
Testing requested, as well as two commit OKs if it seems all right.
Works here as expected but we should wait for Jürgen's comment on this.
NOTE: Some other issues I noticed here, which I'll put in bugzilla if it
seems a
The attached addresses http://bugzilla.lyx.org/show_bug.cgi?id=3650. The
issues were two. (i) When the old inset was erased, the iterator became
invalid, and the attempt to increment it caused an abort; (ii) after
clearing that up, a different abort made it clear that the cursor
position needed
Richard Heck wrote:
> NOTE: Some other issues I noticed here, which I'll put in bugzilla if it
> seems a good idea. (iii) Change the layout of one of
> these paragraphs to Standard. Shouldn't the bibitem be erased? (This
> could be handled in checkBiblio without too much effort.)
>
Never mind
> The attached addresses http://bugzilla.lyx.org/show_bug.cgi?id=3650.
>
> Testing requested, as well as two commit OKs if it seems all right.
Works here as expected but we should wait for Jürgen's comment on this.
> NOTE: Some other issues I noticed here, which I'll put in bugzilla if it
>
18 matches
Mail list logo
