Abdelrazak Younes wrote:
Bo Peng wrote:
Per the use of exception, I think exception should be used more often
in lyx.
LyX's code base is not exception safe. The code hasn't been written
with exception safety in mind, largely because we weren't proficient
in the use of exceptions. (I
Abdelrazak Younes wrote:
Bo Peng wrote:
Per the use of exception, I think exception should be used more often
in lyx.
LyX's code base is not exception safe. The code hasn't been written
with exception safety in mind, largely because we weren't proficient
in the use of exceptions. (I
Bo Peng wrote:
Bo Fixed in the attached patch. Jose, OK to apply?
I am not very pleased with the use of an exception there, but on the
other hand I do not have (yet) a better idea.
I though of returning TocItem and let update() add the labels.
However, ParConstIterator does not have a default
Bo Peng wrote:
Bo> Fixed in the attached patch. Jose, OK to apply?
I am not very pleased with the use of an exception there, but on the
other hand I do not have (yet) a better idea.
I though of returning TocItem and let update() add the labels.
However, ParConstIterator does not have a
Bo Fixed in the attached patch. Jose, OK to apply?
I am not very pleased with the use of an exception there, but on the
other hand I do not have (yet) a better idea.
Jose,
This patch works although JMarc does not like it.
I can commit it with your permission or put it to bugzilla if you
Bo == Bo Peng [EMAIL PROTECTED] writes:
Bo This patch works although JMarc does not like it.
To clarify: I am not against using exceptions for something else than
an error, but we should make clear the kind of use we envision, not
just use them on an ad-hoc basis. In this particular case, I
In this particular case, I think
that I'd prefer to pass a cursor to addToToc.
Do you mean the attached? This looks better to me but I was trying not
to alter the inset interface.
Bo
Index: src/insets/InsetCaption.cpp
===
---
On Monday 04 June 2007 16:59:59 Jean-Marc Lasgouttes wrote:
To clarify: I am not against using exceptions for something else than
an error, but we should make clear the kind of use we envision, not
just use them on an ad-hoc basis.
I agree with Jean-Marc here.
In this particular case, I
Bo> Fixed in the attached patch. Jose, OK to apply?
I am not very pleased with the use of an exception there, but on the
other hand I do not have (yet) a better idea.
Jose,
This patch works although JMarc does not like it.
I can commit it with your permission or put it to bugzilla if you
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes:
Bo> This patch works although JMarc does not like it.
To clarify: I am not against using exceptions for something else than
an error, but we should make clear the kind of use we envision, not
just use them on an ad-hoc basis. In this particular
In this particular case, I think
that I'd prefer to pass a cursor to addToToc.
Do you mean the attached? This looks better to me but I was trying not
to alter the inset interface.
Bo
Index: src/insets/InsetCaption.cpp
===
---
On Monday 04 June 2007 16:59:59 Jean-Marc Lasgouttes wrote:
> To clarify: I am not against using exceptions for something else than
> an error, but we should make clear the kind of use we envision, not
> just use them on an ad-hoc basis.
I agree with Jean-Marc here.
> In this particular case,
On Sat, Jun 02, 2007 at 12:26:48AM -0500, Bo Peng wrote:
When an inset such as InsetInclude does not have a valid
ParConstIterator (because it does not have valid paragraphs), it has
to use the iterator of its parent paragraph. This patch implements
this and add InsetInclude with a caption to
+/// thrown by an inset that does not have a valid ParConstIterator
+/// so the paragraph containing this inset has to be used
+class outerTocItem
'OuterTocItem'
Fixed in the attached patch. Jose, OK to apply? (I assume Andre has
tested this patch).
Bo
Index: src/insets/InsetInclude.cpp
Bo == Bo Peng [EMAIL PROTECTED] writes:
+/// thrown by an inset that does not have a valid
ParConstIterator +/// so the paragraph containing this inset has
to be used +class outerTocItem
'OuterTocItem'
Bo Fixed in the attached patch. Jose, OK to apply?
I am not very pleased with the
Bo Fixed in the attached patch. Jose, OK to apply?
I am not very pleased with the use of an exception there, but on the
other hand I do not have (yet) a better idea.
I though of returning TocItem and let update() add the labels.
However, ParConstIterator does not have a default constructor
On Sat, Jun 02, 2007 at 08:41:06AM -0500, Bo Peng wrote:
+/// thrown by an inset that does not have a valid ParConstIterator
+/// so the paragraph containing this inset has to be used
+class outerTocItem
'OuterTocItem'
Fixed in the attached patch. Jose, OK to apply? (I assume Andre has
On Sat, Jun 02, 2007 at 12:26:48AM -0500, Bo Peng wrote:
> When an inset such as InsetInclude does not have a valid
> ParConstIterator (because it does not have valid paragraphs), it has
> to use the iterator of its parent paragraph. This patch implements
> this and add InsetInclude with a caption
> +/// thrown by an inset that does not have a valid ParConstIterator
> +/// so the paragraph containing this inset has to be used
> +class outerTocItem
'OuterTocItem'
Fixed in the attached patch. Jose, OK to apply? (I assume Andre has
tested this patch).
Bo
Index: src/insets/InsetInclude.cpp
> "Bo" == Bo Peng <[EMAIL PROTECTED]> writes:
>> > +/// thrown by an inset that does not have a valid
>> ParConstIterator > +/// so the paragraph containing this inset has
>> to be used > +class outerTocItem
>>
>> 'OuterTocItem'
Bo> Fixed in the attached patch. Jose, OK to apply?
I am not
Bo> Fixed in the attached patch. Jose, OK to apply?
I am not very pleased with the use of an exception there, but on the
other hand I do not have (yet) a better idea.
I though of returning TocItem and let update() add the labels.
However, ParConstIterator does not have a default constructor
On Sat, Jun 02, 2007 at 08:41:06AM -0500, Bo Peng wrote:
> >> +/// thrown by an inset that does not have a valid ParConstIterator
> >> +/// so the paragraph containing this inset has to be used
> >> +class outerTocItem
> >
> >'OuterTocItem'
>
> Fixed in the attached patch. Jose, OK to apply? (I
When an inset such as InsetInclude does not have a valid
ParConstIterator (because it does not have valid paragraphs), it has
to use the iterator of its parent paragraph. This patch implements
this and add InsetInclude with a caption to nagivation - list of
listings.
To test, look under
When an inset such as InsetInclude does not have a valid
ParConstIterator (because it does not have valid paragraphs), it has
to use the iterator of its parent paragraph. This patch implements
this and add InsetInclude with a caption to nagivation -> list of
listings.
To test, look under
24 matches
Mail list logo
