On 25/09/2008 15:14, Jean-Marc Lasgouttes wrote:
rgheck[EMAIL PROTECTED] writes:
Well, if you're going to leave InsetInfo until after 1.6, we can do
this together. You can tell me what character styles you want, and
I'll produce definitions of them that you can use. I've already done
this
Abdelrazak Younes [EMAIL PROTECTED] writes:
One not so minor comment: please use InsetCollapsable::xxx instead of
InsetText::xxx unless you explicitely don't want to use existent
InsetCollapsable method.
Better: could you tell me why I cannot directly use setText() and need
to add the
Abdelrazak Younes [EMAIL PROTECTED] writes:
One not so minor comment: please use InsetCollapsable::xxx instead of
InsetText::xxx unless you explicitely don't want to use existent
InsetCollapsable method.
Better: could you tell me why I cannot directly use setText() and need
to add the
On 26/09/2008 14:11, Jean-Marc Lasgouttes wrote:
Abdelrazak Younes[EMAIL PROTECTED] writes:
One not so minor comment: please use InsetCollapsable::xxx instead of
InsetText::xxx unless you explicitely don't want to use existent
InsetCollapsable method.
Better: could you tell me why
On 26/09/2008 14:51, Abdelrazak Younes wrote:
On 26/09/2008 14:11, Jean-Marc Lasgouttes wrote:
Abdelrazak Younes[EMAIL PROTECTED] writes:
One not so minor comment: please use InsetCollapsable::xxx instead of
InsetText::xxx unless you explicitely don't want to use existent
InsetCollapsable
Abdelrazak Younes [EMAIL PROTECTED] writes:
I guess gcc has difficulties to decide between the two versions of it
because if InsetText::setText() had a default value to _its_ second
argument, there would be no _way_ to differentiate them.
Looks like Vincent solution was the right one.
JMarc
Vincent van Ravesteijn - TNW [EMAIL PROTECTED] writes:
See:
Why doesn't overloading work for derived classes? at
http://www.research.att.com/~bs/bs_faq2.html#overloadderived
Yes, it works! I am not convinced by the argument, but it is OK.
JMarc
PS: here is my updated insetinfo patch with
On Friday 26 September 2008 14:43:44 Jean-Marc Lasgouttes wrote:
PS: here is my updated insetinfo patch with further simplifications.
Post rc3, please.
As soon as you are happy with the resulting code this can go in.
--
José Abílio
José Matos [EMAIL PROTECTED] writes:
On Friday 26 September 2008 14:43:44 Jean-Marc Lasgouttes wrote:
PS: here is my updated insetinfo patch with further simplifications.
Post rc3, please.
Yes, this was my plan.
JMarc
On 25/09/2008 15:14, Jean-Marc Lasgouttes wrote:
rgheck<[EMAIL PROTECTED]> writes:
Well, if you're going to leave InsetInfo until after 1.6, we can do
this together. You can tell me what character styles you want, and
I'll produce definitions of them that you can use. I've already done
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> One not so minor comment: please use InsetCollapsable::xxx instead of
> InsetText::xxx unless you explicitely don't want to use existent
> InsetCollapsable method.
Better: could you tell me why I cannot directly use setText() and need
to add the
>Abdelrazak Younes <[EMAIL PROTECTED]> writes:
>> One not so minor comment: please use InsetCollapsable::xxx instead of
>> InsetText::xxx unless you explicitely don't want to use existent
>> InsetCollapsable method.
>Better: could you tell me why I cannot directly use setText() and need
>to
On 26/09/2008 14:11, Jean-Marc Lasgouttes wrote:
Abdelrazak Younes<[EMAIL PROTECTED]> writes:
One not so minor comment: please use InsetCollapsable::xxx instead of
InsetText::xxx unless you explicitely don't want to use existent
InsetCollapsable method.
Better: could you tell me
On 26/09/2008 14:51, Abdelrazak Younes wrote:
On 26/09/2008 14:11, Jean-Marc Lasgouttes wrote:
Abdelrazak Younes<[EMAIL PROTECTED]> writes:
One not so minor comment: please use InsetCollapsable::xxx instead of
InsetText::xxx unless you explicitely don't want to use existent
InsetCollapsable
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> I guess gcc has difficulties to decide between the two versions of it
> because if InsetText::setText() had a default value to _its_ second
> argument, there would be no _way_ to differentiate them.
Looks like Vincent solution was the right one.
"Vincent van Ravesteijn - TNW" <[EMAIL PROTECTED]> writes:
> See:
>
> "Why doesn't overloading work for derived classes?" at
>
> http://www.research.att.com/~bs/bs_faq2.html#overloadderived
Yes, it works! I am not convinced by the argument, but it is OK.
JMarc
PS: here is my updated insetinfo
On Friday 26 September 2008 14:43:44 Jean-Marc Lasgouttes wrote:
> PS: here is my updated insetinfo patch with further simplifications.
Post rc3, please.
As soon as you are happy with the resulting code this can go in.
--
José Abílio
José Matos <[EMAIL PROTECTED]> writes:
> On Friday 26 September 2008 14:43:44 Jean-Marc Lasgouttes wrote:
>> PS: here is my updated insetinfo patch with further simplifications.
>
> Post rc3, please.
Yes, this was my plan.
JMarc
rgheck [EMAIL PROTECTED] writes:
Well, if you're going to leave InsetInfo until after 1.6, we can do
this together. You can tell me what character styles you want, and
I'll produce definitions of them that you can use. I've already done
this for Customization, as you'll see if you look under
On 25/09/2008 15:14, Jean-Marc Lasgouttes wrote:
rgheck[EMAIL PROTECTED] writes:
Well, if you're going to leave InsetInfo until after 1.6, we can do
this together. You can tell me what character styles you want, and
I'll produce definitions of them that you can use. I've already done
this
Abdelrazak Younes [EMAIL PROTECTED] writes:
1/ make InsetInfo depend on InsetCollapsable (this is only because I
need this to have an insetlayout, in principle InsetText is OK).
Why not transferring InsetLayout to InsetText as you initially suggested?
Because it requires a bit more work,
Jean-Marc Lasgouttes wrote:
rgheck [EMAIL PROTECTED] writes:
Well, if you're going to leave InsetInfo until after 1.6, we can do
this together. You can tell me what character styles you want, and
I'll produce definitions of them that you can use. I've already done
this for Customization, as
rgheck [EMAIL PROTECTED] writes:
This looks good to me. It's really a great illustration of why
InsetLayout was such a great idea. Yours, if I recall
Maybe, but Martin did all the hard work.
JMarc
rgheck <[EMAIL PROTECTED]> writes:
> Well, if you're going to leave InsetInfo until after 1.6, we can do
> this together. You can tell me what character styles you want, and
> I'll produce definitions of them that you can use. I've already done
> this for Customization, as you'll see if you look
On 25/09/2008 15:14, Jean-Marc Lasgouttes wrote:
rgheck<[EMAIL PROTECTED]> writes:
Well, if you're going to leave InsetInfo until after 1.6, we can do
this together. You can tell me what character styles you want, and
I'll produce definitions of them that you can use. I've already done
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
>> 1/ make InsetInfo depend on InsetCollapsable (this is only because I
>> need this to have an insetlayout, in principle InsetText is OK).
>
> Why not transferring InsetLayout to InsetText as you initially suggested?
Because it requires a bit more
Jean-Marc Lasgouttes wrote:
rgheck <[EMAIL PROTECTED]> writes:
Well, if you're going to leave InsetInfo until after 1.6, we can do
this together. You can tell me what character styles you want, and
I'll produce definitions of them that you can use. I've already done
this for Customization,
rgheck <[EMAIL PROTECTED]> writes:
> This looks good to me. It's really a great illustration of why
> InsetLayout was such a great idea. Yours, if I recall
Maybe, but Martin did all the hard work.
JMarc
28 matches
Mail list logo
