[PATCH] Trivial patch to fix warning

2007-05-24 Thread Richard Heck
The attached removes a few pointless calls from QInclude.cpp that do nothing but cause a warning to be written to the console. OK to commit? rh -- == Richard G Heck, Jr Professor of Philosophy Brown University

Re: [PATCH] Trivial patch to fix warning

2007-05-24 Thread José Matos
On Thursday 24 May 2007 07:28:40 Richard Heck wrote: The attached removes a few pointless calls from QInclude.cpp that do nothing but cause a warning to be written to the console. OK to commit? The purpose of the code seems to be resetting the options, if you are sure that it works without

Re: [PATCH] Trivial patch to fix warning

2007-05-24 Thread Richard Heck
José Matos wrote: On Thursday 24 May 2007 07:28:40 Richard Heck wrote: The attached removes a few pointless calls from QInclude.cpp that do nothing but cause a warning to be written to the console. OK to commit? The purpose of the code seems to be resetting the options, if you are

Re: [PATCH] Trivial patch to fix warning

2007-05-24 Thread Bo Peng
Hmm, I see. Let's ask Bo about this, as I think he must have added these calls. I haven't been able to cause a problem after deleting these lines. The reason is that the InsetInclude::latex() routine just ignores the options, anyway, if we're not dealing with a listings include. The advantage

Re: [PATCH] Trivial patch to fix warning

2007-05-24 Thread Richard Heck
Bo Peng wrote: I haven't been able to cause a problem after deleting these lines. The reason is that the InsetInclude::latex() routine just ignores the options, anyway, if we're not dealing with a listings include. The advantage to deleting them turns out to be that if you switch from

[PATCH] Trivial patch to fix warning

2007-05-24 Thread Richard Heck
The attached removes a few pointless calls from QInclude.cpp that do nothing but cause a warning to be written to the console. OK to commit? rh -- == Richard G Heck, Jr Professor of Philosophy Brown University

Re: [PATCH] Trivial patch to fix warning

2007-05-24 Thread José Matos
On Thursday 24 May 2007 07:28:40 Richard Heck wrote: > The attached removes a few pointless calls from QInclude.cpp that do > nothing but cause a warning to be written to the console. OK to commit? The purpose of the code seems to be resetting the options, if you are sure that it works without

Re: [PATCH] Trivial patch to fix warning

2007-05-24 Thread Richard Heck
José Matos wrote: > On Thursday 24 May 2007 07:28:40 Richard Heck wrote: > >> The attached removes a few pointless calls from QInclude.cpp that do >> nothing but cause a warning to be written to the console. OK to commit? >> > The purpose of the code seems to be resetting the options, if

Re: [PATCH] Trivial patch to fix warning

2007-05-24 Thread Bo Peng
Hmm, I see. Let's ask Bo about this, as I think he must have added these calls. I haven't been able to cause a problem after deleting these lines. The reason is that the InsetInclude::latex() routine just ignores the options, anyway, if we're not dealing with a listings include. The advantage

Re: [PATCH] Trivial patch to fix warning

2007-05-24 Thread Richard Heck
Bo Peng wrote: >> I haven't been able to cause a problem after deleting these lines. The >> reason is that the InsetInclude::latex() routine just ignores the >> options, anyway, if we're not dealing with a listings include. The >> advantage to deleting them turns out to be that if you switch from