Re: [PATCH] compilation fix for libc++ in C++11 mode

2016-04-18 Thread Jean-Marc Lasgouttes
Le 17/04/2016 01:03, Guillaume Munch a écrit : Le 10/01/2016 21:38, Jean-Marc Lasgouttes a écrit : Le 10/01/16 22:33, Guillaume Munch a écrit : I imagine that Toc and other classes are being forward-declared in some headers probably for the same speed reason. Toc.h is there to provide an

Re: [PATCH] compilation fix for libc++ in C++11 mode

2016-04-16 Thread Guillaume Munch
Le 10/01/2016 21:38, Jean-Marc Lasgouttes a écrit : Le 10/01/16 22:33, Guillaume Munch a écrit : I imagine that Toc and other classes are being forward-declared in some headers probably for the same speed reason. Toc.h is there to provide an alternative to the forward declarations without

Re: [PATCH] compilation fix for libc++ in C++11 mode

2016-01-11 Thread Jean-Marc Lasgouttes
Le 08/01/2016 22:39, Georg Baum a écrit : Jean-Marc Lasgouttes wrote: The following patch fixes compilation for me with clang and libc++ (with autotools I set CXX="clang++ --stdlib=libc++"). This is a workaround to https://llvm.org/bugs/show_bug.cgi?id=24137 to be fixed in 3.7.1 or 3.8.0.

Re: [PATCH] compilation fix for libc++ in C++11 mode

2016-01-11 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 10/01/16 22:17, Guillaume Munch a écrit : >> Since you have gotten a +1 from somebody else, sure. I was not so sure >> myself, so I wanted to offer an alternative that was sure to be safe. I >> think this will have to be done nevertheless, so I am going to keep it

Re: [PATCH] compilation fix for libc++ in C++11 mode

2016-01-10 Thread Jean-Marc Lasgouttes
Le 08/01/16 22:50, Guillaume Munch a écrit : I tried to look it up. It might work right now but I think we should get rid of this subclassing entirely. It is just used for forward-declaration and defining helper functions. I have a bad feeling about starting to define custom constructors for STL

Re: [PATCH] compilation fix for libc++ in C++11 mode

2016-01-10 Thread Guillaume Munch
Le 10/01/2016 20:42, Jean-Marc Lasgouttes a écrit : Le 08/01/16 22:50, Guillaume Munch a écrit : I tried to look it up. It might work right now but I think we should get rid of this subclassing entirely. It is just used for forward-declaration and defining helper functions. I have a bad feeling

Re: [PATCH] compilation fix for libc++ in C++11 mode

2016-01-10 Thread Jean-Marc Lasgouttes
Le 10/01/16 22:17, Guillaume Munch a écrit : Since you have gotten a +1 from somebody else, sure. I was not so sure myself, so I wanted to offer an alternative that was sure to be safe. I think this will have to be done nevertheless, so I am going to keep it for later. Indeed Georg's comment

Re: [PATCH] compilation fix for libc++ in C++11 mode

2016-01-10 Thread Guillaume Munch
Le 10/01/2016 21:26, Jean-Marc Lasgouttes a écrit : Le 10/01/16 22:17, Guillaume Munch a écrit : Since you have gotten a +1 from somebody else, sure. I was not so sure myself, so I wanted to offer an alternative that was sure to be safe. I think this will have to be done nevertheless, so I am

Re: [PATCH] compilation fix for libc++ in C++11 mode

2016-01-10 Thread Jean-Marc Lasgouttes
Le 10/01/16 22:33, Guillaume Munch a écrit : I imagine that Toc and other classes are being forward-declared in some headers probably for the same speed reason. Toc.h is there to provide an alternative to the forward declarations without sacrificing speed (or maybe my Toc.h already includes too

[PATCH] compilation fix for libc++ in C++11 mode

2016-01-08 Thread Jean-Marc Lasgouttes
The following patch fixes compilation for me with clang and libc++ (with autotools I set CXX="clang++ --stdlib=libc++"). This is a workaround to https://llvm.org/bugs/show_bug.cgi?id=24137 to be fixed in 3.7.1 or 3.8.0. Can someone confirm that adding the default constructor like that is

Re: [PATCH] compilation fix for libc++ in C++11 mode

2016-01-08 Thread Guillaume Munch
Le 08/01/2016 08:59, Jean-Marc Lasgouttes a écrit : The following patch fixes compilation for me with clang and libc++ (with autotools I set CXX="clang++ --stdlib=libc++"). This is a workaround to https://llvm.org/bugs/show_bug.cgi?id=24137 to be fixed in 3.7.1 or 3.8.0. Can someone confirm

Re: [PATCH] compilation fix for libc++ in C++11 mode

2016-01-08 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > The following patch fixes compilation for me with clang and libc++ (with > autotools I set CXX="clang++ --stdlib=libc++"). > > This is a workaround to https://llvm.org/bugs/show_bug.cgi?id=24137 > to be fixed in 3.7.1 or 3.8.0. > > Can someone confirm that adding