Re: [PATCH] fix "scroll here" (#10311)

2016-07-30 Thread Scott Kostyshak
On Sat, Jul 30, 2016 at 01:54:03AM +0100, Guillaume Munch wrote: > An invariant is that the scrollbar position is always zero. I remember your comment pointing this out. This was helpful when I was debugging. > With your > patch, in rare occasions I noticed that it would become negative (for >

Re: [PATCH] fix "scroll here" (#10311)

2016-07-29 Thread Guillaume Munch
Le 29/07/2016 à 18:51, Scott Kostyshak a écrit : I have a patch for http://www.lyx.org/trac/ticket/10311 which I attach on this email for convenience. It fixes the bug for me, but I don't actually understand what's going on. It is a simple patch (just a reordering), but since I don't understand

Re: [PATCH] fix "scroll here" (#10311)

2016-07-29 Thread Guillaume Munch
Le 29/07/2016 à 23:32, Jean-Marc Lasgouttes a écrit : Le 29/07/2016 à 19:51, Scott Kostyshak a écrit : I have a patch for http://www.lyx.org/trac/ticket/10311 which I attach on this email for convenience. It fixes the bug for me, but I don't actually understand what's going on. It is a simple

Re: [PATCH] fix "scroll here" (#10311)

2016-07-29 Thread Jean-Marc Lasgouttes
Le 29/07/2016 à 19:51, Scott Kostyshak a écrit : I have a patch for http://www.lyx.org/trac/ticket/10311 which I attach on this email for convenience. It fixes the bug for me, but I don't actually understand what's going on. It is a simple patch (just a reordering), but since I don't understand

[PATCH] fix "scroll here" (#10311)

2016-07-29 Thread Scott Kostyshak
I have a patch for http://www.lyx.org/trac/ticket/10311 which I attach on this email for convenience. It fixes the bug for me, but I don't actually understand what's going on. It is a simple patch (just a reordering), but since I don't understand exactly why it works I would like to either commit