Re: [PATCH] spellchecker re-working

2003-02-18 Thread John Levon
On Mon, Feb 17, 2003 at 05:38:02PM +0100, Edwin Leuven wrote: ingore all with: students' doesn't work for me can you make a bug ? john

Re: [PATCH] spellchecker re-working

2003-02-18 Thread John Levon
On Mon, Feb 17, 2003 at 05:38:02PM +0100, Edwin Leuven wrote: > ingore all with: students' > > doesn't work for me can you make a bug ? john

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 17. Februar 2003 02:05, John Levon wrote: Here is my final patch. Less code, more features ! Please test. There is one niggle left: we briefly show the dialog when there is no need (clean spell check). It's minorly visually distracting. I think

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Angus Leeming
John Levon wrote: Here is my final patch. Less code, more features ! Please test. There is one niggle left: we briefly show the dialog when there is no need (clean spell check). It's minorly visually distracting. I think it's worth it. Maybe Angus has a smart minimal fix for it. There is

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Moritz Moeller-Herrmann
John Levon wrote: Here is my final patch. Less code, more features ! Please test. It works fine here with gnu aspell-0.50 and lyx-1.3.1CVS. Adding words to the personal dictionary works. -- Moritz Moeller-Herrmann

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 17. Februar 2003 10:31, Kornel Benko wrote: Compiling now ... NOT working. There is only an alert-box about failed invocation (comming immediately) aspell -a -d german -C -w_ -T latin1 This usage _works_ from if invoked manually. Could not

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- Interpreting the trace Lyx-pid = 28437 fork() -- child pid 28488 28488 dup2(9, 0)= 0 28488 dup2(12, 1) = 1 28488 dup2(14, 2) = 2 28488 close(9) = 0 28488 close(10)

Re: [PATCH] spellchecker re-working

2003-02-17 Thread John Levon
On Mon, Feb 17, 2003 at 10:15:29AM +, Angus Leeming wrote: There is a parameter 'emergency_exit' (see ControlDialog). If you set it to true, then the dialog is not shown. Does it do the job for you? No, emergency_exit_ is checked only *before* view().show(). If it's only used by the

Re: [PATCH] spellchecker re-working

2003-02-17 Thread John Levon
On Mon, Feb 17, 2003 at 01:54:15AM -0400, Garst R. Reese wrote: o use Ignore All not Accept - it's far clearer Aspell does not really ignore the word, it puts it in a temp dict so it may become a suggested word later. f.ex. Macphail, then it finds MacPhail and suggests Macphail. Hmm that's

Re: [PATCH] spellchecker re-working

2003-02-17 Thread John Levon
On Mon, Feb 17, 2003 at 01:06:55PM +0100, Kornel Benko wrote: 28488 write(2, s, 1)and so on with the string 'spell invokation was aspell -a -d german -C -w _ -T latin1 ' Hmm, where's this string coming from ? I'm having trouble figuring

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 17. Februar 2003 16:35, John Levon wrote: On Mon, Feb 17, 2003 at 01:06:55PM +0100, Kornel Benko wrote: 28488 write(2, s, 1) and so on with the string 'spell invokation was aspell -a -d german -C

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Angus Leeming
John Levon wrote: On Mon, Feb 17, 2003 at 10:15:29AM +, Angus Leeming wrote: There is a parameter 'emergency_exit' (see ControlDialog). If you set it to true, then the dialog is not shown. Does it do the job for you? No, emergency_exit_ is checked only *before* view().show(). If it's

Re: [PATCH] spellchecker re-working

2003-02-17 Thread John Levon
On Mon, Feb 17, 2003 at 05:00:15PM +0100, Kornel Benko wrote: child is writing to lyxerr[Debug::GUI] (which now happens to be also the pipe) Well, that was stupid of me ! Thanks, I'll remove this code. Apart from that, everything is OK ? john

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 17. Februar 2003 17:00, Kornel Benko wrote: child is writing to lyxerr[Debug::GUI] (which now happens to be also the pipe) Ok, disabling the debug output, spellchecker works so far, but does not allow me to use _ inside words. Kornel -

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 17. Februar 2003 17:12, John Levon wrote: On Mon, Feb 17, 2003 at 05:00:15PM +0100, Kornel Benko wrote: child is writing to lyxerr[Debug::GUI] (which now happens to be also the pipe) Well, that was stupid of me ! Thanks, I'll remove this code.

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Edwin Leuven
Apart from that, everything is OK ? barging into the thread; ingore all with: students' doesn't work for me Ed.

Re: [PATCH] spellchecker re-working

2003-02-17 Thread John Levon
On Mon, Feb 17, 2003 at 05:38:02PM +0100, Edwin Leuven wrote: ingore all with: students' doesn't work for me A bug, but it's not new in my patch. john

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 17. Februar 2003 17:24, Kornel Benko wrote: Apart from that, everything is OK ? Let me test a little. Neither Ignore, nor Add are accepting words with _ (which is _my_ Escape character). - -- Spellchecking stops with an alert-box, which is

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Jean-Marc Lasgouttes
John == John Levon [EMAIL PROTECTED] writes: John JMarc, if this gets a good run for its money, would you consider John it ? Yes. I do not know yet whether it should go in 1.3.1 or 1.3.2. I am considering now a near release of 1.3.1. There is nothing earth-shattering in it, but at least it

Re: [PATCH] spellchecker re-working

2003-02-17 Thread John Levon
On Mon, Feb 17, 2003 at 06:32:32PM +0100, Jean-Marc Lasgouttes wrote: Yes. I do not know yet whether it should go in 1.3.1 or 1.3.2. I am considering now a near release of 1.3.1. There is nothing earth-shattering in it, but at least it should work. Either is fine by me. I'm glad we're having

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Jean-Marc Lasgouttes
John == John Levon [EMAIL PROTECTED] writes: John On Mon, Feb 17, 2003 at 06:32:32PM +0100, Jean-Marc Lasgouttes John wrote: Yes. I do not know yet whether it should go in 1.3.1 or 1.3.2. I am considering now a near release of 1.3.1. There is nothing earth-shattering in it, but at least it

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Moritz Moeller-Herrmann
John Levon wrote: On Mon, Feb 17, 2003 at 01:54:15AM -0400, Garst R. Reese wrote: o use Ignore All not Accept - it's far clearer Aspell does not really ignore the word, it puts it in a temp dict so it may become a suggested word later. f.ex. Macphail, then it finds MacPhail and suggests

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 17. Februar 2003 02:05, John Levon wrote: > Here is my "final" patch. Less code, more features ! Please test. > > There is one niggle left: we briefly show the dialog when there is no > need (clean spell check). It's minorly visually distracting. I

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Angus Leeming
John Levon wrote: > > Here is my "final" patch. Less code, more features ! Please test. > > There is one niggle left: we briefly show the dialog when there is > no need (clean spell check). It's minorly visually distracting. I > think it's worth it. Maybe Angus has a smart minimal fix for it.

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Moritz Moeller-Herrmann
John Levon wrote: > > Here is my "final" patch. Less code, more features ! Please test. It works fine here with gnu aspell-0.50 and lyx-1.3.1CVS. Adding words to the personal dictionary works. -- Moritz Moeller-Herrmann

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 17. Februar 2003 10:31, Kornel Benko wrote: > Compiling now ... NOT working. There is only an alert-box about failed invocation (comming immediately) aspell -a -d german -C -w"_" -T latin1 This usage _works_ from if invoked manually. Could

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- Interpreting the trace Lyx-pid = 28437 fork() --> child pid 28488 28488 dup2(9, 0)= 0 28488 dup2(12, 1) = 1 28488 dup2(14, 2) = 2 28488 close(9) = 0 28488 close(10)

Re: [PATCH] spellchecker re-working

2003-02-17 Thread John Levon
On Mon, Feb 17, 2003 at 10:15:29AM +, Angus Leeming wrote: > There is a parameter 'emergency_exit' (see ControlDialog). If you set > it to true, then the dialog is not shown. Does it do the job for you? No, emergency_exit_ is checked only *before* view().show(). If it's only used by the

Re: [PATCH] spellchecker re-working

2003-02-17 Thread John Levon
On Mon, Feb 17, 2003 at 01:54:15AM -0400, Garst R. Reese wrote: > > o use "Ignore All" not "Accept" - it's far clearer > Aspell does not really ignore the word, it puts it in a temp dict so it > may become a suggested word later. f.ex. Macphail, then it finds > MacPhail and suggests Macphail.

Re: [PATCH] spellchecker re-working

2003-02-17 Thread John Levon
On Mon, Feb 17, 2003 at 01:06:55PM +0100, Kornel Benko wrote: > 28488 write(2, "s", 1)and so on with the string > 'spell invokation was aspell -a -d german -C -w "_" -T >latin1 ' Hmm, where's this string coming from ? I'm having trouble

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 17. Februar 2003 16:35, John Levon wrote: > On Mon, Feb 17, 2003 at 01:06:55PM +0100, Kornel Benko wrote: > > 28488 write(2, "s", 1) and so on with the string > > 'spell invokation was aspell -a -d

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Angus Leeming
John Levon wrote: > On Mon, Feb 17, 2003 at 10:15:29AM +, Angus Leeming wrote: > >> There is a parameter 'emergency_exit' (see ControlDialog). If you >> set it to true, then the dialog is not shown. Does it do the job >> for you? > > No, emergency_exit_ is checked only *before*

Re: [PATCH] spellchecker re-working

2003-02-17 Thread John Levon
On Mon, Feb 17, 2003 at 05:00:15PM +0100, Kornel Benko wrote: > child is writing to lyxerr[Debug::GUI] > (which now happens to be also the pipe) Well, that was stupid of me ! Thanks, I'll remove this code. Apart from that, everything is OK ? john

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 17. Februar 2003 17:00, Kornel Benko wrote: > child is writing to lyxerr[Debug::GUI] (which now happens to be also the > pipe) Ok, disabling the debug output, spellchecker works so far, but does not allow me to use "_" inside words. Kornel

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 17. Februar 2003 17:12, John Levon wrote: > On Mon, Feb 17, 2003 at 05:00:15PM +0100, Kornel Benko wrote: > > child is writing to lyxerr[Debug::GUI] > > (which now happens to be also the pipe) > > Well, that was stupid of me ! Thanks, I'll remove this

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Edwin Leuven
> Apart from that, everything is OK ? barging into the thread; ingore all with: students' doesn't work for me Ed.

Re: [PATCH] spellchecker re-working

2003-02-17 Thread John Levon
On Mon, Feb 17, 2003 at 05:38:02PM +0100, Edwin Leuven wrote: > ingore all with: students' > > doesn't work for me A bug, but it's not new in my patch. john

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Kornel Benko
-BEGIN PGP SIGNED MESSAGE- On Montag, 17. Februar 2003 17:24, Kornel Benko wrote: > > Apart from that, everything is OK ? > > Let me test a little. Neither "Ignore", nor "Add" are accepting words with "_" (which is _my_ Escape character). - --> Spellchecking stops with an alert-box,

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> JMarc, if this gets a good run for its money, would you consider John> it ? Yes. I do not know yet whether it should go in 1.3.1 or 1.3.2. I am considering now a near release of 1.3.1. There is nothing earth-shattering in it, but at

Re: [PATCH] spellchecker re-working

2003-02-17 Thread John Levon
On Mon, Feb 17, 2003 at 06:32:32PM +0100, Jean-Marc Lasgouttes wrote: > Yes. I do not know yet whether it should go in 1.3.1 or 1.3.2. I am > considering now a near release of 1.3.1. There is nothing > earth-shattering in it, but at least it should work. Either is fine by me. I'm glad we're

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> On Mon, Feb 17, 2003 at 06:32:32PM +0100, Jean-Marc Lasgouttes John> wrote: >> Yes. I do not know yet whether it should go in 1.3.1 or 1.3.2. I am >> considering now a near release of 1.3.1. There is nothing >> earth-shattering in it,

Re: [PATCH] spellchecker re-working

2003-02-17 Thread Moritz Moeller-Herrmann
John Levon wrote: > On Mon, Feb 17, 2003 at 01:54:15AM -0400, Garst R. Reese wrote: > >> > o use "Ignore All" not "Accept" - it's far clearer >> Aspell does not really ignore the word, it puts it in a temp dict so it >> may become a suggested word later. f.ex. Macphail, then it finds >> MacPhail

[PATCH] spellchecker re-working

2003-02-16 Thread John Levon
Here is my final patch. Less code, more features ! Please test. There is one niggle left: we briefly show the dialog when there is no need (clean spell check). It's minorly visually distracting. I think it's worth it. Maybe Angus has a smart minimal fix for it. Kornel, you should be seeing your

[PATCH] spellchecker re-working

2003-02-16 Thread John Levon
Here is my "final" patch. Less code, more features ! Please test. There is one niggle left: we briefly show the dialog when there is no need (clean spell check). It's minorly visually distracting. I think it's worth it. Maybe Angus has a smart minimal fix for it. Kornel, you should be seeing