Re: [PATCH] to avoid crash in misspelled marker painting while deleting table rows fast

2018-04-04 Thread Scott Kostyshak
On Wed, Apr 04, 2018 at 10:38:58AM +, Jean-Marc Lasgouttes wrote: > We did not manage to have a full discussion :) Executive summary is like I like this phrase. Next time, I will ask for an "Executive summary". It is better than the alternative, "summary for dummies" :) > Stephan: I get a

Re: [PATCH] to avoid crash in misspelled marker painting while deleting table rows fast

2018-04-04 Thread Jean-Marc Lasgouttes
Le 04/04/2018 à 03:54, Scott Kostyshak a écrit : On Thu, Dec 28, 2017 at 08:40:31AM +, Scott Kostyshak wrote: On Fri, Oct 27, 2017 at 10:52:02AM +, Jean-Marc Lasgouttes wrote: Le 13/10/2017 à 07:24, Stephan Witt a écrit : A question: is the 'quickly' important to get the crash? From

Re: [PATCH] to avoid crash in misspelled marker painting while deleting table rows fast

2018-04-03 Thread Scott Kostyshak
On Thu, Dec 28, 2017 at 08:40:31AM +, Scott Kostyshak wrote: > On Fri, Oct 27, 2017 at 10:52:02AM +, Jean-Marc Lasgouttes wrote: > > Le 13/10/2017 à 07:24, Stephan Witt a écrit : > > > > A question: is the 'quickly' important to get the crash? From what I > > > > see, Cursor::newWord() is

Re: [PATCH] to avoid crash in misspelled marker painting while deleting table rows fast

2017-12-28 Thread Scott Kostyshak
On Fri, Oct 27, 2017 at 10:52:02AM +, Jean-Marc Lasgouttes wrote: > Le 13/10/2017 à 07:24, Stephan Witt a écrit : > > > A question: is the 'quickly' important to get the crash? From what I see, > > > Cursor::newWord() is not updated to the changes in the document > > > structure. Why does

Re: [PATCH] to avoid crash in misspelled marker painting while deleting table rows fast

2017-10-27 Thread Jean-Marc Lasgouttes
Le 13/10/2017 à 07:24, Stephan Witt a écrit : A question: is the 'quickly' important to get the crash? From what I see, Cursor::newWord() is not updated to the changes in the document structure. Why does this happen? Sorry for the delay. I tried to reproduce and cannot anymore ATM. I had the

Re: [PATCH] to avoid crash in misspelled marker painting while deleting table rows fast

2017-10-26 Thread Scott Kostyshak
On Wed, Oct 25, 2017 at 05:26:25PM +, Scott Kostyshak wrote: > What shall we do with this regarding rc1? If for some reason we do not > put in Stephan's patch, can we at least put in some debug code or an > assert or something to help us make progress on this in the future? Bump. I'm not

Re: [PATCH] to avoid crash in misspelled marker painting while deleting table rows fast

2017-10-25 Thread Scott Kostyshak
On Fri, Oct 13, 2017 at 05:24:50AM +, Stephan Witt wrote: > Am 11.10.2017 um 12:10 schrieb Jean-Marc Lasgouttes : > > > > Le 08/10/2017 à 18:01, Stephan Witt a écrit : > >> Hi, > >> these days I’ve got a crash while deleting multiple rows from a table with > >> bottom

Re: [PATCH] to avoid crash in misspelled marker painting while deleting table rows fast

2017-10-12 Thread Stephan Witt
Am 11.10.2017 um 12:10 schrieb Jean-Marc Lasgouttes : > > Le 08/10/2017 à 18:01, Stephan Witt a écrit : >> Hi, >> these days I’ve got a crash while deleting multiple rows from a table with >> bottom table toolbar quickly. >> This happened with LyX 2.2. - I can reproduce it

Re: [PATCH] to avoid crash in misspelled marker painting while deleting table rows fast

2017-10-11 Thread Jean-Marc Lasgouttes
Le 08/10/2017 à 18:01, Stephan Witt a écrit : Hi, these days I’ve got a crash while deleting multiple rows from a table with bottom table toolbar quickly. This happened with LyX 2.2. - I can reproduce it with master. I’m attaching the crash report and a patch to avoid the crash. I’d like to

[PATCH] to avoid crash in misspelled marker painting while deleting table rows fast

2017-10-08 Thread Stephan Witt
Hi, these days I’ve got a crash while deleting multiple rows from a table with bottom table toolbar quickly. This happened with LyX 2.2. - I can reproduce it with master. I’m attaching the crash report and a patch to avoid the crash. I’d like to put it in and if possible backport it to 2.3.x