Re: [patch] KeyMap bug (again)

2007-06-11 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov Ok, here's an attempt to do something similar to what you Dov suggested: Dov *) I added this new translateAndInsert to BufferView, not to Dov Intl. First of all, Intl seems to be very specific to only Dov

Re: [patch] KeyMap bug (again)

2007-06-11 Thread José Matos
On Monday 11 June 2007 19:13:11 Dov Feldstern wrote: Jose, since this is slightly different than what you last OKed --- is this still OK to commit? Yes. Thanks! Dov -- José Abílio

Re: [patch] KeyMap bug (again)

2007-06-11 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Ok, here's an attempt to do something similar to what you Dov> suggested: Dov> *) I added this new translateAndInsert to BufferView, not to Dov> Intl. First of all, Intl seems to be very specific to only Dov>

Re: [patch] KeyMap bug (again)

2007-06-11 Thread José Matos
On Monday 11 June 2007 19:13:11 Dov Feldstern wrote: > Jose, since this is slightly different than what you last OKed --- is > this still OK to commit? Yes. > Thanks! > Dov -- José Abílio

Re: [patch] KeyMap bug (again)

2007-06-08 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov But what do you think about this suggestion: instead of adding Dov switchKeyMap in the new place, and where I added it originally, Dov just add it inside translateAndInsert() itself? (I haven't tried Dov this out

Re: [patch] KeyMap bug (again)

2007-06-08 Thread Jean-Marc Lasgouttes
Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov Ok, here's an attempt to do something similar to what you Dov suggested: Dov *) I added this new translateAndInsert to BufferView, not to Dov Intl. First of all, Intl seems to be very specific to only Dov manipulating the KeyMap; also, adding

Re: [patch] KeyMap bug (again)

2007-06-08 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> But what do you think about this suggestion: instead of adding Dov> switchKeyMap in the new place, and where I added it originally, Dov> just add it inside translateAndInsert() itself? (I haven't tried Dov>

Re: [patch] KeyMap bug (again)

2007-06-08 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Ok, here's an attempt to do something similar to what you Dov> suggested: Dov> *) I added this new translateAndInsert to BufferView, not to Dov> Intl. First of all, Intl seems to be very specific to only Dov> manipulating the KeyMap;

Re: [patch] KeyMap bug (again)

2007-06-07 Thread Jean-Marc Lasgouttes
Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov I imagine it should, too. Is the keymap really actually used for Dov the accents? How does one insert an accent? Perhaps the accent Dov lfuns should actually call (dispatch?) the SELF_INSERT lfun, Dov instead of inserting the accent character

Re: [patch] KeyMap bug (again)

2007-06-07 Thread José Matos
On Thursday 07 June 2007 08:47:24 Jean-Marc Lasgouttes wrote: The patch is OK to me (with the extra switchKeymap). Dov if you come with a patch with this suggestion implemented then you have my OK. :-) JMarc -- José Abílio

Re: [patch] KeyMap bug (again)

2007-06-07 Thread Dov Feldstern
José Matos wrote: On Thursday 07 June 2007 08:47:24 Jean-Marc Lasgouttes wrote: The patch is OK to me (with the extra switchKeymap). Dov if you come with a patch with this suggestion implemented then you have my OK. :-) JMarc Thanks, I will send a corrected patch soon.

Re: [patch] KeyMap bug (again)

2007-06-07 Thread Dov Feldstern
Dov Feldstern wrote: José Matos wrote: On Thursday 07 June 2007 08:47:24 Jean-Marc Lasgouttes wrote: The patch is OK to me (with the extra switchKeymap). Dov if you come with a patch with this suggestion implemented then you have my OK. :-) JMarc Thanks, I will send a corrected

Re: [patch] KeyMap bug (again)

2007-06-07 Thread Jean-Marc Lasgouttes
Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov But what do you think about this suggestion: instead of adding Dov switchKeyMap in the new place, and where I added it originally, Dov just add it inside translateAndInsert() itself? (I haven't tried Dov this out yet --- but if it works, does

Re: [patch] KeyMap bug (again)

2007-06-07 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> I imagine it should, too. Is the keymap really actually used for Dov> the accents? How does one insert an accent? Perhaps the accent Dov> lfuns should actually call (dispatch?) the SELF_INSERT lfun, Dov> instead of inserting the accent

Re: [patch] KeyMap bug (again)

2007-06-07 Thread José Matos
On Thursday 07 June 2007 08:47:24 Jean-Marc Lasgouttes wrote: > The patch is OK to me (with the extra switchKeymap). Dov if you come with a patch with this suggestion implemented then you have my OK. :-) > JMarc -- José Abílio

Re: [patch] KeyMap bug (again)

2007-06-07 Thread Dov Feldstern
José Matos wrote: On Thursday 07 June 2007 08:47:24 Jean-Marc Lasgouttes wrote: The patch is OK to me (with the extra switchKeymap). Dov if you come with a patch with this suggestion implemented then you have my OK. :-) JMarc Thanks, I will send a corrected patch soon.

Re: [patch] KeyMap bug (again)

2007-06-07 Thread Dov Feldstern
Dov Feldstern wrote: José Matos wrote: On Thursday 07 June 2007 08:47:24 Jean-Marc Lasgouttes wrote: The patch is OK to me (with the extra switchKeymap). Dov if you come with a patch with this suggestion implemented then you have my OK. :-) JMarc Thanks, I will send a corrected

Re: [patch] KeyMap bug (again)

2007-06-07 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> But what do you think about this suggestion: instead of adding Dov> switchKeyMap in the new place, and where I added it originally, Dov> just add it inside translateAndInsert() itself? (I haven't tried Dov> this out yet --- but if it

Re: [patch] KeyMap bug (again)

2007-06-06 Thread Jean-Marc Lasgouttes
Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov Hi! I haven't gotten any responses to the patch I sent in Dov yesterday, so I took the opportunity to open a bug for this in Dov bugzilla (http://bugzilla.lyx.org/show_bug.cgi?id=3811). Dov There are explanations there regarding the patch

Re: [patch] KeyMap bug (again)

2007-06-06 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: Dov == Dov Feldstern [EMAIL PROTECTED] writes: Dov Hi! I haven't gotten any responses to the patch I sent in Dov yesterday, so I took the opportunity to open a bug for this in Dov bugzilla (http://bugzilla.lyx.org/show_bug.cgi?id=3811). Dov There are explanations

Re: [patch] KeyMap bug (again)

2007-06-06 Thread Jean-Marc Lasgouttes
> "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Hi! I haven't gotten any responses to the patch I sent in Dov> yesterday, so I took the opportunity to open a bug for this in Dov> bugzilla (http://bugzilla.lyx.org/show_bug.cgi?id=3811). Dov> There are explanations there regarding

Re: [patch] KeyMap bug (again)

2007-06-06 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: "Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes: Dov> Hi! I haven't gotten any responses to the patch I sent in Dov> yesterday, so I took the opportunity to open a bug for this in Dov> bugzilla (http://bugzilla.lyx.org/show_bug.cgi?id=3811). Dov> There are

[patch] KeyMap bug (again)

2007-06-04 Thread Dov Feldstern
Hi! I haven't gotten any responses to the patch I sent in yesterday, so I took the opportunity to open a bug for this in bugzilla (http://bugzilla.lyx.org/show_bug.cgi?id=3811). There are explanations there regarding the patch (which is also attached here). Please make sure it makes sense,

Re: [patch] KeyMap bug (again)

2007-06-04 Thread Richard Heck
Dov Feldstern wrote: Hi! I haven't gotten any responses to the patch I sent in yesterday, so I took the opportunity to open a bug for this in bugzilla (http://bugzilla.lyx.org/show_bug.cgi?id=3811). Your explanation seems very sensible to me, but I don't know this code at all well. There are

[patch] KeyMap bug (again)

2007-06-04 Thread Dov Feldstern
Hi! I haven't gotten any responses to the patch I sent in yesterday, so I took the opportunity to open a bug for this in bugzilla (http://bugzilla.lyx.org/show_bug.cgi?id=3811). There are explanations there regarding the patch (which is also attached here). Please make sure it makes sense,

Re: [patch] KeyMap bug (again)

2007-06-04 Thread Richard Heck
Dov Feldstern wrote: Hi! I haven't gotten any responses to the patch I sent in yesterday, so I took the opportunity to open a bug for this in bugzilla (http://bugzilla.lyx.org/show_bug.cgi?id=3811). Your explanation seems very sensible to me, but I don't know this code at all well. There are