Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

If we want this, another OK is needed. Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan == Stefan Schimanski [EMAIL PROTECTED] writes: Stefan If we want this, another OK is needed. Stefan I missed the latest patch. COuld you report it please? JMarc

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Am 14.06.2007 um 10:39 schrieb Jean-Marc Lasgouttes: Stefan == Stefan Schimanski [EMAIL PROTECTED] writes: Stefan If we want this, another OK is needed. Stefan I missed the latest patch. COuld you report it please? Sure, inlined and attached: Index: lyx-devel/src/Cursor.cpp

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: Am 14.06.2007 um 10:39 schrieb Jean-Marc Lasgouttes: Stefan == Stefan Schimanski [EMAIL PROTECTED] writes: Stefan If we want this, another OK is needed. Stefan I missed the latest patch. COuld you report it please? Sure, inlined and attached: Works for me (when

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Works for me (when leaving the macro using down key, macro collapses). I don't have the first part of the patch in, though, so down doesn't move to the second parameter, but directly out --- but that's to be expected, right? Thanks for testing! You are right. I have split the two (in fact

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: Works for me (when leaving the macro using down key, macro collapses). I don't have the first part of the patch in, though, so down doesn't move to the second parameter, but directly out --- but that's to be expected, right? Thanks for testing! You are right. I have

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Am 14.06.2007 um 22:45 schrieb Dov Feldstern: Stefan Schimanski wrote: Works for me (when leaving the macro using down key, macro collapses). I don't have the first part of the patch in, though, so down doesn't move to the second parameter, but directly out --- but that's to be

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

If we want this, another OK is needed. Stefan PGP.sig Description: Signierter Teil der Nachricht

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

> "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Stefan> If we want this, another OK is needed. Stefan I missed the latest patch. COuld you report it please? JMarc

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Am 14.06.2007 um 10:39 schrieb Jean-Marc Lasgouttes: "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Stefan> If we want this, another OK is needed. Stefan I missed the latest patch. COuld you report it please? Sure, inlined and attached: Index: lyx-devel/src/Cursor.cpp

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: Am 14.06.2007 um 10:39 schrieb Jean-Marc Lasgouttes: "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Stefan> If we want this, another OK is needed. Stefan I missed the latest patch. COuld you report it please? Sure, inlined and attached: Works for me

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Works for me (when leaving the macro using down key, macro collapses). I don't have the first part of the patch in, though, so down doesn't move to the second parameter, but directly out --- but that's to be expected, right? Thanks for testing! You are right. I have split the two (in fact

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: Works for me (when leaving the macro using down key, macro collapses). I don't have the first part of the patch in, though, so down doesn't move to the second parameter, but directly out --- but that's to be expected, right? Thanks for testing! You are right. I have

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Am 14.06.2007 um 22:45 schrieb Dov Feldstern: Stefan Schimanski wrote: Works for me (when leaving the macro using down key, macro collapses). I don't have the first part of the patch in, though, so down doesn't move to the second parameter, but directly out --- but that's to be

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: Right, too late for 1.5. Still the inverse logic is better IMHO. So it marks the lfun as undispatched. But then the Update::Force flag is overwritten later by the cursor down handler of the text. Maybe you could change this overwritting? As far as I see there is no

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

I mean: if (cur.result().update() == Update::Force) this means that the flag has been explicitely set previously as opposed to have the default value (Update::FitCursor | Update::Force). Maybe this information could be used? Here is a solution in the direction I described: the old cursor is

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: I mean: if (cur.result().update() == Update::Force) this means that the flag has been explicitely set previously as opposed to have the default value (Update::FitCursor | Update::Force). Maybe this information could be used? Here is a solution in the direction I

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: Right, too late for 1.5. Still the inverse logic is better IMHO. So it marks the lfun as undispatched. But then the Update::Force flag is overwritten later by the cursor down handler of the text. Maybe you could change this overwritting? As far as I see there is no

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

I mean: if (cur.result().update() == Update::Force) this means that the flag has been explicitely set previously as opposed to have the default value (Update::FitCursor | Update::Force). Maybe this information could be used? Here is a solution in the direction I described: the old cursor is

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: I mean: if (cur.result().update() == Update::Force) this means that the flag has been explicitely set previously as opposed to have the default value (Update::FitCursor | Update::Force). Maybe this information could be used? Here is a solution in the direction I

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: No, it's not intentional. It's a bug that notifyCursorLeaves is not called. Had noticed that before some time ago. Will look into it. This whole updateflag business makes me crazy. The MathMacro get's the notifyCursorLeaves call. It then sets the Update::Force flag to

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Am 12.06.2007 um 10:22 schrieb Abdelrazak Younes: Stefan Schimanski wrote: No, it's not intentional. It's a bug that notifyCursorLeaves is not called. Had noticed that before some time ago. Will look into it. This whole updateflag business makes me crazy. The MathMacro get's the

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: Am 12.06.2007 um 10:22 schrieb Abdelrazak Younes: Stefan Schimanski wrote: No, it's not intentional. It's a bug that notifyCursorLeaves is not called. Had noticed that before some time ago. Will look into it. This whole updateflag business makes me crazy. The

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

As far as I see there is no way to trigger a complete redraw reliable from anywhere else than the inset which dispatches the lfun. If the Cursor is passed there is: by checking and accumulating the update flag. What do you mean? I don't see how to do anything like that. I mean: if

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

The real problem is the notifyCursorLeaves is called in a chaotic way. In certain functions like Cursor::popLeft, or the handler for mouse click in the BufferView, this function is called. But of course there can be plenty of way to leave an inset. A clean way would be to remove these

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Ah yes I remember... I wanted to inverse the logic but never found the time to do so. So checking for Update::Force is not possible like that. And setting it to NoUpdate first and then check for Force will break a lot I guess. Right, too late for 1.5. Still the inverse logic is better

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Right, too late for 1.5. Still the inverse logic is better IMHO. So it marks the lfun as undispatched. But then the Update::Force flag is overwritten later by the cursor down handler of the text. Maybe you could change this overwritting? As far as I see there is no way to trigger a

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

And with this change you can leave mathed with cursor up/down and get the math redrawn for the decorations: Index: src/Text3.cpp === --- src/Text3.cpp (Revision 18737) +++ src/Text3.cpp (Arbeitskopie) @@ -512,24

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: No, it's not intentional. It's a bug that notifyCursorLeaves is not called. Had noticed that before some time ago. Will look into it. This whole updateflag business makes me crazy. The MathMacro get's the notifyCursorLeaves call. It then sets the Update::Force flag to

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Am 12.06.2007 um 10:22 schrieb Abdelrazak Younes: Stefan Schimanski wrote: No, it's not intentional. It's a bug that notifyCursorLeaves is not called. Had noticed that before some time ago. Will look into it. This whole updateflag business makes me crazy. The MathMacro get's the

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: Am 12.06.2007 um 10:22 schrieb Abdelrazak Younes: Stefan Schimanski wrote: No, it's not intentional. It's a bug that notifyCursorLeaves is not called. Had noticed that before some time ago. Will look into it. This whole updateflag business makes me crazy. The

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

As far as I see there is no way to trigger a complete redraw reliable from anywhere else than the inset which dispatches the lfun. If the Cursor is passed there is: by checking and accumulating the update flag. What do you mean? I don't see how to do anything like that. I mean: if

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

The real problem is the notifyCursorLeaves is called in a chaotic way. In certain functions like Cursor::popLeft, or the handler for mouse click in the BufferView, this function is called. But of course there can be plenty of way to leave an inset. A clean way would be to remove these

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Ah yes I remember... I wanted to inverse the logic but never found the time to do so. So checking for Update::Force is not possible like that. And setting it to NoUpdate first and then check for Force will break a lot I guess. Right, too late for 1.5. Still the inverse logic is better

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Right, too late for 1.5. Still the inverse logic is better IMHO. So it marks the lfun as undispatched. But then the Update::Force flag is overwritten later by the cursor down handler of the text. Maybe you could change this overwritting? As far as I see there is no way to trigger a

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

And with this change you can leave mathed with cursor up/down and get the math redrawn for the decorations: Index: src/Text3.cpp === --- src/Text3.cpp (Revision 18737) +++ src/Text3.cpp (Arbeitskopie) @@ -512,24

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: Bug: http://bugzilla.lyx.org/show_bug.cgi?id=3830 The patch should be obvious. I won't dispute the obviousness of it with our macro expert ;-) Abdel.

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Need another OK. Anybody? José? Stefan Am 09.06.2007 um 18:29 schrieb Stefan Schimanski: Bug: http://bugzilla.lyx.org/show_bug.cgi?id=3830 The patch should be obvious. Stefan Index: lyx-devel/src/mathed/MathMacro.cpp === ---

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: Need another OK. Anybody? José? Hi! 1. I have trouble applying the patches that you inline in the emails --- it's something with the whitespace, I think, but I always get malformed patch messages, and end up having to type them in by hand... 2. I got this error:

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Thanks for testing! 1. I have trouble applying the patches that you inline in the emails --- it's something with the whitespace, I think, but I always get malformed patch messages, and end up having to type them in by hand... Yes, in fact same for me with other people's inlined patches.

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

No, it's not intentional. It's a bug that notifyCursorLeaves is not called. Had noticed that before some time ago. Will look into it. This whole updateflag business makes me crazy. The MathMacro get's the notifyCursorLeaves call. It then sets the Update::Force flag to trigger a redraw. But

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

On Mon, Jun 11, 2007 at 08:32:44PM +0200, Stefan Schimanski wrote: Index: lyx-devel/src/mathed/MathMacro.cpp === --- lyx-devel.orig/src/mathed/MathMacro.cpp 2007-06-02 11:24:05.0 +0200 +++

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

And this MathMacro:: qualification is useless at best, but I have a strong suspicion that it is not allowed at all. Was a copy/paste mistake and an Xcode not saving the file before my svn diff... PS: I seem to remember to have something like that as 'generic' implementation in

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: Bug: http://bugzilla.lyx.org/show_bug.cgi?id=3830 The patch should be obvious. I won't dispute the obviousness of it with our macro expert ;-) Abdel.

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Need another OK. Anybody? José? Stefan Am 09.06.2007 um 18:29 schrieb Stefan Schimanski: Bug: http://bugzilla.lyx.org/show_bug.cgi?id=3830 The patch should be obvious. Stefan Index: lyx-devel/src/mathed/MathMacro.cpp === ---

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Stefan Schimanski wrote: Need another OK. Anybody? José? Hi! 1. I have trouble applying the patches that you inline in the emails --- it's something with the whitespace, I think, but I always get "malformed patch" messages, and end up having to type them in by hand... 2. I got this

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

Thanks for testing! 1. I have trouble applying the patches that you inline in the emails --- it's something with the whitespace, I think, but I always get "malformed patch" messages, and end up having to type them in by hand... Yes, in fact same for me with other people's inlined

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

No, it's not intentional. It's a bug that notifyCursorLeaves is not called. Had noticed that before some time ago. Will look into it. This whole updateflag business makes me crazy. The MathMacro get's the notifyCursorLeaves call. It then sets the Update::Force flag to trigger a redraw. But

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

On Mon, Jun 11, 2007 at 08:32:44PM +0200, Stefan Schimanski wrote: > >Index: lyx-devel/src/mathed/MathMacro.cpp > >=== > >--- lyx-devel.orig/src/mathed/MathMacro.cpp 2007-06-02 > >11:24:05.0 +0200 > >+++

Re: [patch] Up/down cursor in math-macro jumps out of the macro, #3830

And this MathMacro:: qualification is useless at best, but I have a strong suspicion that it is not allowed at all. Was a copy/paste mistake and an Xcode not saving the file before my svn diff... PS: I seem to remember to have something like that as 'generic' implementation in

[patch] Up/down cursor in math-macro jumps out of the macro, #3830

Bug: http://bugzilla.lyx.org/show_bug.cgi?id=3830 The patch should be obvious. Stefan Index: lyx-devel/src/mathed/MathMacro.cpp === --- lyx-devel.orig/src/mathed/MathMacro.cpp 2007-06-02 11:24:05.0 +0200 +++

[patch] Up/down cursor in math-macro jumps out of the macro, #3830

Bug: http://bugzilla.lyx.org/show_bug.cgi?id=3830 The patch should be obvious. Stefan Index: lyx-devel/src/mathed/MathMacro.cpp === --- lyx-devel.orig/src/mathed/MathMacro.cpp 2007-06-02 11:24:05.0 +0200 +++