Re: [patch] fix drawing issue

2007-07-18 Thread José Matos
On Wednesday 18 July 2007 06:43:17 Jürgen Spitzmüller wrote: José? OK. Jürgen -- José Abílio

Re: [patch] fix drawing issue

2007-07-18 Thread José Matos
On Wednesday 18 July 2007 06:43:17 Jürgen Spitzmüller wrote: > José? OK. > Jürgen -- José Abílio

[patch] fix drawing issue

2007-07-17 Thread Jürgen Spitzmüller
This oneliner fixes some ugly drawing artefacts with insets in the appendix (probably introduced with revision 19039). Attached also a testcase where you can see the artefacts. OK to apply? Jürgen Index: src/rowpainter.cpp === ---

Re: [patch] fix drawing issue

2007-07-17 Thread José Matos
On Tuesday 17 July 2007 14:25:23 Jürgen Spitzmüller wrote: This oneliner fixes some ugly drawing artefacts with insets in the appendix (probably introduced with revision 19039). Attached also a testcase where you can see the artefacts. OK to apply? OK. Jürgen -- José Abílio

Re: [patch] fix drawing issue

2007-07-17 Thread Bo Peng
On 7/17/07, Jürgen Spitzmüller [EMAIL PROTECTED] wrote: This oneliner fixes some ugly drawing artefacts with insets in the appendix (probably introduced with revision 19039). There is also a redraw problem when you delete in ERT or listings inset, do you also have an oneliner? :-) Bo

Re: [patch] fix drawing issue

2007-07-17 Thread Jürgen Spitzmüller
Bo Peng wrote: There is also a redraw problem when you delete in ERT or listings inset, do you also have an oneliner? :-) No, unfortunately not. Jürgen

Re: [patch] fix drawing issue

2007-07-17 Thread Jürgen Spitzmüller
Bo Peng wrote: There is also a redraw problem when you delete in ERT or listings inset, do you also have an oneliner? :-) Try this (OK, a bit more than one line). Jürgen Index: src/rowpainter.cpp === --- src/rowpainter.cpp

Re: [patch] fix drawing issue

2007-07-17 Thread Bo Peng
On 7/17/07, Jürgen Spitzmüller [EMAIL PROTECTED] wrote: Bo Peng wrote: There is also a redraw problem when you delete in ERT or listings inset, do you also have an oneliner? :-) Try this (OK, a bit more than one line). The problem seems to be solved, but I can not figure out when an ERT

Re: [patch] fix drawing issue

2007-07-17 Thread Jürgen Spitzmüller
Bo Peng wrote: The problem seems to be solved, but I can not figure out when an ERT inset will occupy the rest of the line during edition. E.g. This is the unsavoury wide() thing (TM). The rule is: an inset spans the whole line, if - it is the only thing in the row and - the cursor is inside.

Re: [patch] fix drawing issue

2007-07-17 Thread Bo Peng
So if you think that bug 3582 is solved, I'd propose to put that into 1.5.0. It should, but you need another OK. Bo

Re: [patch] fix drawing issue

2007-07-17 Thread Abdelrazak Younes
Bo Peng wrote: So if you think that bug 3582 is solved, I'd propose to put that into 1.5.0. It should, but you need another OK. OK from me. Abdel.

Re: [patch] fix drawing issue

2007-07-17 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: It should, but you need another OK. OK from me. José? Jürgen

[patch] fix drawing issue

2007-07-17 Thread Jürgen Spitzmüller
This oneliner fixes some ugly drawing artefacts with insets in the appendix (probably introduced with revision 19039). Attached also a testcase where you can see the artefacts. OK to apply? Jürgen Index: src/rowpainter.cpp === ---

Re: [patch] fix drawing issue

2007-07-17 Thread José Matos
On Tuesday 17 July 2007 14:25:23 Jürgen Spitzmüller wrote: > This oneliner fixes some ugly drawing artefacts with insets in the appendix > (probably introduced with revision 19039). > > Attached also a testcase where you can see the artefacts. > > OK to apply? OK. > Jürgen -- José Abílio

Re: [patch] fix drawing issue

2007-07-17 Thread Bo Peng
On 7/17/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote: This oneliner fixes some ugly drawing artefacts with insets in the appendix (probably introduced with revision 19039). There is also a redraw problem when you delete in ERT or listings inset, do you also have an oneliner? :-) Bo

Re: [patch] fix drawing issue

2007-07-17 Thread Jürgen Spitzmüller
Bo Peng wrote: > There is also a redraw problem when you delete in ERT or listings > inset, do you also have an oneliner? :-) No, unfortunately not. Jürgen

Re: [patch] fix drawing issue

2007-07-17 Thread Jürgen Spitzmüller
Bo Peng wrote: > There is also a redraw problem when you delete in ERT or listings > inset, do you also have an oneliner? :-) Try this (OK, a bit more than one line). Jürgen Index: src/rowpainter.cpp === --- src/rowpainter.cpp

Re: [patch] fix drawing issue

2007-07-17 Thread Bo Peng
On 7/17/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote: Bo Peng wrote: > There is also a redraw problem when you delete in ERT or listings > inset, do you also have an oneliner? :-) Try this (OK, a bit more than one line). The problem seems to be solved, but I can not figure out when an ERT

Re: [patch] fix drawing issue

2007-07-17 Thread Jürgen Spitzmüller
Bo Peng wrote: > The problem seems to be solved, but I can not figure out when an ERT > inset will occupy the rest of the line during edition. E.g. This is the unsavoury "wide() thing" (TM). The rule is: an inset spans the whole line, if - it is the only thing in the row and - the cursor is

Re: [patch] fix drawing issue

2007-07-17 Thread Bo Peng
So if you think that bug 3582 is solved, I'd propose to put that into 1.5.0. It should, but you need another OK. Bo

Re: [patch] fix drawing issue

2007-07-17 Thread Abdelrazak Younes
Bo Peng wrote: So if you think that bug 3582 is solved, I'd propose to put that into 1.5.0. It should, but you need another OK. OK from me. Abdel.

Re: [patch] fix drawing issue

2007-07-17 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > > It should, but you need another OK. > > OK from me. José? Jürgen