Re: About the rowpainter2 branch (testers, have a look!)

On 23/07/2015 16:45, Jean-Marc Lasgouttes wrote: Le 23/07/2015 16:29, Richard Heck a écrit : I wonder how bad this will be. In practice, people do not actually use that many different words when writing. Probably no more than a few hundred, and a couple thousand, at most. It is not a problem

Re: About the rowpainter2 branch (testers, have a look!)

On 23/07/2015 16:45, Jean-Marc Lasgouttes wrote: Le 23/07/2015 16:29, Richard Heck a écrit : I wonder how bad this will be. In practice, people do not actually use that many different words when writing. Probably no more than a few hundred, and a couple thousand, at most. It is not a problem

Re: About the rowpainter2 branch (testers, have a look!)

Den 23. juli 2015 10:16, skrev Jean-Marc Lasgouttes: Except for #9691. The big remaining problem though is that I rely on a mapdocstring,int for caching word widths and this will probably fill up with long editing sessions. In the original rowpainter2 code, there were only words in the

Re: About the rowpainter2 branch (testers, have a look!)

Le 23/07/2015 16:19, Helge Hafting a écrit : There are many strings - but instead the number of rows in a document is limited. There is one entry per screen line, right? (Assuming all are indeed different.) Even a 1000-page book will have a very limited number of screen lines - compared to the

Re: About the rowpainter2 branch (testers, have a look!)

Le 23/07/2015 16:29, Richard Heck a écrit : I wonder how bad this will be. In practice, people do not actually use that many different words when writing. Probably no more than a few hundred, and a couple thousand, at most. It is not a problem of words, it is a problem of lines of text. For

Re: About the rowpainter2 branch (testers, have a look!)

On 07/23/2015 04:16 AM, Jean-Marc Lasgouttes wrote: Le 23/07/2015 08:09, Jürgen Spitzmüller a écrit : Am Donnerstag 23 Juli 2015, 00:43:35 schrieb Jean-Marc Lasgouttes: Le 22/07/2015 17:42, Jürgen Spitzmüller a écrit : Yes, this is with recent master. I can easily reproduce it with sec 2.5.1

Re: About the rowpainter2 branch (testers, have a look!)

Am Donnerstag 23 Juli 2015, 00:43:35 schrieb Jean-Marc Lasgouttes: Le 22/07/2015 17:42, Jürgen Spitzmüller a écrit : Yes, this is with recent master. I can easily reproduce it with sec 2.5.1 of the User Guide, for instance (see attached screenshot). OK, try again now. Let's see how it

Re: About the rowpainter2 branch (testers, have a look!)

Le 23/07/2015 08:09, Jürgen Spitzmüller a écrit : Am Donnerstag 23 Juli 2015, 00:43:35 schrieb Jean-Marc Lasgouttes: Le 22/07/2015 17:42, Jürgen Spitzmüller a écrit : Yes, this is with recent master. I can easily reproduce it with sec 2.5.1 of the User Guide, for instance (see attached

Re: About the rowpainter2 branch (testers, have a look!)

Am Donnerstag 23 Juli 2015, 00:43:35 schrieb Jean-Marc Lasgouttes: > Le 22/07/2015 17:42, Jürgen Spitzmüller a écrit : > > Yes, this is with recent master. I can easily reproduce it with sec 2.5.1 > > of the User Guide, for instance (see attached screenshot). > > OK, try again now. Let's see how

Re: About the rowpainter2 branch (testers, have a look!)

Le 23/07/2015 08:09, Jürgen Spitzmüller a écrit : Am Donnerstag 23 Juli 2015, 00:43:35 schrieb Jean-Marc Lasgouttes: Le 22/07/2015 17:42, Jürgen Spitzmüller a écrit : Yes, this is with recent master. I can easily reproduce it with sec 2.5.1 of the User Guide, for instance (see attached

Re: About the rowpainter2 branch (testers, have a look!)

Den 23. juli 2015 10:16, skrev Jean-Marc Lasgouttes: Except for #9691. The big remaining problem though is that I rely on a map for caching word widths and this will probably fill up with long editing sessions. In the original rowpainter2 code, there were only words in the

Re: About the rowpainter2 branch (testers, have a look!)

On 07/23/2015 04:16 AM, Jean-Marc Lasgouttes wrote: Le 23/07/2015 08:09, Jürgen Spitzmüller a écrit : Am Donnerstag 23 Juli 2015, 00:43:35 schrieb Jean-Marc Lasgouttes: Le 22/07/2015 17:42, Jürgen Spitzmüller a écrit : Yes, this is with recent master. I can easily reproduce it with sec 2.5.1

Re: About the rowpainter2 branch (testers, have a look!)

Le 23/07/2015 16:19, Helge Hafting a écrit : There are many strings - but instead the number of rows in a document is limited. There is one entry per screen line, right? (Assuming all are indeed different.) Even a 1000-page book will have a very limited number of screen lines - compared to the

Re: About the rowpainter2 branch (testers, have a look!)

Le 23/07/2015 16:29, Richard Heck a écrit : I wonder how bad this will be. In practice, people do not actually use that many different words when writing. Probably no more than a few hundred, and a couple thousand, at most. It is not a problem of words, it is a problem of lines of text. For

Re: About the rowpainter2 branch (testers, have a look!)

Le 22/07/2015 13:34, Jürgen Spitzmüller a écrit : Am Mittwoch 22 Juli 2015, 11:55:32 schrieb Jean-Marc Lasgouttes: I fixed this problem. Now I am interested in any row-breaking behavior that does not sound good. It breaks between xref inset and closing bracket, e.g. in (for details, cf. [XRef

Re: About the rowpainter2 branch (testers, have a look!)

Le 22/07/2015 05:56, Scott Kostyshak a écrit : On Tue, Jul 21, 2015 at 6:04 PM, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: I landed in master now. I could be imagining things, but scrolling feels smoother to me. Yes it should. The number of QPainter::drawText calls is reduced a lot

Re: About the rowpainter2 branch (testers, have a look!)

Am Mittwoch 22 Juli 2015, 11:55:32 schrieb Jean-Marc Lasgouttes: I fixed this problem. Now I am interested in any row-breaking behavior that does not sound good. It breaks between xref inset and closing bracket, e.g. in (for details, cf. [XRef Inset]). Jürgen

Re: About the rowpainter2 branch (testers, have a look!)

Le 22/07/2015 09:40, Jean-Marc Lasgouttes a écrit : Are you interested in *any* difference in behavior I notice when testing? For example, if a linebreak is at a different (but still sensible) place than it was before? No, because I am not sure that my row breaking after str-metrics was

Re: About the rowpainter2 branch (testers, have a look!)

Le 22/07/2015 17:42, Jürgen Spitzmüller a écrit : Yes, this is with recent master. I can easily reproduce it with sec 2.5.1 of the User Guide, for instance (see attached screenshot). OK, try again now. Let's see how it fares. JMarc

Re: About the rowpainter2 branch (testers, have a look!)

Le 22/07/2015 05:56, Scott Kostyshak a écrit : On Tue, Jul 21, 2015 at 6:04 PM, Jean-Marc Lasgouttes wrote: I landed in master now. I could be imagining things, but scrolling feels smoother to me. Yes it should. The number of QPainter::drawText calls is reduced a lot

Re: About the rowpainter2 branch (testers, have a look!)

Le 22/07/2015 09:40, Jean-Marc Lasgouttes a écrit : Are you interested in *any* difference in behavior I notice when testing? For example, if a linebreak is at a different (but still sensible) place than it was before? No, because I am not sure that my row breaking after str-metrics was

Re: About the rowpainter2 branch (testers, have a look!)

Am Mittwoch 22 Juli 2015, 11:55:32 schrieb Jean-Marc Lasgouttes: > I fixed this problem. Now I am interested in any row-breaking behavior > that does not sound good. It breaks between xref inset and closing bracket, e.g. in "(for details, cf. [XRef Inset])." Jürgen

Re: About the rowpainter2 branch (testers, have a look!)

Le 22/07/2015 13:34, Jürgen Spitzmüller a écrit : Am Mittwoch 22 Juli 2015, 11:55:32 schrieb Jean-Marc Lasgouttes: I fixed this problem. Now I am interested in any row-breaking behavior that does not sound good. It breaks between xref inset and closing bracket, e.g. in "(for details, cf.

Re: About the rowpainter2 branch (testers, have a look!)

Le 22/07/2015 17:42, Jürgen Spitzmüller a écrit : Yes, this is with recent master. I can easily reproduce it with sec 2.5.1 of the User Guide, for instance (see attached screenshot). OK, try again now. Let's see how it fares. JMarc

Re: About the rowpainter2 branch (testers, have a look!)

On 07/21/2015 09:36 AM, Scott Kostyshak wrote: On Tue, Jul 21, 2015 at 8:10 AM, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: Basically, I'd appreciate if some people could test it so that we can see what's right and what's wrong. Since leave on thursday for vacation, the choice is between

Re: About the rowpainter2 branch (testers, have a look!)

Am 21.07.2015 um 18:04 schrieb Richard Heck rgh...@lyx.org: On 07/21/2015 09:36 AM, Scott Kostyshak wrote: On Tue, Jul 21, 2015 at 8:10 AM, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: Basically, I'd appreciate if some people could test it so that we can see what's right and what's

Re: About the rowpainter2 branch (testers, have a look!)

On Tue, Jul 21, 2015 at 6:04 PM, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: I landed in master now. I could be imagining things, but scrolling feels smoother to me. Are you interested in *any* difference in behavior I notice when testing? For example, if a linebreak is at a different (but

Re: About the rowpainter2 branch (testers, have a look!)

Richard Heck wrote: On 07/21/2015 09:36 AM, Scott Kostyshak wrote: On Tue, Jul 21, 2015 at 8:10 AM, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: Basically, I'd appreciate if some people could test it so that we can see what's right and what's wrong. Since leave on thursday for vacation,

Re: About the rowpainter2 branch (testers, have a look!)

Le 21/07/15 15:36, Scott Kostyshak a écrit : I propose that you land it in master. If something goes very wrong, we can always revert it without you here. This is why I really appreciate your having done the work on a branch (as opposed to master directly), so it is easy to merge/unmerge. I

About the rowpainter2 branch (testers, have a look!)

Hello, I have now done most of what I wanted on the rowpainter2 branch. When I decided a few month ago that it would be a good JMarc Week of Code project I thought that 2.2 would be near enough then and that this work would be 2.3 material. Now I guess it makes more sense to land it for 2.2.

Re: About the rowpainter2 branch (testers, have a look!)

On Tue, Jul 21, 2015 at 8:10 AM, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: Basically, I'd appreciate if some people could test it so that we can see what's right and what's wrong. Since leave on thursday for vacation, the choice is between landing it now or landing it in late August when

About the rowpainter2 branch (testers, have a look!)

Hello, I have now done most of what I wanted on the rowpainter2 branch. When I decided a few month ago that it would be a good JMarc Week of Code project I thought that 2.2 would be near enough then and that this work would be 2.3 material. Now I guess it makes more sense to land it for 2.2.

Re: About the rowpainter2 branch (testers, have a look!)

On Tue, Jul 21, 2015 at 8:10 AM, Jean-Marc Lasgouttes wrote: > Basically, I'd appreciate if some people could test it so that we can see > what's right and what's wrong. Since leave on thursday for vacation, the > choice is between landing it now or landing it in late August

Re: About the rowpainter2 branch (testers, have a look!)

On 07/21/2015 09:36 AM, Scott Kostyshak wrote: On Tue, Jul 21, 2015 at 8:10 AM, Jean-Marc Lasgouttes wrote: Basically, I'd appreciate if some people could test it so that we can see what's right and what's wrong. Since leave on thursday for vacation, the choice is between

Re: About the rowpainter2 branch (testers, have a look!)

Am 21.07.2015 um 18:04 schrieb Richard Heck : > On 07/21/2015 09:36 AM, Scott Kostyshak wrote: >> On Tue, Jul 21, 2015 at 8:10 AM, Jean-Marc Lasgouttes >> wrote: >> >>> Basically, I'd appreciate if some people could test it so that we can see >>> what's right

Re: About the rowpainter2 branch (testers, have a look!)

Richard Heck wrote: > On 07/21/2015 09:36 AM, Scott Kostyshak wrote: >> On Tue, Jul 21, 2015 at 8:10 AM, Jean-Marc Lasgouttes >> wrote: >> >>> Basically, I'd appreciate if some people could test it so that we can >>> see what's right and what's wrong. Since leave on thursday

Re: About the rowpainter2 branch (testers, have a look!)

Le 21/07/15 15:36, Scott Kostyshak a écrit : I propose that you land it in master. If something goes very wrong, we can always revert it without you here. This is why I really appreciate your having done the work on a branch (as opposed to master directly), so it is easy to merge/unmerge. I

Re: About the rowpainter2 branch (testers, have a look!)

On Tue, Jul 21, 2015 at 6:04 PM, Jean-Marc Lasgouttes wrote: > I landed in master now. I could be imagining things, but scrolling feels smoother to me. Are you interested in *any* difference in behavior I notice when testing? For example, if a linebreak is at a different