Re: Annoying Mac Bug....

2007-06-06 Thread Andre Poenitz
On Wed, Jun 06, 2007 at 09:54:37AM +0200, Stefan Schimanski wrote: > > Am 06.06.2007 um 09:49 schrieb Jean-Marc Lasgouttes: > > >>"Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: > > > >Stefan> Well, at the moment confirmOverwrite is set to false for the > >Stefan> non- native dialog

Re: [PATCH] over-write=>overwrite (was Re: [PATCH] Bug 3818: Save and replace asks twice whether to overwrite (Re: Annoying Mac Bug....))

2007-06-06 Thread José Matos
On Wednesday 06 June 2007 15:01:57 Jean-Marc Lasgouttes wrote: > Jose'? > > JMarc OK. -- José Abílio

[PATCH] over-write=>overwrite (was Re: [PATCH] Bug 3818: Save and replace asks twice whether to overwrite (Re: Annoying Mac Bug....))

2007-06-06 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: >> Good question. It looks like it is not plain English. I propose to >> make a separate patch for that, but before I do so, could some >> native English speaker chime in? Bennett> You mean take over Angus' job? Exact :) Bennett> "Ove

Re: [PATCH] Bug 3818: Save and replace asks twice whether to overwrite (Re: Annoying Mac Bug....)

2007-06-06 Thread Jean-Marc Lasgouttes
> "José" == José Matos <[EMAIL PROTECTED]> writes: José> On Wednesday 06 June 2007 13:06:34 Jean-Marc Lasgouttes wrote: Stefan> OK, looks good and works. >> Jose, can I commit? José> OK. Applied. JMarc

Re: [PATCH] Bug 3818: Save and replace asks twice whether to overwrite (Re: Annoying Mac Bug....)

2007-06-06 Thread Bennett Helm
On Jun 6, 2007, at 8:06 AM, Jean-Marc Lasgouttes wrote: "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Could some osx user test this patch? JMarc Stefan> OK, looks good and works. Jose, can I commit? Stefan> One question: why is overwrite written over- write in the Stefan> d

Re: [PATCH] Bug 3818: Save and replace asks twice whether to overwrite (Re: Annoying Mac Bug....)

2007-06-06 Thread José Matos
On Wednesday 06 June 2007 13:06:34 Jean-Marc Lasgouttes wrote: > Stefan> OK, looks good and works. > > Jose, can I commit? OK. -- José Abílio

Re: [PATCH] Bug 3818: Save and replace asks twice whether to overwrite (Re: Annoying Mac Bug....)

2007-06-06 Thread Jean-Marc Lasgouttes
> "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: >> Could some osx user test this patch? >> >> JMarc >> >> Stefan> OK, looks good and works. Jose, can I commit? Stefan> One question: why is overwrite written over- write in the Stefan> dialog? Good question. It looks like it

Re: [PATCH] Bug 3818: Save and replace asks twice whether to overwrite (Re: Annoying Mac Bug....)

2007-06-06 Thread Stefan Schimanski
Am 06.06.2007 um 12:21 schrieb Jean-Marc Lasgouttes: "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: http://bugzilla.lyx.org/show_bug.cgi?id=3818 Stefan> You make a patch? OK. It turns out to be easier to disable overwrite control for the native dialog. Could some osx user test t

[PATCH] Bug 3818: Save and replace asks twice whether to overwrite (Re: Annoying Mac Bug....)

2007-06-06 Thread Jean-Marc Lasgouttes
> "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: http://bugzilla.lyx.org/show_bug.cgi?id=3818 Stefan> You make a patch? OK. It turns out to be easier to disable overwrite control for the native dialog. Could some osx user test this patch? JMarc Index: src/frontends/qt4/FileDial

Re: Annoying Mac Bug....

2007-06-06 Thread Stefan Schimanski
Am 06.06.2007 um 09:55 schrieb Jean-Marc Lasgouttes: "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: (2) we could force confirmation in the non-native case too and simplify our code. Stefan> And force any frontend (even if we have only one currently) to Stefan> do that overwrite

Re: Annoying Mac Bug....

2007-06-06 Thread Jean-Marc Lasgouttes
> "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: >> (2) we could force confirmation in the non-native case too and >> simplify our code. Stefan> And force any frontend (even if we have only one currently) to Stefan> do that overwrite dialog? Yes. Just document it. JMarc

Re: Annoying Mac Bug....

2007-06-06 Thread Stefan Schimanski
Am 06.06.2007 um 09:49 schrieb Jean-Marc Lasgouttes: "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Stefan> Well, at the moment confirmOverwrite is set to false for the Stefan> non- native dialog. You might question this decision and set Stefan> it to true, and change the asksForOv

Re: Annoying Mac Bug....

2007-06-06 Thread Jean-Marc Lasgouttes
> "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Stefan> Well, at the moment confirmOverwrite is set to false for the Stefan> non- native dialog. You might question this decision and set Stefan> it to true, and change the asksForOverwriteConfirmation then Stefan> accordingly. But th

Re: Annoying Mac Bug....

2007-06-06 Thread Stefan Schimanski
Am 06.06.2007 um 09:36 schrieb Jean-Marc Lasgouttes: "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Stefan> No, it doesn't. USE_NATIVE_FILEDIALOG is not defined in Stefan> callback.cpp on any platform. Putting an #ifdef around the Stefan> part is like "#ifdef 0". The right patch is

Re: Annoying Mac Bug....

2007-06-06 Thread Jean-Marc Lasgouttes
> "Stefan" == Stefan Schimanski <[EMAIL PROTECTED]> writes: Stefan> No, it doesn't. USE_NATIVE_FILEDIALOG is not defined in Stefan> callback.cpp on any platform. Putting an #ifdef around the Stefan> part is like "#ifdef 0". The right patch is attached. +bool FileDialog::asksForOverwriteConfir

Re: Annoying Mac Bug....

2007-06-06 Thread Stefan Schimanski
Am 06.06.2007 um 00:03 schrieb Mael Hilléreau: Le 5 juin 07 à 19:20, Richard Heck a écrit : Can someone on Mac sort this out: http://bugzilla.lyx.org/ show_bug.cgi?id=3818? I think I know what needs to be done, but I'm not on Mac. See my comments. Should be simple. Tested on Intel Mac OS

Re: Annoying Mac Bug....

2007-06-05 Thread Mael Hilléreau
Le 5 juin 07 à 19:20, Richard Heck a écrit : Can someone on Mac sort this out: http://bugzilla.lyx.org/ show_bug.cgi?id=3818? I think I know what needs to be done, but I'm not on Mac. See my comments. Should be simple. Tested on Intel Mac OS 10.4.9, with 1.5.0rc1: your #ifdef USE_NATIVE_FI

Annoying Mac Bug....

2007-06-05 Thread Richard Heck
Can someone on Mac sort this out: http://bugzilla.lyx.org/show_bug.cgi?id=3818? I think I know what needs to be done, but I'm not on Mac. See my comments. Should be simple. Richard -- == Richard G Heck, Jr Professor of Philosoph