Re: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-23 Thread Jean-Marc Lasgouttes
Rob == Rob Bearman [EMAIL PROTECTED] writes: Rob Apologies if I'm unclear on protocol as I haven't heard back on Rob this. Could my win32 patches please be applied if they're Rob acceptable? If you send the patch to me again, I'll apply it. Sorry for the delay. JMarc

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-23 Thread Rob Bearman
If you send the patch to me again, I'll apply it. Sorry for the delay. JMarc Thank you! Here they are again, including my comments: win32_kludge.diff - This is the fixed development\win32\win32_kludge.diff file (a replacement for the existing file, not a diff of the diff file). msvc.diff

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-23 Thread Angus Leeming
Rob Bearman wrote: If you send the patch to me again, I'll apply it. Sorry for the delay. JMarc Thank you! Here they are again, including my comments: win32_kludge.diff - This is the fixed development\win32\win32_kludge.diff file (a replacement for the existing file, not a diff of

Re: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-23 Thread Jean-Marc Lasgouttes
> "Rob" == Rob Bearman <[EMAIL PROTECTED]> writes: Rob> Apologies if I'm unclear on protocol as I haven't heard back on Rob> this. Could my win32 patches please be applied if they're Rob> acceptable? If you send the patch to me again, I'll apply it. Sorry for the delay. JMarc

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-23 Thread Rob Bearman
> If you send the patch to me again, I'll apply it. Sorry for the delay. > > JMarc > Thank you! Here they are again, including my comments: win32_kludge.diff - This is the fixed development\win32\win32_kludge.diff file (a replacement for the existing file, not a diff of the diff file).

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-23 Thread Angus Leeming
Rob Bearman wrote: >> If you send the patch to me again, I'll apply it. Sorry for the delay. >> >> JMarc >> > > Thank you! Here they are again, including my comments: > > win32_kludge.diff - This is the fixed > development\win32\win32_kludge.diff file (a replacement for the existing > file,

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-22 Thread Rob Bearman
Asking me nicely should suffice. -- Lgb That's easy enough. Please grant me access to the lyx-devel\development\win32 directory and refer me to any commit guideline docs that I should read. Thanks Rob Apologies if I'm unclear on protocol as I haven't heard back on this.

Re: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-22 Thread Lars Gullik Bjønnes
Rob Bearman [EMAIL PROTECTED] writes: Asking me nicely should suffice. -- Lgb That's easy enough. Please grant me access to the lyx-devel\development\win32 directory and refer me to any commit guideline docs that I should read. Thanks Rob | Apologies if I'm unclear on

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-22 Thread Rob Bearman
> > Asking me nicely should suffice. > > > > -- > > Lgb > > That's easy enough. Please grant me access to the > lyx-devel\development\win32 directory and refer me to any > commit guideline docs that I should read. > > Thanks > Rob Apologies if I'm unclear on protocol as I haven't heard

Re: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-22 Thread Lars Gullik Bjønnes
"Rob Bearman" <[EMAIL PROTECTED]> writes: >> > Asking me nicely should suffice. >> > >> > -- >> >Lgb >> >> That's easy enough. Please grant me access to the >> lyx-devel\development\win32 directory and refer me to any >> commit guideline docs that I should read. >> >> Thanks >> Rob > |

Re: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-18 Thread Asger Alstrup
Here are patches representing the above; it would be helpful if these could be committed if approved. I've built fresh successfully with these patches applied. Maybe you could get karma to commit yourself to the lyx-devel\development\win32 directory? Regards, Asger

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-18 Thread Rob Bearman
Maybe you could get karma to commit yourself to the lyx-devel\development\win32 directory? Regards, Asger If that's helpful, sure. Is there a karma application I should fill out? Thanks Rob

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-18 Thread Rob Bearman
Asking me nicely should suffice. -- Lgb That's easy enough. Please grant me access to the lyx-devel\development\win32 directory and refer me to any commit guideline docs that I should read. Thanks Rob

Re: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-18 Thread Asger Alstrup
Here are patches representing the above; it would be helpful if these could be committed if approved. I've built fresh successfully with these patches applied. Maybe you could get karma to commit yourself to the lyx-devel\development\win32 directory? Regards, Asger

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-18 Thread Rob Bearman
> Maybe you could get karma to commit yourself to the > lyx-devel\development\win32 directory? > > Regards, > Asger > If that's helpful, sure. Is there a karma application I should fill out? Thanks Rob

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-18 Thread Rob Bearman
> Asking me nicely should suffice. > > -- > Lgb That's easy enough. Please grant me access to the lyx-devel\development\win32 directory and refer me to any commit guideline docs that I should read. Thanks Rob

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-17 Thread Rob Bearman
Here's a summary of what needs to be done to fix the vcproj build: development\win32\package.C: Change GetEnv to getEnv and/or update from package.C.in development\win32\lyx.vcproj Add src\support\environment.C Remove src\support\putenv.C src\lyxserver.C (win32_kludge.diff) Fix by

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-17 Thread Rob Bearman
> Here's a summary of what needs to be done to fix the vcproj build: > > development\win32\package.C: > Change GetEnv to getEnv and/or update from package.C.in > > development\win32\lyx.vcproj > Add src\support\environment.C > Remove src\support\putenv.C > > src\lyxserver.C (win32_kludge.diff)

Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-15 Thread Rob Bearman
CVSROOT: /usr/local/lyx/cvsroot Module name: lyx-devel Repository: lyx-devel/src/ Changes by: [EMAIL PROTECTED] 05/02/15 12:04:40 Modified files: lyx-devel/src/: ChangeLog lyxserver.C Log message: Squash MSVC warning local variable 'fd' used without having

Re: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-15 Thread Asger Alstrup
A fixed VS lyxserver.C is attached. When I find the time, I'll update the patch. Regards, Asger /** * \file lyxserver.C * This file is part of LyX, the document processor. * Licence details can be found in the file COPYING. * * \author Lars Gullik Bjønnes * \author Jean-Marc Lasgouttes *

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-15 Thread Rob Bearman
A fixed VS lyxserver.C is attached. When I find the time, I'll update the patch. Regards, Asger Thank you. Also, I think the vcproj file will need to be updated to remove putenv.C and add environment.C. Unfortunately, environment.C doesn't build under MSVC: Compiling... environment.C

Re: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-15 Thread Angus Leeming
Rob Bearman wrote: Unfortunately, environment.C doesn't build under MSVC: environment.C \lyx\lyx-devel\src\support\environment.C(90) : error C2079: 'ss' uses undefined class 'std::basic_ostringstream_Elem,_Traits,_Alloc' Oops! Add #include sstream package.C package.C(322) : error C3861: 'GetEnv':

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-15 Thread Rob Bearman
Here's a summary of what needs to be done to fix the vcproj build: development\win32\package.C: Change GetEnv to getEnv and/or update from package.C.in development\win32\lyx.vcproj Add src\support\environment.C Remove src\support\putenv.C src\lyxserver.C (win32_kludge.diff) Fix by updating

Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-15 Thread Rob Bearman
> CVSROOT: /usr/local/lyx/cvsroot > Module name: lyx-devel > Repository: lyx-devel/src/ > Changes by: [EMAIL PROTECTED] 05/02/15 12:04:40 > > Modified files: > lyx-devel/src/: ChangeLog lyxserver.C > > Log message: > Squash MSVC warning "local variable 'fd' used

Re: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-15 Thread Asger Alstrup
A fixed VS lyxserver.C is attached. When I find the time, I'll update the patch. Regards, Asger /** * \file lyxserver.C * This file is part of LyX, the document processor. * Licence details can be found in the file COPYING. * * \author Lars Gullik Bjønnes * \author Jean-Marc Lasgouttes *

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-15 Thread Rob Bearman
> A fixed VS lyxserver.C is attached. When I find the time, > I'll update the > patch. > > Regards, > Asger > Thank you. Also, I think the vcproj file will need to be updated to remove putenv.C and add environment.C. Unfortunately, environment.C doesn't build under MSVC: Compiling...

Re: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-15 Thread Angus Leeming
Rob Bearman wrote: Unfortunately, environment.C doesn't build under MSVC: environment.C \lyx\lyx-devel\src\support\environment.C(90) : error C2079: 'ss' uses undefined class 'std::basic_ostringstream<_Elem,_Traits,_Alloc>' Oops! Add #include package.C package.C(322) : error C3861: 'GetEnv':

RE: Change to lyxserver.C breaks win32_kludge.diff patch

2005-02-15 Thread Rob Bearman
Here's a summary of what needs to be done to fix the vcproj build: development\win32\package.C: Change GetEnv to getEnv and/or update from package.C.in development\win32\lyx.vcproj Add src\support\environment.C Remove src\support\putenv.C src\lyxserver.C (win32_kludge.diff) Fix by updating