Re: Citation Label Undo/Redo Bug

2018-01-28 Thread Scott Kostyshak
On Mon, Jan 29, 2018 at 04:42:03AM +, Richard Heck wrote: > This is now bug #11055, fixed in master. For reference, it's #11005. > Scott, it is up to you about 2.3.0. It's really a very old bug, so I > don't think it's crucial. Thanks, Richard. Let's not put it in 2.3.0. Scott signature.

Re: Citation Label Undo/Redo Bug

2018-01-28 Thread Richard Heck
On 01/28/2018 03:31 AM, Jürgen Spitzmüller wrote: > Am Samstag, den 27.01.2018, 17:28 -0500 schrieb Richard Heck: >> I guess what we need to do here is mark the citation labels as >> invalid, >> so they will all be recalculated. So we need a >> Buffer::invalidateCiteLabels() routine, which is obvio

Re: Citation Label Undo/Redo Bug

2018-01-28 Thread Jürgen Spitzmüller
Am Samstag, den 27.01.2018, 17:28 -0500 schrieb Richard Heck: > I guess what we need to do here is mark the citation labels as > invalid, > so they will all be recalculated. So we need a > Buffer::invalidateCiteLabels() routine, which is obviously easy, and > we > need to decide when to call it. I'

Citation Label Undo/Redo Bug

2018-01-27 Thread Richard Heck
On 12/20/2017 12:34 PM, Richard Heck wrote: > On 12/20/2017 01:43 AM, Scott Kostyshak wrote: >> Note that a7677bfb (the reversion commit) introduced another issue: >> To reproduce: >> >> 1. Open e.g. tufte-handout.lyx (any LyX file with a citation inset will >> reproduce) >> 2. Scroll down to a cit