Re: Custom Insets on a Menu

2016-08-28 Thread Guillaume Munch
Le 14/08/2016 à 22:43, Richard Heck a écrit : On 08/14/2016 07:07 AM, Guillaume Munch wrote: Le 04/08/2016 à 02:11, Guillaume Munch a écrit : In the attached patch, I propose to replace the reference with a shared_ptr to avoid copying tens of FuncRequests every time one opens a menu. I

Re: Custom Insets on a Menu

2016-08-14 Thread Richard Heck
On 08/14/2016 07:07 AM, Guillaume Munch wrote: > Le 04/08/2016 à 02:11, Guillaume Munch a écrit : >> In the attached patch, I propose to replace the reference with a >> shared_ptr to avoid copying tens of FuncRequests every time one >> opens a menu. >> > > > I would like to commit this patch to

Re: Custom Insets on a Menu

2016-08-14 Thread Guillaume Munch
Le 04/08/2016 à 02:11, Guillaume Munch a écrit : In the attached patch, I propose to replace the reference with a shared_ptr to avoid copying tens of FuncRequests every time one opens a menu. I would like to commit this patch to unblock the development of Richard's.

Re: Custom Insets on a Menu

2016-08-03 Thread Guillaume Munch
Le 26/06/2016 à 16:27, Richard Heck a écrit : The problem here seems to trace to how FuncRequest objects are handled by our Action class. Namely, when an Action is created, it retains a const & to a FuncRequest. So one can't pass a temporary. Well, you can always pass a temporary, but Action

Re: Custom Insets on a Menu

2016-06-26 Thread Guillaume Munch
Le 26/06/2016 16:27, Richard Heck a écrit : The attached patch almost works. (Details like the icon are not yet there.) There are some big problems, however, which seem to derive from the fact that the whole menu and toolbar setup is not really designed to be modified on the fly. The problem

Custom Insets on a Menu

2016-06-26 Thread Richard Heck
The attached patch almost works. (Details like the icon are not yet there.) There are some big problems, however, which seem to derive from the fact that the whole menu and toolbar setup is not really designed to be modified on the fly. The problem here seems to trace to how FuncRequest