Re: InsetListingsParams enhancement for Bo (was [patch] Bug 3639- Sorted listing params)

2007-05-30 Thread Abdelrazak Younes
Bo Peng wrote: Sorry Bo, it is been a bit late, but I wait for all the changes for the source file settles. It can go in if you change .find() to contains(), and trim() suffix to avoid problem with '?style ' etc (if it has not been trimmed before key is passed). All these controls and string

Re: InsetListingsParams enhancement for Bo (was [patch] Bug 3639- Sorted listing params)

2007-05-30 Thread Ozgur Ugras BARAN
On 5/30/07, Abdelrazak Younes [EMAIL PROTECTED] wrote: Bo Peng wrote: Sorry Bo, it is been a bit late, but I wait for all the changes for the source file settles. It can go in if you change .find() to contains(), and trim() suffix to avoid problem with '?style ' etc (if it has not been

Re: InsetListingsParams enhancement for Bo (was [patch] Bug 3639- Sorted listing params)

2007-05-30 Thread Bo Peng
+1 I can move it to frontend after the release, if nobody objects. After 1.5.0 please. Time would be better spent on real bugs now. Bo

Re: InsetListingsParams enhancement for Bo (was [patch] Bug 3639- Sorted listing params)

2007-05-30 Thread Ozgur Ugras BARAN
Otherwise, '?something ' will not match anything. I guess, a trim is already applied. I updated the code for the situations '? something' and attached the patch. However, It does not cover the situations '?some thing'. I used trim (), but since the string is already trimmed, rtrim() is

Re: InsetListingsParams enhancement for Bo (was [patch] Bug 3639- Sorted listing params)

2007-05-30 Thread Abdelrazak Younes
Bo Peng wrote: Sorry Bo, it is been a bit late, but I wait for all the changes for the source file settles. It can go in if you change .find() to contains(), and trim() suffix to avoid problem with '?style ' etc (if it has not been trimmed before key is passed). All these controls and string

Re: InsetListingsParams enhancement for Bo (was [patch] Bug 3639- Sorted listing params)

2007-05-30 Thread Ozgur Ugras BARAN
On 5/30/07, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Bo Peng wrote: >> Sorry Bo, it is been a bit late, but I wait for all the changes for >> the source file settles. > > It can go in if you change .find() to contains(), and trim() suffix to > avoid problem with '?style ' etc (if it has not

Re: InsetListingsParams enhancement for Bo (was [patch] Bug 3639- Sorted listing params)

2007-05-30 Thread Bo Peng
> > +1 I can move it to frontend after the release, if nobody objects. After 1.5.0 please. Time would be better spent on real bugs now. Bo

Re: InsetListingsParams enhancement for Bo (was [patch] Bug 3639- Sorted listing params)

2007-05-30 Thread Ozgur Ugras BARAN
Otherwise, '?something ' will not match anything. I guess, a trim is already applied. I updated the code for the situations '? something' and attached the patch. However, It does not cover the situations '?some thing'. I used trim (), but since the string is already trimmed, rtrim() is

InsetListingsParams enhancement for Bo (was [patch] Bug 3639- Sorted listing params)

2007-05-29 Thread Ozgur Ugras BARAN
Attached is a patch for a small feature that Bo asked for. It simply filters InsetListingsParams when the text in the corresponding dialog is entered as ?string . Sorry Bo, it is been a bit late, but I wait for all the changes for the source file settles. cheers Ugras Index:

Re: InsetListingsParams enhancement for Bo (was [patch] Bug 3639- Sorted listing params)

2007-05-29 Thread Bo Peng
Sorry Bo, it is been a bit late, but I wait for all the changes for the source file settles. It can go in if you change .find() to contains(), and trim() suffix to avoid problem with '?style ' etc (if it has not been trimmed before key is passed). Thanks. Bo

InsetListingsParams enhancement for Bo (was [patch] Bug 3639- Sorted listing params)

2007-05-29 Thread Ozgur Ugras BARAN
Attached is a patch for a small feature that Bo asked for. It simply filters InsetListingsParams when the text in the corresponding dialog is entered as ? . Sorry Bo, it is been a bit late, but I wait for all the changes for the source file settles. cheers Ugras Index:

Re: InsetListingsParams enhancement for Bo (was [patch] Bug 3639- Sorted listing params)

2007-05-29 Thread Bo Peng
Sorry Bo, it is been a bit late, but I wait for all the changes for the source file settles. It can go in if you change .find() to contains(), and trim() suffix to avoid problem with '?style ' etc (if it has not been trimmed before key is passed). Thanks. Bo