Re: Movable toolbars

2006-11-11 Thread Andre Poenitz
On Wed, Nov 01, 2006 at 08:43:19AM +1800, Bo Peng wrote: I've just enabled it. Then, it makes sense to save toolbar position in session. Could you please tell me the functions to get/set toolbar position? Note that the interface has to be done independent of frontend. Why don't you simply

Re: Movable toolbars

2006-11-11 Thread Andre Poenitz
On Tue, Oct 31, 2006 at 03:30:43PM +, John Levon wrote: On Tue, Oct 31, 2006 at 03:22:34PM +, José Matos wrote: On Tuesday 31 October 2006 2:43 pm, John Levon wrote: On Tue, Oct 31, 2006 at 03:42:32PM +0100, Peter Kümmel wrote: I've just enabled it. Nice :( Could

Re: Movable toolbars

2006-11-11 Thread Andre Poenitz
On Tue, Oct 31, 2006 at 03:51:44PM +0100, Peter Kümmel wrote: José Matos wrote: GuiView.C:78: error: ISO C++ forbids declaration of 'QTabBar' with no type I've added the include of QTabBar. Does this help? Maybe I should remove the Qt headers from the precompiled msvc-headers. Why? The

Re: Movable toolbars

2006-11-11 Thread Andre Poenitz
On Wed, Nov 01, 2006 at 08:43:19AM +1800, Bo Peng wrote: > >I've just enabled it. > > > > Then, it makes sense to save toolbar position in session. Could you > please tell me the functions to get/set toolbar position? Note that > the interface has to be done independent of frontend. Why don't

Re: Movable toolbars

2006-11-11 Thread Andre Poenitz
On Tue, Oct 31, 2006 at 03:30:43PM +, John Levon wrote: > On Tue, Oct 31, 2006 at 03:22:34PM +, José Matos wrote: > > > On Tuesday 31 October 2006 2:43 pm, John Levon wrote: > > > On Tue, Oct 31, 2006 at 03:42:32PM +0100, Peter Kümmel wrote: > > > > I've just enabled it. > > > > > > Nice

Re: Movable toolbars

2006-11-11 Thread Andre Poenitz
On Tue, Oct 31, 2006 at 03:51:44PM +0100, Peter Kümmel wrote: > José Matos wrote: > > GuiView.C:78: error: ISO C++ forbids declaration of 'QTabBar' with no type > > I've added the include of QTabBar. > Does this help? > > Maybe I should remove the Qt headers from the precompiled msvc-headers.

Re: Movable toolbars

2006-11-02 Thread Enrico Forestieri
On Tue, Oct 31, 2006 at 04:46:07PM +0100, Abdelrazak Younes wrote: Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a

Re: Movable toolbars

2006-11-02 Thread Enrico Forestieri
On Tue, Oct 31, 2006 at 04:46:07PM +0100, Abdelrazak Younes wrote: > Peter Kümmel wrote: > > Because > > - it costs us nothing > > - it's a nice feature for the user > > - I don't see any reason way we should disable it > > - we are releasing only a alpha version > > - I don't want to

Re: Movable toolbars

2006-11-01 Thread Peter Kümmel
John Levon wrote: On Tue, Oct 31, 2006 at 07:46:04PM +0100, Peter Kümmel wrote: As I understand it, your main reason against 'setMovable(true)' is the the 'tearing off' (comment in the code) or the 'popping out'. But this is not possible also not with my So I discovered when I finished

Re: Movable toolbars

2006-11-01 Thread Michael Gerz
John Levon wrote: On Tue, Oct 31, 2006 at 08:12:26PM +0100, Michael Gerz wrote: Why does the Review toolbar have to have the review flag? You can BTW, one comment about the Review toolbar. It's very neat functionality to have, but it's severely hampered by the lack of any icons.

Re: Movable toolbars

2006-11-01 Thread John Levon
On Wed, Nov 01, 2006 at 09:48:49AM +0100, Peter Kümmel wrote: 3. Disable it again when the Toolbars dialog is done: only show the grippies when the dialog is active, like Firefox etc. do Why not. The session stuff is on the why. Does the 3. point mean to completely disable the context

Re: Movable toolbars

2006-11-01 Thread Peter Kümmel
John Levon wrote: > On Tue, Oct 31, 2006 at 07:46:04PM +0100, Peter Kümmel wrote: > >> As I understand it, your main reason against 'setMovable(true)' >> is the the 'tearing off' (comment in the code) or the >> 'popping out'. But this is not possible also not with my > > So I discovered when I

Re: Movable toolbars

2006-11-01 Thread Michael Gerz
John Levon wrote: On Tue, Oct 31, 2006 at 08:12:26PM +0100, Michael Gerz wrote: Why does the "Review" toolbar have to have the "review" flag? You can BTW, one comment about the Review toolbar. It's very neat functionality to have, but it's severely hampered by the lack of any icons.

Re: Movable toolbars

2006-11-01 Thread John Levon
On Wed, Nov 01, 2006 at 09:48:49AM +0100, Peter Kümmel wrote: > > 3. Disable it again when the Toolbars dialog is done: only show the > > grippies when the dialog is active, like Firefox etc. do > > Why not. The session stuff is on the why. > > Does the 3. point mean to completely disable the

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Bo Peng wrote: OK, I disable the default precompilng of Qt headers. I guess you VC guys can turn it on during development, and turn it off and test before commit? I don't know if there is a way of disabling it without a complete recompile. Maybe it will work only with two build trees. --

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
José Matos wrote: On Tuesday 31 October 2006 2:51 pm, Peter Kümmel wrote: José Matos wrote: GuiView.C:78: error: ISO C++ forbids declaration of 'QTabBar' with no type I've added the include of QTabBar. Does this help? It helps but it is not enough: ... GuiView.C:83: error:

Re: Movable toolbars

2006-10-31 Thread Bo Peng
OK, I disable the default precompilng of Qt headers. I guess you VC guys can turn it on during development, and turn it off and test before commit? Bo

Re: Movable toolbars

2006-10-31 Thread José Matos
On Tuesday 31 October 2006 2:42 pm, Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a endless discussion I've just enabled it.

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Abdelrazak Younes wrote: Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a endless discussion I've just enabled it. No

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Abdelrazak Younes wrote: José Matos wrote: On Tuesday 31 October 2006 2:42 pm, Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a

Re: Movable toolbars

2006-10-31 Thread Bo Peng
I've just enabled it. Then, it makes sense to save toolbar position in session. Could you please tell me the functions to get/set toolbar position? Note that the interface has to be done independent of frontend. Bo

Movable toolbars

2006-10-31 Thread Peter Kümmel
Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a endless discussion I've just enabled it. Peter The diff: Index: frontends/qt4/QLToolbar.C

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a endless discussion I've just enabled

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: José Matos wrote: On Tuesday 31 October 2006 2:42 pm, Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't

Re: Movable toolbars

2006-10-31 Thread John Levon
On Tue, Oct 31, 2006 at 03:42:32PM +0100, Peter Kümmel wrote: I've just enabled it. Nice :( john

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Bo Peng wrote: I've just enabled it. Then, it makes sense to save toolbar position in session. Could you please tell me the functions to get/set toolbar position? Note that the interface has to be done independent of frontend. Bo Yes, I also think this should be added, see the

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
José Matos wrote: GuiView.C:78: error: ISO C++ forbids declaration of 'QTabBar' with no type I've added the include of QTabBar. Does this help? Maybe I should remove the Qt headers from the precompiled msvc-headers. Peter

Re: Movable toolbars

2006-10-31 Thread José Matos
On Tuesday 31 October 2006 2:51 pm, Peter Kümmel wrote: José Matos wrote: GuiView.C:78: error: ISO C++ forbids declaration of 'QTabBar' with no type I've added the include of QTabBar. Does this help? It helps but it is not enough: if /bin/sh ../../../libtool --tag=CXX --mode=compile

Re: Movable toolbars

2006-10-31 Thread José Matos
On Tuesday 31 October 2006 3:30 pm, John Levon wrote: That it just happened without discussion of whether it makes sense, unlike when I disabled it, when I actually asked people? John time passes and my memory is not improving. :-) Do you remember the arguments at that time? I have

Re: Movable toolbars

2006-10-31 Thread José Matos
On Tuesday 31 October 2006 2:43 pm, John Levon wrote: On Tue, Oct 31, 2006 at 03:42:32PM +0100, Peter Kümmel wrote: I've just enabled it. Nice :( Could you elaborate, please? The switch is simple, and we can change it at any time. :-) john -- José Abílio

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
John Levon wrote: On Tue, Oct 31, 2006 at 03:42:32PM +0100, Peter Kümmel wrote: I've just enabled it. Nice :( Maybe we could add a settings somewhere to disable it for people like you. Abdel.

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Abdelrazak Younes wrote: Peter Kümmel wrote: Abdelrazak Younes wrote: José Matos wrote: On Tuesday 31 October 2006 2:42 pm, Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing

Re: Movable toolbars

2006-10-31 Thread Jean-Marc Lasgouttes
John == John Levon [EMAIL PROTECTED] writes: John Besides us not having any support for remembering it in a John session, it's far too easy to pop out toolbars. I've also never John understood why it's preferable to have toolbars that occlude John other windows (and indeed UI design experts

Re: Movable toolbars

2006-10-31 Thread John Levon
On Tue, Oct 31, 2006 at 04:00:21PM +, José Matos wrote: That it just happened without discussion of whether it makes sense, unlike when I disabled it, when I actually asked people? John time passes and my memory is not improving. :-) Do you remember the arguments at that time?

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a endless discussion I've just enabled it. I think we should make a distinction

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a endless discussion I've just enabled it. No problem with it but how does this work

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
José Matos wrote: On Tuesday 31 October 2006 2:42 pm, Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a endless discussion I've just

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
Peter Kümmel wrote: José Matos wrote: On Tuesday 31 October 2006 2:51 pm, Peter Kümmel wrote: José Matos wrote: GuiView.C:78: error: ISO C++ forbids declaration of 'QTabBar' with no type I've added the include of QTabBar. Does this help? It helps but it is not enough: ... GuiView.C:83:

Re: Movable toolbars

2006-10-31 Thread John Levon
On Tue, Oct 31, 2006 at 03:22:34PM +, José Matos wrote: On Tuesday 31 October 2006 2:43 pm, John Levon wrote: On Tue, Oct 31, 2006 at 03:42:32PM +0100, Peter Kümmel wrote: I've just enabled it. Nice :( Could you elaborate, please? The switch is simple, and we can change it

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Hi John, sorry if I've annoyed you. At least we have now a active discussion about it and I know the author of the code which I've changed. ;) As I understand it, your main reason against 'setMovable(true)' is the the 'tearing off' (comment in the code) or the 'popping out'. But this is not

Re: Movable toolbars

2006-10-31 Thread Bo Peng
Because of this I haven't seen a reason not to enable 'movable'. I like movable toolbars but I share JMarc's concerns about math/table toolbars and session. I will add session/toolbar very soon and I would appreciate it if you can show me how to get/restore toolbar position. Bo

Re: Movable toolbars

2006-10-31 Thread Michael Gerz
John Levon wrote: That it just happened without discussion of whether it makes sense, unlike when I disabled it, when I actually asked people? Anyway, seems I've been overruled by the current devs, so it doesn't really matter. Peter, to tell the truth I am also not happy about your change

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Michael Gerz wrote: John Levon wrote: That it just happened without discussion of whether it makes sense, unlike when I disabled it, when I actually asked people? Anyway, seems I've been overruled by the current devs, so it doesn't really matter. Peter, to tell the truth I am also not

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Bo Peng wrote: Because of this I haven't seen a reason not to enable 'movable'. I like movable toolbars but I share JMarc's concerns about math/table toolbars and session. I will add session/toolbar very soon and I would appreciate it if you can show me how to get/restore toolbar position

Re: Movable toolbars

2006-10-31 Thread Michael Gerz
Peter Kümmel wrote: Anyway, all the toolbar stuff is a moving target so lets not argue about it. Yes. And I am not going to touch your code. Michael

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Michael Gerz wrote: Peter Kümmel wrote: Anyway, all the toolbar stuff is a moving target so lets not argue about it. Yes. And I am not going to touch your code. Thanks, Michael, and sorry for my brutal committing. Hope I'm now not in your ignore list. ;) Peter

Re: Movable toolbars

2006-10-31 Thread José Matos
On Tuesday 31 October 2006 8:57 pm, Peter Kümmel wrote: Michael Gerz wrote: Peter Kümmel wrote: Anyway, all the toolbar stuff is a moving target so lets not argue about it. Yes. And I am not going to touch your code. Thanks, Michael, and sorry for my brutal committing. Hope I'm now

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
José Matos wrote: On Tuesday 31 October 2006 8:57 pm, Peter Kümmel wrote: Michael Gerz wrote: Peter Kümmel wrote: Anyway, all the toolbar stuff is a moving target so lets not argue about it. Yes. And I am not going to touch your code. Thanks, Michael, and sorry for my brutal committing.

Re: Movable toolbars

2006-10-31 Thread John Levon
On Tue, Oct 31, 2006 at 07:46:04PM +0100, Peter Kümmel wrote: As I understand it, your main reason against 'setMovable(true)' is the the 'tearing off' (comment in the code) or the 'popping out'. But this is not possible also not with my So I discovered when I finished the build. My apologies

Re: Movable toolbars

2006-10-31 Thread John Levon
On Tue, Oct 31, 2006 at 08:12:26PM +0100, Michael Gerz wrote: Why does the Review toolbar have to have the review flag? You can BTW, one comment about the Review toolbar. It's very neat functionality to have, but it's severely hampered by the lack of any icons. It's not fun work if you're not

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Bo Peng wrote: >> OK, I disable the default precompilng of Qt headers. > > I guess you VC guys can turn it on during development, and turn it off > and test before commit? I don't know if there is a way of disabling it without a complete recompile. Maybe it will work only with two build trees.

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
José Matos wrote: > On Tuesday 31 October 2006 2:51 pm, Peter Kümmel wrote: >> José Matos wrote: >>> GuiView.C:78: error: ISO C++ forbids declaration of 'QTabBar' with no >>> type >> I've added the include of QTabBar. >> Does this help? > > It helps but it is not enough: ... > GuiView.C:83:

Re: Movable toolbars

2006-10-31 Thread Bo Peng
OK, I disable the default precompilng of Qt headers. I guess you VC guys can turn it on during development, and turn it off and test before commit? Bo

Re: Movable toolbars

2006-10-31 Thread José Matos
On Tuesday 31 October 2006 2:42 pm, Peter Kümmel wrote: > Because > - it costs us nothing > - it's a nice feature for the user > - I don't see any reason way we should disable it > - we are releasing only a alpha version > - I don't want to start a endless discussion > > I've just

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Abdelrazak Younes wrote: > Peter Kümmel wrote: >> Because >> - it costs us nothing >> - it's a nice feature for the user >> - I don't see any reason way we should disable it >> - we are releasing only a alpha version >> - I don't want to start a endless discussion >> >> I've just enabled

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Abdelrazak Younes wrote: > José Matos wrote: >> On Tuesday 31 October 2006 2:42 pm, Peter Kümmel wrote: >>> Because >>> - it costs us nothing >>> - it's a nice feature for the user >>> - I don't see any reason way we should disable it >>> - we are releasing only a alpha version >>> - I

Re: Movable toolbars

2006-10-31 Thread Bo Peng
I've just enabled it. Then, it makes sense to save toolbar position in session. Could you please tell me the functions to get/set toolbar position? Note that the interface has to be done independent of frontend. Bo

Movable toolbars

2006-10-31 Thread Peter Kümmel
Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a endless discussion I've just enabled it. Peter The diff: Index: frontends/qt4/QLToolbar.C

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a endless discussion I've just enabled

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: José Matos wrote: On Tuesday 31 October 2006 2:42 pm, Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't

Re: Movable toolbars

2006-10-31 Thread John Levon
On Tue, Oct 31, 2006 at 03:42:32PM +0100, Peter Kümmel wrote: > I've just enabled it. Nice :( john

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Bo Peng wrote: >> I've just enabled it. >> > > Then, it makes sense to save toolbar position in session. Could you > please tell me the functions to get/set toolbar position? Note that > the interface has to be done independent of frontend. > > Bo > > Yes, I also think this should be added,

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
José Matos wrote: > GuiView.C:78: error: ISO C++ forbids declaration of 'QTabBar' with no type I've added the include of QTabBar. Does this help? Maybe I should remove the Qt headers from the precompiled msvc-headers. Peter

Re: Movable toolbars

2006-10-31 Thread José Matos
On Tuesday 31 October 2006 2:51 pm, Peter Kümmel wrote: > José Matos wrote: > > GuiView.C:78: error: ISO C++ forbids declaration of 'QTabBar' with no > > type > > I've added the include of QTabBar. > Does this help? It helps but it is not enough: if /bin/sh ../../../libtool --tag=CXX

Re: Movable toolbars

2006-10-31 Thread José Matos
On Tuesday 31 October 2006 3:30 pm, John Levon wrote: > > That it just happened without discussion of whether it makes sense, > unlike when I disabled it, when I actually asked people? John time passes and my memory is not improving. :-) Do you remember the arguments at that time? I have

Re: Movable toolbars

2006-10-31 Thread José Matos
On Tuesday 31 October 2006 2:43 pm, John Levon wrote: > On Tue, Oct 31, 2006 at 03:42:32PM +0100, Peter Kümmel wrote: > > I've just enabled it. > > Nice :( Could you elaborate, please? The switch is simple, and we can change it at any time. :-) > john -- José Abílio

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
John Levon wrote: On Tue, Oct 31, 2006 at 03:42:32PM +0100, Peter Kümmel wrote: I've just enabled it. Nice :( Maybe we could add a settings somewhere to disable it for people like you. Abdel.

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Abdelrazak Younes wrote: > Peter Kümmel wrote: >> Abdelrazak Younes wrote: >>> José Matos wrote: On Tuesday 31 October 2006 2:42 pm, Peter Kümmel wrote: > Because > - it costs us nothing > - it's a nice feature for the user > - I don't see any reason way we should

Re: Movable toolbars

2006-10-31 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> Besides us not having any support for remembering it in a John> session, it's far too easy to pop out toolbars. I've also never John> understood why it's preferable to have toolbars that occlude John> other windows (and indeed UI design

Re: Movable toolbars

2006-10-31 Thread John Levon
On Tue, Oct 31, 2006 at 04:00:21PM +, José Matos wrote: > > That it just happened without discussion of whether it makes sense, > > unlike when I disabled it, when I actually asked people? > > John time passes and my memory is not improving. :-) > > Do you remember the arguments at that

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a endless discussion I've just enabled it. I think we should make a distinction

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a endless discussion I've just enabled it. No problem with it but how does this work

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
José Matos wrote: On Tuesday 31 October 2006 2:42 pm, Peter Kümmel wrote: Because - it costs us nothing - it's a nice feature for the user - I don't see any reason way we should disable it - we are releasing only a alpha version - I don't want to start a endless discussion I've just

Re: Movable toolbars

2006-10-31 Thread Abdelrazak Younes
Peter Kümmel wrote: José Matos wrote: On Tuesday 31 October 2006 2:51 pm, Peter Kümmel wrote: José Matos wrote: GuiView.C:78: error: ISO C++ forbids declaration of 'QTabBar' with no type I've added the include of QTabBar. Does this help? It helps but it is not enough: ... GuiView.C:83:

Re: Movable toolbars

2006-10-31 Thread John Levon
On Tue, Oct 31, 2006 at 03:22:34PM +, José Matos wrote: > On Tuesday 31 October 2006 2:43 pm, John Levon wrote: > > On Tue, Oct 31, 2006 at 03:42:32PM +0100, Peter Kümmel wrote: > > > I've just enabled it. > > > > Nice :( > > Could you elaborate, please? > > The switch is simple, and we

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Hi John, sorry if I've annoyed you. At least we have now a active discussion about it and I know the author of the code which I've changed. ;) As I understand it, your main reason against 'setMovable(true)' is the the 'tearing off' (comment in the code) or the 'popping out'. But this is not

Re: Movable toolbars

2006-10-31 Thread Bo Peng
Because of this I haven't seen a reason not to enable 'movable'. I like movable toolbars but I share JMarc's concerns about math/table toolbars and session. I will add session/toolbar very soon and I would appreciate it if you can show me how to get/restore toolbar position. Bo

Re: Movable toolbars

2006-10-31 Thread Michael Gerz
John Levon wrote: That it just happened without discussion of whether it makes sense, unlike when I disabled it, when I actually asked people? Anyway, seems I've been overruled by the current devs, so it doesn't really matter. Peter, to tell the truth I am also not happy about your change

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Michael Gerz wrote: > John Levon wrote: > >> That it just happened without discussion of whether it makes sense, >> unlike when I disabled it, when I actually asked people? >> >> Anyway, seems I've been overruled by the current devs, so it doesn't >> really matter. >> >> > Peter, to tell the

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Bo Peng wrote: >> Because of this I haven't seen a reason not to enable 'movable'. > > I like movable toolbars but I share JMarc's concerns about math/table > toolbars and session. I will add session/toolbar very soon and I would > appreciate it if you can show me how to g

Re: Movable toolbars

2006-10-31 Thread Michael Gerz
Peter Kümmel wrote: Anyway, all the toolbar stuff is a moving target so lets not argue about it. Yes. And I am not going to touch your code. Michael

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
Michael Gerz wrote: > Peter Kümmel wrote: > >> Anyway, all the toolbar stuff is a moving target so lets not argue >> about it. >> >> > Yes. And I am not going to touch your code. Thanks, Michael, and sorry for my brutal committing. Hope I'm now not in your ignore list. ;) Peter

Re: Movable toolbars

2006-10-31 Thread José Matos
On Tuesday 31 October 2006 8:57 pm, Peter Kümmel wrote: > Michael Gerz wrote: > > Peter Kümmel wrote: > >> Anyway, all the toolbar stuff is a moving target so lets not argue > >> about it. > > > > Yes. And I am not going to touch your code. > > Thanks, Michael, and sorry for my brutal committing.

Re: Movable toolbars

2006-10-31 Thread Peter Kümmel
José Matos wrote: > On Tuesday 31 October 2006 8:57 pm, Peter Kümmel wrote: >> Michael Gerz wrote: >>> Peter Kümmel wrote: Anyway, all the toolbar stuff is a moving target so lets not argue about it. >>> Yes. And I am not going to touch your code. >> Thanks, Michael, and sorry for my

Re: Movable toolbars

2006-10-31 Thread John Levon
On Tue, Oct 31, 2006 at 07:46:04PM +0100, Peter Kümmel wrote: > As I understand it, your main reason against 'setMovable(true)' > is the the 'tearing off' (comment in the code) or the > 'popping out'. But this is not possible also not with my So I discovered when I finished the build. My

Re: Movable toolbars

2006-10-31 Thread John Levon
On Tue, Oct 31, 2006 at 08:12:26PM +0100, Michael Gerz wrote: > Why does the "Review" toolbar have to have the "review" flag? You can BTW, one comment about the Review toolbar. It's very neat functionality to have, but it's severely hampered by the lack of any icons. It's not fun work if you're