On Thu, May 10, 2018 at 05:23:32PM +, Jean-Marc Lasgouttes wrote:
> Le 10/05/2018 à 19:05, Scott Kostyshak a écrit :
> > It would make it easier to read the code. For example, I would know that
> > methods such as forwardPar() could be used, but that no changes to the
> > document would be
Le 10/05/2018 à 19:05, Scott Kostyshak a écrit :
It would make it easier to read the code. For example, I would know that
methods such as forwardPar() could be used, but that no changes to the
document would be done. But perhaps it is not clear what a "change" is.
Knowing what a change is is
On Thu, May 10, 2018 at 11:26:41AM +, Jean-Marc Lasgouttes wrote:
> Le 08/05/2018 à 02:04, Scott Kostyshak a écrit :
> > The patch is attached. Any comments?
>
> It looks good.
Thanks, it's in at 23de5e5e.
> > In addition, I have a couple of questions:
> >
> > 1. Is there a reason that
Le 08/05/2018 à 02:04, Scott Kostyshak a écrit :
The patch is attached. Any comments?
It looks good.
In addition, I have a couple of questions:
1. Is there a reason that there is no const_DocIterator class?
No, what would it be good for?
2. If paragraph::id() did not exist, would it be
lt;skost...@lyx.org>
Date: Fri, 4 May 2018 18:21:54 -0400
Subject: [PATCH] Only show Accept/Reject Change options if relevant
In the context menu for a selection, we now only show the options
"Accept Change" and "Reject Change" if there is actually a change in
the selection.
On Sun, May 06, 2018 at 07:29:03PM +, Jean-Marc Lasgouttes wrote:
> Le 05/05/2018 à 21:53, Scott Kostyshak a écrit :
> > I'm unsure what approach to take. One option would be to define
> > "isChanged()" to return true if there is a change in the paragraph or in
> > any paragraph within the
Le 05/05/2018 à 21:53, Scott Kostyshak a écrit :
I'm unsure what approach to take. One option would be to define
"isChanged()" to return true if there is a change in the paragraph or in
any paragraph within the paragraph. I think that currently, isChanged()
checks only the top-level paragraph. I
On 05/06/2018 09:34 AM, Scott Kostyshak wrote:
> On Sun, May 06, 2018 at 02:05:45AM +, Richard Kimberly Heck wrote:
>
>> You could just define a new method that does this and leave the old one
>> as is.
> That is a good idea. Actually, it appears that this function definition
> is not used.
On Sun, May 06, 2018 at 02:05:45AM +, Richard Kimberly Heck wrote:
> You could just define a new method that does this and leave the old one
> as is.
That is a good idea. Actually, it appears that this function definition
is not used. But I think I will still not touch it and create a new
On 05/05/2018 03:53 PM, Scott Kostyshak wrote:
> On Sat, May 05, 2018 at 05:11:31PM +, Scott Kostyshak wrote:
>> On Sat, May 05, 2018 at 04:05:49PM +, Richard Kimberly Heck wrote:
>>> On 05/05/2018 11:56 AM, Scott Kostyshak wrote:
The attached patch is an attempt to only show the
On Sat, May 05, 2018 at 05:11:31PM +, Scott Kostyshak wrote:
> On Sat, May 05, 2018 at 04:05:49PM +, Richard Kimberly Heck wrote:
> > On 05/05/2018 11:56 AM, Scott Kostyshak wrote:
> > > The attached patch is an attempt to only show the "Accept Change" and
> > > "Reject Change" options in
2 Mon Sep 17 00:00:00 2001
From: Scott Kostyshak <skost...@lyx.org>
Date: Fri, 4 May 2018 18:21:54 -0400
Subject: [PATCH] Only show Accept/Reject Change options if relevant
In the context menu for a selection, we now only show the options
"Accept Change" and "Reject Change"
On 05/05/2018 11:56 AM, Scott Kostyshak wrote:
> The attached patch is an attempt to only show the "Accept Change" and
> "Reject Change" options in the context menu when there is a change in
> the selection.
>
> It works well except if the selection is inside an inset. For example,
> when in a LyX
ak <skost...@lyx.org>
Date: Fri, 4 May 2018 18:21:54 -0400
Subject: [PATCH] Only show Accept/Reject Change options if relevant
In the context menu for a selection, we now only show the options
"Accept Change" and "Reject Change" if there are actually cha
14 matches
Mail list logo
