Re: List of renamings and merges? (Was:....)

2007-05-02 Thread christian . ridderstrom
On Mon, 30 Apr 2007, Andre Poenitz wrote: svn log insets/InsetEnvironment.cpp and manual parse of log messages. In that case, it'd be enough to place the instructions on how to do it somewhere. I think a list is nevertheless a good idea... I was hoping Bo for instance would have a script

Re: List of renamings and merges? (Was:....)

2007-05-02 Thread christian . ridderstrom
On Mon, 30 Apr 2007, Andre Poenitz wrote: svn log insets/InsetEnvironment.cpp and manual parse of log messages. In that case, it'd be enough to place the instructions on how to do it somewhere. I think a list is nevertheless a good idea... I was hoping Bo for instance would have a script

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-30 Thread Abdelrazak Younes
Andre Poenitz wrote: On Mon, Apr 30, 2007 at 01:06:18AM +0200, Uwe Stöhr wrote: On Windows I have of course only FAT and NTFS, in my case only NTFS. This 'of course' is a limitation imposed by yourself. You are going a bit far here :-) There is no problem to have e.g. ext2 partitions

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-30 Thread Martin Vermeer
On Mon, Apr 30, 2007 at 12:37:44AM +0200, Andre Poenitz wrote: On Sun, Apr 29, 2007 at 11:50:08PM +0200, Abdelrazak Younes wrote: Let's please drop this discussion that will get us nowhere. What's done is done. Andre' is obviously a very competent programmer and he knows what he is doing.

Re: List of renamings and merges? (Was:....)

2007-04-30 Thread José Matos
On Monday 30 April 2007 02:08:10 [EMAIL PROTECTED] wrote: Would it be useful to place list somewhere with the files that were renamed and/or merged?  (The list should of course include the name before as well as after). It would be nice. But notice that there are several stages in the

Re: List of renamings and merges? (Was:....)

2007-04-30 Thread christian . ridderstrom
On Mon, 30 Apr 2007, José Matos wrote: On Monday 30 April 2007 02:08:10 [EMAIL PROTECTED] wrote: Would it be useful to place list somewhere with the files that were renamed and/or merged?  (The list should of course include the name before as well as after). It would be nice. But notice

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-30 Thread Andre Poenitz
On Mon, Apr 30, 2007 at 09:47:20AM +0200, Abdelrazak Younes wrote: Andre Poenitz wrote: On Mon, Apr 30, 2007 at 01:06:18AM +0200, Uwe Stöhr wrote: On Windows I have of course only FAT and NTFS, in my case only NTFS. This 'of course' is a limitation imposed by yourself. You are going a bit

Re: List of renamings and merges? (Was:....)

2007-04-30 Thread Andre Poenitz
On Mon, Apr 30, 2007 at 03:08:10AM +0200, [EMAIL PROTECTED] wrote: Would it be useful to place list somewhere with the files that were renamed and/or merged? (The list should of course include the name before as well as after). Good idea. Andre'

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-30 Thread Andre Poenitz
On Mon, Apr 30, 2007 at 03:16:33AM +0200, Uwe Stöhr wrote: SVN was _not_ broken. First, you need not. svn help mv. URL-URL is the interesting part, just rename one of the 'offending' files, run 'svn up' and be done. TortoiseSVN suggested I should cleanup the tree but this doesn't help. My

Re: List of renamings and merges? (Was:....)

2007-04-30 Thread Andre Poenitz
On Mon, Apr 30, 2007 at 01:50:56PM +0200, [EMAIL PROTECTED] wrote: On Mon, 30 Apr 2007, José Matos wrote: On Monday 30 April 2007 02:08:10 [EMAIL PROTECTED] wrote: Would it be useful to place list somewhere with the files that were renamed and/or merged?  (The list should of course include

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-30 Thread Abdelrazak Younes
Andre Poenitz wrote: On Mon, Apr 30, 2007 at 01:06:18AM +0200, Uwe Stöhr wrote: On Windows I have of course only FAT and NTFS, in my case only NTFS. This 'of course' is a limitation imposed by yourself. You are going a bit far here :-) There is no problem to have e.g. ext2 partitions

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-30 Thread Martin Vermeer
On Mon, Apr 30, 2007 at 12:37:44AM +0200, Andre Poenitz wrote: > On Sun, Apr 29, 2007 at 11:50:08PM +0200, Abdelrazak Younes wrote: > > Let's please drop this discussion that will get us nowhere. What's done > > is done. Andre' is obviously a very competent programmer and he knows > > what he is

Re: List of renamings and merges? (Was:....)

2007-04-30 Thread José Matos
On Monday 30 April 2007 02:08:10 [EMAIL PROTECTED] wrote: > Would it be useful to place list somewhere with the files that were > renamed and/or merged?  (The list should of course include the name before > as well as after). It would be nice. But notice that there are several stages in the

Re: List of renamings and merges? (Was:....)

2007-04-30 Thread christian . ridderstrom
On Mon, 30 Apr 2007, José Matos wrote: On Monday 30 April 2007 02:08:10 [EMAIL PROTECTED] wrote: Would it be useful to place list somewhere with the files that were renamed and/or merged?  (The list should of course include the name before as well as after). It would be nice. But notice

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-30 Thread Andre Poenitz
On Mon, Apr 30, 2007 at 09:47:20AM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >On Mon, Apr 30, 2007 at 01:06:18AM +0200, Uwe Stöhr wrote: > >>On Windows I have of course only FAT and NTFS, in my case only NTFS. > > > >This 'of course' is a limitation imposed by yourself. > > You are

Re: List of renamings and merges? (Was:....)

2007-04-30 Thread Andre Poenitz
On Mon, Apr 30, 2007 at 03:08:10AM +0200, [EMAIL PROTECTED] wrote: > Would it be useful to place list somewhere with the files that were > renamed and/or merged? (The list should of course include the name before > as well as after). Good idea. Andre'

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-30 Thread Andre Poenitz
On Mon, Apr 30, 2007 at 03:16:33AM +0200, Uwe Stöhr wrote: > >>>SVN was _not_ broken. > > >First, you need not. svn help mv. URL->URL is the interesting part, > >just rename one of the 'offending' files, run 'svn up' and be done. > > TortoiseSVN suggested I should cleanup the tree but this

Re: List of renamings and merges? (Was:....)

2007-04-30 Thread Andre Poenitz
On Mon, Apr 30, 2007 at 01:50:56PM +0200, [EMAIL PROTECTED] wrote: > On Mon, 30 Apr 2007, José Matos wrote: > > >On Monday 30 April 2007 02:08:10 [EMAIL PROTECTED] wrote: > >>Would it be useful to place list somewhere with the files that were > >>renamed and/or merged?  (The list should of course

Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Uwe Stöhr
I'm very displeased by the renamng actions you did the last week. This was absolutely unnecessary, we just have released a second beta and our exercise is to fix the remaining bugs to be able to release LyX 1.5.0. Sorry, but why did you mean we have to change our complete infrastructure while

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Abdelrazak Younes
Uwe Stöhr wrote: I'm very displeased by the renamng actions you did the last week. This was absolutely unnecessary, we just have released a second beta and our exercise is to fix the remaining bugs to be able to release LyX 1.5.0. Please calm down Uwe, the renaming was discussed and approved

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Andre Poenitz
was to ease maintanance of a stable and a development branch when basically all files change. Sorry, but why did you mean we have to change our complete infrastructure while we are close to a stable release? Hunt the archive. Doing the renamings _now_ was discussed and approved by several people. I don't

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Uwe Stöhr
, just because we are humans and might forget somethig. What is displeasing me are renamings like LyXServer - Server, there's no real advantage and this could also be done at the beginning of the LyX 1.6 development. We now also lost the SVN version history that was very important to be able

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Uwe Stöhr
Uwe Stöhr schrieb: We will see. Most of the changes were of the type 'safe if it compiles afterwards'. I forgot to mention the SVN problems. You blocked the SVN checkout by Color.h and color.h some days ago and now again by Layout.h and layout.h. That an example of the problems I

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Abdelrazak Younes
Uwe Stöhr wrote: Uwe Stöhr schrieb: We will see. Most of the changes were of the type 'safe if it compiles afterwards'. I forgot to mention the SVN problems. You blocked the SVN checkout by Color.h and color.h some days ago and now again by Layout.h and layout.h. That an example of the

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread José Matos
On Sunday 29 April 2007 18:21:34 Uwe Stöhr wrote: I'm very displeased by the renamng actions you did the last week. This was absolutely unnecessary, we just have released a second beta and our exercise is to fix the remaining bugs to be able to release LyX 1.5.0. Uwe, this was said before but

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Andre Poenitz
On Sun, Apr 29, 2007 at 11:38:58PM +0200, Uwe Stöhr wrote: Does anybody know this method? Anybody? Yes, obviously... But besides this, now also many of the 1.5 patches in Bugzilla have the be rewritten. For me it was not easy to follow e.g. where for example a patch to tabular.C is to be

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Andre Poenitz
On Sun, Apr 29, 2007 at 11:46:17PM +0200, Uwe Stöhr wrote: Uwe Stöhr schrieb: We will see. Most of the changes were of the type 'safe if it compiles afterwards'. I forgot to mention the SVN problems. You blocked the SVN checkout by Color.h and color.h some days ago and now again by

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Andre Poenitz
On Sun, Apr 29, 2007 at 11:50:08PM +0200, Abdelrazak Younes wrote: Let's please drop this discussion that will get us nowhere. What's done is done. Andre' is obviously a very competent programmer and he knows what he is doing. I sometimes think I know what I am doing. But the fact that we

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Uwe Stöhr
got a totally broken tree. On Windows I have of course only FAT and NTFS, in my case only NTFS. Andre' is obviously a very competent programmer and he knows what he is doing. Have I ever said something different? I just wasn't happy that he didn't thought about all consequences of the renamings

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Andre Poenitz
different? I just wasn't happy that he didn't thought about all consequences of the renamings. To be precise: I chose not to care too much. I knew that I will be around all the time, so at worst there's a lag of a few hours in case something goes wrong until it get fixed. If I'd double checked

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Uwe Stöhr
Andre Poenitz schrieb: SVN was _not_ broken. First, you need not. svn help mv. URL-URL is the interesting part, just rename one of the 'offending' files, run 'svn up' and be done. TortoiseSVN suggested I should cleanup the tree but this doesn't help. My SVN makes lots of troubles and

List of renamings and merges? (Was:....)

2007-04-29 Thread christian . ridderstrom
Would it be useful to place list somewhere with the files that were renamed and/or merged? (The list should of course include the name before as well as after). /Christian -- Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr

Re: List of renamings and merges? (Was:....)

2007-04-29 Thread Bo Peng
On 4/29/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Would it be useful to place list somewhere with the files that were renamed and/or merged? (The list should of course include the name before as well as after). About half of my changes are documented in svn log messages. Bo

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Bo Peng
SVN was _not_ broken. I second that. If you have color.h and it renames to Color.h, windows will complain. You can always remove color.h and 'svn update'. In the worst case, you can remove the whole source tree and update. Cheers, Bo

Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Uwe Stöhr
I'm very displeased by the renamng actions you did the last week. This was absolutely unnecessary, we just have released a second beta and our exercise is to fix the remaining bugs to be able to release LyX 1.5.0. Sorry, but why did you mean we have to change our complete infrastructure while

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Abdelrazak Younes
Uwe Stöhr wrote: I'm very displeased by the renamng actions you did the last week. This was absolutely unnecessary, we just have released a second beta and our exercise is to fix the remaining bugs to be able to release LyX 1.5.0. Please calm down Uwe, the renaming was discussed and approved

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Andre Poenitz
The idea was to ease maintanance of a stable and a development branch when basically all files change. > Sorry, but why did you mean we have to change our complete infrastructure > while we are close to a stable release? Hunt the archive. Doing the renamings _now_ was discussed and approved by se

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Uwe Stöhr
ot;. I mean the dialog source code merge is error prone, just because we are humans and might forget somethig. What is displeasing me are renamings like "LyXServer" -> "Server", there's no real advantage and this could also be done at the beginning of the LyX 1.6 developm

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Uwe Stöhr
Uwe Stöhr schrieb: > We will see. Most of the changes were of the type 'safe if it compiles > afterwards'. I forgot to mention the SVN problems. You blocked the SVN checkout by "Color.h" and "color.h" some days ago and now again by "Layout.h" and "layout.h". That an example of the problems

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Abdelrazak Younes
Uwe Stöhr wrote: Uwe Stöhr schrieb: > We will see. Most of the changes were of the type 'safe if it compiles > afterwards'. I forgot to mention the SVN problems. You blocked the SVN checkout by "Color.h" and "color.h" some days ago and now again by "Layout.h" and "layout.h". That an

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread José Matos
On Sunday 29 April 2007 18:21:34 Uwe Stöhr wrote: > I'm very displeased by the renamng actions you did the last week. This was > absolutely unnecessary, we just have released a second beta and our > exercise is to fix the remaining bugs to be able to release LyX 1.5.0. Uwe, this was said before

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Andre Poenitz
On Sun, Apr 29, 2007 at 11:38:58PM +0200, Uwe Stöhr wrote: > Does anybody know this method? "Anybody"? Yes, obviously... > But besides this, now also many of the 1.5 > patches in Bugzilla have the be rewritten. For me it was not easy to follow > e.g. where for example a patch to tabular.C is

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Andre Poenitz
On Sun, Apr 29, 2007 at 11:46:17PM +0200, Uwe Stöhr wrote: > Uwe Stöhr schrieb: > > > > We will see. Most of the changes were of the type 'safe if it compiles > > > afterwards'. > > I forgot to mention the SVN problems. You blocked the SVN checkout by > "Color.h" and "color.h" some days ago and

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Andre Poenitz
On Sun, Apr 29, 2007 at 11:50:08PM +0200, Abdelrazak Younes wrote: > Let's please drop this discussion that will get us nowhere. What's done > is done. Andre' is obviously a very competent programmer and he knows > what he is doing. I sometimes think I know what I am doing. But the fact that

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Uwe Stöhr
't thought about all consequences of the renamings. I hope you can understand that I'm not very happy as I have three times this week to check out the sources completely to a new tree because it was broken after SVN checkout trys. I think we can close this discussion now as it was not my intention

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Andre Poenitz
iously a very competent programmer and he knows what > >> he is doing. > > Have I ever said something different? I just wasn't happy that he > didn't thought about all consequences of the renamings. To be precise: I chose not to care too much. I knew that I will be around all the t

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Uwe Stöhr
Andre Poenitz schrieb: SVN was _not_ broken. First, you need not. svn help mv. URL->URL is the interesting part, just rename one of the 'offending' files, run 'svn up' and be done. TortoiseSVN suggested I should cleanup the tree but this doesn't help. My SVN makes lots of troubles and

List of renamings and merges? (Was:....)

2007-04-29 Thread christian . ridderstrom
Would it be useful to place list somewhere with the files that were renamed and/or merged? (The list should of course include the name before as well as after). /Christian -- Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr

Re: List of renamings and merges? (Was:....)

2007-04-29 Thread Bo Peng
On 4/29/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Would it be useful to place list somewhere with the files that were renamed and/or merged? (The list should of course include the name before as well as after). About half of my changes are documented in svn log messages. Bo

Re: Stop the renamings now!!! was: More file/class name changes?

2007-04-29 Thread Bo Peng
>>> SVN was _not_ broken. I second that. If you have color.h and it renames to Color.h, windows will complain. You can always remove color.h and 'svn update'. In the worst case, you can remove the whole source tree and update. Cheers, Bo

Renamings

2007-04-26 Thread Andre Poenitz
So... definitely a step in the right direction. I've a few issues left: 1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. I mean, it is clear that 'LyXLayout' in src/ has something todo with LyX, isn't it. Of course this mean 2. rowpainter.cpp is all about a class

Re: Renamings

2007-04-26 Thread José Matos
On Thursday 26 April 2007 8:29:43 am Andre Poenitz wrote: So... definitely a step in the right direction. I've a few issues left: 1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. I mean, it is clear that 'LyXLayout' in src/ has something todo with LyX, isn't it. Of

Re: Renamings

2007-04-26 Thread Bo Peng
1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. I mean, it is clear that 'LyXLayout' in src/ has something todo with LyX, isn't it. Of course this mean 2. rowpainter.cpp is all about a class RowPainter, which is used only locally, so it does not show up in the .h. I'd

Re: Renamings

2007-04-26 Thread Stephan Witt
Andre Poenitz wrote: So... definitely a step in the right direction. I've a few issues left: 1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. I mean, it is clear that 'LyXLayout' in src/ has something todo with LyX, isn't it. Of course this mean 2. rowpainter.cpp

Re: Renamings

2007-04-26 Thread Andre Poenitz
On Thu, Apr 26, 2007 at 08:05:56AM -0500, Bo Peng wrote: 1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. I mean, it is clear that 'LyXLayout' in src/ has something todo with LyX, isn't it. Of course this mean 2. rowpainter.cpp is all about a class RowPainter, which is

Re: Renamings

2007-04-26 Thread Andre Poenitz
On Thu, Apr 26, 2007 at 03:33:45PM +0200, Stephan Witt wrote: Andre Poenitz wrote: So... definitely a step in the right direction. I've a few issues left: 1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. I mean, it is clear that 'LyXLayout' in src/ has something

Re: Renamings

2007-04-26 Thread Stephan Witt
Andre Poenitz wrote: On Thu, Apr 26, 2007 at 03:33:45PM +0200, Stephan Witt wrote: Andre Poenitz wrote: So... definitely a step in the right direction. I've a few issues left: 1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. I mean, it is clear that 'LyXLayout' in src/

Renamings

2007-04-26 Thread Andre Poenitz
So... definitely a step in the right direction. I've a few issues left: 1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. I mean, it is clear that 'LyXLayout' in src/ has something todo with LyX, isn't it. Of course this mean 2. rowpainter.cpp is all about a class

Re: Renamings

2007-04-26 Thread José Matos
On Thursday 26 April 2007 8:29:43 am Andre Poenitz wrote: > So... definitely a step in the right direction. > > I've a few issues left: > > 1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. >I mean, it is clear that 'LyXLayout' in src/ has something todo with >LyX, isn't

Re: Renamings

2007-04-26 Thread Bo Peng
1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. I mean, it is clear that 'LyXLayout' in src/ has something todo with LyX, isn't it. Of course this mean 2. rowpainter.cpp is all about a class RowPainter, which is used only locally, so it does not show up in the .h. I'd

Re: Renamings

2007-04-26 Thread Stephan Witt
Andre Poenitz wrote: > So... definitely a step in the right direction. > > I've a few issues left: > > 1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. >I mean, it is clear that 'LyXLayout' in src/ has something todo with >LyX, isn't it. Of course this mean > > 2.

Re: Renamings

2007-04-26 Thread Andre Poenitz
On Thu, Apr 26, 2007 at 08:05:56AM -0500, Bo Peng wrote: > >1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. > > I mean, it is clear that 'LyXLayout' in src/ has something todo with > > LyX, isn't it. Of course this mean > > > >2. rowpainter.cpp is all about a class

Re: Renamings

2007-04-26 Thread Andre Poenitz
On Thu, Apr 26, 2007 at 03:33:45PM +0200, Stephan Witt wrote: > Andre Poenitz wrote: > > So... definitely a step in the right direction. > > > > I've a few issues left: > > > > 1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. > >I mean, it is clear that 'LyXLayout' in src/

Re: Renamings

2007-04-26 Thread Stephan Witt
Andre Poenitz wrote: > On Thu, Apr 26, 2007 at 03:33:45PM +0200, Stephan Witt wrote: >> Andre Poenitz wrote: >>> So... definitely a step in the right direction. >>> >>> I've a few issues left: >>> >>> 1. I'd like to get rid of the 'LyX'/'L' prefix whenever possible. >>>I mean, it is clear that

Re: File renamings after beta 2?

2007-04-24 Thread Jean-Marc Lasgouttes
Bernhard == Bernhard Roider [EMAIL PROTECTED] writes: Bernhard I remember that .cc is often used instead of .cpp or .C (at Bernhard least in linux?) Here is what the C++ FAQ has to say: http://www.parashift.com/c++-faq-lite/coding-standards.html#faq-27.8 Basically: If you already have a

renamings (2)

2007-04-24 Thread Andre Poenitz
I just renamed the .ui files. This was straightforward. However, the stuff in qt4/* is harder as there'll be clashes with headers in src/*.h. So I'd keep it as it is at the moment and rather merge QFooDialog.[Ch] into QFoo.[Ch] whenever it makes sense. The dependencies are pretty strong

Re: renamings (2)

2007-04-24 Thread Andre Poenitz
On Tue, Apr 24, 2007 at 11:14:03AM +0200, Andre Poenitz wrote: I just renamed the .ui files. This was straightforward. However, the stuff in qt4/* is harder as there'll be clashes with headers in src/*.h. So I'd keep it as it is at the moment and rather merge QFooDialog.[Ch] into

Re: renamings (2)

2007-04-24 Thread Abdelrazak Younes
Andre Poenitz wrote: I just renamed the .ui files. This was straightforward. However, the stuff in qt4/* is harder as there'll be clashes with headers in src/*.h. So I'd keep it as it is at the moment and rather merge QFooDialog.[Ch] into QFoo.[Ch] whenever it makes sense. The dependencies

Re: renamings (2)

2007-04-24 Thread Andre Poenitz
this would be non-mechanical, i.e. post-1.5.0 stuff. The main reason for the renamings _now_ was that patches later will easier apply to 1.5.x and 1.6.x-svn. Or FooWidget? I'd like to get rid of the QDialog inheritance and switch to QWidget for all dialogs (so that it can be embedded in other

Re: renamings (2)

2007-04-24 Thread Jean-Marc Lasgouttes
into one file. I have Andre not thought too much about the latter, in any case this would Andre be non-mechanical, i.e. post-1.5.0 stuff. Andre The main reason for the renamings _now_ was that patches later Andre will easier apply to 1.5.x and 1.6.x-svn. +1 JMarc

Re: renamings (2)

2007-04-24 Thread José Matos
On Tuesday 24 April 2007 11:07:04 am Jean-Marc Lasgouttes wrote: Andre The main reason for the renamings _now_ was that patches later Andre will easier apply to 1.5.x and 1.6.x-svn. +1 That is the single reason to do it now. :-) JMarc -- José Abílio

Re: renamings (2)

2007-04-24 Thread Abdelrazak Younes
the latter, in any case this would be non-mechanical, i.e. post-1.5.0 stuff. The main reason for the renamings _now_ was that patches later will easier apply to 1.5.x and 1.6.x-svn. OK. Or FooWidget? I'd like to get rid of the QDialog inheritance and switch to QWidget for all dialogs (so

Re: File renamings after beta 2?

2007-04-24 Thread Bo Peng
s/QBox.C/Box.C/g s/QBox.h/Box.h/g Andre, I find a serious problem with these renames. First, it does not follow our policy that class name matching file name. Second, these changes lead to co-existence of src/Box.h and src/frontends/qt4/Box.h etc, and #include Box.h may lead to error. Bo

Re: File renamings after beta 2?

2007-04-24 Thread Andre Poenitz
-existence of src/Box.h and src/frontends/qt4/Box.h etc, and #include Box.h may lead to error. That's one of the reasons I postponed these renamings. Andre'

Re: File renamings after beta 2?

2007-04-24 Thread Jean-Marc Lasgouttes
> "Bernhard" == Bernhard Roider <[EMAIL PROTECTED]> writes: Bernhard> I remember that .cc is often used instead of .cpp or .C (at Bernhard> least in linux?) Here is what the C++ FAQ has to say: http://www.parashift.com/c++-faq-lite/coding-standards.html#faq-27.8 Basically: "If you already

renamings (2)

2007-04-24 Thread Andre Poenitz
I just renamed the .ui files. This was straightforward. However, the stuff in qt4/* is harder as there'll be clashes with headers in src/*.h. So I'd keep it as it is at the moment and rather merge QFooDialog.[Ch] into QFoo.[Ch] whenever it makes sense. The dependencies are pretty strong

Re: renamings (2)

2007-04-24 Thread Andre Poenitz
On Tue, Apr 24, 2007 at 11:14:03AM +0200, Andre Poenitz wrote: > > I just renamed the .ui files. This was straightforward. However, the > stuff in qt4/* is harder as there'll be clashes with headers in src/*.h. > > So I'd keep it as it is at the moment and rather merge QFooDialog.[Ch] > into

Re: renamings (2)

2007-04-24 Thread Abdelrazak Younes
Andre Poenitz wrote: I just renamed the .ui files. This was straightforward. However, the stuff in qt4/* is harder as there'll be clashes with headers in src/*.h. So I'd keep it as it is at the moment and rather merge QFooDialog.[Ch] into QFoo.[Ch] whenever it makes sense. The dependencies

Re: renamings (2)

2007-04-24 Thread Andre Poenitz
ht too much about the latter, in any case this would be non-mechanical, i.e. post-1.5.0 stuff. The main reason for the renamings _now_ was that patches later will easier apply to 1.5.x and 1.6.x-svn. > Or FooWidget? I'd like to get rid of the QDialog inheritance and switch > to QWidget f

Re: renamings (2)

2007-04-24 Thread Jean-Marc Lasgouttes
uot; or "merging the two classes"? Andre> Right now I mean "putting two classes into one file". I have Andre> not thought too much about the latter, in any case this would Andre> be non-mechanical, i.e. post-1.5.0 stuff. Andre> The main reason for the renamings _now_ was that patches later Andre> will easier apply to 1.5.x and 1.6.x-svn. +1 JMarc

Re: renamings (2)

2007-04-24 Thread José Matos
On Tuesday 24 April 2007 11:07:04 am Jean-Marc Lasgouttes wrote: > Andre> The main reason for the renamings _now_ was that patches later > Andre> will easier apply to 1.5.x and 1.6.x-svn. > > +1 That is the single reason to do it now. :-) > JMarc -- José Abílio

Re: renamings (2)

2007-04-24 Thread Abdelrazak Younes
;. I have not thought too much about the latter, in any case this would be non-mechanical, i.e. post-1.5.0 stuff. The main reason for the renamings _now_ was that patches later will easier apply to 1.5.x and 1.6.x-svn. OK. Or FooWidget? I'd like to get rid of the QDialog inheritance and switch

Re: File renamings after beta 2?

2007-04-24 Thread Bo Peng
s/QBox.C/Box.C/g s/QBox.h/Box.h/g Andre, I find a serious problem with these renames. First, it does not follow our policy that class name matching file name. Second, these changes lead to co-existence of src/Box.h and src/frontends/qt4/Box.h etc, and #include "Box.h" may lead to error. Bo

Re: File renamings after beta 2?

2007-04-24 Thread Andre Poenitz
ly > Second, these changes > lead to co-existence of src/Box.h and src/frontends/qt4/Box.h etc, and > #include "Box.h" may lead to error. That's one of the reasons I postponed these renamings. Andre'

Re: File renamings after beta 2?

2007-04-23 Thread christian . ridderstrom
On Sun, 22 Apr 2007, Bo Peng wrote: I am thinking about something like s/QL//g and s/Q//g in src/frontends/qt4. And all .C to .cpp? Why? (I don't remember a consesus for that, but then again I'm lazy as I don't go and look...) /C -- Christian Ridderström, +46-8-768 39 44

Re: File renamings after beta 2?

2007-04-23 Thread Jean-Marc Lasgouttes
Andre == Andre Poenitz [EMAIL PROTECTED] writes: Andre Just to make sure: Did we kind of agree some time ago that Andre 'after beta 2' was a good time to rename classes and files? Andre I am thinking about something like s/QL//g and s/Q//g in Andre src/frontends/qt4. Note that we have to be

Re: File renamings after beta 2?

2007-04-23 Thread Andre Poenitz
On Mon, Apr 23, 2007 at 10:51:55AM +0200, [EMAIL PROTECTED] wrote: I am thinking about something like s/QL//g and s/Q//g in src/frontends/qt4. And all .C to .cpp? Why? (I don't remember a consesus for that, but then again I'm lazy as I don't go and look...) Consensus was along the

Re: File renamings after beta 2?

2007-04-23 Thread Andre Poenitz
On Mon, Apr 23, 2007 at 11:07:43AM +0200, Jean-Marc Lasgouttes wrote: Andre == Andre Poenitz [EMAIL PROTECTED] writes: Andre Just to make sure: Did we kind of agree some time ago that Andre 'after beta 2' was a good time to rename classes and files? Andre I am thinking about something

Re: File renamings after beta 2?

2007-04-23 Thread Andre Poenitz
Complain now or never: s/LyXKeySymFactory.C/KeySymFactory.C/g s/QAbout.C/About.C/g s/QAbout.h/About.h/g s/QAboutDialog.C/AboutDialog.C/g s/QAboutDialog.h/AboutDialog.h/g s/QBibitem.C/Bibitem.C/g s/QBibitem.h/Bibitem.h/g s/QBibitemDialog.C/BibitemDialog.C/g s/QBibitemDialog.h/BibitemDialog.h/g

Re: File renamings after beta 2?

2007-04-23 Thread Abdelrazak Younes
Andre Poenitz wrote: On Mon, Apr 23, 2007 at 10:51:55AM +0200, [EMAIL PROTECTED] wrote: I am thinking about something like s/QL//g and s/Q//g in src/frontends/qt4. And all .C to .cpp? Why? (I don't remember a consesus for that, but then again I'm lazy as I don't go and look...) Consensus

Re: File renamings after beta 2?

2007-04-23 Thread christian . ridderstrom
On Mon, 23 Apr 2007, Abdelrazak Younes wrote: Andre Poenitz wrote: On Mon, Apr 23, 2007 at 10:51:55AM +0200, [EMAIL PROTECTED] wrote: I am thinking about something like s/QL//g and s/Q//g in src/frontends/qt4. And all .C to .cpp? Why? (I don't remember a consesus for that,

Re: File renamings after beta 2?

2007-04-23 Thread Martin Vermeer
On Mon, 23 Apr 2007 11:18:45 +0200 Andre Poenitz [EMAIL PROTECTED] wrote: On Mon, Apr 23, 2007 at 10:51:55AM +0200, [EMAIL PROTECTED] wrote: I am thinking about something like s/QL//g and s/Q//g in src/frontends/qt4. And all .C to .cpp? Why? (I don't remember a consesus for

Re: File renamings after beta 2?

2007-04-23 Thread José Matos
On Monday 23 April 2007 12:26:51 pm [EMAIL PROTECTED] wrote: Guess I'm in the 'don't care' camp. The only advantage I can think of for .C is that you can then do e.g. ls Dialog.[Ch] That is easier to write than ls Dialog.{cpp,h} But not by much. :-) /Christian -- José Abílio

Re: File renamings after beta 2?

2007-04-23 Thread Andre Poenitz
On Mon, Apr 23, 2007 at 03:06:36PM +0300, Martin Vermeer wrote: I remember being opposed. .cpp, .hpp is a windowsism. So how 'opposed' are you? Andre'

Re: File renamings after beta 2?

2007-04-23 Thread Bo Peng
On 4/23/07, Andre Poenitz [EMAIL PROTECTED] wrote: On Mon, Apr 23, 2007 at 03:06:36PM +0300, Martin Vermeer wrote: I remember being opposed. .cpp, .hpp is a windowsism. Yeap. One of the problems with .C is that .c and .C are the same under windows, and caused some trouble in scons (which I

Re: File renamings after beta 2?

2007-04-23 Thread Bo Peng
And standardization of lyxfunc, lyx_cb etc? By this I mean: LyXAction lyx_cb lyxfind lyxgluelength lyxtextclasslist cursor_slice to LyxAction LyxCB (what is cb?) LyxFind LyxGlueLength LyxTextClassList CursorSlice or lyx_action lyx_cb lyx_find lyx_glue_length lyx_textclasslist cursor_slice

Re: File renamings after beta 2?

2007-04-23 Thread Abdelrazak Younes
Bo Peng wrote: And standardization of lyxfunc, lyx_cb etc? By this I mean: LyXAction lyx_cb lyxfind lyxgluelength lyxtextclasslist cursor_slice to LyxAction LyxCB (what is cb?) This should eventually go in 1.6. LyxFind LyxGlueLength LyxTextClassList CursorSlice or lyx_action lyx_cb

Re: File renamings after beta 2?

2007-04-23 Thread José Matos
On Monday 23 April 2007 3:59:48 pm Bo Peng wrote: LyxCB (what is cb?) Callback, this has been in the code since (at least) version 0.5. :-) -- José Abílio

Re: File renamings after beta 2?

2007-04-23 Thread Martin Vermeer
On Mon, 23 Apr 2007 15:53:32 +0200 Andre Poenitz [EMAIL PROTECTED] wrote: On Mon, Apr 23, 2007 at 03:06:36PM +0300, Martin Vermeer wrote: I remember being opposed. .cpp, .hpp is a windowsism. So how 'opposed' are you? Andre' Hmmm... I am just in the mood to be opposed. If there is a

Re: File renamings after beta 2?

2007-04-23 Thread Martin Vermeer
On Mon, 23 Apr 2007 07:50:39 -0700 Bo Peng [EMAIL PROTECTED] wrote: On 4/23/07, Andre Poenitz [EMAIL PROTECTED] wrote: On Mon, Apr 23, 2007 at 03:06:36PM +0300, Martin Vermeer wrote: I remember being opposed. .cpp, .hpp is a windowsism. Yeap. One of the problems with .C is that .c and .C

  1   2   >