Re: Trivial patch review request

2019-08-15 Thread Scott Kostyshak
On Thu, Aug 15, 2019 at 07:26:44AM -0600, Joel Kulesza wrote: > On Wed, Aug 14, 2019 at 5:35 PM Scott Kostyshak wrote: > > > On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > > > > > Hopefully my activity in the credits > > > isn't seen as too vain. > > > > Not at all. I hope my

Re: Trivial patch review request

2019-08-15 Thread Joel Kulesza
On Wed, Aug 14, 2019 at 5:35 PM Scott Kostyshak wrote: > On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > > > Hopefully my activity in the credits > > isn't seen as too vain. > > Not at all. I hope my attempt at humor wasn't what made you think that. > Whenever I attempt to make a

Re: Trivial patch review request

2019-08-14 Thread Scott Kostyshak
On Wed, Aug 14, 2019 at 07:32:45PM -0400, Scott Kostyshak wrote: > On Wed, Aug 14, 2019 at 12:14:02PM -0600, Joel Kulesza wrote: > > > Sorry for the quick follow-up, but Riki alerted me offline that the CREDITS > > file is generated from generate_contributors.py so this fix (and the others > > I

Re: Trivial patch review request

2019-08-14 Thread Scott Kostyshak
On Wed, Aug 14, 2019 at 12:10:46PM -0600, Joel Kulesza wrote: > Riki took care of this not long after I'd sent it, so I think we're good > but I appreciate you following up! Ah good to know. > Hopefully my activity in the credits > isn't seen as too vain. Not at all. I hope my attempt at humor

Re: Trivial patch review request

2019-08-14 Thread Scott Kostyshak
On Wed, Aug 14, 2019 at 12:14:02PM -0600, Joel Kulesza wrote: > Sorry for the quick follow-up, but Riki alerted me offline that the CREDITS > file is generated from generate_contributors.py so this fix (and the others > I see you just made) are needed there. Ah good to know. I just ported the

Re: Trivial patch review request

2019-08-14 Thread Joel Kulesza
On Wed, Aug 14, 2019 at 12:10 PM Joel Kulesza wrote: > On Wed, Aug 14, 2019 at 11:08 AM Scott Kostyshak wrote: > >> On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: >> > LyX Developers, >> > >> > Can someone please review/incorporate the attached, trivial, patch, >> which >> >

Re: Trivial patch review request

2019-08-14 Thread Joel Kulesza
On Wed, Aug 14, 2019 at 11:08 AM Scott Kostyshak wrote: > On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: > > LyX Developers, > > > > Can someone please review/incorporate the attached, trivial, patch, which > > corrects a typo in the credits? > > > > Please let me know if a

Re: Trivial patch review request

2019-08-14 Thread Scott Kostyshak
On Wed, Jul 24, 2019 at 09:10:00PM -0600, Joel Kulesza wrote: > LyX Developers, > > Can someone please review/incorporate the attached, trivial, patch, which > corrects a typo in the credits? > > Please let me know if a tracker issue is warranted. > > Otherwise, please contact me with any

Trivial patch review request

2019-07-24 Thread Joel Kulesza
LyX Developers, Can someone please review/incorporate the attached, trivial, patch, which corrects a typo in the credits? Please let me know if a tracker issue is warranted. Otherwise, please contact me with any comments, questions, or concerns. Thank you, Joel