Re: Various table trouble

2005-04-26 Thread Jean-Marc Lasgouttes
Georg == Georg Baum [EMAIL PROTECTED] writes: Agreed. Also, I'd rather have a signature like virtual FuncStatus getStatus() const; since it is more in line with what LyXFunc does. Georg Yes, but we need only the boolean value here. Things like Georg virtual bool getStatus() const { return

Re: Various table trouble

2005-04-26 Thread Georg Baum
Jean-Marc Lasgouttes wrote: Georg == Georg Baum [EMAIL PROTECTED] writes: Agreed. Also, I'd rather have a signature like virtual FuncStatus getStatus() const; since it is more in line with what LyXFunc does. Georg Yes, but we need only the boolean value here. Things like Georg

Re: Various table trouble

2005-04-26 Thread Angus Leeming
Georg Baum wrote: PS: Angus, thanks for spotting one of my favourite spelling mistakes ;-) It's easy to get right if you pronounce it correctly :) http://evaeaston.com/pr/w-pr-weather.html -- Angus

Re: Various table trouble

2005-04-26 Thread Jean-Marc Lasgouttes
Georg == Georg Baum [EMAIL PROTECTED] writes: Georg I choose getStatus because it is nearly the same (and btw we Georg have already getStatus() functions with different signatures). But both versions fill a FuncStatus object. Georg But canApply() is fine with me, so I'll use that now. Thanks.

Re: Various table trouble

2005-04-26 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: >> Agreed. Also, I'd rather have a signature like virtual FuncStatus >> getStatus() const; since it is more in line with what LyXFunc does. Georg> Yes, but we need only the boolean value here. Things like Georg> virtual bool getStatus()

Re: Various table trouble

2005-04-26 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > >>> Agreed. Also, I'd rather have a signature like virtual FuncStatus >>> getStatus() const; since it is more in line with what LyXFunc does. > > Georg> Yes, but we need only the boolean value

Re: Various table trouble

2005-04-26 Thread Angus Leeming
Georg Baum wrote: > PS: Angus, thanks for spotting one of my favourite spelling mistakes ;-) It's easy to get right if you pronounce it correctly :) http://evaeaston.com/pr/w-pr-weather.html -- Angus

Re: Various table trouble

2005-04-26 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> I choose getStatus because it is nearly the same (and btw we Georg> have already getStatus() functions with different signatures). But both versions fill a FuncStatus object. Georg> But canApply() is fine with me, so I'll use that

Re: Various table trouble

2005-04-25 Thread Angus Leeming
Georg Baum wrote: Am Sonntag, 24. April 2005 13:12 schrieb Juergen Spitzmueller: Georg, we are talking about the Text Style dialog (a.k.a character dialog), not the char style inset. Does the patch really not enable the settings in that dialog for you? Sorry, that was a misunderstanding.

Re: Various table trouble

2005-04-25 Thread Juergen Spitzmueller
Georg Baum wrote: The attached patch fixes Dialog::checkStatus(). The dialog dependant part is now in Dialog::Controller::getStatus() and reimplemented in all dialogs that need it. OK to apply? fine with me. Jürgen

Re: Various table trouble

2005-04-25 Thread Jean-Marc Lasgouttes
Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus However, I wonder if it would not be nicer to have: [a getLFUN method] Agreed. Also, I'd rather have a signature like virtual FuncStatus getStatus() const; since it is more in line with what LyXFunc does. JMarc

Re: Various table trouble

2005-04-25 Thread Georg Baum
Jean-Marc Lasgouttes wrote: Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus However, I wonder if it would not be nicer to have: [a getLFUN method] Yes. Agreed. Also, I'd rather have a signature like virtual FuncStatus getStatus() const; since it is more in line with what LyXFunc

Re: Various table trouble

2005-04-25 Thread Angus Leeming
Georg Baum wrote: Angus However, I wonder if it would not be nicer to have: [a getLFUN method] Yes. Agreed. Also, I'd rather have a signature like virtual FuncStatus getStatus() const; since it is more in line with what LyXFunc does. Yes, but we need only the boolean value here.

Re: Various table trouble

2005-04-25 Thread Angus Leeming
Georg Baum wrote: > Am Sonntag, 24. April 2005 13:12 schrieb Juergen Spitzmueller: >> Georg, we are talking about the "Text Style" dialog (a.k.a "character >> dialog"), not the char style inset. Does the patch really not enable the >> settings in that dialog for you? > > Sorry, that was a

Re: Various table trouble

2005-04-25 Thread Juergen Spitzmueller
Georg Baum wrote: > The attached patch fixes Dialog::checkStatus(). The dialog dependant part > is now in Dialog::Controller::getStatus() and reimplemented in all > dialogs that need it. > > OK to apply? fine with me. Jürgen

Re: Various table trouble

2005-04-25 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> However, I wonder if it would not be nicer to have: [a getLFUN method] Agreed. Also, I'd rather have a signature like virtual FuncStatus getStatus() const; since it is more in line with what LyXFunc does. JMarc

Re: Various table trouble

2005-04-25 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Angus" == Angus Leeming <[EMAIL PROTECTED]> >> writes: > > Angus> However, I wonder if it would not be nicer to have: > [a getLFUN method] Yes. > Agreed. Also, I'd rather have a signature like > virtual FuncStatus getStatus() const; > since it is more in

Re: Various table trouble

2005-04-25 Thread Angus Leeming
Georg Baum wrote: >> Angus> However, I wonder if it would not be nicer to have: >> [a getLFUN method] > > Yes. > >> Agreed. Also, I'd rather have a signature like >> virtual FuncStatus getStatus() const; >> since it is more in line with what LyXFunc does. > > Yes, but we need only the boolean

Re: Various table trouble

2005-04-24 Thread Georg Baum
Am Samstag, 23. April 2005 15:21 schrieb Juergen Spitzmueller: Helge Hafting wrote: * One may select several table cells and apply bold or emphasize over all.   One may not use the charstyle dialog (qt) though - everything   is grayed out when the selection span cell borders. patch

Re: Various table trouble

2005-04-24 Thread Juergen Spitzmueller
Georg Baum wrote: It does not work for me. I guess you removed the wrong lfun :-( I disabled LFUN_INSET_INSERT some days ago on purpose as part of the fix applying open dialogs in wrong insets patch. It is not possible to insert an inset when multiple cells are selected unless there is special

Re: Various table trouble

2005-04-24 Thread Georg Baum
Am Sonntag, 24. April 2005 13:12 schrieb Juergen Spitzmueller: Georg, we are talking about the Text Style dialog (a.k.a character dialog), not the char style inset. Does the patch really not enable the settings in that dialog for you? Sorry, that was a misunderstanding. The patch enables the

Re: Various table trouble

2005-04-24 Thread Georg Baum
Am Samstag, 23. April 2005 15:21 schrieb Juergen Spitzmueller: > Helge Hafting wrote: > > * One may select several table cells and apply bold or emphasize over all. > >   One may not use the charstyle dialog (qt) though - everything > >   is grayed out when the selection span cell borders. > >

Re: Various table trouble

2005-04-24 Thread Juergen Spitzmueller
Georg Baum wrote: > It does not work for me. I guess you removed the wrong lfun :-( I disabled > LFUN_INSET_INSERT some days ago on purpose as part of the "fix applying > open dialogs in wrong insets" patch. It is not possible to insert an > inset when multiple cells are selected unless there is

Re: Various table trouble

2005-04-24 Thread Georg Baum
Am Sonntag, 24. April 2005 13:12 schrieb Juergen Spitzmueller: > Georg, we are talking about the "Text Style" dialog (a.k.a "character > dialog"), not the char style inset. Does the patch really not enable the > settings in that dialog for you? Sorry, that was a misunderstanding. The patch

Re: Various table trouble

2005-04-23 Thread Juergen Spitzmueller
Helge Hafting wrote: * One may select several table cells and apply bold or emphasize over all.   One may not use the charstyle dialog (qt) though - everything   is grayed out when the selection span cell borders. patch attached. I will commit if nobody objects. Jürgen Index: insettabular.C

Re: Various table trouble

2005-04-23 Thread Juergen Spitzmueller
Helge Hafting wrote: > * One may select several table cells and apply bold or emphasize over all. >   One may not use the charstyle dialog (qt) though - everything >   is grayed out when the selection span cell borders. patch attached. I will commit if nobody objects. Jürgen Index:

Re: Various table trouble

2005-04-22 Thread Juergen Spitzmueller
Helge Hafting wrote: * Right-click a table. Set the column with to something like 3cm.   Then change from centered to left and notice that the   column width is lost! cannot reproduce * Leave the table dialog open, move the cursor from cell to cell   and make changes all over the place.    

Re: Various table trouble

2005-04-22 Thread Helge Hafting
On Fri, Apr 22, 2005 at 08:24:42AM +0200, Juergen Spitzmueller wrote: Helge Hafting wrote: * Right-click a table. Set the column with to something like 3cm.   Then change from centered to left and notice that the   column width is lost! cannot reproduce * Leave the table dialog open,

Re: Various table trouble

2005-04-22 Thread Juergen Spitzmueller
Helge Hafting wrote: How about having the change take effect immediately, i.e. no option for regretting?  Or is that just as hard as adding an apply button? Actually, having to apply changes for every cell or columns is cumbersome.  The lines part of that dialog does not need apply, one

Re: Various table trouble

2005-04-22 Thread Juergen Spitzmueller
Helge Hafting wrote: > * Right-click a table. Set the column with to something like 3cm. >   Then change from "centered" to "left" and notice that the >   column width is lost! cannot reproduce > * Leave the table dialog open, move the cursor from cell to cell >   and make changes all over the

Re: Various table trouble

2005-04-22 Thread Helge Hafting
On Fri, Apr 22, 2005 at 08:24:42AM +0200, Juergen Spitzmueller wrote: > Helge Hafting wrote: > > * Right-click a table. Set the column with to something like 3cm. > >   Then change from "centered" to "left" and notice that the > >   column width is lost! > > cannot reproduce > > > * Leave the

Re: Various table trouble

2005-04-22 Thread Juergen Spitzmueller
Helge Hafting wrote: > How about having the change take effect immediately, i.e. no > option for regretting?  Or is that just as hard as adding > an apply button? > > Actually, having to "apply" changes for every cell or columns > is cumbersome.  The "lines" part of that dialog does not > need

Various table trouble

2005-04-21 Thread Helge Hafting
Some tabular oddities. This time I made sure to have todays cvs, there should be no old test patches around anymore. * One may select several table cells and apply bold or emphasize over all. One may not use the charstyle dialog (qt) though - everything is grayed out when the selection span

Various table trouble

2005-04-21 Thread Helge Hafting
Some tabular oddities. This time I made sure to have todays cvs, there should be no old test patches around anymore. * One may select several table cells and apply bold or emphasize over all. One may not use the charstyle dialog (qt) though - everything is grayed out when the selection span