Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

2013-05-12 Thread Jean-Marc Lasgouttes
Le 09/05/2013 09:43, pdv a écrit : Yes, I'm available. I've posted another version as you might already have noticed. Unfortunately it seems that we will not have time to look at it seriously :( This stuff is complicated to get right... JMarc

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1) - LyXscrollpatch20130509.diff (1/1)

2013-05-09 Thread Jean-Marc Lasgouttes
Le 09/05/2013 09:37, pdv a écrit : I've moved the code to GuiFontMetrics which is indeed much better. Solved also a remaining issue with smallcaps. Very good. Thanks. JMarc

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

2013-05-09 Thread pdv
In article <5186ae01.4080...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 05/05/13 20:36, pdv a écrit : > >> What exactly takes 17.4s? > > > > I suppose that's the time taken by GuiPainter::text(), but I don't know > > enough of the Instruments app and it's modules to give any more details. > > >

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1) - LyXscrollpatch20130509.diff (1/1)

2013-05-09 Thread pdv
In article <517ee12b.4040...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 28/04/2013 13:06, pdv a écrit : > > OK, here is a new version. Let me know if you experience anymore > > problems. > > For the time being I've left the clean-up step of the map as it was, > > although I realize it's of limit

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

2013-05-05 Thread Jean-Marc Lasgouttes
Le 05/05/13 20:36, pdv a écrit : What exactly takes 17.4s? I suppose that's the time taken by GuiPainter::text(), but I don't know enough of the Instruments app and it's modules to give any more details. I've now monitored both functions with pmprof: ( I scroll through a document of mine start

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

2013-05-05 Thread pdv
In article <518166ab.5070...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 01/05/2013 20:55, pdv a écrit : > > There are 2 occurences of calculate_qt_char_width, in TextMetrics and in > > RowPainter. > > Yes, I toggled both. > > > and there is at least one change which is not enclosed by these >

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

2013-05-01 Thread Jean-Marc Lasgouttes
Le 01/05/2013 20:55, pdv a écrit : There are 2 occurences of calculate_qt_char_width, in TextMetrics and in RowPainter. Yes, I toggled both. and there is at least one change which is not enclosed by these conditionals: In TextMetrics I changed rowBreakPoint() to return the breakpoint as well

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

2013-05-01 Thread pdv
In article <517fe428.8070...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 28/04/2013 13:06, pdv a écrit : > > OK, here is a new version. Let me know if you experience anymore > > problems. > > For the time being I've left the clean-up step of the map as it was, > > although I realize it's of limit

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

2013-04-30 Thread Jean-Marc Lasgouttes
Le 28/04/2013 13:06, pdv a écrit : OK, here is a new version. Let me know if you experience anymore problems. For the time being I've left the clean-up step of the map as it was, although I realize it's of limited value; when entering the same word multiple times, the partial words get included a

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

2013-04-29 Thread Jean-Marc Lasgouttes
Le 28/04/2013 13:06, pdv a écrit : OK, here is a new version. Let me know if you experience anymore problems. For the time being I've left the clean-up step of the map as it was, although I realize it's of limited value; when entering the same word multiple times, the partial words get included a

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

2013-04-28 Thread pdv
In article <5178e9fc.6040...@lyx.org>, Jean-Marc Lasgouttes wrote: > 24/04/2013 21:41, pdv: > >> Why do you add 0x61 to the values? > > > > That's just for easy reading when looking at what exactly gets written > > to the map; In this way the codes are a, b, c ... > > That makes sense. > > >>

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1)

2013-04-25 Thread Jean-Marc Lasgouttes
24/04/2013 21:14, pdv: Sorry, the problem is obvious. I'm using cmake and although --enable-stdlib-debug is mentioned in the install notes, I can't set that option. Once (more or less) ready I build manually with the LyX-Mac-binary-release.sh script, which by default disables this option. When I

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1)

2013-04-25 Thread Jean-Marc Lasgouttes
24/04/2013 21:41, pdv: Why do you add 0x61 to the values? That's just for easy reading when looking at what exactly gets written to the map; In this way the codes are a, b, c ... That makes sense. I do not think there is a need to have a map per document. A shared map stored in TextLetrics

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1)

2013-04-24 Thread pdv
In article <5176ae47.9050...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 21/04/2013 21:24, pdv a écrit : > > Hereafter I've listed some comments which might be helpful or answer > > suggestions you've made earlier. (btw I couldn't find support/pmprof.h) > > If you have comments, questions ... I'm

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1)

2013-04-24 Thread pdv
In article <5176c559.3030...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 21/04/2013 21:24, pdv a écrit : > > Of course, but I wanted a fully functional patch before posting. > > As far as I have tested the functionality should be largely OK now (at > > least the User's Guide and some of my docume

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1)

2013-04-23 Thread Jean-Marc Lasgouttes
Le 21/04/2013 21:24, pdv a écrit : Of course, but I wanted a fully functional patch before posting. As far as I have tested the functionality should be largely OK now (at least the User's Guide and some of my documents are displayed and handled correctly). There might still be problems with the c

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1)

2013-04-23 Thread Jean-Marc Lasgouttes
Le 21/04/2013 21:24, pdv a écrit : (btw I couldn't find support/pmprof.h) You should find it if you update to latest master (git update --rebase). JMarc

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1)

2013-04-23 Thread Jean-Marc Lasgouttes
Le 21/04/2013 21:24, pdv a écrit : Hereafter I've listed some comments which might be helpful or answer suggestions you've made earlier. (btw I couldn't find support/pmprof.h) If you have comments, questions ... I'm looking forward to hearing from you. I need some time to really understand the

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1)

2013-04-21 Thread pdv
In article <516eabdf.5090...@lyx.org>, Jean-Marc Lasgouttes wrote: > 17/04/2013 00:05, pdv: > > I do now all the width-calculations in one function. > > In that function the widths are cached in a map. > > I then obtain again a substantial speed increase. > > For testing I defined a static map,

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1)

2013-04-18 Thread Jean-Marc Lasgouttes
17/04/2013 00:05, pdv: I do now all the width-calculations in one function. In that function the widths are cached in a map. I then obtain again a substantial speed increase. For testing I defined a static map, but I assume that eventually the map should be stored in a suitable object so that the

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1)

2013-04-17 Thread Jean-Marc Lasgouttes
17/04/2013 00:05, pdv: I do now all the width-calculations in one function. In that function the widths are cached in a map. I then obtain again a substantial speed increase. For testing I defined a static map, but I assume that eventually the map should be stored in a suitable object so that the

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1)

2013-04-16 Thread pdv
In article <516519f8.2070...@lyx.org>, Jean-Marc Lasgouttes wrote: > 09/04/2013 23:12, pdv: > > I've adapted rowBreakPoint() and also removed the following call to > > rowWidth(), where the same calculations are done again. > > The on screen layout is now OK, except for a small remaining issue w

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1)

2013-04-10 Thread Jean-Marc Lasgouttes
09/04/2013 23:12, pdv: I've adapted rowBreakPoint() and also removed the following call to rowWidth(), where the same calculations are done again. The on screen layout is now OK, except for a small remaining issue with RTL-languages. Yes, we should not have several pieces of code that do the sa

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1)

2013-04-09 Thread pdv
In article <515e8cdf.5010...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 29/03/2013 20:52, pdv a écrit : > > I didn't know about rowBreakPoint(). > > At some point I thought about keeping a list of positions, but discarded > > the idea somehow. Even with this new code the scrolling is still not >

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1)

2013-04-05 Thread Jean-Marc Lasgouttes
Le 29/03/2013 20:52, pdv a écrit : I didn't know about rowBreakPoint(). At some point I thought about keeping a list of positions, but discarded the idea somehow. Even with this new code the scrolling is still not ideal, so anything that could save some more time could be useful. I'll take a look

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130401.diff (1/1)

2013-04-01 Thread pdv
In article , pdv wrote: > In article <51506c02.8040...@lyx.org>, > Jean-Marc Lasgouttes wrote: > > > Le 25/03/2013 16:15, Jean-Marc Lasgouttes a écrit : > > > In case you are interested in working more on this coe, here are a few > > > remarks: > > > > And another one: > > > > * How come yo

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1)

2013-03-29 Thread pdv
In article <51506c02.8040...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 25/03/2013 16:15, Jean-Marc Lasgouttes a écrit : > > In case you are interested in working more on this coe, here are a few > > remarks: > > And another one: > > * How come you do not touch TextMetrics::rowBreakPoint? > >

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1)

2013-03-29 Thread pdv
In article <51506a27.3060...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 22/03/2013 12:59, pdv a écrit : > > Hi everyone, > > > > I've developed a patch which solves the scrolling issue on "OS X". > > I assume that there have been different scrolling issues but the one I'm > > referring to is the

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1)

2013-03-29 Thread Stephan Witt
Am 25.03.2013 um 16:15 schrieb Jean-Marc Lasgouttes : > Le 22/03/2013 12:59, pdv a écrit : >> Hi everyone, >> >> I've developed a patch which solves the scrolling issue on "OS X". >> I assume that there have been different scrolling issues but the one I'm >> referring to is the one diagnosed by S

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1)

2013-03-25 Thread Jean-Marc Lasgouttes
Le 25/03/2013 16:15, Jean-Marc Lasgouttes a écrit : In case you are interested in working more on this coe, here are a few remarks: And another one: * How come you do not touch TextMetrics::rowBreakPoint? Actually, my plan was to build in rowBreakPoint a description of the Row as a list of f

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1)

2013-03-25 Thread Jean-Marc Lasgouttes
Le 22/03/2013 12:59, pdv a écrit : Hi everyone, I've developed a patch which solves the scrolling issue on "OS X". I assume that there have been different scrolling issues but the one I'm referring to is the one diagnosed by Stephan Witt Hi, This looks awesome... My current plan was to work o

patch for scrolling issue - LyXscrollpatch20130302.diff (1/1)

2013-03-22 Thread pdv
Hi everyone, I've developed a patch which solves the scrolling issue on "OS X". I assume that there have been different scrolling issues but the one I'm referring to is the one diagnosed by Stephan Witt > (LyX developer list 18 may 2011, Stephan Witt) > It isn't a bug, it's a feature. Qt4.7 rend