Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

Le 09/05/2013 09:43, pdv a écrit : Yes, I'm available. I've posted another version as you might already have noticed. Unfortunately it seems that we will not have time to look at it seriously :( This stuff is complicated to get right... JMarc

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

Le 09/05/2013 09:43, pdv a écrit : Yes, I'm available. I've posted another version as you might already have noticed. Unfortunately it seems that we will not have time to look at it seriously :( This stuff is complicated to get right... JMarc

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1) - LyXscrollpatch20130509.diff (1/1)

In article 517ee12b.4040...@lyx.org, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: Le 28/04/2013 13:06, pdv a écrit : OK, here is a new version. Let me know if you experience anymore problems. For the time being I've left the clean-up step of the map as it was, although I realize it's

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

In article 5186ae01.4080...@lyx.org, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: Le 05/05/13 20:36, pdv a écrit : What exactly takes 17.4s? I suppose that's the time taken by GuiPainter::text(), but I don't know enough of the Instruments app and it's modules to give any more details.

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1) - LyXscrollpatch20130509.diff (1/1)

Le 09/05/2013 09:37, pdv a écrit : I've moved the code to GuiFontMetrics which is indeed much better. Solved also a remaining issue with smallcaps. Very good. Thanks. JMarc

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1) - LyXscrollpatch20130509.diff (1/1)

In article <517ee12b.4040...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 28/04/2013 13:06, pdv a écrit : > > OK, here is a new version. Let me know if you experience anymore > > problems. > > For the time being I've left the clean-up step of the map as it was, > > although I

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

In article <5186ae01.4080...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 05/05/13 20:36, pdv a écrit : > >> What exactly takes 17.4s? > > > > I suppose that's the time taken by GuiPainter::text(), but I don't know > > enough of the Instruments app and it's modules to give any

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1) - LyXscrollpatch20130509.diff (1/1)

Le 09/05/2013 09:37, pdv a écrit : I've moved the code to GuiFontMetrics which is indeed much better. Solved also a remaining issue with smallcaps. Very good. Thanks. JMarc

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

In article 518166ab.5070...@lyx.org, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: Le 01/05/2013 20:55, pdv a écrit : There are 2 occurences of calculate_qt_char_width, in TextMetrics and in RowPainter. Yes, I toggled both. and there is at least one change which is not enclosed by

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

Le 05/05/13 20:36, pdv a écrit : What exactly takes 17.4s? I suppose that's the time taken by GuiPainter::text(), but I don't know enough of the Instruments app and it's modules to give any more details. I've now monitored both functions with pmprof: ( I scroll through a document of mine

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

In article <518166ab.5070...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 01/05/2013 20:55, pdv a écrit : > > There are 2 occurences of calculate_qt_char_width, in TextMetrics and in > > RowPainter. > > Yes, I toggled both. > > > and there is at least one change which is not

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

Le 05/05/13 20:36, pdv a écrit : What exactly takes 17.4s? I suppose that's the time taken by GuiPainter::text(), but I don't know enough of the Instruments app and it's modules to give any more details. I've now monitored both functions with pmprof: ( I scroll through a document of mine

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

In article 517fe428.8070...@lyx.org, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: Le 28/04/2013 13:06, pdv a écrit : OK, here is a new version. Let me know if you experience anymore problems. For the time being I've left the clean-up step of the map as it was, although I realize it's

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

Le 01/05/2013 20:55, pdv a écrit : There are 2 occurences of calculate_qt_char_width, in TextMetrics and in RowPainter. Yes, I toggled both. and there is at least one change which is not enclosed by these conditionals: In TextMetrics I changed rowBreakPoint() to return the breakpoint as well

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

In article <517fe428.8070...@lyx.org>, Jean-Marc Lasgouttes wrote: > Le 28/04/2013 13:06, pdv a écrit : > > OK, here is a new version. Let me know if you experience anymore > > problems. > > For the time being I've left the clean-up step of the map as it was, > > although I

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

Le 01/05/2013 20:55, pdv a écrit : There are 2 occurences of calculate_qt_char_width, in TextMetrics and in RowPainter. Yes, I toggled both. and there is at least one change which is not enclosed by these conditionals: In TextMetrics I changed rowBreakPoint() to return the breakpoint as well

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

Le 28/04/2013 13:06, pdv a écrit : OK, here is a new version. Let me know if you experience anymore problems. For the time being I've left the clean-up step of the map as it was, although I realize it's of limited value; when entering the same word multiple times, the partial words get included

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

Le 28/04/2013 13:06, pdv a écrit : OK, here is a new version. Let me know if you experience anymore problems. For the time being I've left the clean-up step of the map as it was, although I realize it's of limited value; when entering the same word multiple times, the partial words get included

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

Le 28/04/2013 13:06, pdv a écrit : OK, here is a new version. Let me know if you experience anymore problems. For the time being I've left the clean-up step of the map as it was, although I realize it's of limited value; when entering the same word multiple times, the partial words get included

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

Le 28/04/2013 13:06, pdv a écrit : OK, here is a new version. Let me know if you experience anymore problems. For the time being I've left the clean-up step of the map as it was, although I realize it's of limited value; when entering the same word multiple times, the partial words get included

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

In article 5178e9fc.6040...@lyx.org, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: 24/04/2013 21:41, pdv: Why do you add 0x61 to the values? That's just for easy reading when looking at what exactly gets written to the map; In this way the codes are a, b, c ... That makes sense.

Re: patch for scrolling issue - LyXscrollpatch20130302.diff (1/1) - LyXscrollpatch20130421.diff (1/1) - LyXscrollpatch20130427.diff (1/1)

In article <5178e9fc.6040...@lyx.org>, Jean-Marc Lasgouttes wrote: > 24/04/2013 21:41, pdv: > >> Why do you add 0x61 to the values? > > > > That's just for easy reading when looking at what exactly gets written > > to the map; In this way the codes are a, b, c ... > > That