Re: r21994 - /lyx-devel/trunk/src/tex2lyx/preamble.cpp

2007-12-09 Thread Uwe Stöhr
Jürgen Spitzmüller schrieb: Please use tabs instead of spaces for indendation. Ooops, fixed now. regards Uwe

Re: r21994 - /lyx-devel/trunk/src/tex2lyx/preamble.cpp

2007-12-09 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > What do you mean, the first "{"? The code is conform to our guidelines for > functions. Please use tabs instead of spaces for indendation. Jürgen

Re: r21994 - /lyx-devel/trunk/src/tex2lyx/preamble.cpp

2007-12-09 Thread Uwe Stöhr
> But please fix the whitespace here: What do you mean, the first "{"? The code is conform to our guidelines for functions. regards Uwe

Re: r21994 - /lyx-devel/trunk/src/tex2lyx/preamble.cpp

2007-12-09 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > > Jürgen, I assume that this code cleanup can go to trunk too although no > > functionality is changed, right? > > Yes. But please fix the whitespace here: +// Given is a string like "scaled=0.9", return 0.9 * 100 +string const scale_as_percentage(string const & scale)

Re: r21994 - /lyx-devel/trunk/src/tex2lyx/preamble.cpp

2007-12-09 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > Jürgen, I assume that this code cleanup can go to trunk too although no > functionality is changed, right? Yes. Jürgen

Re: r21994 - /lyx-devel/trunk/src/tex2lyx/preamble.cpp

2007-12-09 Thread Uwe Stöhr
> Couldn't you put this code in a function and call it from both places? Thanks for the hint. A function is cleaner, I committed it: http://www.lyx.org/trac/changeset/22034 Jürgen, I assume that this code cleanup can go to trunk too although no functionality is changed, right? thanks and regar

Re: r21994 - /lyx-devel/trunk/src/tex2lyx/preamble.cpp

2007-12-08 Thread Angus Leeming
[EMAIL PROTECTED] wrote: // special columntypes extern std::map special_columns; @@ -218,8 +220,17 @@ h_font_sans = name; if (!opts.empty()) { scale = opts; - pos = scale.find("."); - h_font_sf_s