Re: two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-21 Thread Scott Kostyshak
On Sun, Feb 21, 2016 at 12:00:05PM -0500, PhilipPirrip wrote: > On 02/21/2016 10:59 AM, Richard Heck wrote: > >I'd say go ahead. I'm almost certain this is not the right way to fix > >the bug. > > Done: http://www.lyx.org/trac/ticket/9979 > > Do we need one for the first problem, as a reminder

Re: two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-21 Thread PhilipPirrip
On 02/21/2016 10:59 AM, Richard Heck wrote: I'd say go ahead. I'm almost certain this is not the right way to fix the bug. Done: http://www.lyx.org/trac/ticket/9979 Do we need one for the first problem, as a reminder to commit?

Re: two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-21 Thread Richard Heck
On 02/21/2016 10:35 AM, PhilipPirrip wrote: > On 02/20/2016 11:18 PM, Richard Heck wrote: >> One solution would be to have Buffer::collectChildren make sure the >> Buffers exist. > > I can confirm that your patch fixes the problem. Thanks, Richard! > > Scott, do you still want me to file the bug

Re: two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-21 Thread PhilipPirrip
On 02/20/2016 11:18 PM, Richard Heck wrote: One solution would be to have Buffer::collectChildren make sure the Buffers exist. I can confirm that your patch fixes the problem. Thanks, Richard! Scott, do you still want me to file the bug report?

Re: two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-20 Thread Richard Heck
On 02/20/2016 07:21 PM, PhilipPirrip wrote: > - 2 - > download and unpack > https://bitbucket.org/amiede/classicthesis/downloads/classicthesis-LyX-v4.2.zip > (it might 'work' with simpler master/child documents, I don't have > time to test it) > > > start lyx2.2 from terminal > > start a new

Re: two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-20 Thread Scott Kostyshak
On Sat, Feb 20, 2016 at 08:01:37PM -0500, PhilipPirrip wrote: > On 02/20/2016 07:45 PM, Richard Heck wrote: > >Something like this: > >... > > ... > >should fix it. > > #1 fixed Good. I would say commit then, Richard. I tried to think of a better variable name that isReadOnly to take into

Re: two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-20 Thread PhilipPirrip
On 02/20/2016 07:45 PM, Richard Heck wrote: Something like this: ... > ... should fix it. #1 fixed Not sure about the other one. #2 not

Re: two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-20 Thread Richard Heck
On 02/20/2016 07:46 PM, PhilipPirrip wrote: > On 02/20/2016 07:40 PM, Richard Heck wrote: >> There's a missing test somewhere on whether the dialog needs a view, >> which this one does. The dialog should really be closed when the last >> view disappears. > > That's only the first case, I believe.

Re: two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-20 Thread PhilipPirrip
On 02/20/2016 07:40 PM, Richard Heck wrote: There's a missing test somewhere on whether the dialog needs a view, which this one does. The dialog should really be closed when the last view disappears. That's only the first case, I believe. But in the second case you still have the first, new,

Re: two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-20 Thread Richard Heck
On 02/20/2016 07:21 PM, PhilipPirrip wrote: > Hey guys, I need you to confirm this (my config is Fedora Linux, fresh > master 89985beb, Qt 5.5.1): > > > - 1 - > start lyx2.2 from terminal > start a new document (ctrl-n) > open Document Settings dialog > close the new document (ctrl-w or

Re: two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-20 Thread Richard Heck
On 02/20/2016 07:36 PM, Scott Kostyshak wrote: > On Sat, Feb 20, 2016 at 07:21:31PM -0500, PhilipPirrip wrote: >> Hey guys, I need you to confirm this (my config is Fedora Linux, fresh >> master 89985beb, Qt 5.5.1): > I confirm both. I will look into the first one. Hopefully the second one is >

Re: two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-20 Thread Scott Kostyshak
On Sat, Feb 20, 2016 at 07:21:31PM -0500, PhilipPirrip wrote: > Hey guys, I need you to confirm this (my config is Fedora Linux, fresh > master 89985beb, Qt 5.5.1): I confirm both. I will look into the first one. Hopefully the second one is related. Thanks a lot for testing, Phillip, and for

two ways to crash LyX 2.2 (Document Settings dialog open)

2016-02-20 Thread PhilipPirrip
Hey guys, I need you to confirm this (my config is Fedora Linux, fresh master 89985beb, Qt 5.5.1): - 1 - start lyx2.2 from terminal start a new document (ctrl-n) open Document Settings dialog close the new document (ctrl-w or file-close) LyX aborts, with Assertion triggered in void