Re: [LyX/2.3.x] Revert "Do not increment start for find(phrase) while looping over phrases"
On 08/04/2018 07:41 AM, Kornel Benko wrote: > commit 1140ed1ed345f37c43339601c7fde1dd2ef65806 > Author: Kornel Benko > Date: Sat Aug 4 13:36:38 2018 +0200 > > Revert "Do not increment start for find(phrase) while looping over > phrases" > > This reverts commit e7b3b62b0bf9a9f611bf8021556b8584ac0115c3. > The 'for phrase in' loop is organized differently to master. Yes, sorry, I made a number of changes to these in response to bug #11200, which are not yet in stable. Riki
Jenkins build is back to normal : Build branch "master" ยป ubuntu-xenial-qt4-autotools-extended #1107
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/1107/
Re: lyx2lyx error
Am Samstag, 4. August 2018 12:51:19 CEST schrieb Enrico Forestieri : > On Thu, Aug 02, 2018 at 10:54:47PM +0200, Kornel Benko wrote: > > Am Mittwoch, 1. August 2018 20:10:38 CEST schrieb Kornel Benko > > : > > > Am Mittwoch, 1. August 2018 19:26:15 CEST schrieb Enrico Forestieri > > > : > > > > It is not possible loading the attached document with current master > > > > because lyx2lyx fails with the following error: > > > > > > > > Warning: An error ocurred in 482, > > > 0x6c49d70> > > > > Traceback (most recent call last): > > > > File "/usr/local/src/lyx/lyx-devel/lib/lyx2lyx/lyx2lyx", line 96, in > > > > > > > > main() > > > > File "/usr/local/src/lyx/lyx-devel/lib/lyx2lyx/lyx2lyx", line 90, in > > > > main > > > > doc.convert() > > > > File "/usr/local/src/lyx/lyx-devel/lib/lyx2lyx/LyX.py", line 692, in > > > > convert > > > > conv(self) > > > > File "/usr/local/src/lyx/lyx-devel/lib/lyx2lyx/lyx_2_2.py", line 759, > > > > in convert_phrases > > > > j = document.body[i].find(phrase) > > > > IndexError: list index out of range > > > > > > > > > > Line lyx_2_2.py:761 > > > 'i += 1' > > > is wrong. Should be deleted. > > > > > > > Nobody screamed. Committed at a968456. > > Thanks. However, note that this was not needed in stable. > Now, after e7b3b62b, lyx2lyx seems going into an endless loop. > Reverting e7b3b62b fixes it and the document attached to this thread > is correctly loaded also in lyx 2.3. > Right, in 2.3.x the 'for phrase in' loop is organized differently. Sorry, did not check. I will revert. Kornel signature.asc Description: This is a digitally signed message part.
Re: lyx2lyx error
On Thu, Aug 02, 2018 at 10:54:47PM +0200, Kornel Benko wrote: > Am Mittwoch, 1. August 2018 20:10:38 CEST schrieb Kornel Benko > : > > Am Mittwoch, 1. August 2018 19:26:15 CEST schrieb Enrico Forestieri > > : > > > It is not possible loading the attached document with current master > > > because lyx2lyx fails with the following error: > > > > > > Warning: An error ocurred in 482, > > 0x6c49d70> > > > Traceback (most recent call last): > > > File "/usr/local/src/lyx/lyx-devel/lib/lyx2lyx/lyx2lyx", line 96, in > > > > > > main() > > > File "/usr/local/src/lyx/lyx-devel/lib/lyx2lyx/lyx2lyx", line 90, in > > > main > > > doc.convert() > > > File "/usr/local/src/lyx/lyx-devel/lib/lyx2lyx/LyX.py", line 692, in > > > convert > > > conv(self) > > > File "/usr/local/src/lyx/lyx-devel/lib/lyx2lyx/lyx_2_2.py", line 759, > > > in convert_phrases > > > j = document.body[i].find(phrase) > > > IndexError: list index out of range > > > > > > > Line lyx_2_2.py:761 > > 'i += 1' > > is wrong. Should be deleted. > > > > Nobody screamed. Committed at a968456. Thanks. However, note that this was not needed in stable. Now, after e7b3b62b, lyx2lyx seems going into an endless loop. Reverting e7b3b62b fixes it and the document attached to this thread is correctly loaded also in lyx 2.3. -- Enrico
