Re: [RFC] Try to compute row height like it should be done

2019-01-06 Thread Jürgen Spitzmüller
Am Sonntag, den 06.01.2019, 13:35 +0100 schrieb Jean-Marc Lasgouttes: > Then, here is what I propose: > * apply the leading to the font > * add the 20% height leading This sounds sensible to me. Jürgen signature.asc Description: This is a digitally signed message part

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Jürgen Spitzmüller
Am Sonntag, den 06.01.2019, 15:14 +0100 schrieb Kornel Benko: > > Nice. But now even more tests are failing. If you provide me with details, I might be able to do something. Jürgen > > Kornel > signature.asc Description: This is a digitally signed message part

Re: [RFC] Try to compute row height like it should be done

2019-01-06 Thread Jürgen Spitzmüller
Am Samstag, den 05.01.2019, 18:36 +0100 schrieb Enrico Forestieri: > For what I understand, the leading is a suggested spacing to add to > account for accents and similar that might otherwise overlap. > However, if we already provide for a larger line spacing (because we > have inserts to take

Re: [RFC] Try to compute row height like it should be done

2019-01-06 Thread Jürgen Spitzmüller
Am Sonntag, den 06.01.2019, 09:49 +0100 schrieb Enrico Forestieri: > > My understanding is that the yGap value (Qt's leading()) accounts > > for > > the fact that different fonts need different line spacings. See > > https://docs.microsoft.com/en-us/typography/opentype/spec/vhea > >

Re: [RFC] Try to compute row height like it should be done

2019-01-06 Thread Enrico Forestieri
On Sun, Jan 06, 2019 at 10:14:28AM +0100, Jürgen Spitzmüller wrote: > Am Sonntag, den 06.01.2019, 09:49 +0100 schrieb Enrico Forestieri: > > > My understanding is that the yGap value (Qt's leading()) accounts > > > for > > > the fact that different fonts need different line spacings. See > > >

Re: [RFC] Try to compute row height like it should be done

2019-01-06 Thread Jean-Marc Lasgouttes
Le 06/01/2019 à 10:14, Jürgen Spitzmüller a écrit : Who says we want single-spacing? I just say that if we use, say, 1.2, we should add yGap _on top_ of that. MinionPro in 1.2 line spacing needs more leading than Garamond in 1.2 line spacing. and even avoid changing the spacing if two

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Jürgen Spitzmüller
Am Sonntag, den 06.01.2019, 01:47 -0500 schrieb Scott Kostyshak: > +1 I'm fine with that since the current splash is not compilable at > all by > default and since nanumGothic is a free font. But should we really require a font that users need to install first for such a basic file than Splash

Re: [RFC] Try to compute row height like it should be done

2019-01-06 Thread Enrico Forestieri
On Sun, Jan 06, 2019 at 10:54:51AM +0100, Enrico Forestieri wrote: > > If we add a spacing which is already larger than the suggested > leading, what is the point of still taking into account it? I think you already answered this previously, but I overlooked it. Sorry. You said: > The initial

Re: [RFC] Try to compute row height like it should be done

2019-01-06 Thread Enrico Forestieri
On Sun, Jan 06, 2019 at 02:10:26PM +0100, Jürgen Spitzmüller wrote: > Am Sonntag, den 06.01.2019, 13:35 +0100 schrieb Jean-Marc Lasgouttes: > > Then, here is what I propose: > > * apply the leading to the font > > * add the 20% height leading > > This sounds sensible to me. Yes, this might work.

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Jürgen Spitzmüller
Am Sonntag, den 06.01.2019, 09:40 +0100 schrieb Kornel Benko: > Even if this compiles, the output looks ugly with default fonts. > 1.) Tons of 'Missing glyphs!' > 2.) See attached Then we should fix the cause, not the symptoms. The cause is that this document uses utf8 encoding, which triggers

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Kornel Benko
Am Sonntag, 6. Januar 2019 14:37:27 CET schrieb Jürgen Spitzmüller : > Am Sonntag, den 06.01.2019, 09:40 +0100 schrieb Kornel Benko: > > Even if this compiles, the output looks ugly with default fonts. > > 1.) Tons of 'Missing glyphs!' > > 2.) See attached > > Then we should fix the cause, not

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Kornel Benko
Am Sonntag, 6. Januar 2019 09:25:41 CET schrieb Jürgen Spitzmüller : > Am Sonntag, den 06.01.2019, 01:47 -0500 schrieb Scott Kostyshak: > > +1 I'm fine with that since the current splash is not compilable at > > all by > > default and since nanumGothic is a free font. > > But should we really

Re: [RFC] Try to compute row height like it should be done

2019-01-06 Thread Enrico Forestieri
On Sun, Jan 06, 2019 at 09:33:03AM +0100, Jürgen Spitzmüller wrote: > Am Samstag, den 05.01.2019, 18:36 +0100 schrieb Enrico Forestieri: > > For what I understand, the leading is a suggested spacing to add to > > account for accents and similar that might otherwise overlap. > > However, if we

Re: [RFC] Try to compute row height like it should be done

2019-01-06 Thread Jürgen Spitzmüller
Am Sonntag, den 06.01.2019, 11:11 +0100 schrieb Enrico Forestieri: > So, even in the current implementation the line spacing is not > sufficient > and needs to be incresead. Ok, understood. Yes. With specific fonts, that is. Jürgen signature.asc Description: This is a digitally signed message

Re: Lyx V2.3.2 - Issues with svgs snippets on Mac OS X

2019-01-06 Thread Enrico Forestieri
On Sun, Jan 06, 2019 at 12:29:40AM +0100, Stephan Witt wrote: > > I did it with the wrapper script approach and pushed it with commit > caa1dd2aee. Strangely enough, your commit didn't show up on the lyx-cvs list. > I’ve tested it on Mac extensively. It shouldn’t change anything on other >

Re: Lyx V2.3.2 - Issues with svgs snippets on Mac OS X

2019-01-06 Thread Stephan Witt
Am 06.01.2019 um 09:57 schrieb Enrico Forestieri : > > On Sun, Jan 06, 2019 at 12:29:40AM +0100, Stephan Witt wrote: >> >> I did it with the wrapper script approach and pushed it with commit >> caa1dd2aee. > > Strangely enough, your commit didn't show up on the lyx-cvs list. Yes, I’ve noticed

Re: define LYX_USE_LONG_LONG

2019-01-06 Thread Pavel Sanda
On Sat, Jan 05, 2019 at 07:58:59PM -0300, Elias M. Mariani wrote: > (maybe you want to update https://www.lyx.org/Download). We rely on https://repology.org/metapackage/lyx/versions for the correct version number, so that's place where to complain. At most we can delete openbsd tag completely if

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Kornel Benko
Am Sonntag, 6. Januar 2019 16:41:15 CET schrieb Jürgen Spitzmüller : > Am Sonntag, den 06.01.2019, 16:22 +0100 schrieb Kornel Benko: > > For instance the test > > export/examples/ko/splash_pdf4_systemF > > passed previously, now it does not. > > Should be fixed. > > > Also the tests > >

Re: Lyx V2.3.2 - Issues with svgs snippets on Mac OS X

2019-01-06 Thread Richard Kimberly Heck
On 1/6/19 7:49 AM, Stephan Witt wrote: > Am 06.01.2019 um 09:57 schrieb Enrico Forestieri : >> On Sun, Jan 06, 2019 at 12:29:40AM +0100, Stephan Witt wrote: >>> I did it with the wrapper script approach and pushed it with commit >>> caa1dd2aee. >> Strangely enough, your commit didn't show up on

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Jürgen Spitzmüller
Am Sonntag, den 06.01.2019, 18:08 +0100 schrieb Kornel Benko: > For pdflatex, I get > !pdfTeX error: pdflatex (file cyberbb5): Font cyberbb5 at 600 > not found > > I have cyberbb5.tfm installed > /usr/local/texlive/2018/texmf- > dist/fonts/tfm/zhmetrics/cyberb/cyberbb5.tfm > but

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Kornel Benko
Am Sonntag, 6. Januar 2019 15:23:06 CET schrieb Jürgen Spitzmüller : > Am Sonntag, den 06.01.2019, 15:14 +0100 schrieb Kornel Benko: > > > > Nice. But now even more tests are failing. > > If you provide me with details, I might be able to do something. > > Jürgen > For instance the test

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Jürgen Spitzmüller
Am Sonntag, den 06.01.2019, 13:39 -0500 schrieb Scott Kostyshak: > Nice! Thanks for implementing that, Jürgen. It would be great for it > to > compile with pdfTeX out of the box. I get the same error as > Kornel. I > will search for more information on the map file and how to enable > it. Does

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Jürgen Spitzmüller
Am Sonntag, den 06.01.2019, 16:22 +0100 schrieb Kornel Benko: > For instance the test > export/examples/ko/splash_pdf4_systemF > passed previously, now it does not. Should be fixed. > Also the tests > INVERTED.TODO_export/examples/ko/splash_pdf2 >

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Kornel Benko
Am Sonntag, 6. Januar 2019 17:18:14 CET schrieb Jürgen Spitzmüller : > Am Sonntag, den 06.01.2019, 17:08 +0100 schrieb Kornel Benko: > > > > Also the tests > > > > INVERTED.TODO_export/examples/ko/splash_pdf2 > > > > INVERTED.TODO_export/examples/ko/splash_pdf > > > >

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Jürgen Spitzmüller
Am Sonntag, den 06.01.2019, 17:08 +0100 schrieb Kornel Benko: > > > Also the tests > > > INVERTED.TODO_export/examples/ko/splash_pdf2 > > > INVERTED.TODO_export/examples/ko/splash_pdf > > > INVERTED.TODO_export/examples/ko/splash_pdf3 > > > which should now fail, passes. >

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Scott Kostyshak
On Sun, Jan 06, 2019 at 07:46:03PM +0100, Jürgen Spitzmüller wrote: > Am Sonntag, den 06.01.2019, 13:39 -0500 schrieb Scott Kostyshak: > > Nice! Thanks for implementing that, Jürgen. It would be great for it > > to > > compile with pdfTeX out of the box. I get the same error as > > Kornel. I > >

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Kornel Benko
Am Sonntag, 6. Januar 2019 14:03:37 CET schrieb Scott Kostyshak : > On Sun, Jan 06, 2019 at 07:46:03PM +0100, Jürgen Spitzmüller wrote: > > Am Sonntag, den 06.01.2019, 13:39 -0500 schrieb Scott Kostyshak: > > > Nice! Thanks for implementing that, Jürgen. It would be great for it > > > to > > >

Re: define LYX_USE_LONG_LONG

2019-01-06 Thread Jean-Marc Lasgouttes
Le 05/01/2019 à 23:58, Elias M. Mariani a écrit : That is an extract from configure.ac, where you currently check if the size of long long is greater than long. Currently on OpenBSD amd64 the sizes are the same, so LYX_USE_LONG_LONG is undef. This triggers errors during compilation time, given

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Scott Kostyshak
On Sun, Jan 06, 2019 at 07:14:49PM +0100, Jürgen Spitzmüller wrote: > Am Sonntag, den 06.01.2019, 18:08 +0100 schrieb Kornel Benko: > > For pdflatex, I get > > !pdfTeX error: pdflatex (file cyberbb5): Font cyberbb5 at 600 > > not found > > > > I have cyberbb5.tfm installed > >

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Jürgen Spitzmüller
Am Sonntag, den 06.01.2019, 14:03 -0500 schrieb Scott Kostyshak: > Yes, that works well. With that change, the test output looks good. Good. Would you commit this change, please? Jürgen signature.asc Description: This is a digitally signed message part

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Scott Kostyshak
On Sun, Jan 06, 2019 at 08:05:23PM +0100, Jürgen Spitzmüller wrote: > Am Sonntag, den 06.01.2019, 14:03 -0500 schrieb Scott Kostyshak: > > Yes, that works well. With that change, the test output looks good. > > Good. Would you commit this change, please? Done at 0cfaf406. Thanks, Scott

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Scott Kostyshak
On Sun, Jan 06, 2019 at 08:15:20PM +0100, Kornel Benko wrote: > Am Sonntag, 6. Januar 2019 14:03:37 CET schrieb Scott Kostyshak > : > > On Sun, Jan 06, 2019 at 07:46:03PM +0100, Jürgen Spitzmüller wrote: > > > Am Sonntag, den 06.01.2019, 13:39 -0500 schrieb Scott Kostyshak: > > > > Nice! Thanks

Re: [LyX/master] Add comment.

2019-01-06 Thread Scott Kostyshak
On Sun, Jan 06, 2019 at 06:59:59PM +0100, Richard Kimberly Heck wrote: > commit b35d90014ec5f37863679fc4ef4a2a67c87b4c64 > Author: Richard Kimberly Heck > Date: Sun Jan 6 13:02:40 2019 -0500 > > Add comment. > --- > src/frontends/qt4/GuiRef.cpp |2 ++ > 1 files changed, 2

Re: [LyX/master] Add comment.

2019-01-06 Thread Richard Kimberly Heck
On 1/6/19 4:47 PM, Scott Kostyshak wrote: > On Sun, Jan 06, 2019 at 06:59:59PM +0100, Richard Kimberly Heck wrote: >> commit b35d90014ec5f37863679fc4ef4a2a67c87b4c64 >> Author: Richard Kimberly Heck >> Date: Sun Jan 6 13:02:40 2019 -0500 >> >> Add comment. >> --- >>

Re: #11369: Mac Initialization error

2019-01-06 Thread Roger
Reconfigure triggers the problem. However, it does not cause a permanent problem. When the error message caused by Reconfigure occurs I have to quit LyX using the Dock icon after which LyX starts OK. There is only one Lyx folder in ~/Library/Applications Support. However, if needed I can probably

Re: [LyX/master] Add comment.

2019-01-06 Thread Scott Kostyshak
On Sun, Jan 06, 2019 at 05:51:37PM -0500, Richard Kimberly Heck wrote: > On 1/6/19 4:47 PM, Scott Kostyshak wrote: > > On Sun, Jan 06, 2019 at 06:59:59PM +0100, Richard Kimberly Heck wrote: > >> commit b35d90014ec5f37863679fc4ef4a2a67c87b4c64 > >> Author: Richard Kimberly Heck > >> Date: Sun

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Scott Kostyshak
On Mon, Jan 07, 2019 at 06:45:58AM +0100, Kornel Benko wrote: > Am Sonntag, 6. Januar 2019 14:51:54 CET schrieb Scott Kostyshak > : > > On Sun, Jan 06, 2019 at 08:15:20PM +0100, Kornel Benko wrote: > > > Am Sonntag, 6. Januar 2019 14:03:37 CET schrieb Scott Kostyshak > > > : > > > > On Sun, Jan

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Kornel Benko
Am Sonntag, 6. Januar 2019 14:51:54 CET schrieb Scott Kostyshak : > On Sun, Jan 06, 2019 at 08:15:20PM +0100, Kornel Benko wrote: > > Am Sonntag, 6. Januar 2019 14:03:37 CET schrieb Scott Kostyshak > > : > > > On Sun, Jan 06, 2019 at 07:46:03PM +0100, Jürgen Spitzmüller wrote: > > > > Am

Re: [LyX/master] ctests: invert ko splash lyx22x and lyx23x tests

2019-01-06 Thread Jürgen Spitzmüller
Am Montag, den 07.01.2019, 06:45 +0100 schrieb Kornel Benko: > Thanks Jürgen and Scott, works as expected. > What about to make it compilable for xetex and luatex too? > Since 'mj' refers to 'myeongjo', the attached seems appropriate. Good idea. Jürgen signature.asc Description: This is a

Re: [LyX/master] Properly implement CJKutf8

2019-01-06 Thread Jürgen Spitzmüller
Am Sonntag, den 06.01.2019, 14:34 +0100 schrieb Juergen Spitzmueller: > commit d193cd05a8e3be92e34a873416a16c2a474b61cb > Author: Juergen Spitzmueller > Date: Sun Jan 6 14:36:11 2019 +0100 > > Properly implement CJKutf8 > > If we use that, the document actually needs to be in utf8