Re: Misplaced IME window in 2.4.0
On 2024-04-07 12:38 PM, lyx-devel-requ...@lists.lyx.org wrote: On 2024-04-07 4:15 AM,lyx-devel-requ...@lists.lyx.org wrote: On Sat, Apr 06, 2024 at 04:48:03PM GMT, Allan Chain wrote: Hi Scott, I think its a regression in LyX code. Although the Qt version is different, the code in 2.3.x branch correctly returns the position of the caret in `GuiWorkArea::inputMethodQuery`. However in 2.4.x branch, it returns `im_cursor_rect_` which is only updated when preedit is enabled. Allan Chain Thanks for the explanation, Allan. As J?rgen mentions, having this on trac will help. Here is a ticket that Koji is currently working on: https://www.lyx.org/trac/ticket/11723 Scott Hi Scott, Thanks for the advice, and also thank J?rgen. However, I currently don't have access to my trac account because somehow the password saved in my password manager is incorrect, and I failed to find the reset password link. I'll see if I can find the correct password, otherwise I'll create a new account to create the ticket. Allan Chain Thanks for the help from Riki and JMarc. I have got access to my account and create a ticket at https://www.lyx.org/trac/ticket/13054#ticket -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: File format increases on master make it hard to test
On Sun, Apr 07, 2024 at 03:13:44PM GMT, Richard Kimberly Heck wrote: > On 4/7/24 12:46, José Matos wrote: > > On Sun, 2024-04-07 at 11:31 -0400, Scott Kostyshak wrote: > > > Fair enough. That was what I was afraid of (and expected). > > > > > > Scott > > A possible mid-term solution, to your use case, is to set the output > > format of the latest stable version. > > > > This would mean that any document is always imported to the latest > > development release and when saved it is done in the stable file > > format. > > > > On the other hand what this would mean to stress the > > conversion/reversion round trip. > > > > This could be implemented as some kind of option to set, by default, > > the save file format version or even better, because in this case this > > is what it intended, the target version. > > > > In the preferences file this could go as: > > > > \save_file_format 2.4 > > > > If this option is not set then everything works as usual. > > If it is set then, when the file is saved, the file is reverted to that > > file format. > > > > I hope that this idea helps, :-) > > That is a good idea. It's too late for 2.4.x, but if it were added early to > master, then it would be usable for Scott's purpose. > > The roundtrip would of course only matter if one made use of features that > required a format change. Thanks, that is a good idea, but I would not want to use that setting for most of my documents. I find that doing repeated lyx2lyx does not create a smooth workflow. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: SIGSEGV introduced recently on master when deleting an inset
On Sun, Apr 07, 2024 at 07:34:10PM GMT, Jean-Marc Lasgouttes wrote: > Le 06/04/2024 à 22:14, Scott Kostyshak a écrit : > > To reproduce: > > > > 1. Open the attached example. > > 2. Put the cursor just after the Note inset. > > 3. Press twice. > > > > I get a SIGSEGV with the attached backtrace. > > > > Can anyone else reproduce on current master? > > This is now fixed in master at 89901123c579. A typical example of why the > second part of biginset is more dangerous IMO: removing an update that was > here "just in case" will expose cases where the update should have been > requested because of a real need. Thanks for the fix! Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Layout file format change proposal
On 4/7/24 08:39, Lorenzo Bertini wrote: Just out of curiosity I've tried converting a LyX document to YAML and XML to see how they would look. I spent some time once working on an XML file format, thinking I could use some of the machinery developed for XHTML output, which is now even more robust since Thibaut's work on DocBook. It quickly became clear, though, that this was going to be very non-trivial. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: File format increases on master make it hard to test
On 4/7/24 12:46, José Matos wrote: On Sun, 2024-04-07 at 11:31 -0400, Scott Kostyshak wrote: Fair enough. That was what I was afraid of (and expected). Scott A possible mid-term solution, to your use case, is to set the output format of the latest stable version. This would mean that any document is always imported to the latest development release and when saved it is done in the stable file format. On the other hand what this would mean to stress the conversion/reversion round trip. This could be implemented as some kind of option to set, by default, the save file format version or even better, because in this case this is what it intended, the target version. In the preferences file this could go as: \save_file_format 2.4 If this option is not set then everything works as usual. If it is set then, when the file is saved, the file is reverted to that file format. I hope that this idea helps, :-) That is a good idea. It's too late for 2.4.x, but if it were added early to master, then it would be usable for Scott's purpose. The roundtrip would of course only matter if one made use of features that required a format change. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: c2248 compile error with qcompare and Qt 6.7.0
On 4/7/24 14:48, Jean-Marc Lasgouttes wrote: Le 05/04/2024 à 18:09, Yu Jin a écrit : Is it better when replacing uint with unsigned int? Yeah, it is. This is now in master. Riki, can I backport this trivial fix (c7f53afd), along with the more complicated 51562ff3 to 2.4.x? This is needed for compilation with MSVC 2019. OK. -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: SIGSEGV introduced recently on master when deleting an inset
Le 07/04/2024 à 20:45, Jürgen Spitzmüller a écrit : Am Sonntag, dem 07.04.2024 um 19:34 +0200 schrieb Jean-Marc Lasgouttes: This is now fixed in master at 89901123c579. Thanks, this also fixes the other, minor issue (CT related) I reported. Great, I was about to look for this one. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: c2248 compile error with qcompare and Qt 6.7.0
Le 05/04/2024 à 18:09, Yu Jin a écrit : Is it better when replacing uint with unsigned int? Yeah, it is. This is now in master. Riki, can I backport this trivial fix (c7f53afd), along with the more complicated 51562ff3 to 2.4.x? This is needed for compilation with MSVC 2019. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: SIGSEGV introduced recently on master when deleting an inset
Am Sonntag, dem 07.04.2024 um 19:34 +0200 schrieb Jean-Marc Lasgouttes: > This is now fixed in master at 89901123c579. Thanks, this also fixes the other, minor issue (CT related) I reported. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: 2.3.x does not compile on Windows
Le 05/04/2024 à 22:12, Yu Jin a écrit : Hi, Since 2.3.8 is around the corner I thought to try compiling the 2.3.x branch but failed on Format.cpp, get these errors: Build started at 22:05... 1>-- Build started: Project: LyX (applications\LyX\LyX), Configuration: Debug x64 -- 1>Format.cpp 1>C:\lyx\master\src\Format.cpp(61,33): error C2504: 'unary_function': base class undefined 1>C:\lyx\master\src\Format.cpp(61,47): error C2143: syntax error: missing ',' before '<' 1>C:\lyx\master\src\Format.cpp(75,38): error C2504: 'unary_function': base class undefined 1>C:\lyx\master\src\Format.cpp(75,52): error C2143: syntax error: missing ',' before '<' 1>C:\lyx\master\src\Format.cpp(89,32): error C2504: 'unary_function': base class undefined 1>C:\lyx\master\src\Format.cpp(89,46): error C2143: syntax error: missing ',' before '<' 1>C:\lyx\master\src\Format.cpp(608,18): warning C4244: 'return': conversion from '__int64' to 'int', possible loss of data 1>Done building project "LyX.vcxproj" -- FAILED. == Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped == == Build completed at 22:05 and took 00,762 seconds == Any Ideas? Can you try to enforce C++11 mode to see whether it works better? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: SIGSEGV introduced recently on master when deleting an inset
Le 06/04/2024 à 22:14, Scott Kostyshak a écrit : To reproduce: 1. Open the attached example. 2. Put the cursor just after the Note inset. 3. Press twice. I get a SIGSEGV with the attached backtrace. Can anyone else reproduce on current master? This is now fixed in master at 89901123c579. A typical example of why the second part of biginset is more dangerous IMO: removing an update that was here "just in case" will expose cases where the update should have been requested because of a real need. I will cherry-pick this to biginset branch for later use. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: File format increases on master make it hard to test
On Sun, 2024-04-07 at 11:31 -0400, Scott Kostyshak wrote: > Fair enough. That was what I was afraid of (and expected). > > Scott A possible mid-term solution, to your use case, is to set the output format of the latest stable version. This would mean that any document is always imported to the latest development release and when saved it is done in the stable file format. On the other hand what this would mean to stress the conversion/reversion round trip. This could be implemented as some kind of option to set, by default, the save file format version or even better, because in this case this is what it intended, the target version. In the preferences file this could go as: \save_file_format 2.4 If this option is not set then everything works as usual. If it is set then, when the file is saved, the file is reverted to that file format. I hope that this idea helps, :-) -- José Abílio -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: File format increases on master make it hard to test
On Sun, Apr 07, 2024 at 06:32:47AM GMT, Jürgen Spitzmüller wrote: > Am Samstag, dem 06.04.2024 um 16:51 -0400 schrieb Scott Kostyshak: > > I imagine others face the same situation? Is there anything that can > > be done? > > No, I think this will be a nightmare to maintain. And then, you really > do not "text master" if you strip the most interesting commits. Fair enough. That was what I was afraid of (and expected). Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Layout file format change proposal
Dear devs, thanks to everyone who chimed in. I didn't understand José's reply until I looked at the lexers we use and found only one. I just didn't occur to me that most files LyX uses are in this same format, documents and configurations alike. This is a considerable advantage of LyX's own format, and made me rethink my proposal. Indeed it would make sense, if we have to change, to choose only one format. But in my opinion, the best option for documents would be XML, contrary to what so far we discussed about configuration files. Perhaps it's best to leave things as they are. Just out of curiosity I've tried converting a LyX document to YAML and XML to see how they would look. LYX: \lyxformat 620 \begin_document \begin_header \language italian \language_package default \inputencoding utf8 \fontencoding auto \font_roman "default" "default" \font_sf_scale 100 100 \end_header \begin_body \begin_layout Title LyX is a great editor \end_layout \begin_layout Author Lorenzo \end_layout \begin_layout Section Why LyX is great \end_layout \begin_layout Standard \SpecialChar LyX can write \series bold equations \series default like this with a nice editor \begin_inset Formula \[ (i\hbar\gamma^{\mu}\partial_{\mu}-mc)\psi(x)=0 \] \end_inset \end_layout \begin_layout Section Lyx is the best \end_layout \begin_layout Standard Lyx can make \emph on tables \emph default and \emph on figures \emph default . \begin_inset Float figure placement document alignment document wide false sideways false status collapsed \begin_layout Plain Layout \begin_inset Graphics filename empty.png \end_inset \end_layout \begin_layout Plain Layout \begin_inset Caption Standard \begin_layout Plain Layout Example image \end_layout \end_inset \end_layout \end_inset \end_layout \end_body \end_document YAML: document: header: language: italian language_package: default inputencoding: utf8 fontencoding: auto font_roman: [default, default] font_sf_scale: [100, 100] body: - Title: "LyX is a great editor" - Author: "Lorenzo" - Section: "Why LyX is great" Standard: | "LyX can write **equations** like this with a nice editor" "\\[ (i\hbar\gamma^{\mu}\partial_{\mu}-mc)\psi(x)=0 \\]" - Section: "Lyx is the best" Standard: | "Lyx can make *on* tables *default* and *on* figures *default*." Float_figure: placement: document alignment: document wide: false sideways: false status: collapsed Plain_Layout: - Graphics: filename: empty.png - Caption: "Example image" XML: italian default utf8 auto default default 100 100 LyX is a great editor Lorenzo Why LyX is great LyX can write equations like this with a nice editor (i\hbar\gamma^{\mu}\partial_{\mu}-mc)\psi(x)=0 Lyx is the best Lyx can make on tables default and on figures default. document document false false collapsed empty.png Example image More informations about the XML structure can be found in the wiki page about the hypothetical transition. I updated it with some examples and things yet to determine. Thanks to everyone that contributed to this discussion. It was insightful. Lorenzo. Il giorno ven 5 apr 2024 alle ore 11:52 José Matos ha scritto: > > On Thu, 2024-03-28 at 13:00 +0100, Thibaut Cuvelier wrote: > > All of these formats are rather well supported and far from shiny new > > things (I think all of them have at least a decade of existence). > > > > Regarding validation: XML Schema has many offsprings, such as JSON > > Schema (https://json-schema.org/), with implementations that work on > > YAML and TOML (https://json-schema-everywhere.github.io/toml). In any > > case, these schemas are extremely lacking compared to 21st-century > > XML validation (RelaxNG with Schematron). > > We currently have no validation, but it would be great to have it as > > part of the test suite. > > > > How well do these formats work with (long) strings? What's great with > > the current format is that you don't need to escape anything when LyX > > expects a string. This aspect of the design removes a huge source of > > typos. > > I agree with Thibaut's analysis. > > In addition I would say that with all its faults the upgrade mechanism > between the different file formats is well defined and streamlined, > note for example the number of LyX file formats that we have (more than > 100). > > And this is also the part that lead us to the elephant in the room, the > LyX file format where most of these discussions took place. > > IMHO it only makes sense to choose a file format if the purpose is to > change all the different file formats to that model: > > * bind (key
Re: SIGSEGV introduced recently on master when deleting an inset
Thanks for the bisect. I'll handle it. JMarc Le 7 avril 2024 07:16:17 GMT+02:00, "Jürgen Spitzmüller" a écrit : >Am Sonntag, dem 07.04.2024 um 06:50 +0200 schrieb Jürgen Spitzmüller: >> Just doing a bisect. > >73678dcde977802d5ff3ae07f0226484041fff48 is the first bad commit >commit 73678dcde977802d5ff3ae07f0226484041fff48 >Author: Jean-Marc Lasgouttes >Date: Mon Nov 27 15:57:09 2023 +0100 > >Avoid full metrics computation when entering/leaving inset > >Annotate function LFUN_FINISHED_xxx to indicate that they do not >require a full metrics computation. > >Remove an "optimization" that meant that when the cursor changed >inset, a full metrics computation was requested. > >Part of bug #12297 > > >-- >Jürgen >-- >lyx-devel mailing list >lyx-devel@lists.lyx.org >http://lists.lyx.org/mailman/listinfo/lyx-devel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel