Re: LyX Status

2004-11-10 Thread Andreas Vox
Jos Ablio Oliveira Matos [EMAIL PROTECTED] writes: On Tue, Nov 09, 2004 at 11:39:50AM +, Andreas Vox wrote: Branches work fine except two minor quirks: * If you insert a branch for the whole section, the layout becomes standard inside the branch inset and stays section

[patch] two fixes

2004-11-10 Thread Alfredo Braunstein
I've applied these two patches to CoordBranch and the same could be done for HEAD. collap.diff is a bug in insetcollapsable::dispatch, it calls insetcollapsable::edit on opening but it shouldn't (edit has an extraneous cur.push(this)). I don't know if this bug manifests itself in HEAD in some

Re: [patch] two fixes

2004-11-10 Thread Jean-Marc Lasgouttes
Alfredo == Alfredo Braunstein [EMAIL PROTECTED] writes: Alfredo I've applied these two patches to CoordBranch and the same Alfredo could be done for HEAD. Alfredo collap.diff is a bug in insetcollapsable::dispatch, it calls Alfredo insetcollapsable::edit on opening but it shouldn't (edit has

[PATCH] make insetlatexaccents real letters

2004-11-10 Thread Jean-Marc Lasgouttes
This patch makes sure that insetlatexaccents are considered as normal letters by the code that handles words (word-backward/forward, word-select). I'll apply it shortly. JMarc Index: src/insets/ChangeLog === RCS file:

Re: [patch] two fixes

2004-11-10 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: Alfredo == Alfredo Braunstein [EMAIL PROTECTED] writes: Alfredo I've applied these two patches to CoordBranch and the same Alfredo could be done for HEAD. Alfredo collap.diff is a bug in insetcollapsable::dispatch, it calls Alfredo insetcollapsable::edit on

Re: [patch] two fixes

2004-11-10 Thread Jean-Marc Lasgouttes
Alfredo == Alfredo Braunstein [EMAIL PROTECTED] writes: Alfredo The cur.push bit is a bug, not the behaviour of putting the Alfredo cursor inside (that I don't particularly like in any case). Alfredo The inset is already inside the cursor, this is done in Alfredo editXY. Pushing again the inset

[PATCH] Bug 1739: The optional argument inset does not propagate the NeedProtect flag

2004-11-10 Thread Jean-Marc Lasgouttes
The following patches intend to fix bug 1739. Basically, the problem was that InsetOptArg::latexOptional did not honor correctly the moving_arg parameter of the enclosing paragraph. Comments? JMarc Index: src/ChangeLog === RCS

Re: [patch] two fixes

2004-11-10 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: Alfredo The cur.push bit is a bug, not the behaviour of putting the Alfredo cursor inside (that I don't particularly like in any case). Alfredo The inset is already inside the cursor, this is done in Alfredo editXY. Pushing again the inset gives a non-valid cursor,

Re: [patch] two fixes

2004-11-10 Thread Jean-Marc Lasgouttes
Alfredo == Alfredo Braunstein [EMAIL PROTECTED] writes: Inheriting is the right thing to do in tabulars, for example. Alfredo You didn't say that before. Are you sure? I guess InsetNote and InsetBranch may need that too, but

Re: [patch] two fixes

2004-11-10 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: Inheriting is the right thing to do in tabulars, for example. Alfredo You didn't say that before. Are you sure? Yes, I'm sure. ;-) One thing is Inheriting is the right thing to do in tabulars,

Re: [patch] two fixes

2004-11-10 Thread Jean-Marc Lasgouttes
Alfredo == Alfredo Braunstein [EMAIL PROTECTED] writes: Alfredo Yes, I'm sure. ;-) One thing is Inheriting is the right Alfredo thing to do in tabulars, for example. another is tabulars Alfredo are the only latex example I can think of now The fact that I only cited one example was a proof that

Re: LyX Status

2004-11-10 Thread Alfredo Braunstein
John Levon wrote: On Tue, Nov 09, 2004 at 10:08:50AM +0100, Juergen Spitzmueller wrote: What needs to be done beneath fixing the crashes is: getting the merge feature in a workable state again. This is not a big deal, since it's new in 1.4, it can easily be backed out. Or, we could just

Re: Format hack in client.C

2004-11-10 Thread Herbert Voss
Georg Baum wrote: Am Dienstag, 9. November 2004 09:19 schrieb Lars Gullik Bjønnes: I am quite happy with your patch... Good. with this fixed. Of course ;-) I am applying this now. I'll fix the users format later if it is needed after Herberts explanation (which he hopefully gives). I have an

Re: LyX Status

2004-11-10 Thread Juergen Spitzmueller
Andreas Vox wrote: * Always deactivates branches after opening (is this wanted?) no (but I cannot reproduce it). Can you give an example? Jürgen

Re: [patch] two fixes

2004-11-10 Thread Martin Vermeer
On Wed, 2004-11-10 at 17:02, Alfredo Braunstein wrote: Jean-Marc Lasgouttes wrote: Inheriting is the right thing to do in tabulars, for example. Alfredo You didn't say that before. Are you sure? Yes, I'm sure.

[patch] fix a crash in backspace

2004-11-10 Thread Alfredo Braunstein
[foot]--+ |aa | ||bbb | +---+ and press backspace - crash. fix attached. Alfredo Index: text.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/text.C,v retrieving revision 1.584 diff -u -p -u -r1.584

Re: LyX Status

2004-11-10 Thread Andreas Vox
Josà AbÃlio Oliveira Matos <[EMAIL PROTECTED]> writes: < On Tue, Nov 09, 2004 at 11:39:50AM +, Andreas Vox wrote: < > < > Branches work fine except two minor quirks: < > * If you insert a branch for the whole section, the layout becomes < > "standard" < >inside the branch inset and

[patch] two fixes

2004-11-10 Thread Alfredo Braunstein
I've applied these two patches to CoordBranch and the same could be done for HEAD. collap.diff is a bug in insetcollapsable::dispatch, it calls insetcollapsable::edit on opening but it shouldn't (edit has an extraneous cur.push(this)). I don't know if this bug manifests itself in HEAD in some

Re: [patch] two fixes

2004-11-10 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> I've applied these two patches to CoordBranch and the same Alfredo> could be done for HEAD. Alfredo> collap.diff is a bug in insetcollapsable::dispatch, it calls Alfredo> insetcollapsable::edit on opening but it shouldn't

[PATCH] make insetlatexaccents real letters

2004-11-10 Thread Jean-Marc Lasgouttes
This patch makes sure that insetlatexaccents are considered as normal letters by the code that handles words (word-backward/forward, word-select). I'll apply it shortly. JMarc Index: src/insets/ChangeLog === RCS file:

Re: [patch] two fixes

2004-11-10 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: >> "Alfredo" == Alfredo Braunstein >> <[EMAIL PROTECTED]> writes: > > Alfredo> I've applied these two patches to CoordBranch and the same > Alfredo> could be done for HEAD. > > Alfredo> collap.diff is a bug in insetcollapsable::dispatch, it calls > Alfredo>

Re: [patch] two fixes

2004-11-10 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> The cur.push bit is a bug, not the behaviour of putting the Alfredo> cursor inside (that I don't particularly like in any case). Alfredo> The inset is already inside the cursor, this is done in Alfredo> editXY. Pushing

[PATCH] Bug 1739: The optional argument inset does not propagate the NeedProtect flag

2004-11-10 Thread Jean-Marc Lasgouttes
The following patches intend to fix bug 1739. Basically, the problem was that InsetOptArg::latexOptional did not honor correctly the moving_arg parameter of the enclosing paragraph. Comments? JMarc Index: src/ChangeLog === RCS

Re: [patch] two fixes

2004-11-10 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Alfredo> The cur.push bit is a bug, not the behaviour of putting the > Alfredo> cursor inside (that I don't particularly like in any case). > Alfredo> The inset is already inside the cursor, this is done in > Alfredo> editXY. Pushing again the inset gives a non-valid

Re: [patch] two fixes

2004-11-10 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Inheriting is the right thing to do in tabulars, for example. Alfredo> You didn't say that before. Are you sure? >> I guess InsetNote and InsetBranch may

Re: [patch] two fixes

2004-11-10 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Inheriting is the right thing to do in tabulars, for example. > > > Alfredo> You didn't say that before. > > Are you sure? Yes, I'm sure. ;-) One thing is "Inheriting is the right thing to do in

Re: [patch] two fixes

2004-11-10 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> Yes, I'm sure. ;-) One thing is "Inheriting is the right Alfredo> thing to do in tabulars, for example." another is "tabulars Alfredo> are the only latex example I can think of now" The fact that I only cited one example

Re: LyX Status

2004-11-10 Thread Alfredo Braunstein
John Levon wrote: > On Tue, Nov 09, 2004 at 10:08:50AM +0100, Juergen Spitzmueller wrote: > >> What needs to be done beneath fixing the crashes is: getting the merge >> feature in a workable state again. > > This is not a big deal, since it's new in 1.4, it can easily be backed > out. Or, we

Re: Format hack in client.C

2004-11-10 Thread Herbert Voss
Georg Baum wrote: Am Dienstag, 9. November 2004 09:19 schrieb Lars Gullik Bjønnes: I am quite happy with your patch... Good. with this fixed. Of course ;-) I am applying this now. I'll fix the "users" format later if it is needed after Herberts explanation (which he hopefully gives). I have an

Re: LyX Status

2004-11-10 Thread Juergen Spitzmueller
Andreas Vox wrote: > * Always deactivates branches after opening (is this wanted?) no (but I cannot reproduce it). Can you give an example? Jürgen

Re: [patch] two fixes

2004-11-10 Thread Martin Vermeer
On Wed, 2004-11-10 at 17:02, Alfredo Braunstein wrote: > Jean-Marc Lasgouttes wrote: > > > Inheriting is the right thing to do in tabulars, for example. > > > > > > Alfredo> You didn't say that before. > > > > Are you sure? >

[patch] fix a crash in backspace

2004-11-10 Thread Alfredo Braunstein
[foot]--+ |aa | ||bbb | +---+ and press backspace -> crash. fix attached. Alfredo Index: text.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/text.C,v retrieving revision 1.584 diff -u -p -u -r1.584