Georg Baum wrote:
Am Samstag, 16. September 2006 18:47 schrieb Abdelrazak Younes:
I don't need to know. I am just moving code around and this should just
work. I am quite confident actually that it _will_ just work.
OK, suppose it works. Then there is still the problem that this is supposed
Andre Poenitz wrote:
On Sat, Sep 16, 2006 at 07:19:16PM +0200, Georg Baum wrote:
Am Samstag, 16. September 2006 18:47 schrieb Abdelrazak
Younes:
I don't need to know. I am just moving code around and this
should just work. I am quite confident actually that it
_will_ just work.
OK, suppose
Andre Poenitz wrote:
On Sat, Sep 16, 2006 at 03:20:36PM +0200, Abdelrazak Younes wrote:
Comments?
I am about to re-evaluate my stance about parent inset pointers
being bad.
[It's already lasting for a while...]
If we had them, there was a natural solution fo this the main
text problem.
Joost Verburg wrote:
Jean-Marc Lasgouttes wrote:
This last bug seems to be a consequence of the fix to bug 2423. Try to
see what happens when the spellchecker window gains and looses focus:
it jumps to the next word :(
Most spell checker problems are indeed caused by this wrong fix. I
[EMAIL PROTECTED] wrote:
Author: poenitz
Date: Sat Sep 16 20:11:38 2006
New Revision: 15023
URL: http://www.lyx.org/trac/changeset/15023
Log:
rename Math*Inset into InsetMath*
Modified:
lyx-devel/trunk/src/CutAndPaste.C
lyx-devel/trunk/src/cursor.C
lyx-devel/trunk/src/cursor.h
Georg Baum wrote:
selection, so a sensible cleanup IMO would be to rename selectionRequested
to requestSelection and selectionLost to clearSelection.
I've done that and verified that it will compile under X11. Will commit
soon.
Abdel.
Index: BufferView.C
Jean-Marc,
attached please find a simple patch that improves CT in LyX 1.4.
Essentially, the patch consists of three parts:
1. The change bar is smarter (reduced width, more margin)
The code changes are trivial and please your eyes :-)
2. next change is introduced
This feature makes it
Forgot to generate a patch, sorry.
[EMAIL PROTECTED] wrote:
Author: younes
Date: Sun Sep 17 10:48:06 2006
New Revision: 15025
URL: http://www.lyx.org/trac/changeset/15025
Log:
delete unsetXSel() method
Modified:
lyx-devel/trunk/src/BufferView.C
lyx-devel/trunk/src/BufferView.h
Hello,
I would like to move the Intl member from LyXView to BufferView as this
is more a kernel thing IMHO.
Any objection?
Abdel.
On Sun, Sep 17, 2006 at 12:04:20AM +0200, [EMAIL PROTECTED] wrote:
On Sat, 16 Sep 2006, Andre Poenitz wrote:
On Sat, Sep 16, 2006 at 05:34:37PM +0200, [EMAIL PROTECTED] wrote:
The function InsetERT:getStatus() suppress (disable) accents within ERT
insets, which makes sense.
But
On Sat, Sep 16, 2006 at 10:27:43PM +0100, Angus Leeming wrote:
Author: poenitz
Date: Sat Sep 16 20:11:38 2006
New Revision: 15023
URL: http://www.lyx.org/trac/changeset/15023
Log:
rename Math*Inset into InsetMath*
lyx-devel/trunk/src/mathed/math_amsarrayinset.C
Michael Gerz wrote:
Hello sml sml world
That looks like 4 words.
Joost
On Sun, Sep 17, 2006 at 11:06:05AM +0200, Abdelrazak Younes wrote:
Hello,
I would like to move the Intl member from LyXView to BufferView as this
is more a kernel thing IMHO.
Any objection?
Not really.
Andre'
On Sun, Sep 17, 2006 at 10:03:58AM +0200, Abdelrazak Younes wrote:
Did you remove the CursorShape macro trick on purpose?
The only thing I removed on purpose on top of what I announced was a
compile error due to someone using
Foo const foo = ...
instead of
Foo const foo = ...
Andre'
Andre Poenitz wrote:
On Sat, Sep 16, 2006 at 10:27:43PM +0100, Angus Leeming wrote:
Author: poenitz
Date: Sat Sep 16 20:11:38 2006
New Revision: 15023
URL: http://www.lyx.org/trac/changeset/15023
Log:
rename Math*Inset into InsetMath*
lyx-devel/trunk/src/mathed/math_amsarrayinset.C
On Sun, Sep 17, 2006 at 10:03:58AM +0200, Abdelrazak Younes wrote:
[EMAIL PROTECTED] wrote:
Author: poenitz
Date: Sat Sep 16 20:11:38 2006
New Revision: 15023
URL: http://www.lyx.org/trac/changeset/15023
Log:
rename Math*Inset into InsetMath*
Modified:
Michael Gerz wrote:
only the third word is identified as faulty but the spell checker states
that it has checked four words. So it definitely skips some words in the
document.
The first misspelled word is skipped because of the wrong fix for bug
2423. It identifies both words when the patch
Andre Poenitz wrote:
On Sun, Sep 17, 2006 at 10:03:58AM +0200, Abdelrazak Younes wrote:
Did you remove the CursorShape macro trick on purpose?
The only thing I removed on purpose on top of what I announced was a
compile error due to someone using
Year, I tried to commit it myself but you
Andre Poenitz wrote:
On Sun, Sep 17, 2006 at 10:03:58AM +0200, Abdelrazak Younes wrote:
[EMAIL PROTECTED] wrote:
Author: poenitz
Date: Sat Sep 16 20:11:38 2006
New Revision: 15023
URL: http://www.lyx.org/trac/changeset/15023
Log:
rename Math*Inset into InsetMath*
Modified:
Andre Poenitz wrote:
On Sun, Sep 17, 2006 at 11:06:05AM +0200, Abdelrazak Younes wrote:
Hello,
I would like to move the Intl member from LyXView to BufferView as this
is more a kernel thing IMHO.
Any objection?
Not really.
OK, then this patch does so. Will commit soon.
Abdel.
Index:
On Sun, Sep 17, 2006 at 11:10:51AM +0200, Abdelrazak Younes wrote:
Andre Poenitz wrote:
On Sat, Sep 16, 2006 at 10:27:43PM +0100, Angus Leeming wrote:
Author: poenitz
Date: Sat Sep 16 20:11:38 2006
New Revision: 15023
URL: http://www.lyx.org/trac/changeset/15023
Log:
rename Math*Inset
On Sun, Sep 17, 2006 at 11:28:49AM +0200, Abdelrazak Younes wrote:
Andre Poenitz wrote:
On Sun, Sep 17, 2006 at 10:03:58AM +0200, Abdelrazak Younes wrote:
[EMAIL PROTECTED] wrote:
Author: poenitz
Date: Sat Sep 16 20:11:38 2006
New Revision: 15023
URL:
Has anybody seen svn being unable to even run 'svn cleanup'?
[EMAIL PROTECTED]:/laptop/usr/src/lyx/trunk/src/mathed svn cleanup
svn: In directory ''
svn: Error processing command 'committed' in ''
svn: Log command for directory 'math_tfracinset.C' is mislocated
This happened after the modem
[EMAIL PROTECTED] wrote:
Author: poenitz
Date: Sun Sep 17 12:00:15 2006
New Revision: 15029
URL: http://www.lyx.org/trac/changeset/15029
Log:
cleanup after svn hang-up, #undef CursorShape. Should be compilable ganin n=
ow.
I still have compilation problems:
InsetMathXYArrow.C
Hello,
This patch makes LyXText code use directly LyXText::dispatch() instead
of the cur.bv().owner()-dispatch() redirection.
Objection?
Abdel.
Index: text2.C
===
--- text2.C (revision 15030)
+++ text2.C (working copy)
This avoids the bv-owner()-dispatch() redirection.
Will commit soon.
Abdel.
Index: lyxfunc.C
===
--- lyxfunc.C (revision 15031)
+++ lyxfunc.C (working copy)
@@ -651,9 +651,7 @@
}
-namespace {
-
-bool
Abdelrazak Younes [EMAIL PROTECTED] writes:
|
|
| -int BufferView::offset_ref() const
| -{
| - return offset_ref_;
| -}
| -
Why is this change in this patch?
--
Lgb
Abdelrazak Younes [EMAIL PROTECTED] writes:
| Hello,
|
| This patch makes LyXText code use directly LyXText::dispatch() instead
| of the cur.bv().owner()-dispatch() redirection.
|
| Objection?
Is it guaranteed that 'this' is equal to 'bv.owner()'?
How is that guarantee forced?
--
Abdelrazak Younes [EMAIL PROTECTED] writes:
| This avoids the bv-owner()-dispatch() redirection.
|
| Will commit soon.
I am not confident in its correctness.
--
Lgb
On a clean tree, after make distclean and running autogen.sh:
QWorkArea.C: In function 'bool lyxX11EventFilter(XEvent*)':
QWorkArea.C:114: error: 'class LyXView' has no member named 'requestSelection'
QWorkArea.C:116: error: invalid use of undefined type 'struct
lyx::frontend::Gui'
Juergen Spitzmueller wrote:
QWorkArea.C: In function 'bool lyxX11EventFilter(XEvent*)':
QWorkArea.C:114: error: 'class LyXView' has no member named
'requestSelection'
This error is fixed with the attached patch.
No idea about the second one, though:
QWorkArea.C:116: error: invalid use of
Jean-Marc Lasgouttes schrieb:
I propose to add accept/reject change and tipa now. I am not sure we
need dissolve inset (especially since the name itself may be more
misleading than the action). I am not sure what reference-next does
and whether it is useful.
I applied the changes on which you
Michael Gerz wrote:
I applied the changes on which you agreed. Personally, I think that
function inset-dissolve should also be promoted a little bit. There is
no way for the average user to get notice of it.
Document it in the User Guide (sec. 4.1, for instance)! The most common use is
[EMAIL PROTECTED] writes:
| Author: poenitz
| Date: Sun Sep 17 12:00:15 2006
| New Revision: 15029
|
| URL: http://www.lyx.org/trac/changeset/15029
| Log:
| cleanup after svn hang-up, #undef CursorShape. Should be compilable ganin n=
| ow.
|
| Modified:
| lyx-devel/trunk/src/buffer.C
|
Lars Gullik Bjønnes wrote:
Abdelrazak Younes [EMAIL PROTECTED] writes:
|
|
| -int BufferView::offset_ref() const
| -{
| - return offset_ref_;
| -}
| -
Why is this change in this patch?
Because I forgot to commit this cleanup before this one.
Lars Gullik Bjønnes wrote:
Abdelrazak Younes [EMAIL PROTECTED] writes:
| Hello,
|
| This patch makes LyXText code use directly LyXText::dispatch() instead
| of the cur.bv().owner()-dispatch() redirection.
|
| Objection?
Is it guaranteed that 'this' is equal to 'bv.owner()'?
How is that
Juergen Spitzmueller wrote:
Juergen Spitzmueller wrote:
QWorkArea.C: In function 'bool lyxX11EventFilter(XEvent*)':
QWorkArea.C:114: error: 'class LyXView' has no member named
'requestSelection'
This error is fixed with the attached patch.
No idea about the second one, though:
Lars Gullik Bjønnes wrote:
Abdelrazak Younes [EMAIL PROTECTED] writes:
| This avoids the bv-owner()-dispatch() redirection.
|
| Will commit soon.
I am not confident in its correctness.
I am not confident in your empty argument.
Abdel.
Abdelrazak Younes [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
| Abdelrazak Younes [EMAIL PROTECTED] writes:
| | This avoids the bv-owner()-dispatch() redirection.
| | | Will commit soon.
| I am not confident in its correctness.
|
| I am not confident in your empty argument.
We
Lars Gullik Bjønnes wrote:
Abdelrazak Younes [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
| Abdelrazak Younes [EMAIL PROTECTED] writes:
| | This avoids the bv-owner()-dispatch() redirection.
| | | Will commit soon.
| I am not confident in its correctness.
|
| I am not confident
Abdelrazak Younes wrote:
[EMAIL PROTECTED] wrote:
Author: poenitz
Date: Sun Sep 17 12:00:15 2006
New Revision: 15029
URL: http://www.lyx.org/trac/changeset/15029
Log:
cleanup after svn hang-up, #undef CursorShape. Should be compilable
ganin n=
ow.
I still have compilation problems:
Is
Abdelrazak Younes [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
| Abdelrazak Younes [EMAIL PROTECTED] writes:
| | Lars Gullik Bjønnes wrote:
| | Abdelrazak Younes [EMAIL PROTECTED] writes:
| | | This avoids the bv-owner()-dispatch() redirection.
| | | | Will commit soon.
| | I
Intl (lyx keymaps) and the transmanager.
I'd like to get rid of these. They were added ages ago to alleviate
problems with X,xforms and the desktopsystems we had then (the
non-existing ones).
It is not LyX's job to have keymaps, keyboard maps and the like. Even
dead keys is supported through
Lars Gullik Bjønnes wrote:
Abdelrazak Younes [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
| Abdelrazak Younes [EMAIL PROTECTED] writes:
| | Lars Gullik Bjønnes wrote:
| | Abdelrazak Younes [EMAIL PROTECTED] writes:
| | | This avoids the bv-owner()-dispatch() redirection.
| | |
Abdelrazak Younes [EMAIL PROTECTED] writes:
| Hello,
|
| This patch makes LyXText code use directly LyXText::dispatch() instead
| of the cur.bv().owner()-dispatch() redirection.
|
| Objection?
|
| Abdel.
| Index: text2.C
| ===
|
Abdelrazak Younes [EMAIL PROTECTED] writes:
| Hell? It is not very bad lamguage if you ask me. You have been using
| worse word against me. Check your archive.
Then I am sorry, I'll try to clean up my language and henceforth only
use the most civil language in my accusations.
| | The onus is
Lars Gullik Bjønnes wrote:
Abdelrazak Younes [EMAIL PROTECTED] writes:
| Hello,
|
| This patch makes LyXText code use directly LyXText::dispatch() instead
| of the cur.bv().owner()-dispatch() redirection.
|
| Objection?
|
| Abdel.
| Index: text2.C
|
Someone has been trying to spam wiki.lyx.org by having a script repated
upload files... (most likely this is the guy that Juergen was spending
a lot of time cleaning up after - thanks for all that work Juergen!).
After I while I discovered the uploading was done using our normal upload
manager
Lars Gullik Bjønnes wrote:
Abdelrazak Younes [EMAIL PROTECTED] writes:
| Hell? It is not very bad lamguage if you ask me. You have been using
| worse word against me. Check your archive.
Then I am sorry, I'll try to clean up my language and henceforth only
use the most civil language in my
Abdelrazak Younes [EMAIL PROTECTED] writes:
| The dispatch function called is not the same dispatch function
| anymore. There might be a reason why we have decided to go through the
| top most dispatch and let that handle the traversement of the dispatch
| hierarchy.
|
| And what is that
Abdelrazak Younes [EMAIL PROTECTED] writes:
| I have to change and you are right. Of course that's how it is.
|
| Are you ironic here or serious? I was pretty serious.
A bit of both I guess.
| A pity that you cannot come to denmark, we should get drunk (at least
| I) and then we could go
Lars Gullik Bjønnes wrote:
Abdelrazak Younes [EMAIL PROTECTED] writes:
| The dispatch function called is not the same dispatch function
| anymore. There might be a reason why we have decided to go through the
| top most dispatch and let that handle the traversement of the dispatch
|
Abdelrazak Younes wrote:
More seriously, why is it a problem? The dispatch hierarchy will
inevitably end-up there so why not take the shortcut? IMHO the code
looks a lot more cleaner this way.
It may look cleaner to you, but now you're creating two ways to get to
the same point. That's
On Sunday 17 September 2006 20:32, Lars Gullik Bjønnes wrote:
Other opinions on this?
I agree, I do not see anyone using this since at least 1.1.x
--
Lgb
--
José Abílio
As I've spent some time fiddling with stuff to deal with a spammer, please
report any problems you notice on the wiki. I hope nothing has broken, but
you never know!
cheers
/Christian
PS. Many thanks to Jürgen for fixing many of that spammers work this
weekend.
--
Christian Ridderström,
Abdelrazak Younes wrote:
You'd loose, I've been practising French boxing in my youth.
like zidane?!
lars, be careful!!
;-)
Abdelrazak Younes [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
| Abdelrazak Younes [EMAIL PROTECTED] writes:
| | The dispatch function called is not the same dispatch function
| | anymore. There might be a reason why we have decided to go through the
| | top most dispatch and let
This change makes Makefile.in.in also look at qt4 ui files.
In addition to that it changes the qt3 ui parsing to _not_ handle
caption names. I am not sure if this is wanted or not, but at least
the current captions are just bogus, so either we change them into
something useful, or we remove them
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| This change makes Makefile.in.in also look at qt4 ui files.
|
| In addition to that it changes the qt3 ui parsing to _not_ handle
| caption names. I am not sure if this is wanted or not, but at least
| the current captions are just bogus, so
Georg Baum wrote:
Am Samstag, 16. September 2006 18:47 schrieb Abdelrazak Younes:
I don't need to know. I am just moving code around and this should just
work. I am quite confident actually that it _will_ just work.
OK, suppose it works. Then there is still the problem that this is supposed
Andre Poenitz wrote:
On Sat, Sep 16, 2006 at 07:19:16PM +0200, Georg Baum wrote:
Am Samstag, 16. September 2006 18:47 schrieb Abdelrazak
Younes:
I don't need to know. I am just moving code around and this
should just work. I am quite confident actually that it
_will_ just work.
OK, suppose
Andre Poenitz wrote:
On Sat, Sep 16, 2006 at 03:20:36PM +0200, Abdelrazak Younes wrote:
Comments?
I am about to re-evaluate my stance about parent inset pointers
being bad.
[It's already lasting for a while...]
If we had them, there was a natural solution fo this the main
text problem.
Joost Verburg wrote:
Jean-Marc Lasgouttes wrote:
This last bug seems to be a consequence of the fix to bug 2423. Try to
see what happens when the spellchecker window gains and looses focus:
it jumps to the next word :(
Most spell checker problems are indeed caused by this wrong fix. I
[EMAIL PROTECTED] wrote:
Author: poenitz
Date: Sat Sep 16 20:11:38 2006
New Revision: 15023
URL: http://www.lyx.org/trac/changeset/15023
Log:
rename Math*Inset into InsetMath*
Modified:
lyx-devel/trunk/src/CutAndPaste.C
lyx-devel/trunk/src/cursor.C
lyx-devel/trunk/src/cursor.h
Georg Baum wrote:
selection, so a sensible cleanup IMO would be to rename selectionRequested
to requestSelection and selectionLost to clearSelection.
I've done that and verified that it will compile under X11. Will commit
soon.
Abdel.
Index: BufferView.C
Jean-Marc,
attached please find a simple patch that improves CT in LyX 1.4.
Essentially, the patch consists of three parts:
1. The change bar is smarter (reduced width, more margin)
The code changes are trivial and please your eyes :-)
2. "next change" is introduced
This feature makes
Forgot to generate a patch, sorry.
[EMAIL PROTECTED] wrote:
Author: younes
Date: Sun Sep 17 10:48:06 2006
New Revision: 15025
URL: http://www.lyx.org/trac/changeset/15025
Log:
delete unsetXSel() method
Modified:
lyx-devel/trunk/src/BufferView.C
lyx-devel/trunk/src/BufferView.h
Hello,
I would like to move the Intl member from LyXView to BufferView as this
is more a kernel thing IMHO.
Any objection?
Abdel.
On Sun, Sep 17, 2006 at 12:04:20AM +0200, [EMAIL PROTECTED] wrote:
> On Sat, 16 Sep 2006, Andre Poenitz wrote:
>
> > On Sat, Sep 16, 2006 at 05:34:37PM +0200, [EMAIL PROTECTED] wrote:
> > > The function InsetERT:getStatus() suppress (disable) accents within ERT
> > > insets, which makes sense.
>
On Sat, Sep 16, 2006 at 10:27:43PM +0100, Angus Leeming wrote:
> > Author: poenitz
> > Date: Sat Sep 16 20:11:38 2006
> > New Revision: 15023
> >
> > URL: http://www.lyx.org/trac/changeset/15023
> > Log:
> > rename Math*Inset into InsetMath*
>
> >
Michael Gerz wrote:
Hello sml sml world
That looks like 4 words.
Joost
On Sun, Sep 17, 2006 at 11:06:05AM +0200, Abdelrazak Younes wrote:
> Hello,
>
> I would like to move the Intl member from LyXView to BufferView as this
> is more a kernel thing IMHO.
>
> Any objection?
Not really.
Andre'
On Sun, Sep 17, 2006 at 10:03:58AM +0200, Abdelrazak Younes wrote:
> Did you remove the CursorShape macro trick on purpose?
The only thing I removed on purpose on top of what I announced was a
compile error due to someone using
Foo & const foo = ...
instead of
Foo const & foo = ...
Andre'
Andre Poenitz wrote:
On Sat, Sep 16, 2006 at 10:27:43PM +0100, Angus Leeming wrote:
Author: poenitz
Date: Sat Sep 16 20:11:38 2006
New Revision: 15023
URL: http://www.lyx.org/trac/changeset/15023
Log:
rename Math*Inset into InsetMath*
lyx-devel/trunk/src/mathed/math_amsarrayinset.C
On Sun, Sep 17, 2006 at 10:03:58AM +0200, Abdelrazak Younes wrote:
> [EMAIL PROTECTED] wrote:
> >Author: poenitz
> >Date: Sat Sep 16 20:11:38 2006
> >New Revision: 15023
> >
> >URL: http://www.lyx.org/trac/changeset/15023
> >Log:
> >rename Math*Inset into InsetMath*
> >
> >Modified:
> >
Michael Gerz wrote:
only the third word is identified as faulty but the spell checker states
that it has checked four words. So it definitely skips some words in the
document.
The first misspelled word is skipped because of the wrong fix for bug
2423. It identifies both words when the patch
Andre Poenitz wrote:
On Sun, Sep 17, 2006 at 10:03:58AM +0200, Abdelrazak Younes wrote:
Did you remove the CursorShape macro trick on purpose?
The only thing I removed on purpose on top of what I announced was a
compile error due to someone using
Year, I tried to commit it myself but you
Andre Poenitz wrote:
On Sun, Sep 17, 2006 at 10:03:58AM +0200, Abdelrazak Younes wrote:
[EMAIL PROTECTED] wrote:
Author: poenitz
Date: Sat Sep 16 20:11:38 2006
New Revision: 15023
URL: http://www.lyx.org/trac/changeset/15023
Log:
rename Math*Inset into InsetMath*
Modified:
Andre Poenitz wrote:
On Sun, Sep 17, 2006 at 11:06:05AM +0200, Abdelrazak Younes wrote:
Hello,
I would like to move the Intl member from LyXView to BufferView as this
is more a kernel thing IMHO.
Any objection?
Not really.
OK, then this patch does so. Will commit soon.
Abdel.
Index:
On Sun, Sep 17, 2006 at 11:10:51AM +0200, Abdelrazak Younes wrote:
> Andre Poenitz wrote:
> >On Sat, Sep 16, 2006 at 10:27:43PM +0100, Angus Leeming wrote:
> >>>Author: poenitz
> >>>Date: Sat Sep 16 20:11:38 2006
> >>>New Revision: 15023
> >>>
> >>>URL: http://www.lyx.org/trac/changeset/15023
>
On Sun, Sep 17, 2006 at 11:28:49AM +0200, Abdelrazak Younes wrote:
> Andre Poenitz wrote:
> >On Sun, Sep 17, 2006 at 10:03:58AM +0200, Abdelrazak Younes wrote:
> >>[EMAIL PROTECTED] wrote:
> >>>Author: poenitz
> >>>Date: Sat Sep 16 20:11:38 2006
> >>>New Revision: 15023
> >>>
> >>>URL:
Has anybody seen svn being unable to even run 'svn cleanup'?
[EMAIL PROTECTED]:/laptop/usr/src/lyx/trunk/src/mathed > svn cleanup
svn: In directory ''
svn: Error processing command 'committed' in ''
svn: Log command for directory 'math_tfracinset.C' is mislocated
This happened after the modem
[EMAIL PROTECTED] wrote:
Author: poenitz
Date: Sun Sep 17 12:00:15 2006
New Revision: 15029
URL: http://www.lyx.org/trac/changeset/15029
Log:
cleanup after svn hang-up, #undef CursorShape. Should be compilable ganin n=
ow.
I still have compilation problems:
InsetMathXYArrow.C
Hello,
This patch makes LyXText code use directly LyXText::dispatch() instead
of the cur.bv().owner()->dispatch() redirection.
Objection?
Abdel.
Index: text2.C
===
--- text2.C (revision 15030)
+++ text2.C (working copy)
This avoids the bv->owner()->dispatch() redirection.
Will commit soon.
Abdel.
Index: lyxfunc.C
===
--- lyxfunc.C (revision 15031)
+++ lyxfunc.C (working copy)
@@ -651,9 +651,7 @@
}
-namespace {
-
-bool
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
|
|
| -int BufferView::offset_ref() const
| -{
| - return offset_ref_;
| -}
| -
Why is this change in this patch?
--
Lgb
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Hello,
|
| This patch makes LyXText code use directly LyXText::dispatch() instead
| of the cur.bv().owner()->dispatch() redirection.
|
| Objection?
Is it guaranteed that 'this' is equal to 'bv.owner()'?
How is that guarantee forced?
--
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| This avoids the bv->owner()->dispatch() redirection.
|
| Will commit soon.
I am not confident in its correctness.
--
Lgb
On a clean tree, after make distclean and running autogen.sh:
QWorkArea.C: In function 'bool lyxX11EventFilter(XEvent*)':
QWorkArea.C:114: error: 'class LyXView' has no member named 'requestSelection'
QWorkArea.C:116: error: invalid use of undefined type 'struct
lyx::frontend::Gui'
Juergen Spitzmueller wrote:
> QWorkArea.C: In function 'bool lyxX11EventFilter(XEvent*)':
> QWorkArea.C:114: error: 'class LyXView' has no member named
> 'requestSelection'
This error is fixed with the attached patch.
No idea about the second one, though:
> QWorkArea.C:116: error: invalid use
Jean-Marc Lasgouttes schrieb:
I propose to add accept/reject change and tipa now. I am not sure we
need dissolve inset (especially since the name itself may be more
misleading than the action). I am not sure what reference-next does
and whether it is useful.
I applied the changes on which you
Michael Gerz wrote:
> I applied the changes on which you agreed. Personally, I think that
> function inset-dissolve should also be promoted a little bit. There is
> no way for the average user to get notice of it.
Document it in the User Guide (sec. 4.1, for instance)! The most common use is
[EMAIL PROTECTED] writes:
| Author: poenitz
| Date: Sun Sep 17 12:00:15 2006
| New Revision: 15029
|
| URL: http://www.lyx.org/trac/changeset/15029
| Log:
| cleanup after svn hang-up, #undef CursorShape. Should be compilable ganin n=
| ow.
|
| Modified:
| lyx-devel/trunk/src/buffer.C
|
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
|
|
| -int BufferView::offset_ref() const
| -{
| - return offset_ref_;
| -}
| -
Why is this change in this patch?
Because I forgot to commit this cleanup before this one.
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Hello,
|
| This patch makes LyXText code use directly LyXText::dispatch() instead
| of the cur.bv().owner()->dispatch() redirection.
|
| Objection?
Is it guaranteed that 'this' is equal to 'bv.owner()'?
How is that
Juergen Spitzmueller wrote:
Juergen Spitzmueller wrote:
QWorkArea.C: In function 'bool lyxX11EventFilter(XEvent*)':
QWorkArea.C:114: error: 'class LyXView' has no member named
'requestSelection'
This error is fixed with the attached patch.
No idea about the second one, though:
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| This avoids the bv->owner()->dispatch() redirection.
|
| Will commit soon.
I am not confident in its correctness.
I am not confident in your empty argument.
Abdel.
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | This avoids the bv->owner()->dispatch() redirection.
| > | | Will commit soon.
| > I am not confident in its correctness.
|
| I am not confident in your empty
Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| > | This avoids the bv->owner()->dispatch() redirection.
| > | | Will commit soon.
| > I am not confident in its correctness.
|
| I am not
Abdelrazak Younes wrote:
[EMAIL PROTECTED] wrote:
Author: poenitz
Date: Sun Sep 17 12:00:15 2006
New Revision: 15029
URL: http://www.lyx.org/trac/changeset/15029
Log:
cleanup after svn hang-up, #undef CursorShape. Should be compilable
ganin n=
ow.
I still have compilation problems:
Is
1 - 100 of 118 matches
Mail list logo
