> What about an iterator object? (that is, I'm no longer asking about
> "iterator vs. const_iterator" but now "const_iterator" vs. "const
> iterator const")
Never mind, your previous comment applies to this as well:
>> The fact that end is not modified anywhere in the loop will be quickly
>> disco
On Sun, Sep 2, 2012 at 4:23 PM, Pavel Sanda wrote:
> Scott Kostyshak wrote:
>> (a) the style is inconsistent
>
> This is good enough reason. I did grep sources and we indeed use
> const_iterator
> for end in most cases.
>
>> (3) I've read that compilers can apply more aggressive optimizations whe
Scott Kostyshak wrote:
> (a) the style is inconsistent
This is good enough reason. I did grep sources and we indeed use const_iterator
for end in most cases.
> (3) I've read that compilers can apply more aggressive optimizations when more
> of the data is const. I'm not sure if this would apply
On Sun, Sep 2, 2012 at 10:12 AM, Enrico Forestieri wrote:
> On Sat, Sep 01, 2012 at 07:10:59PM -0400, Scott Kostyshak wrote:
>
>> I don't know much about git and I don't know much about cmake so I
>> wouldn't be surprised if this is incorrect. The attached patch asks
>> git to ignore temporary cma
On Sun, Sep 2, 2012 at 8:47 AM, Pavel Sanda wrote:
> Scott Kostyshak wrote:
>> @@ -2453,7 +2453,7 @@ void GuiApplication::hideDialogs(string const & name,
>> Inset * inset) const
>> Buffer const * GuiApplication::updateInset(Inset const * inset) const
>> {
>> Buffer const * buffer_ = 0;
>
On Sat, Sep 01, 2012 at 07:10:59PM -0400, Scott Kostyshak wrote:
> I don't know much about git and I don't know much about cmake so I
> wouldn't be surprised if this is incorrect. The attached patch asks
> git to ignore temporary cmake files, which are created after running
> "cmake .". Could some
Scott Kostyshak wrote:
> @@ -2453,7 +2453,7 @@ void GuiApplication::hideDialogs(string const & name,
> Inset * inset) const
> Buffer const * GuiApplication::updateInset(Inset const * inset) const
> {
> Buffer const * buffer_ = 0;
> - QHash::iterator end = d->views_.end();
> + QHash
Scott Kostyshak wrote:
> The attached patch cleans up some comments, LFUN documentation, an
> error message, and lyx --help output.
Fine for trunk. Pavel
