Re: [LyX master] Fix UI for decimal table alignment (bug #8285)

2012-09-12 Thread Pavel Sanda
Uwe Stöhr wrote: Am 11.09.2012 11:55, schrieb Pavel Sanda: + if ((multicolumnCB-isChecked() || multirowCB-isChecked()) +hAlignCO-findText(qt_(At Decimal Separator))) + hAlignCO-removeItem(3); Uwe, can you comment on this hAlignCO-removeItem(3); line, it looks

Usage of \begin{centering} in floats

2012-09-12 Thread Rainer M Krug
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I am by no means a LaTeX expert and only was told (http://tex.stackexchange.com/questions/71280/best-way-to-centre-figure-in-float and also http://tex.stackexchange.com/questions/2651/should-i-use-center-or-centering-for-figures-and-tables) that

Re: Closing views versus closing buffers

2012-09-12 Thread Richard Heck
On 09/11/2012 03:42 PM, Tommaso Cucinotta wrote: I just noticed that when you type C-w, LyX closes the buffer, along with all views. Also, if you have a split window and multiple tabbed views on both splits, pushing the X button on one of the tabs triggers a close of the buffer, so also the

Re: [LyX master] Fix UI for decimal table alignment (bug #8285)

2012-09-12 Thread Uwe Stöhr
Am 12.09.2012 09:52, schrieb Pavel Sanda: But this code is still error prone - we should not depend at UI-string. Hmm, in principle you are right but in this case we already set this string in GuiTabular.cpp. So I only use the string which is introduced there. Using GUI/data separation is

Re: LFUN documentation typos

2012-09-12 Thread Scott Kostyshak
On Fri, Aug 31, 2012 at 9:11 AM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: OK, this is also in the updated patch. Thanks, this can go in. It is in now. Should I commit LFUNs.lyx after `make lfundoc` now or is this only done prior to release? Scott

Re: [patch] typos

2012-09-12 Thread Scott Kostyshak
On Sun, Sep 2, 2012 at 8:42 AM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: The attached patch cleans up some comments, LFUN documentation, an error message, and lyx --help output. Fine for trunk. Pavel It is in. Thanks, Scott

Re: LFUN documentation typos

2012-09-12 Thread Pavel Sanda
Scott Kostyshak wrote: Should I commit LFUNs.lyx after `make lfundoc` now or is this only No need. P

Re: Closing views versus closing buffers

2012-09-12 Thread Pavel Sanda
Richard Heck wrote: Shouldn't we close the view only, I thought thats why we have hide function distinguished from close. Pavel

Re: [LyX master] Fix UI for decimal table alignment (bug #8285)

2012-09-12 Thread Pavel Sanda
Uwe Stöhr wrote: Am 12.09.2012 09:52, schrieb Pavel Sanda: But this code is still error prone - we should not depend at UI-string. Hmm, in principle you are right but in this case we already set this string in GuiTabular.cpp. So I only use the string which is introduced there. Multiple

Re: LFUN documentation typos

2012-09-12 Thread Scott Kostyshak
On Wed, Sep 12, 2012 at 8:03 PM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: Should I commit LFUNs.lyx after `make lfundoc` now or is this only No need. P OK, thanks. Scott

Re: [patch] constify

2012-09-12 Thread Scott Kostyshak
On Sun, Sep 2, 2012 at 4:23 PM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: (a) the style is inconsistent This is good enough reason. I did grep sources and we indeed use const_iterator for end in most cases. (3) I've read that compilers can apply more aggressive optimizations

Re: [LyX master] Fix UI for decimal table alignment (bug #8285)

2012-09-12 Thread Pavel Sanda
Uwe Stöhr wrote: > Am 11.09.2012 11:55, schrieb Pavel Sanda: > >>> + if ((multicolumnCB->isChecked() || multirowCB->isChecked()) >>> + && hAlignCO->findText(qt_("At Decimal Separator"))) >>> + hAlignCO->removeItem(3); >> >> Uwe, can you comment on this

Usage of \begin{centering} in floats

2012-09-12 Thread Rainer M Krug
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I am by no means a LaTeX expert and only was told (http://tex.stackexchange.com/questions/71280/best-way-to-centre-figure-in-float and also http://tex.stackexchange.com/questions/2651/should-i-use-center-or-centering-for-figures-and-tables) that

Re: Closing views versus closing buffers

2012-09-12 Thread Richard Heck
On 09/11/2012 03:42 PM, Tommaso Cucinotta wrote: I just noticed that when you type C-w, LyX closes the buffer, along with all views. Also, if you have a split window and multiple tabbed views on both splits, pushing the "X" button on one of the tabs triggers a close of the buffer, so also

Re: [LyX master] Fix UI for decimal table alignment (bug #8285)

2012-09-12 Thread Uwe Stöhr
Am 12.09.2012 09:52, schrieb Pavel Sanda: But this code is still error prone - we should not depend at UI-string. Hmm, in principle you are right but in this case we already set this string in GuiTabular.cpp. So I only use the string which is introduced there. Using GUI/data separation is

Re: LFUN documentation typos

2012-09-12 Thread Scott Kostyshak
On Fri, Aug 31, 2012 at 9:11 AM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> OK, this is also in the updated patch. > > Thanks, this can go in. It is in now. Should I commit LFUNs.lyx after `make lfundoc` now or is this only done prior to release? Scott

Re: [patch] typos

2012-09-12 Thread Scott Kostyshak
On Sun, Sep 2, 2012 at 8:42 AM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> The attached patch cleans up some comments, LFUN documentation, an >> error message, and lyx --help output. > > Fine for trunk. Pavel It is in. Thanks, Scott

Re: LFUN documentation typos

2012-09-12 Thread Pavel Sanda
Scott Kostyshak wrote: > Should I commit LFUNs.lyx after `make lfundoc` now or is this only No need. P

Re: Closing views versus closing buffers

2012-09-12 Thread Pavel Sanda
Richard Heck wrote: >> Shouldn't we close the view only, I thought thats why we have "hide" function distinguished from close. Pavel

Re: [LyX master] Fix UI for decimal table alignment (bug #8285)

2012-09-12 Thread Pavel Sanda
Uwe Stöhr wrote: > Am 12.09.2012 09:52, schrieb Pavel Sanda: > >> But this code is still error prone - we should not depend at UI-string. > > Hmm, in principle you are right but in this case we already set this string > in GuiTabular.cpp. So I only use the string which is introduced there.

Re: LFUN documentation typos

2012-09-12 Thread Scott Kostyshak
On Wed, Sep 12, 2012 at 8:03 PM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> Should I commit LFUNs.lyx after `make lfundoc` now or is this only > > No need. P OK, thanks. Scott

Re: [patch] constify

2012-09-12 Thread Scott Kostyshak
On Sun, Sep 2, 2012 at 4:23 PM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> (a) the style is inconsistent > > This is good enough reason. I did grep sources and we indeed use > const_iterator > for end in most cases. > >> (3) I've read that compilers can apply more aggressive