Re: [LyX/master] DocBook: add a layout tag to tell whether an item is the abstract or not.

2020-08-03 Thread Richard Kimberly Heck 
On 8/3/20 5:06 PM, Scott Kostyshak wrote:
> On Mon, Aug 03, 2020 at 11:02:28PM +0200, Thibaut Cuvelier wrote:
>> On Mon, 3 Aug 2020 at 19:45, Scott Kostyshak  wrote:
>>
>>> On Mon, Aug 03, 2020 at 12:08:51PM -0400, Richard Kimberly Heck wrote:
 On 8/3/20 10:57 AM, Thibaut Cuvelier wrote:
> On Mon, 3 Aug 2020 at 16:41, Scott Kostyshak  > wrote:
>
> On Mon, Aug 03, 2020 at 04:29:57PM +0200, Kornel Benko wrote:
> > Am Mon,  3 Aug 2020 15:39:49 +0200 (CEST)
> > schrieb Thibaut Cuvelier  >:
> >
> > > commit 5ccd63eff6731a972f1d65d855859a65fe8e3a5b
> > > Author: Thibaut Cuvelier  >
> > > Date:   Mon Aug 3 16:04:26 2020 +0200
> > >
> > > DocBook: add a layout tag to tell whether an item is the
> abstract or not.
> > > ---
> > >  .../docbook/bibliography_precooked_aastex.xml  |  221
> -
> > >  lib/layouts/aastex.layout  |3 -
> > >  lib/layouts/stdstruct.inc  |3 +-
> > >  lib/scripts/layout2layout.py   |2 +-
> > >  src/Layout.cpp |8 +
> > >  src/Layout.h   |9 +-
> > >  src/output_docbook.cpp |  265
> 
> > >  src/xml.h  |2 +
> > >  8 files changed, 283 insertions(+), 230 deletions(-)
> >
> > Thibaut, could you please test the exports before commit?
> >
> > Some of the last commits are the reason for
> >
> > 1.) extrem slowness
> > 2.) many endless loops
> > 3.) 54% tests passed, 162 tests failed out of 350
>
> +1
> An alternative would be to do work on a branch, then when you are
> ready
> do all the testing at once and then after the testing looks good
>>> merge
> to master.
>
> I think that some projects are not as strict, but here on master
> we like
> to keep it useable. This makes it easier to test master.  Also, it
> makes
> it easier to bisect other bugs that have nothing to do with a
>>> commit
> that broke something else.
>
> Thank you very much to Thibaut for all of your work!
>
> And thank you to Kornel for spending so much time on the tests.
>
>
> Working on a branch would be the best solution, indeed. May I do a
> force push to remove those commits from master?
 Just revert them, I'd think.
>>> +1
>>>
>>> For a branch, if Thibaut would like to share the branch before pushing,
>>> perhaps the "features" remote would be the right place? In normal times,
>>> I would be interested in pulling your branch (from features), and
>>> running the tests to see if there are any regressions. However, these
>>> days I do not have the time to offer this.
>>>
>> I've just reverted many commits, and put them back in a branch locally.
>> However, the Git server does not accept new branches (or I'm doing
>> something wrong):
>>
>> $ git push --set-upstream official feature/docbook
>> Enumerating objects: 104, done.
>> Counting objects: 100% (104/104), done.
>> Delta compression using up to 12 threads
>> Compressing objects: 100% (87/87), done.
>> Writing objects: 100% (87/87), 15.74 KiB | 848.00 KiB/s, done.
>> Total 87 (delta 76), reused 0 (delta 0), pack-reused 0
>> remote: C refs/heads/feature/docbook lyx tcuvelier DENIED by fallthru
>> remote: error: hook declined to update refs/heads/feature/docbook
>> To git.lyx.org:lyx
>>  ! [remote rejected]   feature/docbook -> feature/docbook (hook
>> declined)
>> error: failed to push some refs to 'git.lyx.org:lyx'
> Thanks for being responsive to feedback and for your time on that,
> Thibaut. I'm not sure how to set up your access for the features remote.
> I have the following settings:
>
> features  g...@git.lyx.org:features.git (fetch)
> features  g...@git.lyx.org:features.git (push)
>
> I don't know if this information is up-to-date:
>
> https://wiki.lyx.org/Devel/LyXGit#toc3

I would expect it to be, but if not, we can fix it.

Riki


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] DocBook: add a layout tag to tell whether an item is the abstract or not.

2020-08-03 Thread Richard Kimberly Heck 
On 8/3/20 1:44 PM, Scott Kostyshak wrote:
> On Mon, Aug 03, 2020 at 12:08:51PM -0400, Richard Kimberly Heck wrote:
>> On 8/3/20 10:57 AM, Thibaut Cuvelier wrote:
>>> On Mon, 3 Aug 2020 at 16:41, Scott Kostyshak >> > wrote:
>>>
>>> On Mon, Aug 03, 2020 at 04:29:57PM +0200, Kornel Benko wrote:
>>> > Am Mon,  3 Aug 2020 15:39:49 +0200 (CEST)
>>> > schrieb Thibaut Cuvelier >> >:
>>> >
>>> > > commit 5ccd63eff6731a972f1d65d855859a65fe8e3a5b
>>> > > Author: Thibaut Cuvelier >> >
>>> > > Date:   Mon Aug 3 16:04:26 2020 +0200
>>> > >
>>> > >     DocBook: add a layout tag to tell whether an item is the
>>> abstract or not.
>>> > > ---
>>> > >  .../docbook/bibliography_precooked_aastex.xml      |  221
>>> -
>>> > >  lib/layouts/aastex.layout                          |    3 -
>>> > >  lib/layouts/stdstruct.inc                          |    3 +-
>>> > >  lib/scripts/layout2layout.py                       |    2 +-
>>> > >  src/Layout.cpp                                     |    8 +
>>> > >  src/Layout.h                                       |    9 +-
>>> > >  src/output_docbook.cpp                             |  265
>>> 
>>> > >  src/xml.h                                          |    2 +
>>> > >  8 files changed, 283 insertions(+), 230 deletions(-)
>>> >
>>> > Thibaut, could you please test the exports before commit?
>>> >
>>> > Some of the last commits are the reason for
>>> >
>>> > 1.) extrem slowness
>>> > 2.) many endless loops
>>> > 3.) 54% tests passed, 162 tests failed out of 350
>>>
>>> +1
>>> An alternative would be to do work on a branch, then when you are
>>> ready
>>> do all the testing at once and then after the testing looks good merge
>>> to master.
>>>
>>> I think that some projects are not as strict, but here on master
>>> we like
>>> to keep it useable. This makes it easier to test master.  Also, it
>>> makes
>>> it easier to bisect other bugs that have nothing to do with a commit
>>> that broke something else.
>>>
>>> Thank you very much to Thibaut for all of your work!
>>>
>>> And thank you to Kornel for spending so much time on the tests.
>>>
>>>
>>> Working on a branch would be the best solution, indeed. May I do a
>>> force push to remove those commits from master? 
>> Just revert them, I'd think.
> +1
>
> For a branch, if Thibaut would like to share the branch before pushing,
> perhaps the "features" remote would be the right place? 

Yes, that would be the easiest thing. Then people can give feedback
along the way.

Riki


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

2020-08-03 Thread Daniel 

On 2020-08-04 00:03, Daniel wrote:

On 2020-08-03 22:43, Stephan Witt wrote:

Am 03.08.2020 um 16:52 schrieb Daniel :


On 3/8/20 16:20, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:

Thanks. I hope you did not compile the list manually. :)

No: grep setFlat *.h

I was actually hoping that there could be a general way to affect all
boxes with "one" call. But if my search for this does not bear
fruit, I'll resort to the manual solution.

I doubt you can do this generally.


Seemed to me like something one should be able to do. But probably I 
will need to ask on stackexchange…


Something like the attached patch? It’s only a hack for the 
preferences to get the idea.


This can be put in a helper method and called when it seems appropriate.

Stephan




Nice! It seems to work as expected. And I think it improves the 
readability of the preferences on mac. My hunch is that we would want 
the analogue for every other OS but with "setFlat(true)" because 
currently not all group boxes are set to flat and likely some will be 
missed in the future.


Just to be sure: the method relies on the particular creation process of 
panels by the Preferences dialog, right? It can probably be adapted for 
the Document Settings dialog but would not (easily) work on the lowesy 
(application) level.


Daniel


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Jenkins build is back to normal : Build branch "master" » ubuntu-xenial-qt4-autotools-extended #2039

2020-08-03 Thread ci-lyx 
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/2039/
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

2020-08-03 Thread Daniel 

On 2020-08-03 22:43, Stephan Witt wrote:

Am 03.08.2020 um 16:52 schrieb Daniel :


On 3/8/20 16:20, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:

Thanks. I hope you did not compile the list manually. :)

No: grep setFlat *.h

I was actually hoping that there could be a general way to affect all
boxes with "one" call. But if my search for this does not bear
fruit, I'll resort to the manual solution.

I doubt you can do this generally.


Seemed to me like something one should be able to do. But probably I will need 
to ask on stackexchange…


Something like the attached patch? It’s only a hack for the preferences to get 
the idea.

This can be put in a helper method and called when it seems appropriate.

Stephan




Nice! It seems to work as expected. And I think it improves the 
readability of the preferences on mac. My hunch is that we would want 
the analogue for every other OS but with "setFlat(true)" because 
currently not all group boxes are set to flat and likely some will be 
missed in the future.


Daniel

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: #10571: Tabs not showing properly in macOS full (and split) screen

2020-08-03 Thread Pavel Sanda 
On Sun, Aug 02, 2020 at 10:55:55AM +0200, Stephan Witt wrote:
> Here is the current state of my patch to improve switch to/from full-screen.
> 
> It contains additional code to detect switch to/from window maximize state.
> This is actually not used yet. On Mac it could be a possibility to implement
> the switch to/from the state you???ve called ???focus mode???. That???s why I 
> left it
> as is ATM. The final patch will be without it and the maximize state can be 
> done
> later. For now I???d like to ask Pavel how this is different and/or managed 
> on Linux.
> Perhaps it doesn???t work the same way as on Mac.

With this patch I don't see any loss of functionality for our innate fullscreen 
lfun
and improvement with handling of WM's signal. Few strange differences remain 
(like
the command buffer appearance mentioned earlier), but I consider the current 
patch
as an improvement already  - so please go on.

It would be good if someone on more standard linux environment like GNOME/KDE
could test as well.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] DocBook: add a layout tag to tell whether an item is the abstract or not.

2020-08-03 Thread Scott Kostyshak 
On Mon, Aug 03, 2020 at 11:02:28PM +0200, Thibaut Cuvelier wrote:
> On Mon, 3 Aug 2020 at 19:45, Scott Kostyshak  wrote:
> 
> > On Mon, Aug 03, 2020 at 12:08:51PM -0400, Richard Kimberly Heck wrote:
> > > On 8/3/20 10:57 AM, Thibaut Cuvelier wrote:
> > > > On Mon, 3 Aug 2020 at 16:41, Scott Kostyshak  > > > > wrote:
> > > >
> > > > On Mon, Aug 03, 2020 at 04:29:57PM +0200, Kornel Benko wrote:
> > > > > Am Mon,  3 Aug 2020 15:39:49 +0200 (CEST)
> > > > > schrieb Thibaut Cuvelier  > > > >:
> > > > >
> > > > > > commit 5ccd63eff6731a972f1d65d855859a65fe8e3a5b
> > > > > > Author: Thibaut Cuvelier  > > > >
> > > > > > Date:   Mon Aug 3 16:04:26 2020 +0200
> > > > > >
> > > > > > DocBook: add a layout tag to tell whether an item is the
> > > > abstract or not.
> > > > > > ---
> > > > > >  .../docbook/bibliography_precooked_aastex.xml  |  221
> > > > -
> > > > > >  lib/layouts/aastex.layout  |3 -
> > > > > >  lib/layouts/stdstruct.inc  |3 +-
> > > > > >  lib/scripts/layout2layout.py   |2 +-
> > > > > >  src/Layout.cpp |8 +
> > > > > >  src/Layout.h   |9 +-
> > > > > >  src/output_docbook.cpp |  265
> > > > 
> > > > > >  src/xml.h  |2 +
> > > > > >  8 files changed, 283 insertions(+), 230 deletions(-)
> > > > >
> > > > > Thibaut, could you please test the exports before commit?
> > > > >
> > > > > Some of the last commits are the reason for
> > > > >
> > > > > 1.) extrem slowness
> > > > > 2.) many endless loops
> > > > > 3.) 54% tests passed, 162 tests failed out of 350
> > > >
> > > > +1
> > > > An alternative would be to do work on a branch, then when you are
> > > > ready
> > > > do all the testing at once and then after the testing looks good
> > merge
> > > > to master.
> > > >
> > > > I think that some projects are not as strict, but here on master
> > > > we like
> > > > to keep it useable. This makes it easier to test master.  Also, it
> > > > makes
> > > > it easier to bisect other bugs that have nothing to do with a
> > commit
> > > > that broke something else.
> > > >
> > > > Thank you very much to Thibaut for all of your work!
> > > >
> > > > And thank you to Kornel for spending so much time on the tests.
> > > >
> > > >
> > > > Working on a branch would be the best solution, indeed. May I do a
> > > > force push to remove those commits from master?
> > >
> > > Just revert them, I'd think.
> >
> > +1
> >
> > For a branch, if Thibaut would like to share the branch before pushing,
> > perhaps the "features" remote would be the right place? In normal times,
> > I would be interested in pulling your branch (from features), and
> > running the tests to see if there are any regressions. However, these
> > days I do not have the time to offer this.
> >
> 
> I've just reverted many commits, and put them back in a branch locally.
> However, the Git server does not accept new branches (or I'm doing
> something wrong):
> 
> $ git push --set-upstream official feature/docbook
> Enumerating objects: 104, done.
> Counting objects: 100% (104/104), done.
> Delta compression using up to 12 threads
> Compressing objects: 100% (87/87), done.
> Writing objects: 100% (87/87), 15.74 KiB | 848.00 KiB/s, done.
> Total 87 (delta 76), reused 0 (delta 0), pack-reused 0
> remote: C refs/heads/feature/docbook lyx tcuvelier DENIED by fallthru
> remote: error: hook declined to update refs/heads/feature/docbook
> To git.lyx.org:lyx
>  ! [remote rejected]   feature/docbook -> feature/docbook (hook
> declined)
> error: failed to push some refs to 'git.lyx.org:lyx'

Thanks for being responsive to feedback and for your time on that,
Thibaut. I'm not sure how to set up your access for the features remote.
I have the following settings:

featuresg...@git.lyx.org:features.git (fetch)
featuresg...@git.lyx.org:features.git (push)

I don't know if this information is up-to-date:

https://wiki.lyx.org/Devel/LyXGit#toc3

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] DocBook: add a layout tag to tell whether an item is the abstract or not.

2020-08-03 Thread Thibaut Cuvelier 
On Mon, 3 Aug 2020 at 19:45, Scott Kostyshak  wrote:

> On Mon, Aug 03, 2020 at 12:08:51PM -0400, Richard Kimberly Heck wrote:
> > On 8/3/20 10:57 AM, Thibaut Cuvelier wrote:
> > > On Mon, 3 Aug 2020 at 16:41, Scott Kostyshak  > > > wrote:
> > >
> > > On Mon, Aug 03, 2020 at 04:29:57PM +0200, Kornel Benko wrote:
> > > > Am Mon,  3 Aug 2020 15:39:49 +0200 (CEST)
> > > > schrieb Thibaut Cuvelier  > > >:
> > > >
> > > > > commit 5ccd63eff6731a972f1d65d855859a65fe8e3a5b
> > > > > Author: Thibaut Cuvelier  > > >
> > > > > Date:   Mon Aug 3 16:04:26 2020 +0200
> > > > >
> > > > > DocBook: add a layout tag to tell whether an item is the
> > > abstract or not.
> > > > > ---
> > > > >  .../docbook/bibliography_precooked_aastex.xml  |  221
> > > -
> > > > >  lib/layouts/aastex.layout  |3 -
> > > > >  lib/layouts/stdstruct.inc  |3 +-
> > > > >  lib/scripts/layout2layout.py   |2 +-
> > > > >  src/Layout.cpp |8 +
> > > > >  src/Layout.h   |9 +-
> > > > >  src/output_docbook.cpp |  265
> > > 
> > > > >  src/xml.h  |2 +
> > > > >  8 files changed, 283 insertions(+), 230 deletions(-)
> > > >
> > > > Thibaut, could you please test the exports before commit?
> > > >
> > > > Some of the last commits are the reason for
> > > >
> > > > 1.) extrem slowness
> > > > 2.) many endless loops
> > > > 3.) 54% tests passed, 162 tests failed out of 350
> > >
> > > +1
> > > An alternative would be to do work on a branch, then when you are
> > > ready
> > > do all the testing at once and then after the testing looks good
> merge
> > > to master.
> > >
> > > I think that some projects are not as strict, but here on master
> > > we like
> > > to keep it useable. This makes it easier to test master.  Also, it
> > > makes
> > > it easier to bisect other bugs that have nothing to do with a
> commit
> > > that broke something else.
> > >
> > > Thank you very much to Thibaut for all of your work!
> > >
> > > And thank you to Kornel for spending so much time on the tests.
> > >
> > >
> > > Working on a branch would be the best solution, indeed. May I do a
> > > force push to remove those commits from master?
> >
> > Just revert them, I'd think.
>
> +1
>
> For a branch, if Thibaut would like to share the branch before pushing,
> perhaps the "features" remote would be the right place? In normal times,
> I would be interested in pulling your branch (from features), and
> running the tests to see if there are any regressions. However, these
> days I do not have the time to offer this.
>

I've just reverted many commits, and put them back in a branch locally.
However, the Git server does not accept new branches (or I'm doing
something wrong):

$ git push --set-upstream official feature/docbook
Enumerating objects: 104, done.
Counting objects: 100% (104/104), done.
Delta compression using up to 12 threads
Compressing objects: 100% (87/87), done.
Writing objects: 100% (87/87), 15.74 KiB | 848.00 KiB/s, done.
Total 87 (delta 76), reused 0 (delta 0), pack-reused 0
remote: C refs/heads/feature/docbook lyx tcuvelier DENIED by fallthru
remote: error: hook declined to update refs/heads/feature/docbook
To git.lyx.org:lyx
 ! [remote rejected]   feature/docbook -> feature/docbook (hook
declined)
error: failed to push some refs to 'git.lyx.org:lyx'
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

2020-08-03 Thread Stephan Witt 
Am 03.08.2020 um 16:52 schrieb Daniel :
> 
> On 3/8/20 16:20, Jürgen Spitzmüller wrote:
>> Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:
>>> Thanks. I hope you did not compile the list manually. :)
>> No: grep setFlat *.h
>>> I was actually hoping that there could be a general way to affect all
>>> boxes with "one" call. But if my search for this does not bear
>>> fruit, I'll resort to the manual solution.
>> I doubt you can do this generally.
> 
> Seemed to me like something one should be able to do. But probably I will 
> need to ask on stackexchange…

Something like the attached patch? It’s only a hack for the preferences to get 
the idea.

This can be put in a helper method and called when it seems appropriate.

Stephan


QGroupBox-setFlat.patch
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #2038

2020-08-03 Thread ci-lyx 
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/2038/--
[...truncated 1134 lines...]
  CXX  insets/InsetSpace.o
  CXX  insets/InsetSpecialChar.o
  CXX  insets/InsetTabular.o
  CXX  insets/InsetText.o
  CXX  insets/InsetTOC.o
  CXX  insets/InsetVSpace.o
  CXX  insets/InsetWrap.o
  AR   liblyxinsets.a
  CXX  main.o
  CXX  BiblioInfo.o
  CXX  Box.o
  CXX  Compare.o
  CXX  Dimension.o
  CXX  EnchantChecker.o
  CXX  PersonalWordList.o
  CXX  LaTeXFonts.o
  CXX  Thesaurus.o
  CXXLDlyx
make[4]: Leaving directory '/build/workspace/src'
Making all in client
make[4]: Entering directory '/build/workspace/src/client'
  CXX  boost.o
  CXX  client.o
  CXXLDlyxclient
make[4]: Leaving directory '/build/workspace/src/client'
Making all in tex2lyx
make[4]: Entering directory '/build/workspace/src/tex2lyx'
  CXX  boost.o
  CXX  Context.o
  CXX  dummy_impl.o
  CXX  math.o
  CXX  Parser.o
  CXX  Preamble.o
  CXX  table.o
  CXX  tex2lyx.o
  CXX  text.o
  CXXLDtex2lyx
make[4]: Leaving directory '/build/workspace/src/tex2lyx'
Making all in convert
make[4]: Entering directory '/build/workspace/src/convert'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory '/build/workspace/src/convert'
make[3]: Leaving directory '/build/workspace/src'
make[2]: Leaving directory '/build/workspace/src'
Making all in sourcedoc
make[2]: Entering directory '/build/workspace/sourcedoc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/build/workspace/sourcedoc'
Making all in lib
make[2]: Entering directory '/build/workspace/lib'
Making all in doc
make[3]: Entering directory '/build/workspace/lib/doc'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/build/workspace/lib/doc'
Making all in lyx2lyx
make[3]: Entering directory '/build/workspace/lib/lyx2lyx'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/build/workspace/lib/lyx2lyx'
make[3]: Entering directory '/build/workspace/lib'
  GEN  lyx.desktop
  GEN  lyx.png
  GEN  lyx.svg
make[3]: Leaving directory '/build/workspace/lib'
make[2]: Leaving directory '/build/workspace/lib'
Making all in src/client
make[2]: Entering directory '/build/workspace/src/client'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/build/workspace/src/client'
Making all in src/tex2lyx
make[2]: Entering directory '/build/workspace/src/tex2lyx'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/build/workspace/src/tex2lyx'
Making all in src/convert
make[2]: Entering directory '/build/workspace/src/convert'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/build/workspace/src/convert'
make[2]: Entering directory '/build/workspace'
make[2]: Leaving directory '/build/workspace'
make[1]: Leaving directory '/build/workspace'
# Executing: make check
Making check in autotests
make[1]: Entering directory '/build/workspace/autotests'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/build/workspace/autotests'
Making check in config
make[1]: Entering directory '/build/workspace/config'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/build/workspace/config'
Making check in development
make[1]: Entering directory '/build/workspace/development'
make[2]: Entering directory '/build/workspace/development'
make[2]: Nothing to be done for 'check-am'.
make[2]: Leaving directory '/build/workspace/development'
make[1]: Leaving directory '/build/workspace/development'
Making check in po
make[1]: Entering directory '/build/workspace/po'
make[1]: Nothing to be done for 'check'.
make[1]: Leaving directory '/build/workspace/po'
Making check in 3rdparty
make[1]: Entering directory '/build/workspace/3rdparty'
make[2]: Entering directory '/build/workspace/3rdparty'
make[2]: Nothing to be done for 'check-am'.
make[2]: Leaving directory '/build/workspace/3rdparty'
make[1]: Leaving directory '/build/workspace/3rdparty'
Making check in src
make[1]: Entering directory '/build/workspace/src'
  CHK  lyx_commit_hash.h
make  check-recursive
make[2]: Entering directory '/build/workspace/src'
Making check in support
make[3]: Entering directory '/build/workspace/src/support'
make  check-am
make[4]: Entering directory '/build/workspace/src/support'
make  check_convert check_filetools check_lstrings check_trivstring
make[5]: Entering directory '/build/workspace/src/support'
  CXX  tests/check_convert.o
  CXX  tests/dummy_functions.o
  CXX  tests/boost.o
  CXXLDcheck_convert
  CXX  tests/check_filetools.o
  CXXLDcheck_filetools
  CXX  tests/check_lstrings.o
  CXXLDcheck_lstrings
  CXX  tests/check_trivstring.o
  CXXLDcheck_trivstring
make[5]: Leaving directory '/build/workspace/src/support'
make  check-TESTS
make[5]: Entering directory

[PATCH] for MyThesLIB lookup

2020-08-03 Thread Stephan Witt 
Hi Kornel,

I’m getting this warning:

CMake Warning (dev) at 
/opt/local/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272 
(message):
  The package name passed to `find_package_handle_standard_args` (MYTHESLIB)
  does not match the name of the calling package (MyThesLIB).  This can lead
  to problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  development/cmake/modules/FindMyThesLIB.cmake:26 
(find_package_handle_standard_args)
  CMakeLists.txt:826 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

The attached patch cures it, ok?

Stephan


MyThesLIB.patch
Description: Binary data
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] DocBook: add a layout tag to tell whether an item is the abstract or not.

2020-08-03 Thread Scott Kostyshak 
On Mon, Aug 03, 2020 at 12:08:51PM -0400, Richard Kimberly Heck wrote:
> On 8/3/20 10:57 AM, Thibaut Cuvelier wrote:
> > On Mon, 3 Aug 2020 at 16:41, Scott Kostyshak  > > wrote:
> >
> > On Mon, Aug 03, 2020 at 04:29:57PM +0200, Kornel Benko wrote:
> > > Am Mon,  3 Aug 2020 15:39:49 +0200 (CEST)
> > > schrieb Thibaut Cuvelier  > >:
> > >
> > > > commit 5ccd63eff6731a972f1d65d855859a65fe8e3a5b
> > > > Author: Thibaut Cuvelier  > >
> > > > Date:   Mon Aug 3 16:04:26 2020 +0200
> > > >
> > > >     DocBook: add a layout tag to tell whether an item is the
> > abstract or not.
> > > > ---
> > > >  .../docbook/bibliography_precooked_aastex.xml      |  221
> > -
> > > >  lib/layouts/aastex.layout                          |    3 -
> > > >  lib/layouts/stdstruct.inc                          |    3 +-
> > > >  lib/scripts/layout2layout.py                       |    2 +-
> > > >  src/Layout.cpp                                     |    8 +
> > > >  src/Layout.h                                       |    9 +-
> > > >  src/output_docbook.cpp                             |  265
> > 
> > > >  src/xml.h                                          |    2 +
> > > >  8 files changed, 283 insertions(+), 230 deletions(-)
> > >
> > > Thibaut, could you please test the exports before commit?
> > >
> > > Some of the last commits are the reason for
> > >
> > > 1.) extrem slowness
> > > 2.) many endless loops
> > > 3.) 54% tests passed, 162 tests failed out of 350
> >
> > +1
> > An alternative would be to do work on a branch, then when you are
> > ready
> > do all the testing at once and then after the testing looks good merge
> > to master.
> >
> > I think that some projects are not as strict, but here on master
> > we like
> > to keep it useable. This makes it easier to test master.  Also, it
> > makes
> > it easier to bisect other bugs that have nothing to do with a commit
> > that broke something else.
> >
> > Thank you very much to Thibaut for all of your work!
> >
> > And thank you to Kornel for spending so much time on the tests.
> >
> >
> > Working on a branch would be the best solution, indeed. May I do a
> > force push to remove those commits from master? 
> 
> Just revert them, I'd think.

+1

For a branch, if Thibaut would like to share the branch before pushing,
perhaps the "features" remote would be the right place? In normal times,
I would be interested in pulling your branch (from features), and
running the tests to see if there are any regressions. However, these
days I do not have the time to offer this.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] DocBook: add a layout tag to tell whether an item is the abstract or not.

2020-08-03 Thread Richard Kimberly Heck 
On 8/3/20 10:57 AM, Thibaut Cuvelier wrote:
> On Mon, 3 Aug 2020 at 16:41, Scott Kostyshak  > wrote:
>
> On Mon, Aug 03, 2020 at 04:29:57PM +0200, Kornel Benko wrote:
> > Am Mon,  3 Aug 2020 15:39:49 +0200 (CEST)
> > schrieb Thibaut Cuvelier  >:
> >
> > > commit 5ccd63eff6731a972f1d65d855859a65fe8e3a5b
> > > Author: Thibaut Cuvelier  >
> > > Date:   Mon Aug 3 16:04:26 2020 +0200
> > >
> > >     DocBook: add a layout tag to tell whether an item is the
> abstract or not.
> > > ---
> > >  .../docbook/bibliography_precooked_aastex.xml      |  221
> -
> > >  lib/layouts/aastex.layout                          |    3 -
> > >  lib/layouts/stdstruct.inc                          |    3 +-
> > >  lib/scripts/layout2layout.py                       |    2 +-
> > >  src/Layout.cpp                                     |    8 +
> > >  src/Layout.h                                       |    9 +-
> > >  src/output_docbook.cpp                             |  265
> 
> > >  src/xml.h                                          |    2 +
> > >  8 files changed, 283 insertions(+), 230 deletions(-)
> >
> > Thibaut, could you please test the exports before commit?
> >
> > Some of the last commits are the reason for
> >
> > 1.) extrem slowness
> > 2.) many endless loops
> > 3.) 54% tests passed, 162 tests failed out of 350
>
> +1
> An alternative would be to do work on a branch, then when you are
> ready
> do all the testing at once and then after the testing looks good merge
> to master.
>
> I think that some projects are not as strict, but here on master
> we like
> to keep it useable. This makes it easier to test master.  Also, it
> makes
> it easier to bisect other bugs that have nothing to do with a commit
> that broke something else.
>
> Thank you very much to Thibaut for all of your work!
>
> And thank you to Kornel for spending so much time on the tests.
>
>
> Working on a branch would be the best solution, indeed. May I do a
> force push to remove those commits from master? 

Just revert them, I'd think.

Riki


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

2020-08-03 Thread Jean-Marc Lasgouttes 
Le 3 août 2020 13:28:47 GMT+02:00, "Jürgen Spitzmüller"  a écrit 
:
>This should be possible with some effort. We need to set the flat
>property in the *.cpp files rather than in the layout files (where is
>is set now, via Qt Designer). We could add a new boolean member
>useFlatGB() to support/os.h which returns true by default and false for
>Mac. Then it would be just adding a lot of
>
>xxxGB->SetFlat(os::useFlatGB());

The new helper should not be in os.h, which is not for UI. It should live in 
GuiApplication and depend either on the Qt frontend (I do not remember the 
names) or the current style name

JMarc

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] DocBook: add a layout tag to tell whether an item is the abstract or not.

2020-08-03 Thread Thibaut Cuvelier 
On Mon, 3 Aug 2020 at 16:41, Scott Kostyshak  wrote:

> On Mon, Aug 03, 2020 at 04:29:57PM +0200, Kornel Benko wrote:
> > Am Mon,  3 Aug 2020 15:39:49 +0200 (CEST)
> > schrieb Thibaut Cuvelier :
> >
> > > commit 5ccd63eff6731a972f1d65d855859a65fe8e3a5b
> > > Author: Thibaut Cuvelier 
> > > Date:   Mon Aug 3 16:04:26 2020 +0200
> > >
> > > DocBook: add a layout tag to tell whether an item is the abstract
> or not.
> > > ---
> > >  .../docbook/bibliography_precooked_aastex.xml  |  221
> -
> > >  lib/layouts/aastex.layout  |3 -
> > >  lib/layouts/stdstruct.inc  |3 +-
> > >  lib/scripts/layout2layout.py   |2 +-
> > >  src/Layout.cpp |8 +
> > >  src/Layout.h   |9 +-
> > >  src/output_docbook.cpp |  265
> 
> > >  src/xml.h  |2 +
> > >  8 files changed, 283 insertions(+), 230 deletions(-)
> >
> > Thibaut, could you please test the exports before commit?
> >
> > Some of the last commits are the reason for
> >
> > 1.) extrem slowness
> > 2.) many endless loops
> > 3.) 54% tests passed, 162 tests failed out of 350
>
> +1
> An alternative would be to do work on a branch, then when you are ready
> do all the testing at once and then after the testing looks good merge
> to master.
>
> I think that some projects are not as strict, but here on master we like
> to keep it useable. This makes it easier to test master.  Also, it makes
> it easier to bisect other bugs that have nothing to do with a commit
> that broke something else.
>
> Thank you very much to Thibaut for all of your work!
>
> And thank you to Kornel for spending so much time on the tests.
>

Working on a branch would be the best solution, indeed. May I do a force
push to remove those commits from master?
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

2020-08-03 Thread Daniel 

On 3/8/20 16:20, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:

Thanks. I hope you did not compile the list manually. :)


No: grep setFlat *.h


I was actually hoping that there could be a general way to affect all
boxes with "one" call. But if my search for this does not bear
fruit, I'll resort to the manual solution.


I doubt you can do this generally.


Seemed to me like something one should be able to do. But probably I 
will need to ask on stackexchange...


Daniel


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] DocBook: add a layout tag to tell whether an item is the abstract or not.

2020-08-03 Thread Scott Kostyshak 
On Mon, Aug 03, 2020 at 04:29:57PM +0200, Kornel Benko wrote:
> Am Mon,  3 Aug 2020 15:39:49 +0200 (CEST)
> schrieb Thibaut Cuvelier :
> 
> > commit 5ccd63eff6731a972f1d65d855859a65fe8e3a5b
> > Author: Thibaut Cuvelier 
> > Date:   Mon Aug 3 16:04:26 2020 +0200
> > 
> > DocBook: add a layout tag to tell whether an item is the abstract or 
> > not.
> > ---
> >  .../docbook/bibliography_precooked_aastex.xml  |  221 -
> >  lib/layouts/aastex.layout  |3 -
> >  lib/layouts/stdstruct.inc  |3 +-
> >  lib/scripts/layout2layout.py   |2 +-
> >  src/Layout.cpp |8 +
> >  src/Layout.h   |9 +-
> >  src/output_docbook.cpp |  265 
> > 
> >  src/xml.h  |2 +
> >  8 files changed, 283 insertions(+), 230 deletions(-)
> 
> Thibaut, could you please test the exports before commit?
> 
> Some of the last commits are the reason for
> 
> 1.) extrem slowness
> 2.) many endless loops
> 3.) 54% tests passed, 162 tests failed out of 350

+1
An alternative would be to do work on a branch, then when you are ready
do all the testing at once and then after the testing looks good merge
to master.

I think that some projects are not as strict, but here on master we like
to keep it useable. This makes it easier to test master.  Also, it makes
it easier to bisect other bugs that have nothing to do with a commit
that broke something else.

Thank you very much to Thibaut for all of your work!

And thank you to Kornel for spending so much time on the tests.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] DocBook: add a layout tag to tell whether an item is the abstract or not.

2020-08-03 Thread Kornel Benko 
Am Mon,  3 Aug 2020 15:39:49 +0200 (CEST)
schrieb Thibaut Cuvelier :

> commit 5ccd63eff6731a972f1d65d855859a65fe8e3a5b
> Author: Thibaut Cuvelier 
> Date:   Mon Aug 3 16:04:26 2020 +0200
> 
> DocBook: add a layout tag to tell whether an item is the abstract or not.
> ---
>  .../docbook/bibliography_precooked_aastex.xml  |  221 -
>  lib/layouts/aastex.layout  |3 -
>  lib/layouts/stdstruct.inc  |3 +-
>  lib/scripts/layout2layout.py   |2 +-
>  src/Layout.cpp |8 +
>  src/Layout.h   |9 +-
>  src/output_docbook.cpp |  265 
> 
>  src/xml.h  |2 +
>  8 files changed, 283 insertions(+), 230 deletions(-)

Thibaut, could you please test the exports before commit?

Some of the last commits are the reason for

1.) extrem slowness
2.) many endless loops
3.) 54% tests passed, 162 tests failed out of 350

Kornel


pgpVv2wQw0VyE.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

2020-08-03 Thread Jürgen Spitzmüller 
Am Montag, den 03.08.2020, 16:09 +0200 schrieb Daniel:
> Thanks. I hope you did not compile the list manually. :)

No: grep setFlat *.h

> I was actually hoping that there could be a general way to affect all
> boxes with "one" call. But if my search for this does not bear
> fruit, I'll resort to the manual solution.

I doubt you can do this generally.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

2020-08-03 Thread Daniel 

On 3/8/20 13:28, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 11:51 +0200 schrieb Daniel:

More complicated might be to force all group boxes (for macOS) to
non-flat mode. I'll have to research about how that could be done.


This should be possible with some effort. We need to set the flat
property in the *.cpp files rather than in the layout files (where is
is set now, via Qt Designer). We could add a new boolean member
useFlatGB() to support/os.h which returns true by default and false for
Mac. Then it would be just adding a lot of

xxxGB->SetFlat(os::useFlatGB());

These are affected if you feel like having a go:

ui_BiblioUi.h:CiteStyleBG->setFlat(true);
ui_BiblioUi.h:BiblioStyleBG->setFlat(true);
ui_BiblioUi.h:bibtexGB->setFlat(true);
ui_BibtexUi.h:bibGB->setFlat(true);
ui_BibtexUi.h:optionsGB->setFlat(true);
ui_BoxUi.h:TypesizeGB->setFlat(true);
ui_BoxUi.h:AlignmentGB->setFlat(true);
ui_BoxUi.h:DecorationGB->setFlat(true);
ui_BoxUi.h:colorGB->setFlat(true);
ui_CharacterUi.h:groupBox->setFlat(true);
ui_CharacterUi.h:groupBox_2->setFlat(true);
ui_CharacterUi.h:groupBox_4->setFlat(true);
ui_CharacterUi.h:groupBox_3->setFlat(true);
ui_CitationUi.h:FormattingGB->setFlat(true);
ui_ColorUi.h:fontcolorGB->setFlat(true);
ui_ColorUi.h:backgroundGB->setFlat(true);
ui_CompareHistoryUi.h:groupBox->setFlat(true);
ui_CompareUi.h:groupBox->setFlat(true);
ui_ExternalUi.h:GroupBox3->setFlat(true);
ui_ExternalUi.h:optionsGB->setFlat(true);
ui_ExternalUi.h:displayGB->setFlat(true);
ui_ExternalUi.h:rotationGB->setFlat(true);
ui_ExternalUi.h:scaleGB->setFlat(true);
ui_ExternalUi.h:cropGB->setFlat(true);
ui_FindAndReplaceUi.h:groupBox_2->setFlat(true);
ui_FloatPlacementUi.h:aligmentGB->setFlat(true);
ui_FloatPlacementUi.h:optionsGB->setFlat(true);
ui_FloatPlacementUi.h:groupBox->setFlat(true);
ui_GraphicsUi.h:sizeGB->setFlat(true);
ui_GraphicsUi.h:rotationGB->setFlat(true);
ui_GraphicsUi.h:displayGB->setFlat(true);
ui_GraphicsUi.h:graphicsGroupGB->setFlat(true);
ui_HyperlinkUi.h:typeGB->setFlat(true);
ui_IncludeUi.h:listingsGB->setFlat(true);
ui_IndicesUi.h:indexGB->setFlat(true);
ui_LaTeXUi.h:groupBox->setFlat(true);
ui_LaTeXUi.h:optionsGB->setFlat(true);
ui_LaTeXUi.h:childDocGB->setFlat(true);
ui_ListingsSettingsUi.h:packageGB->setFlat(true);
ui_ListingsUi.h:placementGB->setFlat(true);
ui_ListingsUi.h:numberstyleGB->setFlat(true);
ui_ListingsUi.h:basicstyleGB->setFlat(true);
ui_ListingsUi.h:languageGB->setFlat(true);
ui_ListingsUi.h:rangeGB->setFlat(true);
ui_ListingsUi.h:listingsGB->setFlat(true);
ui_LyXFilesUi.h:filterGB->setFlat(true);
ui_MasterChildUi.h:includeonlyGB->setFlat(true);
ui_MathMatrixUi.h:alignmentGB->setFlat(true);
ui_MathMatrixUi.h:decorationtGB->setFlat(true);
ui_OutputUi.h:outputFormatGB->setFlat(true);
ui_OutputUi.h:savingGB->setFlat(true);
ui_OutputUi.h:outputsyncCB->setFlat(true);
ui_OutputUi.h:xhtmlGB->setFlat(true);
ui_PageLayoutUi.h:paperFormatGB->setFlat(true);
ui_PageLayoutUi.h:pageLayoutGB->setFlat(true);
ui_ParagraphUi.h:groupBox->setFlat(true);
ui_ParagraphUi.h:aligmentGB->setFlat(true);
ui_ParagraphUi.h:labelwidthGB->setFlat(true);
ui_PDFSupportUi.h:use_hyperrefGB->setFlat(true);
ui_PDFSupportUi.h:groupBox_2->setFlat(true);
ui_PDFSupportUi.h:bookmarksGB->setFlat(true);
ui_PDFSupportUi.h:groupBox_3->setFlat(true);
ui_PhantomUi.h:PhantomBG->setFlat(true);
ui_PrefCompletionUi.h:groupBox_3->setFlat(true);
ui_PrefCompletionUi.h:groupBox_2->setFlat(true);
ui_PrefCompletionUi.h:groupBox_4->setFlat(true);
ui_PrefConvertersUi.h:converterDefGB->setFlat(true);
ui_PrefConvertersUi.h:cacheGB->setFlat(true);
ui_PrefConvertersUi.h:securityGB->setFlat(true);
ui_PrefDocHandlingUi.h:GeometryGB->setFlat(true);
ui_PrefDocHandlingUi.h:documentsGB->setFlat(true);
ui_PrefDocHandlingUi.h:tabsGB->setFlat(true);
ui_PrefEditUi.h:scrollGB->setFlat(true);
ui_PrefEditUi.h:fullscreenGB->setFlat(true);
ui_PrefEditUi.h:fullscreenLimitGB->setFlat(true);
ui_PrefFileformatsUi.h:defaultFormatGB->setFlat(true);
ui_PrefInputUi.h:keyboardGB->setFlat(true);
ui_PrefInputUi.h:mouseGB->setFlat(true);
ui_PrefInputUi.h:scrollzoomGB->setFlat(true);
ui_PrefLanguageUi.h:rtlGB2->setFlat(true);
ui_PrefLatexUi.h:bibtexGB->setFlat(true);
ui_PrefLatexUi.h:indexGB->setFlat(true);
ui_PrefLatexUi.h:groupBox->setFlat(true);
ui_PrefOutputUi.h:groupBox->setFlat(true);

Re: Layout list WYSIWYM

2020-08-03 Thread Pavel Sanda 
On Sun, Aug 02, 2020 at 12:04:46PM +0200, Jean-Marc Lasgouttes wrote:
> Le 2 ao??t 2020 10:18:50 GMT+02:00, "Jürgen Spitzmüller"  a 
> écrit :
> >Am Sonntag, den 02.08.2020, 09:44 +0200 schrieb Daniel:
> >> Do you prefer a ui or non-ui switch?
> >
> >A pref entry would be fine (JMarc, I hear you screaming!). 
> 
> Just pretend you did not hear me :)

Design of single combo box looks like exactly situation where
we should have fight over single solution than providing another
gui switch.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

2020-08-03 Thread Jürgen Spitzmüller 
Am Montag, den 03.08.2020, 11:51 +0200 schrieb Daniel:
> More complicated might be to force all group boxes (for macOS) to 
> non-flat mode. I'll have to research about how that could be done.

This should be possible with some effort. We need to set the flat
property in the *.cpp files rather than in the layout files (where is
is set now, via Qt Designer). We could add a new boolean member
useFlatGB() to support/os.h which returns true by default and false for
Mac. Then it would be just adding a lot of

xxxGB->SetFlat(os::useFlatGB());

These are affected if you feel like having a go:

ui_BiblioUi.h:CiteStyleBG->setFlat(true);
ui_BiblioUi.h:BiblioStyleBG->setFlat(true);
ui_BiblioUi.h:bibtexGB->setFlat(true);
ui_BibtexUi.h:bibGB->setFlat(true);
ui_BibtexUi.h:optionsGB->setFlat(true);
ui_BoxUi.h:TypesizeGB->setFlat(true);
ui_BoxUi.h:AlignmentGB->setFlat(true);
ui_BoxUi.h:DecorationGB->setFlat(true);
ui_BoxUi.h:colorGB->setFlat(true);
ui_CharacterUi.h:groupBox->setFlat(true);
ui_CharacterUi.h:groupBox_2->setFlat(true);
ui_CharacterUi.h:groupBox_4->setFlat(true);
ui_CharacterUi.h:groupBox_3->setFlat(true);
ui_CitationUi.h:FormattingGB->setFlat(true);
ui_ColorUi.h:fontcolorGB->setFlat(true);
ui_ColorUi.h:backgroundGB->setFlat(true);
ui_CompareHistoryUi.h:groupBox->setFlat(true);
ui_CompareUi.h:groupBox->setFlat(true);
ui_ExternalUi.h:GroupBox3->setFlat(true);
ui_ExternalUi.h:optionsGB->setFlat(true);
ui_ExternalUi.h:displayGB->setFlat(true);
ui_ExternalUi.h:rotationGB->setFlat(true);
ui_ExternalUi.h:scaleGB->setFlat(true);
ui_ExternalUi.h:cropGB->setFlat(true);
ui_FindAndReplaceUi.h:groupBox_2->setFlat(true);
ui_FloatPlacementUi.h:aligmentGB->setFlat(true);
ui_FloatPlacementUi.h:optionsGB->setFlat(true);
ui_FloatPlacementUi.h:groupBox->setFlat(true);
ui_GraphicsUi.h:sizeGB->setFlat(true);
ui_GraphicsUi.h:rotationGB->setFlat(true);
ui_GraphicsUi.h:displayGB->setFlat(true);
ui_GraphicsUi.h:graphicsGroupGB->setFlat(true);
ui_HyperlinkUi.h:typeGB->setFlat(true);
ui_IncludeUi.h:listingsGB->setFlat(true);
ui_IndicesUi.h:indexGB->setFlat(true);
ui_LaTeXUi.h:groupBox->setFlat(true);
ui_LaTeXUi.h:optionsGB->setFlat(true);
ui_LaTeXUi.h:childDocGB->setFlat(true);
ui_ListingsSettingsUi.h:packageGB->setFlat(true);
ui_ListingsUi.h:placementGB->setFlat(true);
ui_ListingsUi.h:numberstyleGB->setFlat(true);
ui_ListingsUi.h:basicstyleGB->setFlat(true);
ui_ListingsUi.h:languageGB->setFlat(true);
ui_ListingsUi.h:rangeGB->setFlat(true);
ui_ListingsUi.h:listingsGB->setFlat(true);
ui_LyXFilesUi.h:filterGB->setFlat(true);
ui_MasterChildUi.h:includeonlyGB->setFlat(true);
ui_MathMatrixUi.h:alignmentGB->setFlat(true);
ui_MathMatrixUi.h:decorationtGB->setFlat(true);
ui_OutputUi.h:outputFormatGB->setFlat(true);
ui_OutputUi.h:savingGB->setFlat(true);
ui_OutputUi.h:outputsyncCB->setFlat(true);
ui_OutputUi.h:xhtmlGB->setFlat(true);
ui_PageLayoutUi.h:paperFormatGB->setFlat(true);
ui_PageLayoutUi.h:pageLayoutGB->setFlat(true);
ui_ParagraphUi.h:groupBox->setFlat(true);
ui_ParagraphUi.h:aligmentGB->setFlat(true);
ui_ParagraphUi.h:labelwidthGB->setFlat(true);
ui_PDFSupportUi.h:use_hyperrefGB->setFlat(true);
ui_PDFSupportUi.h:groupBox_2->setFlat(true);
ui_PDFSupportUi.h:bookmarksGB->setFlat(true);
ui_PDFSupportUi.h:groupBox_3->setFlat(true);
ui_PhantomUi.h:PhantomBG->setFlat(true);
ui_PrefCompletionUi.h:groupBox_3->setFlat(true);
ui_PrefCompletionUi.h:groupBox_2->setFlat(true);
ui_PrefCompletionUi.h:groupBox_4->setFlat(true);
ui_PrefConvertersUi.h:converterDefGB->setFlat(true);
ui_PrefConvertersUi.h:cacheGB->setFlat(true);
ui_PrefConvertersUi.h:securityGB->setFlat(true);
ui_PrefDocHandlingUi.h:GeometryGB->setFlat(true);
ui_PrefDocHandlingUi.h:documentsGB->setFlat(true);
ui_PrefDocHandlingUi.h:tabsGB->setFlat(true);
ui_PrefEditUi.h:scrollGB->setFlat(true);
ui_PrefEditUi.h:fullscreenGB->setFlat(true);
ui_PrefEditUi.h:fullscreenLimitGB->setFlat(true);
ui_PrefFileformatsUi.h:defaultFormatGB->setFlat(true);
ui_PrefInputUi.h:keyboardGB->setFlat(true);
ui_PrefInputUi.h:mouseGB->setFlat(true);
ui_PrefInputUi.h:scrollzoomGB->setFlat(true);
ui_PrefLanguageUi.h:rtlGB2->setFlat(true);
ui_PrefLatexUi.h:bibtexGB->setFlat(true);
ui_PrefLatexUi.h:indexGB->setFlat(true);
ui_PrefLatexUi.h:groupBox->setFlat(true);
ui_PrefOutputUi.h:groupBox->setFlat(true);
ui_PrefOutputUi.h:

Re: Groupbox layout

2020-08-03 Thread Daniel 

On 2/8/20 17:17, Yu Jin wrote:
Am So., 2. Aug. 2020 um 15:51 Uhr schrieb Daniel >:


On 2020-08-02 14:08, Jürgen Spitzmüller wrote:
 > Am Sonntag, den 02.08.2020, 10:30 +0200 schrieb Daniel:
 >> I suggest to add bold to groupbox titles. This is
 >> also how it is done in Libre Office and MS Office.
 >
 > This is a style choice. Here (GTK Adwaita Style), they are bold.

So, at least it is not necessary to apply bold on all WMs. That leaves
at least macOS (and maybe Windows).

Here is how I see the situation: LyX is moving away from the default
(non-flat) styling of group boxes. On macOS there is no style guide for
such boxes. Hence the qt team does the styling. They did not give it
much love. So, I think it's up to LyX to take care of this because
otherwise the user is left in the UI-dust. Maybe a bold should be
applied for macOS only (and maybe Windows) then?

I attached a screenshot showing how it looks on Windows. It's not too 
bad imho.


Yes, that looks more acceptable than on macOS. But it is a bit 
unsatisfactory that it looks only "not too bad". I have not seen this 
style in Windows 10 anywhere else than in LyX.


Daniel


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

2020-08-03 Thread Daniel 

On 3/8/20 11:51, Daniel wrote:

On 3/8/20 10:10, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 08:30 +0200 schrieb Daniel:

That's exactly what I am saying. We should apply a fix to the style!


How do you want to do that? The style is not provided by us.


I am not sure. I am not at the mac currently, so I can't try for now. 
But I'll do later.


Probably the easiest would be a style on the application applied only 
for macOS (and maybe Windows):


QGroupBox::title {font-weight: bold;}

More complicated might be to force all group boxes (for macOS) to 
non-flat mode. I'll have to research about how that could be done.


Being able to do the latter would also be cool because it would allow us 
to switch all groupboxes (except on macOS) to flat (and maybe back once 
it goes out of fashion) without ending up with a mixed-up user interface 
(some flat some not).


Daniel


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

2020-08-03 Thread Daniel 

On 3/8/20 10:10, Jürgen Spitzmüller wrote:

Am Montag, den 03.08.2020, 08:30 +0200 schrieb Daniel:

That's exactly what I am saying. We should apply a fix to the style!


How do you want to do that? The style is not provided by us.


I am not sure. I am not at the mac currently, so I can't try for now. 
But I'll do later.


Probably the easiest would be a style on the application applied only 
for macOS (and maybe Windows):


QGroupBox::title {font-weight: bold;}

More complicated might be to force all group boxes (for macOS) to 
non-flat mode. I'll have to research about how that could be done.


Daniel

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

2020-08-03 Thread Jürgen Spitzmüller 
Am Montag, den 03.08.2020, 08:30 +0200 schrieb Daniel:
> That's exactly what I am saying. We should apply a fix to the style!

How do you want to do that? The style is not provided by us.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: TOC rebuilds on every cursor move

2020-08-03 Thread Kornel Benko 
Am Sun, 14 Jun 2020 21:23:19 +0200
schrieb Kornel Benko :

> The effect is at least questionable.
> I am using QT5.9.5 (Standard on this ubuntu). Disturbing.
> Recompiled with QT5.11, I don't see it anymore.
> 
>   Kornel

Ping


pgpcUeueM_YeE.pgp
Description: Digitale Signatur von OpenPGP
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Style chooser

2020-08-03 Thread Daniel 
There is quite a difference in quality between different Qt user 
interface styles. IMO macOS gets the short stick, Windows fares a bit 
better, while Qt's own Fusion style is probably best.


I have created a style preference patch. It allows the user to choose a 
different Qt style for the user interface via Preferences > User 
Interface > . It's a quick and dirty patch. Nothing is saved to the 
preferences file. For the UI to fully adopt probably a restart of LyX is 
necessary (which the change currently does not survive). However, it 
might be enough to give an impression of what it looks like on other 
styles. Unfortunately, not all styles are available in every OS. For 
example, macOS has "macintosh", "Windows" and "Fusion". Where the 
"Windows" style is quite basic only indicating the look of Windows not 
exactly matching current Windows 10. And "macintosh" is only available 
on macOS, as far as I know. So, it's probably mainly a way for macOS and 
Windows users to try Fusion.


It could be worth shipping this as a "real" preference in LyX. But I am 
not sure what the costs are apart from yet another preference. Though, I 
still think, even if such a preference is added, LyX should take care 
that the native styles look good on macOS and Windows (Linux being more 
flexible and better supported in regards to styles).


Daniel
diff --git a/src/frontends/qt/GuiPrefs.cpp b/src/frontends/qt/GuiPrefs.cpp
index 98aa0c12b8..996db9324e 100644
--- a/src/frontends/qt/GuiPrefs.cpp
+++ b/src/frontends/qt/GuiPrefs.cpp
@@ -66,6 +66,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -2565,6 +2566,8 @@ PrefUserInterface::PrefUserInterface(GuiPreferences * 
form)
 {
setupUi(this);
 
+   connect(styleCO, SIGNAL(activated(int)),
+   this, SIGNAL(changed()));
connect(uiFilePB, SIGNAL(clicked()),
this, SLOT(selectUi()));
connect(uiFileED, SIGNAL(textChanged(QString)),
@@ -2583,6 +2586,8 @@ PrefUserInterface::PrefUserInterface(GuiPreferences * 
form)
iconSetCO->addItem(qt_("Classic"), "classic");
iconSetCO->addItem(qt_("Oxygen"), "oxygen");
 
+   styleCO->addItems(QStyleFactory::keys());
+
 #if (!(defined Q_WS_X11 || defined(QPA_XCB)) || QT_VERSION < 0x040600)
useSystemThemeIconsCB->hide();
 #endif
@@ -2591,6 +2596,7 @@ PrefUserInterface::PrefUserInterface(GuiPreferences * 
form)
 
 void PrefUserInterface::applyRC(LyXRC & rc) const
 {
+   qApp->setStyle(QStyleFactory::create(styleCO->currentText()));
rc.icon_set = fromqstr(iconSetCO->itemData(
iconSetCO->currentIndex()).toString());
 
diff --git a/src/frontends/qt/ui/PrefUi.ui b/src/frontends/qt/ui/PrefUi.ui
index fcc1d3745c..094fc27353 100644
--- a/src/frontends/qt/ui/PrefUi.ui
+++ b/src/frontends/qt/ui/PrefUi.ui
@@ -7,7 +7,7 @@
 0
 0
 426
-340
+379

   
   
@@ -20,6 +20,19 @@

   
   
+   
+
+ 
+  Qt::Vertical
+ 
+ 
+  
+   395
+   16
+  
+ 
+
+   

 
  
@@ -42,7 +55,7 @@
   
   

-
+
  
   
User interface file:
@@ -52,17 +65,13 @@
   
  
 
-
+
  
 
-
- 
-  
-   Browse...
-  
- 
+
+ 
 
-
+
  
   
Icon set:
@@ -72,7 +81,7 @@
   
  
 
-
+
  
   
The icon set to use. Warning: normal size of icons may be 
wrong until you save the preferences and restart LyX.
@@ -80,7 +89,21 @@
  
 
 
- 
+ 
+  
+   Browse...
+  
+ 
+
+
+ 
+  
+   Style:
+  
+ 
+
+
+ 
 

   
@@ -186,19 +209,6 @@
  
 

-   
-
- 
-  Qt::Vertical
- 
- 
-  
-   395
-   16
-  
- 
-
-   
   
  
  
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Groupbox layout

2020-08-03 Thread Daniel 

On 2020-08-03 07:55, Jürgen Spitzmüller wrote:

Am Sonntag, den 02.08.2020, 19:40 +0200 schrieb Daniel:

The people who designed the Qt mac style didn't think much about flat

group boxes. I am quite certain. In particular when they did not have

any guide from Apple how it should be done since Apple does not
support

flat group boxes. Apple is very much about uniformity when it comes
to

style, I think. And it's not like the Qt people couldn't have better

things to do than take care of a non-default style on mac given the

great amount of unresolved Qt bugs.


The people who design the styles are not necessarily the people who fix
Qt bugs.

I think if flat group boxes are not used on Mac, they should link them
to non-flat ones.

I any case this is an issue in the style and should be fixed there.


That's exactly what I am saying. We should apply a fix to the style!

Or do you mean: Qt should fix the style but not LyX? I think there have 
been several Qt bugs that LyX has worked around in the past, so I don't 
see why this one is special. It might take Qt a long time to fix such 
an, arguably, secondary problem (since the usage of flat groupboxes are 
uncommon on macOS). It seems like an obvious problem but no one seems to 
have bothered for now. I think that's due to people not using the flat 
style group boxes, for example, Scribus does not. IMO, if it is rather 
easy, we should do something about it in the meanwhile.


Daniel

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel