Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools #2146

2022-02-19 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/2146/--
[...truncated 704 lines...]
  GEN  moc_DialogView.cpp
  GEN  moc_DockView.cpp
  GEN  moc_EmptyTable.cpp
  GEN  moc_FancyLineEdit.cpp
  GEN  moc_FindAndReplace.cpp
  GEN  moc_FloatPlacement.cpp
  GEN  moc_GuiAbout.cpp
  GEN  moc_GuiApplication.cpp
  GEN  moc_GuiBibitem.cpp
  GEN  moc_GuiBibtex.cpp
  GEN  moc_GuiBox.cpp
  GEN  moc_GuiBranches.cpp
  GEN  moc_GuiBranch.cpp
  GEN  moc_GuiChanges.cpp
  GEN  moc_GuiCharacter.cpp
  GEN  moc_GuiCitation.cpp
  GEN  moc_GuiClickableLabel.cpp
  GEN  moc_GuiClipboard.cpp
  GEN  moc_GuiCommandBuffer.cpp
  GEN  moc_GuiCommandEdit.cpp
  GEN  moc_GuiCompare.cpp
  GEN  moc_GuiCompareHistory.cpp
  GEN  moc_GuiCompleter.cpp
  GEN  moc_GuiCounter.cpp
  GEN  moc_GuiDelimiter.cpp
  GEN  moc_GuiDialog.cpp
  GEN  moc_GuiDocument.cpp
  GEN  moc_GuiErrorList.cpp
  GEN  moc_GuiERT.cpp
  GEN  moc_GuiExternal.cpp
  GEN  moc_GuiGraphics.cpp
  GEN  moc_GuiHSpace.cpp
  GEN  moc_GuiHyperlink.cpp
  GEN  moc_GuiInclude.cpp
  GEN  moc_GuiIndex.cpp
  GEN  moc_GuiIndices.cpp
  GEN  moc_GuiInfo.cpp
  GEN  moc_GuiLabel.cpp
  GEN  moc_GuiLine.cpp
  GEN  moc_GuiListings.cpp
  GEN  moc_GuiLog.cpp
  GEN  moc_GuiLyXFiles.cpp
  GEN  moc_GuiMathMatrix.cpp
  GEN  moc_GuiNomenclature.cpp
  GEN  moc_GuiNote.cpp
  GEN  moc_GuiParagraph.cpp
  GEN  moc_GuiPhantom.cpp
  GEN  moc_GuiPrefs.cpp
  GEN  moc_GuiPrintindex.cpp
  GEN  moc_GuiPrintNomencl.cpp
  GEN  moc_GuiProgress.cpp
  GEN  moc_GuiProgressView.cpp
  GEN  moc_GuiRef.cpp
  GEN  moc_GuiSearch.cpp
  GEN  moc_GuiSelection.cpp
  GEN  moc_GuiSelectionManager.cpp
  GEN  moc_GuiSendto.cpp
  GEN  moc_GuiSetBorder.cpp
  GEN  moc_GuiShowFile.cpp
  GEN  moc_GuiSpellchecker.cpp
  GEN  moc_GuiSymbols.cpp
  GEN  moc_GuiTabularCreate.cpp
  GEN  moc_GuiTabular.cpp
  GEN  moc_GuiTexinfo.cpp
  GEN  moc_GuiThesaurus.cpp
  GEN  moc_GuiToc.cpp
  GEN  moc_GuiToolbar.cpp
  GEN  moc_GuiView.cpp
  GEN  moc_GuiViewSource.cpp
  GEN  moc_GuiVSpace.cpp
  GEN  moc_GuiWorkArea.cpp
  GEN  moc_GuiWrap.cpp
  GEN  moc_IconPalette.cpp
  GEN  moc_InGuiThread.cpp
  GEN  moc_InsertTableWidget.cpp
  GEN  moc_InsetParamsDialog.cpp
  GEN  moc_InsetParamsWidget.cpp
  GEN  moc_LayoutBox.cpp
  GEN  moc_LengthCombo.cpp
  GEN  moc_LyXFileDialog.cpp
  GEN  moc_Menus.cpp
  GEN  moc_PanelStack.cpp
  GEN  moc_TocModel.cpp
  GEN  moc_TocWidget.cpp
  GEN  moc_ToolTipFormatter.cpp
  GEN  moc_Validator.cpp
make  all-am
make[6]: Entering directory '/build/workspace/src/frontends/qt'
  CXX  ButtonPolicy.o
  CXX  Dialog.o
  CXX  DialogFactory.o
  CXX  Action.o
  CXX  BulletsModule.o
  CXX  ButtonController.o
  CXX  CategorizedCombo.o
  CXX  ColorCache.o
  CXX  CustomizedWidgets.o
  CXX  DialogView.o
  CXX  DockView.o
  CXX  EmptyTable.o
  CXX  FancyLineEdit.o
  CXX  FileDialog.o
  CXX  FindAndReplace.o
  CXX  FloatPlacement.o
  CXX  GuiAbout.o
  CXX  GuiAlert.o
  CXX  GuiApplication.o
  CXX  GuiBibitem.o
  CXX  GuiBibtex.o
  CXX  GuiBox.o
  CXX  GuiBranch.o
  CXX  GuiBranches.o
  CXX  GuiChanges.o
  CXX  GuiCharacter.o
  CXX  GuiCitation.o
  CXX  GuiClickableLabel.o
  CXX  GuiClipboard.o
  CXX  GuiCommandBuffer.o
  CXX  GuiCommandEdit.o
  CXX  GuiCompare.o
  CXX  GuiCompareHistory.o
  CXX  GuiCompleter.o
  CXX  GuiCounter.o
  CXX  GuiDelimiter.o
  CXX  GuiDialog.o
  CXX  GuiDocument.o
  CXX  GuiErrorList.o
  CXX  GuiERT.o
  CXX  GuiExternal.o
  CXX  GuiFontExample.o
  CXX  GuiFontLoader.o
  CXX  GuiFontMetrics.o
  CXX  GuiGraphics.o
  CXX  GuiHSpace.o
  CXX  GuiHyperlink.o
  CXX  GuiIdListModel.o
  CXX  GuiImage.o
  CXX  GuiInclude.o
  CXX  GuiIndex.o
  CXX  GuiIndices.o
  CXX  GuiInfo.o
  CXX  GuiKeySymbol.o
  CXX  GuiLabel.o
  CXX  GuiLine.o
  CXX  GuiListings.o
  CXX  GuiLog.o
  CXX  GuiLyXFiles.o
  CXX  GuiMathMatrix.o
  CXX  GuiNomenclature.o
  CXX  GuiNote.o
  CXX  GuiPainter.o
  CXX  GuiParagraph.o
  CXX  GuiPhantom.o
  CXX  GuiPrefs.o
  CXX  GuiPrintindex.o
  CXX  GuiPrintNomencl.o
  CXX  GuiProgress.o
  CXX  GuiProgressView.o
  CXX  GuiRef.o
  CXX  GuiSearch.o
  CXX  GuiSelection.o
  CXX  GuiSelectionManager.o
  CXX  GuiSendto.o
  CXX  GuiSetBorder.o
  CXX  GuiShowFile.o
  CXX  GuiSpellchecker.o
  CXX  GuiSymbols.o
  CXX  GuiTabular.o
  CXX  GuiTabularCreate.o
  CXX  GuiTexinfo.o
  CXX  GuiThesaurus.o
  CXX  

Re: LyX 2.3 and 2.4 have troubles displaying EPS images

2022-02-19 Thread Thibaut Cuvelier
On Sat, 19 Feb 2022 at 11:31, Enrico Forestieri  wrote:

> On Sat, Feb 19, 2022 at 03:16:04AM +0100, Thibaut Cuvelier wrote:
> >
> > I've been back on this issue. I think that slightly changing the call to
> > ImageMagick is the best solution, as it will not break things that used
> to
> > work and has the potential of enabling preview of images that did not
> have.
> >
> > What do you think about this (minimalist) patch?
>
> Given that your investigation clarified why two images can be found in
> an EPS and that the first is the one actually desired, I think this
> patch is good and backward compatible.
>
> However, note that you have to also modify the "convert" entry. This was
> the name of the driver program in old ImageMagick versions. It is still
> present but simlinked to "magick" in recent versions.
>

Thanks for noticing this, I've pushed the corrected version!
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: unicodesymbols: have several commands for a single symbol?

2022-02-19 Thread Thibaut Cuvelier
On Sat, 19 Feb 2022 at 12:28, Enrico Forestieri  wrote:

> On Sat, Feb 19, 2022 at 08:47:17AM +0100, Jürgen Spitzmüller wrote:
> >
> > Am Samstag, dem 19.02.2022 um 02:43 +0100 schrieb Thibaut Cuvelier:
> > > Does it look alright to you? If so, I will push these patches.
> >
> > So if an entry has "", this will be set empty, and if it has nothing,
> > it will inherit the former, right? And until now, only "" was allowed,
> > no missing table entries? I am just asking if I got it right. If so, it
> > looks good to me.
>
> I have a doubt about the change in src/Encoding.cpp. The entire map is
> scanned for a whole match before performing the usual processing.
> This could significantly slow down performance to account for a few
> statistically insignificant cases. Maybe an optional parameter could be
> added to fromLaTeXCommand() asking explicitly for this pre-check in the
> cases where it is really important? Did you check whether the slow down
> is actually significant? I have a recollection that fromLaTeXCommand()
> was deemed to be already very slow in some cases, perhaps when used for
> bibliography processing, but I am not sure.
>

I'm not sure that this change significantly changes the performance of the
function: it basically searches through the whole set for each character in
the input string.

A solution would be to build a hash map to easily find whether a particular
string is present in unicodesymbols and map it to the corresponding Unicode
symbol (an integer), for a low memory consumption (4k entries of a number
and a string of at most 56 characters,
"\\ooalign{\\textdownarrow\\cr\\kern.1em\\textdblhyphen}", that's roughly 1
MiB with UCS-4 encoding).

Do you already have a stress test for that function? Actually, I don't even
see a test to ensure correctness. If there's none, I can create such a
file, with many representative use cases of fromLaTeXCommand. I'd need help
to create it, as I have no idea what it is used with in the other places it
is being used (i.e. I'd need typical insets that call this function with
their contents).
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: unicodesymbols: have several commands for a single symbol?

2022-02-19 Thread Thibaut Cuvelier
On Sat, 19 Feb 2022 at 08:47, Jürgen Spitzmüller  wrote:
>
> Am Samstag, dem 19.02.2022 um 02:43 +0100 schrieb Thibaut Cuvelier:
> > Does it look alright to you? If so, I will push these patches.
>
> So if an entry has "", this will be set empty, and if it has nothing,
> it will inherit the former, right? And until now, only "" was allowed,
> no missing table entries? I am just asking if I got it right. If so, it
> looks good to me.

Empty entries were already allowed. This mostly happened for math entries:

0x00a1 "\\textexclamdown" ""
"force=cp862;cp1255;euc-jp;euc-jp-platex;euc-kr;utf8-platex"

but there was also this one:

0x02d6 "" ""
"notermination=math,force=utf8;utf8x;utf8-cjk" "+"

There is no notion of inheritance, though, I'm only adding a way to have an
alternative way of detecting a symbol. If there is no further line for the
same Unicode symbol, then only the first one counts.
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] child documents: allow inheritance of bibliography file list (#4427)

2022-02-19 Thread Scott Kostyshak
On Sat, Feb 19, 2022 at 01:38:13PM +0100, Juergen Spitzmueller wrote:
> commit 8fa7e27e7ef78f3529be63c5c98c6ad4beb541ef
> Author: Juergen Spitzmueller 
> Date:   Sat Feb 19 14:09:59 2022 +0100
> 
> child documents: allow inheritance of bibliography file list (#4427)
> ---
>  src/Buffer.h|8 +++---
>  src/frontends/qt/GuiBibtex.cpp  |   49 
> +++
>  src/frontends/qt/GuiBibtex.h|3 ++
>  src/frontends/qt/ui/BibtexUi.ui |   14 +-
>  4 files changed, 68 insertions(+), 6 deletions(-)
> 

Cool, thanks for working on this. I'm confused about how this works. Is
it a deep copy of the master's BibTeX or a pointer? e.g., if I click on
"inherit", and then in the master document I change the bibliography, do
I need to change the child again? If so, I wonder if "copy" might be
more clear?

Also, after clicking on inherit does the child's BibTeX inset output
LaTeX when compiling the master?

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX for Mac

2022-02-19 Thread Jean-Marc Lasgouttes

Le 19/02/2022 à 16:23, Stephan Witt a écrit :

Does 
https://www.macissues.com/2014/12/08/how-to-change-your-macs-text-cursor-blink-rate/
 help?


No, not really. I knew this tipp and it doesn’t help with LyX on Mac.

It has an effect for Safari and e.g. SourceTree but not with Apple Mail or LyX. 
Qt doesn’t care for it.

=== 8< Qt documentation >8 ===
cursorFlashTime : int
This property holds the text cursor's flash (blink) time in milliseconds
The flash time is the time required to display, invert and restore the caret 
display. Usually the text cursor is displayed for half the cursor flash time, 
then hidden for the same amount of time, but this may vary.
The default value on X11 is 1000 milliseconds. On Windows, the Control Panel 
value is used and setting this property sets the cursor flash time for all 
applications.
=== 8< Qt documentation >8 ===

IMO it is an Qt bug. One may work around it. But I’m not sure how to do it 
right.


We can have special mac code to query the OS value, right?

But I agree that an OS setting nobody knows about is not really helpful.

JMarc

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX for Mac

2022-02-19 Thread Stephan Witt
Am 19.02.2022 um 12:34 schrieb Hal Kierstead via lyx-users 
:
> 
>> On Feb 18, 2022, at 8:11 PM, Tom Goldring via lyx-users 
>>  wrote:
>> 
>> I don't know how to adjust the cursor blink rate in Apple Mail, Thunderbird, 
>> Safari, etc. (if anyone does, please tell me!) but since I'm not spending a 
>> lot of time typing text into a window when I use a web browser, it isn't 
>> that much of an issue. When composing email, I usually type my text into an 
>> emacs buffer (which does allow me to turn off the blink) and then paste it 
>> into the mail client. In Windows you can turn off the blink via Control 
>> Panel -> Keyboard Properties.
>> 
>> On 2/18/22 8:38 PM, Stephan Witt wrote:
>>> Am 18.02.2022 um 20:46 schrieb Tom Goldring via lyx-users 
>>> :
 I have version 2.3.6.2 on my MacBook Pro. I consider it a poor substitute 
 for the Windows version. I can't turn off the blinking cursor (extremely 
 annoying!), I can't change the background color (white background gives me 
 a headache), hotkeys don't work, etc. Is there an alternative binary that 
 I could download?
>>> Regarding the blinking cursor… it is quite common to have a blinking 
>>> cursor. I agree it might be desirable to adjust the frequency or turn it 
>>> off - but at a system wide level. I don’t know of a setting to read this 
>>> parameter from. How do you adjust the cursor in Apple Mail or Safari? How 
>>> do you adjust it with the Windows version?
>>> 
>>> BR,
>>> Stephan
>>> 
> Does 
> https://www.macissues.com/2014/12/08/how-to-change-your-macs-text-cursor-blink-rate/
>  help?

No, not really. I knew this tipp and it doesn’t help with LyX on Mac.

It has an effect for Safari and e.g. SourceTree but not with Apple Mail or LyX. 
Qt doesn’t care for it.

=== 8< Qt documentation >8 ===
cursorFlashTime : int
This property holds the text cursor's flash (blink) time in milliseconds
The flash time is the time required to display, invert and restore the caret 
display. Usually the text cursor is displayed for half the cursor flash time, 
then hidden for the same amount of time, but this may vary.
The default value on X11 is 1000 milliseconds. On Windows, the Control Panel 
value is used and setting this property sets the cursor flash time for all 
applications.
=== 8< Qt documentation >8 ===

IMO it is an Qt bug. One may work around it. But I’m not sure how to do it 
right.

BR,
Stephan
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: unicodesymbols: have several commands for a single symbol?

2022-02-19 Thread Enrico Forestieri
On Sat, Feb 19, 2022 at 08:47:17AM +0100, Jürgen Spitzmüller wrote:
> 
> Am Samstag, dem 19.02.2022 um 02:43 +0100 schrieb Thibaut Cuvelier:
> > Does it look alright to you? If so, I will push these patches.
> 
> So if an entry has "", this will be set empty, and if it has nothing,
> it will inherit the former, right? And until now, only "" was allowed,
> no missing table entries? I am just asking if I got it right. If so, it
> looks good to me.

I have a doubt about the change in src/Encoding.cpp. The entire map is
scanned for a whole match before performing the usual processing.
This could significantly slow down performance to account for a few
statistically insignificant cases. Maybe an optional parameter could be
added to fromLaTeXCommand() asking explicitly for this pre-check in the
cases where it is really important? Did you check whether the slow down
is actually significant? I have a recollection that fromLaTeXCommand()
was deemed to be already very slow in some cases, perhaps when used for
bibliography processing, but I am not sure.

-- 
Enrico
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: LyX 2.3 and 2.4 have troubles displaying EPS images

2022-02-19 Thread Enrico Forestieri
On Sat, Feb 19, 2022 at 03:16:04AM +0100, Thibaut Cuvelier wrote:
> 
> I've been back on this issue. I think that slightly changing the call to
> ImageMagick is the best solution, as it will not break things that used to
> work and has the potential of enabling preview of images that did not have.
> 
> What do you think about this (minimalist) patch?

Given that your investigation clarified why two images can be found in
an EPS and that the first is the one actually desired, I think this
patch is good and backward compatible.

However, note that you have to also modify the "convert" entry. This was
the name of the driver program in old ImageMagick versions. It is still
present but simlinked to "magick" in recent versions.

> [-- mutt.octet.filter file type: "unified diff output, ASCII text" --]
> 
> From ea7db9f8dcd48c5c35622d442b7262929e04feca Mon Sep 17 00:00:00 2001
> From: Thibaut Cuvelier 
> Date: Sat, 19 Feb 2022 03:11:55 +0100
> Subject: [PATCH 5/5] configure: for EPS to PNG, ask ImageMagick to only
>  consider the first image.
> 
> Issue discussed in the mailing list: when the EPS contains several images 
> (Adobe Photoshop exports two of them, one being a low-quality TIFF for 
> preview), two files are generated, none with the existing name (prefix: -0 
> and -1). Hence, LyX thought that there was an error.
> ---
>  lib/configure.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/configure.py b/lib/configure.py
> index 17ef38fc6d..6b64dfce58 100644
> --- a/lib/configure.py
> +++ b/lib/configure.py
> @@ -1174,7 +1174,7 @@ def checkConverterEntries():
>  checkProg('an EPS -> PDF converter', ['epstopdf'],
>  rc_entry = [ r'\converter epspdf6   "epstopdf 
> --outfile=$$o $$i" ""'])
>  #
> -checkProg('an EPS -> PNG converter', ['magick $$i $$o', 'convert $$i 
> $$o'],
> +checkProg('an EPS -> PNG converter', ['magick $$i[0] $$o', 'convert $$i 
> $$o'],
>  rc_entry = [ r'\converter epspng"%%" ""'])
>  #
>  # no agr -> pdf6 converter, since the pdf library used by gracebat is not
> -- 
> 2.30.1.windows.1
> 

-- 
Enrico
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel