Re: [LyX/master] Add Armenian example file, originally by Günter Milde, extended by me (#10580)
On Fri, Feb 10, 2023 at 12:51:15PM +0100, Juergen Spitzmueller wrote: > commit 3365012fe076813084df567126785fed8931852b > Author: Juergen Spitzmueller > Date: Fri Feb 10 13:50:54 2023 +0100 > > Add Armenian example file, originally by Günter Milde, extended by me > (#10580) > --- When I open this file and go to Document > Settings, I get the following in the terminal output: frontends/qt/CategorizedCombo.cpp (467): Trying to select non existent layout type frontends/qt/CategorizedCombo.cpp (467): Trying to select non existent layout type frontends/qt/CategorizedCombo.cpp (467): Trying to select non existent layout type Can anyone reproduce? Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Problem building lyx-devel
On Sat, Feb 11, 2023 at 11:56:27PM +, José Matos wrote: > On Sat, 2023-02-11 at 16:11 -0500, Scott Kostyshak wrote: > > I just tried c0bca656 with both autotools and CMake and they both > > work. > > Maybe one of the recent commits fixed it for you? > > > > By the way, does compiling with CMake work for you? > > > > Scott > > I had to rerun autogen.sh in the source directory to have the change > propagated. > > I do not care what is the build system that I use as long as it works. > Since for Fedora I use the autoconf/automake combo, in order to build > LyX, that is the one I test. :-) > > For other projects I use cmake. > > In any case I fixed this issue. Thank you for your feedback. Great! Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Problem building lyx-devel
On Sat, 2023-02-11 at 16:11 -0500, Scott Kostyshak wrote: > I just tried c0bca656 with both autotools and CMake and they both > work. > Maybe one of the recent commits fixed it for you? > > By the way, does compiling with CMake work for you? > > Scott I had to rerun autogen.sh in the source directory to have the change propagated. I do not care what is the build system that I use as long as it works. Since for Fedora I use the autoconf/automake combo, in order to build LyX, that is the one I test. :-) For other projects I use cmake. In any case I fixed this issue. Thank you for your feedback. Best regards, -- José Abílio -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Problem building lyx-devel
On Sat, Feb 11, 2023 at 05:51:36PM +, José Matos wrote: > With the latest git update I get: > > make[3]: Entering directory '/home/jamatos/tmp/build/lyx-anon.gcc- > latest/lib' > make[3]: *** No rule to make target 'examples/Localization_Test.lyx', > needed by 'all-am'. Stop. > make[3]: Leaving directory '/home/jamatos/tmp/build/lyx-anon.gcc- > latest/lib' > make[2]: *** [Makefile:6606: all-recursive] Error 1 > make[2]: Leaving directory '/home/jamatos/tmp/build/lyx-anon.gcc- > latest/lib' > make[1]: *** [Makefile:581: all-recursive] Error 1 > make[1]: Leaving directory '/home/jamatos/tmp/build/lyx-anon.gcc- > latest' > make: *** [Makefile:476: all] Error 2 I just tried c0bca656 with both autotools and CMake and they both work. Maybe one of the recent commits fixed it for you? By the way, does compiling with CMake work for you? Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Problem building lyx-devel
With the latest git update I get: make[3]: Entering directory '/home/jamatos/tmp/build/lyx-anon.gcc- latest/lib' make[3]: *** No rule to make target 'examples/Localization_Test.lyx', needed by 'all-am'. Stop. make[3]: Leaving directory '/home/jamatos/tmp/build/lyx-anon.gcc- latest/lib' make[2]: *** [Makefile:6606: all-recursive] Error 1 make[2]: Leaving directory '/home/jamatos/tmp/build/lyx-anon.gcc- latest/lib' make[1]: *** [Makefile:581: all-recursive] Error 1 make[1]: Leaving directory '/home/jamatos/tmp/build/lyx-anon.gcc- latest' make: *** [Makefile:476: all] Error 2 Best regards, -- José Abílio -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Line breaking on beta2
On Sat, Feb 11, 2023 at 03:35:03PM +0100, Daniel wrote: > I cannot test current master for the next week, but just noticed that line > breaking happens within words when there are different formats applied to > parts of the word, say "*un*breakable" will break after "un" if "un" is > emphasized. Maybe this has already been fixed in current master. I can't reproduce on current master. I emphasized "un" but can't seem to get a linebreak after it. Can you send a screenshot? Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Remove space between button and text with inlines collapsible insets
On Fri, Feb 10, 2023 at 07:49:46AM +0100, Daniel wrote: > On 2023-02-10 05:24, Scott Kostyshak wrote: > > On Mon, Feb 06, 2023 at 07:34:38PM +0100, Jean-Marc Lasgouttes wrote: > > > commit 04ece4f0d6af818b3bc572b558181b947a109580 > > > Author: Jean-Marc Lasgouttes > > > Date: Sun Dec 11 20:59:43 2022 +0100 > > > > > > Remove space between button and text with inlines collapsible insets > > > Typically there are two sources of spacing: > > > * the button has two pixels added to the left and to the right > > > * the frame around the text also has 2 pixels to the left and to the > > > right > > > Note that this value of two pixels is given here for simplicity, but > > > these are parameterized by methods like textOffset or leftOffset. > > > What we want to remove is the space after the button and the space > > > before the frame. This is done in 3 places > > > In dimensionCollapsed(), the extra space is removed from the > > > dimension > > > after its computation > > > In metrics(), the space avoided before the frame is removed from > > > width. > > > In draw, the whome text inset is drawn with a negative offset. > > > Fixes #12335. > > > > Does cursor position need to be adapted for some reason? I attach two > > screenshots. "bad.png" is a screenshot with this commit, and "good.png" > > is the screenshot with the commit before. The cursor position of > > "bad.png" seems to intersect the border (the real position is that it's > > at the last position inside the "On Slide" inset). > > > > I think the screenshots also show an improvement from this commit. i.e., > > the space in-between "On Slide" and the rectangle is now gone. I think > > that looks nice now! > > My screenshot with beta2 which seems to have the patch applied looks quite > different. Indeed, your screenshot looks very nice. I wonder what is causing the difference. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Line breaking on beta2
I cannot test current master for the next week, but just noticed that line breaking happens within words when there are different formats applied to parts of the word, say "*un*breakable" will break after "un" if "un" is emphasized. Maybe this has already been fixed in current master. Daniel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
